Robust buffer access for vertex inputs/attributes was not implemented. It's fixed in this cl by adding robustBufferAccess to the Context structure, adding a check in Renderer::advanceInstanceAttributes() to prevent advancing a buffer past its end and adding out of bounds checks in VertexRoutine::readStream() This affects dEQP-VK.robustness.vertex_access.* tests, which will be enabled when the vertexPipelineStoresAndAtomics feature is turned on. For now, this change should be noop in test results. Bug b/140294254 b/131224163 Change-Id: Ib4d4cdb73f48495a556b6bd05b1d0e3ce800ad15 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/36268Tested-by:Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
| Name |
Last commit
|
Last update |
|---|---|---|
| .. | ||
| BUILD.gn | Loading commit data... | |
| Version.h | Loading commit data... | |
| VkBuffer.cpp | Loading commit data... | |
| VkBuffer.hpp | Loading commit data... | |
| VkBufferView.cpp | Loading commit data... | |
| VkBufferView.hpp | Loading commit data... | |
| VkCommandBuffer.cpp | Loading commit data... | |
| VkCommandBuffer.hpp | Loading commit data... | |
| VkCommandPool.cpp | Loading commit data... | |
| VkCommandPool.hpp | Loading commit data... | |
| VkConfig.h | Loading commit data... | |
| VkDebug.cpp | Loading commit data... | |
| VkDebug.hpp | Loading commit data... | |
| VkDescriptorPool.cpp | Loading commit data... | |
| VkDescriptorPool.hpp | Loading commit data... | |
| VkDescriptorSet.hpp | Loading commit data... | |
| VkDescriptorSetLayout.cpp | Loading commit data... | |
| VkDescriptorSetLayout.hpp | Loading commit data... | |
| VkDescriptorUpdateTemplate.cpp | Loading commit data... | |
| VkDescriptorUpdateTemplate.hpp | Loading commit data... | |
| VkDestroy.h | Loading commit data... | |
| VkDevice.cpp | Loading commit data... | |
| VkDevice.hpp | Loading commit data... | |
| VkDeviceMemory.cpp | Loading commit data... | |
| VkDeviceMemory.hpp | Loading commit data... | |
| VkEvent.hpp | Loading commit data... | |
| VkFence.hpp | Loading commit data... | |
| VkFormat.cpp | Loading commit data... | |
| VkFormat.h | Loading commit data... | |
| VkFramebuffer.cpp | Loading commit data... | |
| VkFramebuffer.hpp | Loading commit data... | |
| VkGetProcAddress.cpp | Loading commit data... | |
| VkGetProcAddress.h | Loading commit data... | |
| VkImage.cpp | Loading commit data... | |
| VkImage.hpp | Loading commit data... | |
| VkImageView.cpp | Loading commit data... | |
| VkImageView.hpp | Loading commit data... | |
| VkInstance.cpp | Loading commit data... | |
| VkInstance.hpp | Loading commit data... | |
| VkMemory.cpp | Loading commit data... | |
| VkMemory.h | Loading commit data... | |
| VkObject.hpp | Loading commit data... | |
| VkPhysicalDevice.cpp | Loading commit data... | |
| VkPhysicalDevice.hpp | Loading commit data... | |
| VkPipeline.cpp | Loading commit data... | |
| VkPipeline.hpp | Loading commit data... | |
| VkPipelineCache.cpp | Loading commit data... | |
| VkPipelineCache.hpp | Loading commit data... | |
| VkPipelineLayout.cpp | Loading commit data... | |
| VkPipelineLayout.hpp | Loading commit data... | |
| VkPromotedExtensions.cpp | Loading commit data... | |
| VkQueryPool.cpp | Loading commit data... | |
| VkQueryPool.hpp | Loading commit data... | |
| VkQueue.cpp | Loading commit data... | |
| VkQueue.hpp | Loading commit data... | |
| VkRenderPass.cpp | Loading commit data... | |
| VkRenderPass.hpp | Loading commit data... | |
| VkSampler.cpp | Loading commit data... | |
| VkSampler.hpp | Loading commit data... | |
| VkSemaphore.hpp | Loading commit data... | |
| VkShaderModule.cpp | Loading commit data... | |
| VkShaderModule.hpp | Loading commit data... | |
| Vulkan.rc | Loading commit data... | |
| VulkanPlatform.h | Loading commit data... | |
| libVulkan.cpp | Loading commit data... | |
| main.cpp | Loading commit data... | |
| resource.h | Loading commit data... | |
| vk_swiftshader.def | Loading commit data... | |
| vk_swiftshader.exports | Loading commit data... | |
| vk_swiftshader.lds | Loading commit data... | |
| vk_swiftshader_icd.json | Loading commit data... | |
| vk_swiftshader_icd.json.tmpl | Loading commit data... | |
| vulkan.vcxproj | Loading commit data... | |
| vulkan.vcxproj.filters | Loading commit data... |