This fixes some existing problems with the Variable::LinkedTo splitting/linking mechanism. The problem was that if B is linked to A, and B needs a stack slot, but A doesn't get a stack slot, B's stack offset would never get initialized. This could happen if A ends up with no explicit references in the code, or A's live range gets truncated such that it actually has a register while B doesn't. It gets even more complicated if you have a link chain like A<--B<--C<--D etc. where some of them have stack slots (which should ultimately all be the same slot) and some don't. The solution here is that if B is linked to the root A, and B has a stack slot but A doesn't, we can do a tree rotation so that B is the new root and A links to B. In addition, we initialize Variable::StackOffset to an invalid value and always make sure a value used is valid. Earlier attempts at extending the variable splitting would sometimes silently fail because the default StackOffset value of 0 ended up being used. BUG= none R=jpp@chromium.org Review URL: https://codereview.chromium.org/2116213002 .
| Name |
Last commit
|
Last update |
|---|---|---|
| .. | ||
| DartARM32 | Loading commit data... | |
| IceASanInstrumentation.cpp | Loading commit data... | |
| IceASanInstrumentation.h | Loading commit data... | |
| IceAssembler.cpp | Loading commit data... | |
| IceAssembler.h | Loading commit data... | |
| IceAssemblerARM32.cpp | Loading commit data... | |
| IceAssemblerARM32.h | Loading commit data... | |
| IceAssemblerMIPS32.h | Loading commit data... | |
| IceAssemblerX8632.h | Loading commit data... | |
| IceAssemblerX8664.h | Loading commit data... | |
| IceAssemblerX86Base.h | Loading commit data... | |
| IceAssemblerX86BaseImpl.h | Loading commit data... | |
| IceBitVector.h | Loading commit data... | |
| IceBrowserCompileServer.cpp | Loading commit data... | |
| IceBrowserCompileServer.h | Loading commit data... | |
| IceBuildDefs.h | Loading commit data... | |
| IceCfg.cpp | Loading commit data... | |
| IceCfg.h | Loading commit data... | |
| IceCfgNode.cpp | Loading commit data... | |
| IceCfgNode.h | Loading commit data... | |
| IceClFlags.cpp | Loading commit data... | |
| IceClFlags.def | Loading commit data... | |
| IceClFlags.h | Loading commit data... | |
| IceCompileServer.cpp | Loading commit data... | |
| IceCompileServer.h | Loading commit data... | |
| IceCompiler.cpp | Loading commit data... | |
| IceCompiler.h | Loading commit data... | |
| IceConditionCodesARM32.h | Loading commit data... | |
| IceConditionCodesMIPS32.h | Loading commit data... | |
| IceConditionCodesX8632.h | Loading commit data... | |
| IceConditionCodesX8664.h | Loading commit data... | |
| IceConverter.cpp | Loading commit data... | |
| IceConverter.h | Loading commit data... | |
| IceDefs.h | Loading commit data... | |
| IceELFObjectWriter.cpp | Loading commit data... | |
| IceELFObjectWriter.h | Loading commit data... | |
| IceELFSection.cpp | Loading commit data... | |
| IceELFSection.h | Loading commit data... | |
| IceELFStreamer.h | Loading commit data... | |
| IceFixups.cpp | Loading commit data... | |
| IceFixups.h | Loading commit data... | |
| IceGlobalContext.cpp | Loading commit data... | |
| IceGlobalContext.h | Loading commit data... | |
| IceGlobalInits.cpp | Loading commit data... | |
| IceGlobalInits.h | Loading commit data... | |
| IceInst.cpp | Loading commit data... | |
| IceInst.def | Loading commit data... | |
| IceInst.h | Loading commit data... | |
| IceInstARM32.cpp | Loading commit data... | |
| IceInstARM32.def | Loading commit data... | |
| IceInstARM32.h | Loading commit data... | |
| IceInstMIPS32.cpp | Loading commit data... | |
| IceInstMIPS32.def | Loading commit data... | |
| IceInstMIPS32.h | Loading commit data... | |
| IceInstVarIter.h | Loading commit data... | |
| IceInstX8632.cpp | Loading commit data... | |
| IceInstX8632.def | Loading commit data... | |
| IceInstX8632.h | Loading commit data... | |
| IceInstX8664.cpp | Loading commit data... | |
| IceInstX8664.def | Loading commit data... | |
| IceInstX8664.h | Loading commit data... | |
| IceInstX86Base.h | Loading commit data... | |
| IceInstX86BaseImpl.h | Loading commit data... | |
| IceInstrumentation.cpp | Loading commit data... | |
| IceInstrumentation.h | Loading commit data... | |
| IceIntrinsics.cpp | Loading commit data... | |
| IceIntrinsics.h | Loading commit data... | |
| IceLiveness.cpp | Loading commit data... | |
| IceLiveness.h | Loading commit data... | |
| IceLoopAnalyzer.cpp | Loading commit data... | |
| IceLoopAnalyzer.h | Loading commit data... | |
| IceMangling.cpp | Loading commit data... | |
| IceMangling.h | Loading commit data... | |
| IceMemory.cpp | Loading commit data... | |
| IceMemory.h | Loading commit data... | |
| IceOperand.cpp | Loading commit data... | |
| IceOperand.h | Loading commit data... | |
| IcePhiLoweringImpl.h | Loading commit data... | |
| IceRNG.cpp | Loading commit data... | |
| IceRNG.h | Loading commit data... | |
| IceRangeSpec.cpp | Loading commit data... | |
| IceRangeSpec.h | Loading commit data... | |
| IceRegAlloc.cpp | Loading commit data... | |
| IceRegAlloc.h | Loading commit data... | |
| IceRegList.h | Loading commit data... | |
| IceRegistersARM32.def | Loading commit data... | |
| IceRegistersARM32.h | Loading commit data... | |
| IceRegistersMIPS32.h | Loading commit data... | |
| IceRegistersX8632.h | Loading commit data... | |
| IceRegistersX8664.h | Loading commit data... | |
| IceStringPool.h | Loading commit data... | |
| IceSwitchLowering.cpp | Loading commit data... | |
| IceSwitchLowering.h | Loading commit data... | |
| IceTLS.h | Loading commit data... | |
| IceTargetLowering.cpp | Loading commit data... | |
| IceTargetLowering.def | Loading commit data... | |
| IceTargetLowering.h | Loading commit data... | |
| IceTargetLoweringARM32.cpp | Loading commit data... | |
| IceTargetLoweringARM32.def | Loading commit data... | |
| IceTargetLoweringARM32.h | Loading commit data... | |
| IceTargetLoweringMIPS32.cpp | Loading commit data... | |
| IceTargetLoweringMIPS32.def | Loading commit data... | |
| IceTargetLoweringMIPS32.h | Loading commit data... | |
| IceTargetLoweringX86.cpp | Loading commit data... | |
| IceTargetLoweringX8632.cpp | Loading commit data... | |
| IceTargetLoweringX8632.def | Loading commit data... | |
| IceTargetLoweringX8632.h | Loading commit data... | |
| IceTargetLoweringX8632Traits.h | Loading commit data... | |
| IceTargetLoweringX8664.cpp | Loading commit data... | |
| IceTargetLoweringX8664.def | Loading commit data... | |
| IceTargetLoweringX8664.h | Loading commit data... | |
| IceTargetLoweringX8664Traits.h | Loading commit data... | |
| IceTargetLoweringX86Base.h | Loading commit data... | |
| IceTargetLoweringX86BaseImpl.h | Loading commit data... | |
| IceTargetLoweringX86RegClass.h | Loading commit data... | |
| IceThreading.cpp | Loading commit data... | |
| IceThreading.h | Loading commit data... | |
| IceTimerTree.cpp | Loading commit data... | |
| IceTimerTree.def | Loading commit data... | |
| IceTimerTree.h | Loading commit data... | |
| IceTranslator.cpp | Loading commit data... | |
| IceTranslator.h | Loading commit data... | |
| IceTypeConverter.cpp | Loading commit data... | |
| IceTypeConverter.h | Loading commit data... | |
| IceTypes.cpp | Loading commit data... | |
| IceTypes.def | Loading commit data... | |
| IceTypes.h | Loading commit data... | |
| IceUtils.h | Loading commit data... | |
| LinuxMallocProfiling.cpp | Loading commit data... | |
| LinuxMallocProfiling.h | Loading commit data... | |
| Makefile | Loading commit data... | |
| PNaClTranslator.cpp | Loading commit data... | |
| PNaClTranslator.h | Loading commit data... | |
| README.SIMD.rst | Loading commit data... | |
| SZTargets.def | Loading commit data... | |
| WasmTranslator.cpp | Loading commit data... | |
| WasmTranslator.h | Loading commit data... | |
| main.cpp | Loading commit data... |