Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • libANGLE
  • renderer
  • vulkan
  • CommandBufferNode.cpp
Find file
BlameHistoryPermalink
  • Jamie Madill's avatar
    Vulkan: Fix circular dependency with resource updates. · 0e65454d
    Jamie Madill authored Feb 07, 2018
    The old implementation would try to keep recording draw commands to
    the same framebuffer write operation even if the vertex array buffer
    data changed. This would lead to a broken dependency graph. Fix this
    by forcing any current render operations to create a new node in this
    case, giving a correct command graph.
    
    Old design:
    
    - render (creates a CommandBufferNode A)
    - update buffer (creates a CommandBufferNode B which happens after A)
    - render (to CommandBuffer A, and gives a circular dependency with B)
    
    New design
    
    - render (CommandBufferNode A)
    - update buffer (CommandBufferNode B, happens after A)
    - render (CommandBufferNode C, happens after B)
    
    This also renames some methods to try to clarify them.
    
    Bug: angleproject:2350
    
    Change-Id: I6559bed4ed3f58f68771662422c5bef6a505282b
    Reviewed-on: https://chromium-review.googlesource.com/907416Reviewed-by: 's avatarCorentin Wallez <cwallez@chromium.org>
    Reviewed-by: 's avatarFrank Henigman <fjhenigman@chromium.org>
    Commit-Queue: Jamie Madill <jmadill@chromium.org>
    0e65454d
CommandBufferNode.cpp 11 KB
EditWeb IDE
×

Replace CommandBufferNode.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.