Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • gni
  • angle.gni
Find file
BlameHistoryPermalink
  • Michael Spang's avatar
    Reland "Vulkan: Build validation layers with asserts only" · b08d53d3
    Michael Spang authored Jun 13, 2019
    This reverts commit d187d45e.
    
    Reason for revert: The correct thing to revert was https://chromium-review.googlesource.com/c/chromium/src/+/1657512
    
    Original change's description:
    > Revert "Vulkan: Build validation layers with asserts only"
    > 
    > This reverts commit 85fef1bc.
    > 
    > Reason for revert: This actually seems to break the fucshia_x64 bot:
    > 
    > Exception: Some files were excluded with --exclude-file, but not found in the deps list: lib/libVkLayer_parameter_validation.so, lib/libVkLayer_core_validation.so
    > 
    > See https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzk0ODYyNWNjNDE2NmE3NjRkYWM2NTRlNjlmZDA3MGFjMDE3MzNkNTMM
    > 
    > Original change's description:
    > > Vulkan: Build validation layers with asserts only
    > > 
    > > Adding ANGLE to the build includes the validation layers, which are only
    > > for development. We don't want any development or debugging code to be
    > > included by default in release builds, so tie building the validation
    > > layers to enablement of asserts.
    > > 
    > > Bug: angleproject:2475
    > > Test: gn gen out/fuchsia_rel --args='target_os="fuchsia" is_debug=false use_goma=true'
    > >   gn desc out/fuchsia_rel //fuchsia/engine:web_engine runtime_deps
    > > 
    > > Change-Id: I6d195c680255dcbc81e95f8e6f80e1e8ace169a2
    > > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1656306
    > > Reviewed-by: Jamie Madill <jmadill@chromium.org>
    > > Commit-Queue: Michael Spang <spang@chromium.org>
    > 
    > TBR=spang@chromium.org,geofflang@chromium.org,jmadill@chromium.org
    > 
    > Change-Id: Ia74efcce2b3dda02dc0c0d292bdeb5ea7c5c3530
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Bug: angleproject:2475
    > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1657711
    > Reviewed-by: Jamie Madill <jmadill@chromium.org>
    > Commit-Queue: Jamie Madill <jmadill@chromium.org>
    
    TBR=spang@chromium.org,geofflang@chromium.org,jmadill@chromium.org
    
    Change-Id: Iab669210c23823b403e3fff7f5199a7aadd032bb
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: angleproject:2475
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1658411Reviewed-by: 's avatarMichael Spang <spang@chromium.org>
    Commit-Queue: Michael Spang <spang@chromium.org>
    b08d53d3
angle.gni 7.19 KB
EditWeb IDE
×

Replace angle.gni

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.