D3D11: Fix bug with static vertex attributes.

In some specific cases after binding a zero size buffer we could end up trying to use a buffer storage that was no longer valid. Fix this by ensuring we don't flush dirty bits when we have an early exit due to a zero size buffer. Bug: chromium:1107433 Change-Id: I9db560e8dd3699abed2bb7fe6d91060148ba1817 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2343405Reviewed-by: Jamie Madill <jmadill@chromium.org>

D3D11: Fix bug with static vertex attributes.
29a4abf9 · Jamie Madill · af5b008a · 29a4abf9
Commit 29a4abf9 authored Jul 22, 2020 by Jamie Madill
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 2 deletions

VertexArray11.cpp src/libANGLE/renderer/d3d/d3d11/VertexArray11.cpp +3 -2

No files found.
--- a/src/libANGLE/renderer/d3d/d3d11/VertexArray11.cpp
+++ b/src/libANGLE/renderer/d3d/d3d11/VertexArray11.cpp
@@ -250,8 +250,6 @@ angle::Result VertexArray11::updateDirtyAttribs(const gl::Context *context,
    for (size_t dirtyAttribIndex : activeDirtyAttribs)
    {
-        mAttribsToTranslate.reset(dirtyAttribIndex);
        auto *translatedAttrib   = &mTranslatedAttribs[dirtyAttribIndex];
        const auto &currentValue = glState.getVertexAttribCurrentValue(dirtyAttribIndex);
@@ -279,6 +277,9 @@ angle::Result VertexArray11::updateDirtyAttribs(const gl::Context *context,
                UNREACHABLE();
                break;
        }
+        // Make sure we reset the dirty bit after the switch because STATIC can early exit.
+        mAttribsToTranslate.reset(dirtyAttribIndex);
    }
    return angle::Result::Continue;