Treat linker warnings as errors on Windows

This would have avoided the issue seen here: https://chromium-review.googlesource.com/#/c/304501/ Currently linker warnings are only visible in build logs. VS outputs 0 warnings/0 errors even if there are linker warnings. If linker warnings were treated as errors, then the issue above would have caused a build break. Change-Id: I4b529b778989a7299f83e0ef3e40cccf2c17e905 Reviewed-on: https://chromium-review.googlesource.com/304886Reviewed-by: Jamie Madill <jmadill@chromium.org> Tryjob-Request: Jamie Madill <jmadill@chromium.org> Tested-by: Jamie Madill <jmadill@chromium.org>

Treat linker warnings as errors on Windows
2aaab29f · Austin Kinross · Jamie Madill · 4a3c2341 · 2aaab29f
Commit 2aaab29f authored Oct 08, 2015 by Austin Kinross Committed by Jamie Madill Oct 09, 2015
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 0 deletions

common.gypi build/common.gypi +4 -0

No files found.
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -52,6 +52,10 @@
                    {
                        'WarnAsError': 'true',
                    },
+                    'VCLinkerTool':
+                    {
+                        'TreatLinkerWarningAsErrors': 'true',
+                    },
                },
            }],
        ],