Skip to content

A
angle
Commit 2aaab29f by Austin Kinross Committed by Jamie Madill
Options

Treat linker warnings as errors on Windows

This would have avoided the issue seen here: https://chromium-review.googlesource.com/#/c/304501/ Currently linker warnings are only visible in build logs. VS outputs 0 warnings/0 errors even if there are linker warnings. If linker warnings were treated as errors, then the issue above would have caused a build break. Change-Id: I4b529b778989a7299f83e0ef3e40cccf2c17e905 Reviewed-on: https://chromium-review.googlesource.com/304886Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org> Tryjob-Request: Jamie Madill <jmadill@chromium.org> Tested-by: 's avatarJamie Madill <jmadill@chromium.org>
parent 4a3c2341
Showing with 4 additions and 0 deletions
build/common.gypi
...@@ -52,6 +52,10 @@ ...@@ -52,6 +52,10 @@
{ {
'WarnAsError': 'true', 'WarnAsError': 'true',
}, },
'VCLinkerTool':
{
'TreatLinkerWarningAsErrors': 'true',
},
}, },
}], }],
], ],
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment