Bug fix in glTexParameter and glGetTexParameter validation

It is invalid to pass in GL_TEXTURE_BUFFER to either glTexParameter or glGetTexParameter. Return GL_INVALID_ENUM for such usecases. Bug: angleproject:3573 Bug: angleproject:3577 Test: dEQP.KHR_GLES31/core_texture_border_clamp_texparameteri_errors Change-Id: Ia0573c24d38c6be9d1b79a83a05e2ffbc62c8918 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2892023 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>

Bug fix in glTexParameter and glGetTexParameter validation
35f59118 · Mohan Maiya · Commit Bot · 07ae2970 · 35f59118
Commit 35f59118 authored May 12, 2021 by Mohan Maiya Committed by Commit Bot May 14, 2021
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 2 deletions

validationES.cpp src/libANGLE/validationES.cpp +4 -2

No files found.
--- a/src/libANGLE/validationES.cpp
+++ b/src/libANGLE/validationES.cpp
@@ -6365,7 +6365,8 @@ bool ValidateGetTexParameterBase(const Context *context,
        *length = 0;
    }
-    if (!ValidTextureTarget(context, target) && !ValidTextureExternalTarget(context, target))
+    if ((!ValidTextureTarget(context, target) && !ValidTextureExternalTarget(context, target)) ||
+        target == TextureType::Buffer)
    {
        context->validationError(GL_INVALID_ENUM, kInvalidTextureTarget);
        return false;
@@ -6914,7 +6915,8 @@ bool ValidateTexParameterBase(const Context *context,
                              bool vectorParams,
                              const ParamType *params)
 {
-    if (!ValidTextureTarget(context, target) && !ValidTextureExternalTarget(context, target))
+    if ((!ValidTextureTarget(context, target) && !ValidTextureExternalTarget(context, target)) ||
+        target == TextureType::Buffer)
    {
        context->validationError(GL_INVALID_ENUM, kInvalidTextureTarget);
        return false;