Skip to content

A
angle
Commit 4ebb82e5 by Jamie Madill
Options

Disable warning 4251 for ShaderVars.h.

Exporting STL classes from a DLL produces a warning on MSVS. This warning would only show up for component builds. Change-Id: I1bd9b820a45c04f92b0278d7018507d6a2bc7936 Reviewed-on: https://chromium-review.googlesource.com/251704Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org> Tested-by: 's avatarJamie Madill <jmadill@chromium.org>
parent 0d300ca7
Showing with 4 additions and 0 deletions
build/common_defines.gypi
...@@ -34,6 +34,10 @@ ...@@ -34,6 +34,10 @@
['component=="shared_library"', ['component=="shared_library"',
{ {
'defines': [ 'COMPONENT_BUILD' ], 'defines': [ 'COMPONENT_BUILD' ],
'msvs_disabled_warnings':
[
4251, # STL objects do not have DLL interface, needed by ShaderVars.h
],
}], }],
], ],
'msvs_settings': 'msvs_settings':
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment