Vulkan: Add perf warning for mid-RP clear

Bug: angleproject:3461 Change-Id: Id80ccc81db3cb66438b6b5e6d504eda613f481d1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2416244 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>

Vulkan: Add perf warning for mid-RP clear
5f8af83f · Shahbaz Youssefi · Commit Bot · 8d4331ee · 5f8af83f
Commit 5f8af83f authored Sep 17, 2020 by Shahbaz Youssefi Committed by Commit Bot Sep 18, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 0 deletions

FramebufferVk.cpp src/libANGLE/renderer/vulkan/FramebufferVk.cpp +5 -0

No files found.
--- a/src/libANGLE/renderer/vulkan/FramebufferVk.cpp
+++ b/src/libANGLE/renderer/vulkan/FramebufferVk.cpp
@@ -479,6 +479,11 @@ angle::Result FramebufferVk::clearImpl(const gl::Context *context,
        if (contextVk->hasStartedRenderPassWithCommands() &&
            contextVk->hasStartedRenderPassWithFramebuffer(currentFramebuffer))
        {
+            ANGLE_PERF_WARNING(
+                contextVk->getDebug(), GL_DEBUG_SEVERITY_LOW,
+                "Clear effectively discarding previous draw call results. Suggest earlier Clear "
+                "followed by masked color or depth/stencil draw calls instead");
+
            clearWithCommand(&contextVk->getStartedRenderPassCommands().getCommandBuffer(),
                             scissoredRenderArea, clearColorDrawBuffersMask,
                             clearDepthWithRenderPassLoadOp, clearStencilWithRenderPassLoadOp,