Skip to content

A
angle
Commit 5f8af83f by Shahbaz Youssefi Committed by Commit Bot
Options

Vulkan: Add perf warning for mid-RP clear

Bug: angleproject:3461 Change-Id: Id80ccc81db3cb66438b6b5e6d504eda613f481d1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2416244 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
parent 8d4331ee
Showing with 5 additions and 0 deletions
src/libANGLE/renderer/vulkan/FramebufferVk.cpp
...@@ -479,6 +479,11 @@ angle::Result FramebufferVk::clearImpl(const gl::Context *context, ...@@ -479,6 +479,11 @@ angle::Result FramebufferVk::clearImpl(const gl::Context *context,
if (contextVk->hasStartedRenderPassWithCommands() && if (contextVk->hasStartedRenderPassWithCommands() &&
contextVk->hasStartedRenderPassWithFramebuffer(currentFramebuffer)) contextVk->hasStartedRenderPassWithFramebuffer(currentFramebuffer))
{ {
ANGLE_PERF_WARNING(
contextVk->getDebug(), GL_DEBUG_SEVERITY_LOW,
"Clear effectively discarding previous draw call results. Suggest earlier Clear "
"followed by masked color or depth/stencil draw calls instead");
clearWithCommand(&contextVk->getStartedRenderPassCommands().getCommandBuffer(), clearWithCommand(&contextVk->getStartedRenderPassCommands().getCommandBuffer(),
scissoredRenderArea, clearColorDrawBuffersMask, scissoredRenderArea, clearColorDrawBuffersMask,
clearDepthWithRenderPassLoadOp, clearStencilWithRenderPassLoadOp, clearDepthWithRenderPassLoadOp, clearStencilWithRenderPassLoadOp,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment