Fix compute shared memory size validation

When a struct was involved, the required size for each field was added up, but also multiplied by its array size. However, when calculating the field size, the array size was already multipled in. This resulted in the calculated size to be larger than it actually is, resulting in failures in KHR-GLES31.core.compute_shader.shared-max. Bug: angleproject:4173 Change-Id: I900c17fa65decdeb20c3651c3342295fed2f7c61 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1953483Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

Fix compute shared memory size validation
6e532b8c · Shahbaz Youssefi · Commit Bot · 795a3559 · 6e532b8c
Commit 6e532b8c authored Dec 05, 2019 by Shahbaz Youssefi Committed by Commit Bot Dec 05, 2019
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

ShaderVars.cpp src/compiler/translator/ShaderVars.cpp +1 -1

No files found.
--- a/src/compiler/translator/ShaderVars.cpp
+++ b/src/compiler/translator/ShaderVars.cpp
@@ -190,7 +190,7 @@ unsigned int ShaderVariable::getExternalSize() const
        // Have a structure, need to compute the structure size.
        for (const auto &field : fields)
        {
-            memorySize += field.getArraySizeProduct() * field.getExternalSize();
+            memorySize += field.getExternalSize();
        }
    }
    else