Make angle perftests build with clang.

::testing::WithParamInterface ends up calling deleting an object with the type of the template parameter, and the pointer it deletes could arguably point to a subclass of the param object -- so clang warns that there's a delete on a class with a virtual method but without a virtual dtor. Make the param classes final to let the compiler know that this can't happen in practice. BUG=chromium:82385 Change-Id: I49a4120b15670d876613b22ba709d50bf4685006 Reviewed-on: https://chromium-review.googlesource.com/261965Reviewed-by: Jamie Madill <jmadill@chromium.org> Tested-by: Nico Weber <thakis@chromium.org>

Make angle perftests build with clang.
7e8320d8 · Nico Weber · 7c82bc46 · 7e8320d8 · 7e8320d8 · 7e8320d8
Commit 7e8320d8 authored Mar 23, 2015 by Nico Weber
Showing with 3 additions and 3 deletions

BufferSubData.cpp src/tests/perf_tests/BufferSubData.cpp +1 -1

PointSprites.cpp src/tests/perf_tests/PointSprites.cpp +1 -1

TexSubImage.cpp src/tests/perf_tests/TexSubImage.cpp +1 -1

No files found.
--- a/src/tests/perf_tests/BufferSubData.cpp
+++ b/src/tests/perf_tests/BufferSubData.cpp
@@ -16,7 +16,7 @@
 namespace
 {

-struct BufferSubDataParams : public PerfTestParams
+struct BufferSubDataParams final : public PerfTestParams
 {
    std::string suffix() const override;


--- a/src/tests/perf_tests/PointSprites.cpp
+++ b/src/tests/perf_tests/PointSprites.cpp
@@ -18,7 +18,7 @@
 namespace
 {

-struct PointSpritesParams : public PerfTestParams
+struct PointSpritesParams final : public PerfTestParams
 {
    std::string suffix() const override;


--- a/src/tests/perf_tests/TexSubImage.cpp
+++ b/src/tests/perf_tests/TexSubImage.cpp
@@ -16,7 +16,7 @@
 namespace
 {

-struct TexSubImageParams : public PerfTestParams
+struct TexSubImageParams final : public PerfTestParams
 {
    std::string suffix() const override;