Disallow operations on structures containing arrays in ESSL1

src/compiler/translator/ParseContext.cpp

@@ -2791,13 +2791,20 @@ bool TParseContext::binaryOpCommonCheck(TOperator op, TIntermTyped *left, TInter
         return false;
     }
 
-    // Check that type sizes match exactly on ops that require that:
+    // Check that type sizes match exactly on ops that require that.
+    // Also check restrictions for structs that contain arrays.
     switch(op)
     {
       case EOpAssign:
       case EOpInitialize:
       case EOpEqual:
       case EOpNotEqual:
+        // ESSL 1.00 sections 5.7, 5.8, 5.9
+        if (shaderVersion < 300 && left->getType().isStructureContainingArrays())
+        {
+            error(loc, "undefined operation for structs containing arrays", GetOperatorString(op));
+            return false;
+        }
       case EOpLessThan:
       case EOpGreaterThan:
       case EOpLessThanEqual:

src/tests/compiler_tests/MalformedShader_test.cpp

@@ -121,3 +121,40 @@ TEST_F(MalformedShaderTest, RedeclaringFunctionWithDifferentQualifiers)
       FAIL() << "Shader compilation succeeded, expecting failure " << mInfoLog;
     }
 };
+
+// Assignment and equality are undefined for structures containing arrays (ESSL 1.00 section 5.7)
+TEST_F(MalformedShaderTest, CompareStructsContainingArrays)
+{
+    const std::string &shaderString =
+        "precision mediump float;\n"
+        "struct s { float a[3]; };\n"
+        "void main() {\n"
+        "   s a;\n"
+        "   s b;\n"
+        "   bool c = (a == b);\n"
+        "   gl_FragColor = vec4(c ? 1.0 : 0.0);\n"
+        "}\n";
+    if (compile(shaderString))
+    {
+        FAIL() << "Shader compilation succeeded, expecting failure " << mInfoLog;
+    }
+}
+
+// Assignment and equality are undefined for structures containing arrays (ESSL 1.00 section 5.7)
+TEST_F(MalformedShaderTest, AssignStructsContainingArrays)
+{
+    const std::string &shaderString =
+        "precision mediump float;\n"
+        "struct s { float a[3]; };\n"
+        "void main() {\n"
+        "   s a;\n"
+        "   s b;\n"
+        "   b.a[0] = 0.0;\n"
+        "   a = b;\n"
+        "   gl_FragColor = vec4(a.a[0]);\n"
+        "}\n";
+    if (compile(shaderString))
+    {
+        FAIL() << "Shader compilation succeeded, expecting failure " << mInfoLog;
+    }
+}