capture_replay_tests: Fix MemoryObjectTest.

Add gles_ext_params Capture functions for MemoryObjectsEXT. Add case for GLCreateMemoryObjectsEXT to MaybeCaptureUpdateResourceIDs. Don't skip MemoryObjectTest, as it passes now on SwiftShader ES2. Bug: angleproject:5703 Change-Id: I930fab675cf0848f46a846388955a6bd3274a587 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2729004 Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>

capture_replay_tests: Fix MemoryObjectTest.
c11186c2 · Lubosz Sarnecki · Commit Bot · 9d091b66 · c11186c2 · c11186c2
Commit c11186c2 authored Mar 02, 2021 by Lubosz Sarnecki Committed by Commit Bot Mar 02, 2021
3 changed files
--- a/src/libANGLE/capture/FrameCapture.cpp
+++ b/src/libANGLE/capture/FrameCapture.cpp
@@ -1750,6 +1750,14 @@ void MaybeCaptureUpdateResourceIDs(std::vector<CallCapture> *callsOut)
            break;
        }

+        case EntryPoint::GLCreateMemoryObjectsEXT:
+        {
+            const ParamCapture &memoryObjects =
+                call.params.getParam("memoryObjectsPacked", ParamType::TMemoryObjectIDPointer, 1);
+            CaptureUpdateResourceIDs<gl::MemoryObjectID>(call, memoryObjects, callsOut);
+            break;
+        }
+
        default:
            break;
    }

--- a/src/libANGLE/capture/capture_gles_ext_params.cpp
+++ b/src/libANGLE/capture/capture_gles_ext_params.cpp
@@ -2464,7 +2464,7 @@ void CaptureCreateMemoryObjectsEXT_memoryObjectsPacked(const State &glState,
                                                       MemoryObjectID *memoryObjects,
                                                       ParamCapture *paramCapture)
 {
-    UNIMPLEMENTED();
+    CaptureGenHandles(n, memoryObjects, paramCapture);
 }

 void CaptureDeleteMemoryObjectsEXT_memoryObjectsPacked(const State &glState,
@@ -2473,7 +2473,7 @@ void CaptureDeleteMemoryObjectsEXT_memoryObjectsPacked(const State &glState,
                                                       const MemoryObjectID *memoryObjects,
                                                       ParamCapture *paramCapture)
 {
-    UNIMPLEMENTED();
+    CaptureMemory(memoryObjects, sizeof(MemoryObjectID) * n, paramCapture);
 }

 void CaptureGetMemoryObjectParameterivEXT_params(const State &glState,
@@ -2483,7 +2483,7 @@ void CaptureGetMemoryObjectParameterivEXT_params(const State &glState,
                                                 GLint *params,
                                                 ParamCapture *paramCapture)
 {
-    UNIMPLEMENTED();
+    paramCapture->readBufferSizeBytes = sizeof(GLint);
 }

 void CaptureGetUnsignedBytevEXT_data(const State &glState,
@@ -2512,7 +2512,7 @@ void CaptureMemoryObjectParameterivEXT_params(const State &glState,
                                              const GLint *params,
                                              ParamCapture *paramCapture)
 {
-    UNIMPLEMENTED();
+    CaptureMemory(params, sizeof(GLint), paramCapture);
 }

 void CaptureGetnUniformfvEXT_params(const State &glState,

--- a/src/tests/capture_replay_tests/capture_replay_expectations.txt
+++ b/src/tests/capture_replay_tests/capture_replay_expectations.txt
@@ -108,9 +108,6 @@ EGLSyncTest.AndroidNativeFence_WaitSync/*
 ExplicitContextTest.GetProcAddress/*
 GetImageTest.*
 GetTexLevelParameterTest.Queries/*
-MemoryObjectTest.MemoryObjectQueries/*
-MemoryObjectTest.MemoryObjectShouldBeMemoryObject/*
-MemoryObjectTest.ShouldFailValidationOnImportFdUnsupportedHandleType/*
 PointSpritesTest.PointWithoutAttributesCompliance/*
 RobustBufferAccessBehaviorTest.EmptyBuffer/*
 RobustClientMemoryTest.*