Commit c11186c2 by Lubosz Sarnecki Committed by Commit Bot

capture_replay_tests: Fix MemoryObjectTest.

Add gles_ext_params Capture functions for MemoryObjectsEXT. Add case for GLCreateMemoryObjectsEXT to MaybeCaptureUpdateResourceIDs. Don't skip MemoryObjectTest, as it passes now on SwiftShader ES2. Bug: angleproject:5703 Change-Id: I930fab675cf0848f46a846388955a6bd3274a587 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2729004 Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: 's avatarCody Northrop <cnorthrop@google.com> Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
parent 9d091b66
...@@ -1750,6 +1750,14 @@ void MaybeCaptureUpdateResourceIDs(std::vector<CallCapture> *callsOut) ...@@ -1750,6 +1750,14 @@ void MaybeCaptureUpdateResourceIDs(std::vector<CallCapture> *callsOut)
break; break;
} }
case EntryPoint::GLCreateMemoryObjectsEXT:
{
const ParamCapture &memoryObjects =
call.params.getParam("memoryObjectsPacked", ParamType::TMemoryObjectIDPointer, 1);
CaptureUpdateResourceIDs<gl::MemoryObjectID>(call, memoryObjects, callsOut);
break;
}
default: default:
break; break;
} }
......
...@@ -2464,7 +2464,7 @@ void CaptureCreateMemoryObjectsEXT_memoryObjectsPacked(const State &glState, ...@@ -2464,7 +2464,7 @@ void CaptureCreateMemoryObjectsEXT_memoryObjectsPacked(const State &glState,
MemoryObjectID *memoryObjects, MemoryObjectID *memoryObjects,
ParamCapture *paramCapture) ParamCapture *paramCapture)
{ {
UNIMPLEMENTED(); CaptureGenHandles(n, memoryObjects, paramCapture);
} }
void CaptureDeleteMemoryObjectsEXT_memoryObjectsPacked(const State &glState, void CaptureDeleteMemoryObjectsEXT_memoryObjectsPacked(const State &glState,
...@@ -2473,7 +2473,7 @@ void CaptureDeleteMemoryObjectsEXT_memoryObjectsPacked(const State &glState, ...@@ -2473,7 +2473,7 @@ void CaptureDeleteMemoryObjectsEXT_memoryObjectsPacked(const State &glState,
const MemoryObjectID *memoryObjects, const MemoryObjectID *memoryObjects,
ParamCapture *paramCapture) ParamCapture *paramCapture)
{ {
UNIMPLEMENTED(); CaptureMemory(memoryObjects, sizeof(MemoryObjectID) * n, paramCapture);
} }
void CaptureGetMemoryObjectParameterivEXT_params(const State &glState, void CaptureGetMemoryObjectParameterivEXT_params(const State &glState,
...@@ -2483,7 +2483,7 @@ void CaptureGetMemoryObjectParameterivEXT_params(const State &glState, ...@@ -2483,7 +2483,7 @@ void CaptureGetMemoryObjectParameterivEXT_params(const State &glState,
GLint *params, GLint *params,
ParamCapture *paramCapture) ParamCapture *paramCapture)
{ {
UNIMPLEMENTED(); paramCapture->readBufferSizeBytes = sizeof(GLint);
} }
void CaptureGetUnsignedBytevEXT_data(const State &glState, void CaptureGetUnsignedBytevEXT_data(const State &glState,
...@@ -2512,7 +2512,7 @@ void CaptureMemoryObjectParameterivEXT_params(const State &glState, ...@@ -2512,7 +2512,7 @@ void CaptureMemoryObjectParameterivEXT_params(const State &glState,
const GLint *params, const GLint *params,
ParamCapture *paramCapture) ParamCapture *paramCapture)
{ {
UNIMPLEMENTED(); CaptureMemory(params, sizeof(GLint), paramCapture);
} }
void CaptureGetnUniformfvEXT_params(const State &glState, void CaptureGetnUniformfvEXT_params(const State &glState,
......
...@@ -108,9 +108,6 @@ EGLSyncTest.AndroidNativeFence_WaitSync/* ...@@ -108,9 +108,6 @@ EGLSyncTest.AndroidNativeFence_WaitSync/*
ExplicitContextTest.GetProcAddress/* ExplicitContextTest.GetProcAddress/*
GetImageTest.* GetImageTest.*
GetTexLevelParameterTest.Queries/* GetTexLevelParameterTest.Queries/*
MemoryObjectTest.MemoryObjectQueries/*
MemoryObjectTest.MemoryObjectShouldBeMemoryObject/*
MemoryObjectTest.ShouldFailValidationOnImportFdUnsupportedHandleType/*
PointSpritesTest.PointWithoutAttributesCompliance/* PointSpritesTest.PointWithoutAttributesCompliance/*
RobustBufferAccessBehaviorTest.EmptyBuffer/* RobustBufferAccessBehaviorTest.EmptyBuffer/*
RobustClientMemoryTest.* RobustClientMemoryTest.*
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment