Commit c53507ca by Corentin Wallez Committed by Commit Bot

Noop cleanups to Renderer11.h and Renderer9.h

BUG= Change-Id: I1cdaa61fa00cc418b3c0b4d9e8270e780ff0d8a6 Reviewed-on: https://chromium-review.googlesource.com/365737Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
parent e93d24ef
...@@ -106,7 +106,7 @@ class Renderer11 : public RendererD3D ...@@ -106,7 +106,7 @@ class Renderer11 : public RendererD3D
virtual ~Renderer11(); virtual ~Renderer11();
egl::Error initialize() override; egl::Error initialize() override;
virtual bool resetDevice(); bool resetDevice() override;
egl::ConfigSet generateConfigs() override; egl::ConfigSet generateConfigs() override;
void generateDisplayExtensions(egl::DisplayExtensions *outExtensions) const override; void generateDisplayExtensions(egl::DisplayExtensions *outExtensions) const override;
...@@ -127,8 +127,11 @@ class Renderer11 : public RendererD3D ...@@ -127,8 +127,11 @@ class Renderer11 : public RendererD3D
GLenum depthBufferFormat, GLenum depthBufferFormat,
EGLint orientation) override; EGLint orientation) override;
virtual gl::Error setSamplerState(gl::SamplerType type, int index, gl::Texture *texture, const gl::SamplerState &sampler); gl::Error setSamplerState(gl::SamplerType type,
virtual gl::Error setTexture(gl::SamplerType type, int index, gl::Texture *texture); int index,
gl::Texture *texture,
const gl::SamplerState &sampler) override;
gl::Error setTexture(gl::SamplerType type, int index, gl::Texture *texture) override;
gl::Error setUniformBuffers(const gl::ContextState &data, gl::Error setUniformBuffers(const gl::ContextState &data,
const std::vector<GLint> &vertexUniformBuffers, const std::vector<GLint> &vertexUniformBuffers,
...@@ -171,7 +174,7 @@ class Renderer11 : public RendererD3D ...@@ -171,7 +174,7 @@ class Renderer11 : public RendererD3D
bool getNV12TextureSupport() const; bool getNV12TextureSupport() const;
virtual int getMajorShaderModel() const; int getMajorShaderModel() const override;
int getMinorShaderModel() const override; int getMinorShaderModel() const override;
std::string getShaderModelSuffix() const override; std::string getShaderModelSuffix() const override;
...@@ -293,9 +296,13 @@ class Renderer11 : public RendererD3D ...@@ -293,9 +296,13 @@ class Renderer11 : public RendererD3D
gl::DebugAnnotator *getAnnotator(); gl::DebugAnnotator *getAnnotator();
// Buffer-to-texture and Texture-to-buffer copies // Buffer-to-texture and Texture-to-buffer copies
virtual bool supportsFastCopyBufferToTexture(GLenum internalFormat) const; bool supportsFastCopyBufferToTexture(GLenum internalFormat) const override;
virtual gl::Error fastCopyBufferToTexture(const gl::PixelUnpackState &unpack, unsigned int offset, RenderTargetD3D *destRenderTarget, gl::Error fastCopyBufferToTexture(const gl::PixelUnpackState &unpack,
GLenum destinationFormat, GLenum sourcePixelsType, const gl::Box &destArea); unsigned int offset,
RenderTargetD3D *destRenderTarget,
GLenum destinationFormat,
GLenum sourcePixelsType,
const gl::Box &destArea) override;
void markAllStateDirty(); void markAllStateDirty();
gl::Error packPixels(const TextureHelper11 &textureHelper, gl::Error packPixels(const TextureHelper11 &textureHelper,
......
...@@ -69,7 +69,7 @@ class Renderer9 : public RendererD3D ...@@ -69,7 +69,7 @@ class Renderer9 : public RendererD3D
virtual ~Renderer9(); virtual ~Renderer9();
egl::Error initialize() override; egl::Error initialize() override;
virtual bool resetDevice(); bool resetDevice() override;
egl::ConfigSet generateConfigs() override; egl::ConfigSet generateConfigs() override;
void generateDisplayExtensions(egl::DisplayExtensions *outExtensions) const override; void generateDisplayExtensions(egl::DisplayExtensions *outExtensions) const override;
...@@ -101,8 +101,11 @@ class Renderer9 : public RendererD3D ...@@ -101,8 +101,11 @@ class Renderer9 : public RendererD3D
gl::Error createPixelShader(const DWORD *function, size_t length, IDirect3DPixelShader9 **outShader); gl::Error createPixelShader(const DWORD *function, size_t length, IDirect3DPixelShader9 **outShader);
HRESULT createVertexBuffer(UINT Length, DWORD Usage, IDirect3DVertexBuffer9 **ppVertexBuffer); HRESULT createVertexBuffer(UINT Length, DWORD Usage, IDirect3DVertexBuffer9 **ppVertexBuffer);
HRESULT createIndexBuffer(UINT Length, DWORD Usage, D3DFORMAT Format, IDirect3DIndexBuffer9 **ppIndexBuffer); HRESULT createIndexBuffer(UINT Length, DWORD Usage, D3DFORMAT Format, IDirect3DIndexBuffer9 **ppIndexBuffer);
virtual gl::Error setSamplerState(gl::SamplerType type, int index, gl::Texture *texture, const gl::SamplerState &sampler); gl::Error setSamplerState(gl::SamplerType type,
virtual gl::Error setTexture(gl::SamplerType type, int index, gl::Texture *texture); int index,
gl::Texture *texture,
const gl::SamplerState &sampler) override;
gl::Error setTexture(gl::SamplerType type, int index, gl::Texture *texture) override;
gl::Error setUniformBuffers(const gl::ContextState &data, gl::Error setUniformBuffers(const gl::ContextState &data,
const std::vector<GLint> &vertexUniformBuffers, const std::vector<GLint> &vertexUniformBuffers,
...@@ -145,7 +148,7 @@ class Renderer9 : public RendererD3D ...@@ -145,7 +148,7 @@ class Renderer9 : public RendererD3D
const gl::FramebufferAttachment *colorBuffer, const gl::FramebufferAttachment *colorBuffer,
const gl::FramebufferAttachment *depthStencilBuffer); const gl::FramebufferAttachment *depthStencilBuffer);
virtual void markAllStateDirty(); void markAllStateDirty();
// lost device // lost device
bool testDeviceLost() override; bool testDeviceLost() override;
...@@ -165,7 +168,7 @@ class Renderer9 : public RendererD3D ...@@ -165,7 +168,7 @@ class Renderer9 : public RendererD3D
bool getShareHandleSupport() const; bool getShareHandleSupport() const;
virtual int getMajorShaderModel() const; int getMajorShaderModel() const override;
int getMinorShaderModel() const override; int getMinorShaderModel() const override;
std::string getShaderModelSuffix() const override; std::string getShaderModelSuffix() const override;
...@@ -238,7 +241,7 @@ class Renderer9 : public RendererD3D ...@@ -238,7 +241,7 @@ class Renderer9 : public RendererD3D
gl::Error generateMipmap(ImageD3D *dest, ImageD3D *source) override; gl::Error generateMipmap(ImageD3D *dest, ImageD3D *source) override;
gl::Error generateMipmapUsingD3D(TextureStorage *storage, gl::Error generateMipmapUsingD3D(TextureStorage *storage,
const gl::TextureState &textureState) override; const gl::TextureState &textureState) override;
virtual TextureStorage *createTextureStorage2D(SwapChainD3D *swapChain); TextureStorage *createTextureStorage2D(SwapChainD3D *swapChain) override;
TextureStorage *createTextureStorageEGLImage(EGLImageD3D *eglImage) override; TextureStorage *createTextureStorageEGLImage(EGLImageD3D *eglImage) override;
TextureStorage *createTextureStorageExternal( TextureStorage *createTextureStorageExternal(
egl::Stream *stream, egl::Stream *stream,
...@@ -277,14 +280,13 @@ class Renderer9 : public RendererD3D ...@@ -277,14 +280,13 @@ class Renderer9 : public RendererD3D
const egl::AttributeMap &attribs) override; const egl::AttributeMap &attribs) override;
// Buffer-to-texture and Texture-to-buffer copies // Buffer-to-texture and Texture-to-buffer copies
virtual bool supportsFastCopyBufferToTexture(GLenum internalFormat) const; bool supportsFastCopyBufferToTexture(GLenum internalFormat) const override;
virtual gl::Error fastCopyBufferToTexture(const gl::PixelUnpackState &unpack, unsigned int offset, RenderTargetD3D *destRenderTarget, gl::Error fastCopyBufferToTexture(const gl::PixelUnpackState &unpack,
GLenum destinationFormat, GLenum sourcePixelsType, const gl::Box &destArea); unsigned int offset,
RenderTargetD3D *destRenderTarget,
// EXT_debug_marker GLenum destinationFormat,
void insertEventMarker(GLsizei length, const char *marker); GLenum sourcePixelsType,
void pushGroupMarker(GLsizei length, const char *marker); const gl::Box &destArea) override;
void popGroupMarker();
// D3D9-renderer specific methods // D3D9-renderer specific methods
gl::Error boxFilter(IDirect3DSurface9 *source, IDirect3DSurface9 *dest); gl::Error boxFilter(IDirect3DSurface9 *source, IDirect3DSurface9 *dest);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment