Avoid redundant BindingPointer::set in setBufferBinding

BUG=angleproject:2169 Change-Id: I91f099a53b456fc96988839e34733ce09fe38336 Reviewed-on: https://chromium-review.googlesource.com/766473 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>

Avoid redundant BindingPointer::set in setBufferBinding
d5d3099e · Corentin Wallez · Commit Bot · 7af63727 · d5d3099e
Commit d5d3099e authored Nov 13, 2017 by Corentin Wallez Committed by Commit Bot Nov 13, 2017
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 2 deletions

State.cpp src/libANGLE/State.cpp +4 -2

No files found.
--- a/src/libANGLE/State.cpp
+++ b/src/libANGLE/State.cpp
@@ -1240,17 +1240,18 @@ Query *State::getActiveQuery(GLenum target) const

 void State::setBufferBinding(const Context *context, BufferBinding target, Buffer *buffer)
 {
-    mBoundBuffers[target].set(context, buffer);
-
    switch (target)
    {
        case BufferBinding::PixelPack:
+            mBoundBuffers[target].set(context, buffer);
            mDirtyBits.set(DIRTY_BIT_PACK_BUFFER_BINDING);
            break;
        case BufferBinding::PixelUnpack:
+            mBoundBuffers[target].set(context, buffer);
            mDirtyBits.set(DIRTY_BIT_UNPACK_BUFFER_BINDING);
            break;
        case BufferBinding::DrawIndirect:
+            mBoundBuffers[target].set(context, buffer);
            mDirtyBits.set(DIRTY_BIT_DRAW_INDIRECT_BUFFER_BINDING);
            break;
        case BufferBinding::TransformFeedback:
@@ -1264,6 +1265,7 @@ void State::setBufferBinding(const Context *context, BufferBinding target, Buffe
            mDirtyObjects.set(DIRTY_OBJECT_VERTEX_ARRAY);
            break;
        default:
+            mBoundBuffers[target].set(context, buffer);
            break;
    }
 }