Commit d5d3099e by Corentin Wallez Committed by Commit Bot

Avoid redundant BindingPointer::set in setBufferBinding

BUG=angleproject:2169 Change-Id: I91f099a53b456fc96988839e34733ce09fe38336 Reviewed-on: https://chromium-review.googlesource.com/766473 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: 's avatarGeoff Lang <geofflang@chromium.org>
parent 7af63727
...@@ -1240,17 +1240,18 @@ Query *State::getActiveQuery(GLenum target) const ...@@ -1240,17 +1240,18 @@ Query *State::getActiveQuery(GLenum target) const
void State::setBufferBinding(const Context *context, BufferBinding target, Buffer *buffer) void State::setBufferBinding(const Context *context, BufferBinding target, Buffer *buffer)
{ {
mBoundBuffers[target].set(context, buffer);
switch (target) switch (target)
{ {
case BufferBinding::PixelPack: case BufferBinding::PixelPack:
mBoundBuffers[target].set(context, buffer);
mDirtyBits.set(DIRTY_BIT_PACK_BUFFER_BINDING); mDirtyBits.set(DIRTY_BIT_PACK_BUFFER_BINDING);
break; break;
case BufferBinding::PixelUnpack: case BufferBinding::PixelUnpack:
mBoundBuffers[target].set(context, buffer);
mDirtyBits.set(DIRTY_BIT_UNPACK_BUFFER_BINDING); mDirtyBits.set(DIRTY_BIT_UNPACK_BUFFER_BINDING);
break; break;
case BufferBinding::DrawIndirect: case BufferBinding::DrawIndirect:
mBoundBuffers[target].set(context, buffer);
mDirtyBits.set(DIRTY_BIT_DRAW_INDIRECT_BUFFER_BINDING); mDirtyBits.set(DIRTY_BIT_DRAW_INDIRECT_BUFFER_BINDING);
break; break;
case BufferBinding::TransformFeedback: case BufferBinding::TransformFeedback:
...@@ -1264,6 +1265,7 @@ void State::setBufferBinding(const Context *context, BufferBinding target, Buffe ...@@ -1264,6 +1265,7 @@ void State::setBufferBinding(const Context *context, BufferBinding target, Buffe
mDirtyObjects.set(DIRTY_OBJECT_VERTEX_ARRAY); mDirtyObjects.set(DIRTY_OBJECT_VERTEX_ARRAY);
break; break;
default: default:
mBoundBuffers[target].set(context, buffer);
break; break;
} }
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment