Skip to content

A
angle
Commit e357cc6f by Jamie Madill Committed by Commit Bot
Options

Revert "Vulkan: Prefer host cached memory for Buffers"

This reverts commit 326f128b. Reason for revert: Fails of Mali platform. See bug: Bug: angleproject:5544 Original change's description: > Vulkan: Prefer host cached memory for Buffers > > This improves perf because vertex data upload uses host visible memory, > and uncached memory can be slow. > > Test: > > Android on Windows with 1080Ti: > glmark2 [build] vbo=false 265 -> 3900 fps > > Bug: angleproject:5515 > Change-Id: Ib75582bbdb4ca4a22d3a121c7b477a23a8a809ef > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2615742 > Commit-Queue: Lingfeng Yang <lfy@google.com> > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Tim Van Patten <timvp@google.com> TBR=geofflang@chromium.org,lfy@google.com,doughorn@google.com,timvp@google.com,jmadill@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: angleproject:5515 Change-Id: I59695b1981b43471dbd309d4e859bae7a4821969 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2627604Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org> Reviewed-by: 's avatarLingfeng Yang <lfy@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
parent d392af02
Showing with 2 additions and 8 deletions
src/libANGLE/renderer/vulkan/vk_helpers.cpp
...@@ -3139,16 +3139,10 @@ angle::Result BufferHelper::init(ContextVk *contextVk, ...@@ -3139,16 +3139,10 @@ angle::Result BufferHelper::init(ContextVk *contextVk,
createInfo = &modifiedCreateInfo; createInfo = &modifiedCreateInfo;
} }
const VkMemoryPropertyFlags requiredFlags = VkMemoryPropertyFlags requiredFlags =
memoryPropertyFlags & VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT; (memoryPropertyFlags & VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT);
VkMemoryPropertyFlags preferredFlags = VkMemoryPropertyFlags preferredFlags =
(memoryPropertyFlags & (~VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT)); (memoryPropertyFlags & (~VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT));
// If we want host visible memory, also ask for cached. This can make a big difference for data
// upload.
if (requiredFlags != 0)
{
preferredFlags |= VK_MEMORY_PROPERTY_HOST_CACHED_BIT;
}
const Allocator &allocator = renderer->getAllocator(); const Allocator &allocator = renderer->getAllocator();
bool persistentlyMapped = renderer->getFeatures().persistentlyMappedBuffers.enabled; bool persistentlyMapped = renderer->getFeatures().persistentlyMappedBuffers.enabled;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment