Implement drawRangeElements

Implement drawRangeElements simply by calling drawElements internally. The start and end parameters passed to the function will be checked against results from index validation and an error is generated if indices fall outside the claimed range. Most dEQP-GLES3.functional.draw.draw_range_elements.* tests pass after this change. The remaining failures seem to be related to instanced attributes. BUG=angleproject:957 TEST=dEQP-GLES3.functional.draw.* Change-Id: Id3923eb8114461b441e593357bc49babfd6b5c15 Reviewed-on: https://chromium-review.googlesource.com/262420Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Tested-by: Olli Etuaho <oetuaho@nvidia.com>

Implement drawRangeElements
e8e530ba · Olli Etuaho · 4b07348b · e8e530ba
Commit e8e530ba authored Mar 25, 2015 by Olli Etuaho
Hide whitespace changes
Inline Side-by-side

Showing with 22 additions and 2 deletions

entry_points_gles_3_0.cpp src/libGLESv2/entry_points_gles_3_0.cpp +22 -2

No files found.
--- a/src/libGLESv2/entry_points_gles_3_0.cpp
+++ b/src/libGLESv2/entry_points_gles_3_0.cpp
@@ -59,8 +59,28 @@ void GL_APIENTRY DrawRangeElements(GLenum mode, GLuint start, GLuint end, GLsize
            return;
        }
-        // glDrawRangeElements
+        rx::RangeUI indexRange;
-        UNIMPLEMENTED();
+        if (!ValidateDrawElements(context, mode, count, type, indices, 0, &indexRange))
+        {
+            return;
+        }
+        if (indexRange.end > end || indexRange.start < start)
+        {
+            // GL spec says that behavior in this case is undefined - generating an error is fine.
+            context->recordError(Error(GL_INVALID_OPERATION));
+            return;
+        }
+        // As long as index validation is done, it doesn't matter whether the context receives a drawElements or
+        // a drawRangeElements call - the GL back-end is free to choose to call drawRangeElements based on the
+        // validated index range. If index validation is removed, adding drawRangeElements to the context interface
+        // should be reconsidered.
+        Error error = context->drawElements(mode, count, type, indices, 0, indexRange);
+        if (error.isError())
+        {
+            context->recordError(error);
+            return;
+        }
    }
 }