Don't remove the symbol_visibility_hidden config in asan builds.

We remove symbol_visibility_hidden to get better stack traces in debug builds but it causes ASAN issues with multiply instantiated globals. BUG=angleproject:3507 Change-Id: I8ec664bf7d9506cc45afb6f864de7b7ba7cbe99b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1648275Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>

Don't remove the symbol_visibility_hidden config in asan builds.
ec57a240 · Geoff Lang · Commit Bot · 3f17f929 · ec57a240
Commit ec57a240 authored Jun 06, 2019 by Geoff Lang Committed by Commit Bot Jun 06, 2019
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

angle.gni gni/angle.gni +2 -1

No files found.
--- a/gni/angle.gni
+++ b/gni/angle.gni
@@ -102,7 +102,8 @@ angle_common_configs = [
 ]

 angle_remove_configs = [ "//build/config/compiler:default_include_dirs" ]
-angle_better_stack_traces = (is_debug || dcheck_always_on) && is_linux
+angle_better_stack_traces =
+    (is_debug || dcheck_always_on) && is_linux && !is_asan

 if (is_clang) {
  angle_remove_configs += [ "//build/config/clang:find_bad_constructs" ]