Skip to content

A
angle
Commit ec57a240 by Geoff Lang Committed by Commit Bot
Options

Don't remove the symbol_visibility_hidden config in asan builds.

We remove symbol_visibility_hidden to get better stack traces in debug builds but it causes ASAN issues with multiply instantiated globals. BUG=angleproject:3507 Change-Id: I8ec664bf7d9506cc45afb6f864de7b7ba7cbe99b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1648275Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
parent 3f17f929
Showing with 2 additions and 1 deletion
gni/angle.gni
...@@ -102,7 +102,8 @@ angle_common_configs = [ ...@@ -102,7 +102,8 @@ angle_common_configs = [
] ]
angle_remove_configs = [ "//build/config/compiler:default_include_dirs" ] angle_remove_configs = [ "//build/config/compiler:default_include_dirs" ]
angle_better_stack_traces = (is_debug || dcheck_always_on) && is_linux angle_better_stack_traces =
(is_debug || dcheck_always_on) && is_linux && !is_asan
if (is_clang) { if (is_clang) {
angle_remove_configs += [ "//build/config/clang:find_bad_constructs" ] angle_remove_configs += [ "//build/config/clang:find_bad_constructs" ]
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment