Skip to content

A
angle
Switch branch/tag
  1. 15 Jun, 2018 2 commits
    • Fix compile error in iterating ShaderBitSet · 0661eb89
      Jiawei Shao authored 
      This patch fixes a compile error when we do iteration on ShaderBitSet.
Now we can directly get a ShaderType variable in a range-for iteration
on a ShaderBitSet.

BUG=angleproject:2169

Change-Id: I23e38f2ebd1c72145a2e54be374f7dcd9f5fb9e2
Reviewed-on: https://chromium-review.googlesource.com/1100312
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: 's avatarJiajia Qin <jiajia.qin@intel.com>
Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
Reviewed-by: 's avatarCorentin Wallez <cwallez@chromium.org>
    • ES31: Use indices to access image variables in built-in image functions · 06a22620
      Xinghua Cao authored 
      In order to implement glBindImageTexture to bind a layer of 3D/2DArray/Cube
texture, use indices to access image variables when translating built-in
image functions.
There is a conflict when transferring image2D/iimage2D/uimage2D variables to
an user defined function. For example,
layout(r32ui, binding = 0) readonly uniform highp uimage2D uImage_1;
layout(r32ui, binding = 1) readonly uniform highp uimage2D uImage_2;
uvec4 lod_fun(uimage2D img, ivec2 p)
{
    return imageLoad(img, p);
}
void main()
{
    uvec4 value_1 = lod_fun(uImage_1, ivec2(gl_LocalInvocationID.xy));
    uvec4 value_2 = lod_fun(uImage_2, ivec2(gl_LocalInvocationID.xy));
}
If uImage_1 binds to a 2D texture, and uImage_2 binds to a layer of 3D texture,
uImage_1 will be translated to Texture2D type, and uImage_2 will be translated to
Texture3D type, "img" type of lod_fun will be translated Texture2D, so uImage_2
cannot be transferred to lod_fun as a parameter.
Indices without Texture/RWTexture information could handle this situation easily.

BUG=angleproject:1987
TEST=angle_end2end_tests.ComputeShaderTest.*

Change-Id: I7647395f0042f613c5d6e9eeb49392ab6252e21e
Reviewed-on: https://chromium-review.googlesource.com/1065797
Commit-Queue: Xinghua Cao <xinghua.cao@intel.com>
Reviewed-by: 's avatarGeoff Lang <geofflang@chromium.org>
Reviewed-by: 's avatarOlli Etuaho <oetuaho@nvidia.com>
  3. 14 Jun, 2018 5 commits
  5. 13 Jun, 2018 9 commits
  7. 12 Jun, 2018 6 commits
  9. 11 Jun, 2018 4 commits
  11. 08 Jun, 2018 9 commits
  13. 07 Jun, 2018 3 commits
  15. 06 Jun, 2018 2 commits