Also add a small fix for a WebGL test where DrawElements with a count
of 0 should skip OOB checks.

BUG=angleproject:1523
BUG=chromium:668223

Change-Id: I67fbe939f6c8b925551b658b6178dbbae982df89
Reviewed-on: https://chromium-review.googlesource.com/435279Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

We can use a faster path to write out depth values. Previous attempts
were foiled by a D3D quirk: we need to clear a new DSV before we
write to it the first time.

Multisampled stencil resolve still requires a CPU readback.

BUG=angleproject:1710

Change-Id: I7a7d2f929644f61854d51dd096a8aa599ad648bd
Reviewed-on: https://chromium-review.googlesource.com/435571Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

This microbenchmark targets a variety of blit use cases, including
color blit, depth/stencil blit, and multisample resolve blit.

BUG=angleproject:1710

Change-Id: Ia8b3eb40af29e809e803ed48a69f3975b97fd80b
Reviewed-on: https://chromium-review.googlesource.com/435515Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

This isn't tested on the bots, but fails in standalone.

BUG=angleproject:1810

Change-Id: Ia1743352e236966abf321d312a8beb47a4cff336
Reviewed-on: https://chromium-review.googlesource.com/435012Reviewed-by: Corentin Wallez <cwallez@chromium.org>

Update EGLWindow to select configs that exactly match the requested
config.  Too many tests make assumptions about the default framebuffer's
format.

BUG=angleproject:1662

Change-Id: I4cf8aedf51013ca0f3f40f6bbd40f24a4a90561f
Reviewed-on: https://chromium-review.googlesource.com/419681Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

The zip-archive script was having trouble pulling in data from gen/.
Instead use a separate 'angledata' folder.

BUG=angleproject:1810

Change-Id: I09eaf4766a8360c40af9335bed74a5dc347e05ad
Reviewed-on: https://chromium-review.googlesource.com/435518
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

This would happen when checking the current resource vs the prior one.
Calling GetResource would increment the reference count, but we would
not properly call Release.

BUG=angleproject:1710

Change-Id: Iefa9ee60929b9808985649c83f6322c1043fa5ed
Reviewed-on: https://chromium-review.googlesource.com/434801Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

This fixes standalone build on MSVC, and makes sure the test is
cleaned up as intended.

BUG=angleproject:1651
TEST=build on MSVC

Change-Id: I057176529b57fc8610bdd67749efcef6a4441d33
Reviewed-on: https://chromium-review.googlesource.com/435379
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

Now aggregate nodes are always built with their return type, op and
arguments set. They'll determine their qualifier and precision
automatically.

This fixes setting of gotPrecisionFromChildren in a few cases.

This will also make it easier to split TIntermAggregate further into
specialized classes if that is desired.

BUG=angleproject:1490
TEST=angle_unittests

Change-Id: I1fbe0c75679c517a22d44dfc1ea160ad7a7fdfda
Reviewed-on: https://chromium-review.googlesource.com/433468Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>

BUG=angleproject:1651

Change-Id: I733ccedad7c7424cdb70e21ef8d48b2a15ccdfd7
Reviewed-on: https://chromium-review.googlesource.com/434762Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

The checks for VertexAttribPointer were already implemented in a
previous patch, so we only add the checks for DrawElements.

BUG=angleproject:1523
BUG=chromium:668223

Change-Id: I5da55f9a7e7479627099c7f77618353a63b75a8e
Reviewed-on: https://chromium-review.googlesource.com/434958
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

BUG=angleproject:1651

Change-Id: Ie486f2f2d0f9adad808265f7f3fbd46069265392
Reviewed-on: https://chromium-review.googlesource.com/434764
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

When createUnaryNode() is called, the child node is guaranteed to be
non-null. This enables simplifying it.

BUG=angleproject:1490
TEST=angle_unittests

Change-Id: Ib1d021bbbeab99a6bf1b1be470181e9efbe301c6
Reviewed-on: https://chromium-review.googlesource.com/433467Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>

Whether a function call is user-defined is not orthogonal to TOperator
associated with the call node - other ops than function calls can't be
user-defined. Because of this it makes sense to store the user-
definedness by having different TOperator enums for different types of
calls.

This patch also tags internal helper functions that have a raw
definition outside the AST with a separate TOperator enum. This way
they can be handled with logic that is easy to understand. Before this,
function calls like this left the user-defined bit unset, despite not
really being built-ins either. The EmulatePrecision traverser uses
this. This is also something that could be used to clean up built-in
emulation in the future.

BUG=angleproject:1490
TEST=angle_unittests

Change-Id: I597fcd9789d0cc22b689ef3ce5a0cc3f621d4859
Reviewed-on: https://chromium-review.googlesource.com/433443Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>

BUG=angleproject:1553
BUG=chromium:630498

Change-Id: I4c341e57f2e0439ffd7bdcf74e15ca0de4152c5d
Reviewed-on: https://chromium-review.googlesource.com/435106
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

For WebGL, using native caps incorrectly sets gl_MaxDrawBuffers.
This change always applys the limit for compatible shaders.

BUG=angleproject:1523

Change-Id: Ie956f4b9fdd10bdf9276ae08eaeb49e65690185b
Reviewed-on: https://chromium-review.googlesource.com/425477
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Add floating point EGL configs for the D3D11 backend.

BUG=angleproject:1707

Change-Id: Ic84cd3a0d41e78cc39d0275d83e7695f55673ddf
Reviewed-on: https://chromium-review.googlesource.com/428294
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

CreateZero is called in ParseContext so it should handle types which
don't necessarily make sense to call it with.

BUG=chromium:680961

Change-Id: I8627850e49eb9a4f4ecde61ca2d68371ea6a8dd6
Reviewed-on: https://chromium-review.googlesource.com/431001
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

dEQP assumes EGLNativeDisplayType is a pointer, but EGL recently defined
it to be an integer.

BUG=angleproject:1707

Change-Id: Ief68c763ce159db44f4008cced47e87d92342861
Reviewed-on: https://chromium-review.googlesource.com/434761Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

BUG=angleproject:1639

Change-Id: I943f553cfb0e0feb57953770784b48e22fccc875
Reviewed-on: https://chromium-review.googlesource.com/423172
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

The Vulkan GLSL translator back-end will handle validating and
translating our WebGL/ESSL shaders into Vulkan-specific GLSL.

glslang (the Vulkan one) accepts both GLSL and GLSL ES shaders
as inputs, and both the desktop and ESSL back-ends give
incompleteness warnings when used. For now, use the desktop GL
450 as a target for Vulkan GLSL.

The Vulkan-specific changes are currently only to add locations
to every vertex input and fragment output.

BUG=angleproject:1575

Change-Id: I7c3f32f522e9d18e5f8618eb7927336bf4fbdcf2
Reviewed-on: https://chromium-review.googlesource.com/412266Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Failure was seen on bots since the test was introduced.

BUG=chromium:686105
BUG=angleproject:1730

Change-Id: I60293f17bf5e2498cbfb61f86468c218d58df68d
Reviewed-on: https://chromium-review.googlesource.com/434080
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

This makes function call node creation code simpler and more type
safe. It also prepares for further simplification by removing usage of
TFunction in places where the arguments node is sufficient.

BUG=angleproject:1490
TEST=angle_unittests

Change-Id: I75d9e059bb32c475487f0be24e40ac0d78012d86
Reviewed-on: https://chromium-review.googlesource.com/433217Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>

This adds built-ins found in ESSL 3.10 section 8.8 Integer functions.

This includes constant folding support for functions that may be
constant folded, and support for both GLSL and HLSL output. In HLSL
several of the functions need to be emulated.

The precision qualification for the return value of some of these
functions is determined by special rules, that are now part of type
promotion for TIntermUnary nodes and determining the type of
TIntermAggregate nodes.

BUG=angleproject:1730
TEST=angle_unittests
TEST=dEQP-GLES31.functional.shaders.builtin_functions.integer.*

Change-Id: Ib0056c17671c42b6496c2f0ef059b99f8f25c122
Reviewed-on: https://chromium-review.googlesource.com/431310
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

IDCompositionSurfaces can't be bound as SRVs, so don't try to create
SRVs for them.

Also, OMSetRenderTargets must have NumViews <= 1 if an
IDCompositionSurface is being bound. MRT doesn't work with them, and just
having the remaining elements be null isn't enough.

BUG=678800

Change-Id: I76b28de7cbda772bff286eae2b83b70c9dcd2232
Reviewed-on: https://chromium-review.googlesource.com/431134Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: John Bauman <jbauman@chromium.org>

This is necessary to initialize vertex arrays.

BUG=angleproject:1579

Change-Id: Ic5a232d5cdfaa75b41241901de842e62ff3b173f
Reviewed-on: https://chromium-review.googlesource.com/406645
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

This extension is mandatory for EXT_map_buffer_range support. We can
emulate it using GLES 3.0 core map functionality.

BUG=angleproject:1751

Change-Id: Idba09ce7276603d5556039f4a49aa0b87cae22aa
Reviewed-on: https://chromium-review.googlesource.com/431826Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

Removing one usage of FormatString() and its static buffer.
And preparation for Platform logging.

Fix incorrect enabling of ERR() calls in UNIMPLEMENTED() and
UNREACHABLE(), resulting in increased code size and
<iostream> adding 5 static initializers to chrome because of
cerr referenced in statically linked translator.

BUG=angleproject:1660

Change-Id: I7caa18036118d532e0544f75278602559172ae04
Reviewed-on: https://chromium-review.googlesource.com/431457Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

New entry points are needed to support built-ins with more parameters.

Also, now that ops that are not function calls don't use the
TIntermAggregate class any more, it's easier to exclude nodes that are
not candidates for built-in emulation using a simple blacklist rather
than to use a whitelist.

Also includes function name style cleanup in BuiltInFunctionEmulator.

This will make it possible to add necessary emulation for built-ins
from ESSL 3.10.

BUG=angleproject:1730
TEST=angle_unittests

Change-Id: If267fc68f5cb9b2ee6703cbcbbe4d157da44a7e0
Reviewed-on: https://chromium-review.googlesource.com/431297
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

Built-in function parameter qualifiers are stored in the symbol table.
Some AST traversers need the qualifier information for ops to
determine whether a node is being written to. Add an utility function
that maps a TIntermAggregate node to a symbol table entry, so that the
traversers can get to this information in a convenient way.

This will be necessary for adding more built-ins that have out
parameters from ESSL 3.10.

BUG=angleproject:1730
TEST=angle_unittests

Change-Id: I4bc622d70b2326a04cc858ff1258c22320c590dc
Reviewed-on: https://chromium-review.googlesource.com/431109
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

BUG=angleproject:1679
TEST=dEQP-GLES31.functional.state_query.texture_level.texture_2d_multisample.*

Change-Id: Ic31f079c0c999d695eb695413271bd0ad10d05ba
Reviewed-on: https://chromium-review.googlesource.com/429930Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

BUG=681557

Change-Id: I8fb4e50d241e3519b27d57a507d92cc3c15877ef
Reviewed-on: https://chromium-review.googlesource.com/430877
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

The division between 2- and 3-parameter built-ins is superfluous and
can be removed. Also folding support for ESSL 3.00 is complete, so the
comments about needing to add folding support for more functions can
be removed.

BUG=angleproject:1730
TEST=angle_unittests

Change-Id: I5ca93a957a98a7740eca506e44af48e7b4b83bad
Reviewed-on: https://chromium-review.googlesource.com/431108Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>

The special names for built-ins used in intermediate output are kept
only where they add some significant value, like clearly
disambiguating between component-wise and non-component-wise ops.
Otherwise intermediate output now relies on GetOperatorString to give
names for ops.

This will make it easier to add new built-in functions.

This also fixes intermediate output for TIntermSwizzle, dFdx, dFdy and
fwidth.

BUG=angleproject:1730
TEST=angle_unittests

Change-Id: Ifa06b886ad8e24b0820513adae8decd60d80a0e7
Reviewed-on: https://chromium-review.googlesource.com/431032Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>

This will make it easier to add more built-in functions.

BUG=angleproject:1730
TEST=angle_unittests

Change-Id: I5219a83e964b6ee15c690e108313960a873dd8e5
Reviewed-on: https://chromium-review.googlesource.com/431031Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>

AST traversers tend to sometimes call traverse() functions manually
during PreVisit. Change TIntermTraverser so that even if this happens,
all the nodes are automatically added to the traversal path, instead
of having to add them manually in each individual AST traverser.

This also makes calling getParentNode() return the correct node during
InVisit.

This does cause the same node being added to the traversal path twice
in some cases, where nodes are repeatedly traversed, like in
OutputHLSL, but this should not have adverse side effects. The more
common case is that the traverse() function is called on the children
of the node being currently traversed.

This fixes a bug in OVR_multiview validation, which did not previously
call incrementDepth and decrementDepth when it should have.

BUG=angleproject:1725
TEST=angle_unittests, angle_end2end_tests

Change-Id: I6ae762eef760509ebe853eefa37dac28c16e7a9b
Reviewed-on: https://chromium-review.googlesource.com/430732
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Use baseVertex as the parameter of drawLineLoop and drawTriangleFan. The
old name is not clear for its usage.

BUG=angleproject:1724

Change-Id: I529a157f055eba9d62952093f37eabb8398697db
Reviewed-on: https://chromium-review.googlesource.com/430255
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Certain use patterns could trigger a deallocation of the system memory
storage as it was being initialized. Fix this by resetting the idle
counter before we enter into the internal update which would trigger
the deallocation check.

BUG=chromium:682020

Change-Id: Ic3dac78ffa778cbaf103820a23eea009ce439d5c
Reviewed-on: https://chromium-review.googlesource.com/430304Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

This is a reland of 2cd9d7e0.

BUG=angleproject:1442
TEST=angle_end2end_tests

Change-Id: I5be0032b97617c31cdd4c66a823e8eb3b518867a
Reviewed-on: https://chromium-review.googlesource.com/430199
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Instead of just validating definitions of main(), do the validation
for all function headers for functions named "main", including headers
in prototype declarations.

BUG=angleproject:1712
TEST=angle_unittests

Change-Id: Ia34a2a756e1cc27b241b27e8c01c6ef09bffba71
Reviewed-on: https://chromium-review.googlesource.com/430010Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>