Commits · 09932e046b8e5bf2d9fa218804a4b3440775d71e · Chen Yisong / angle

31 Oct, 2020 1 commit

Vulkan: Support emulated pre-rotation in dEQP testing · 09932e04

authored Oct 29, 2020

Similarly to end2end tests, the window dimensions are swapped with
emulated prerotation at 90 and 270 degrees, while maintaining to the
application that dimensions are as requested.

The following new command line argument can be used to select an
emulated prerotation:

    --emulated-pre-rotation=90
    --emulated-pre-rotation=180
    --emulated-pre-rotation=270

For example:

    $ ./angle_deqp_gles2_tests --use-angle=vulkan \
                               --deqp-case=*draw* \
                               --emulated-pre-rotation=270

Additionally, the deqp test expectations can be marked with the
following new tags to add suppressions for failing tests under
prerotation:

    PREROTATION
    PREROTATION90
    PREROTATION180
    PREROTATION270

Bug: angleproject:4901
Change-Id: I7a68c1a1e7da4366cde981469c589d8d900c40c5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2506810
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

09932e04

30 Oct, 2020 18 commits

Output unknown enum to aid debugging · bef8124f

authored Jun 24, 2020

When investigating issues with apps it's handy to see the actual enum
value, not just that it's an invalid value.

Based on http://crrev.com/c/2182578 by Courtney Goeltzenleuchter.

Bug: b/155487768
Change-Id: I91611cb620a3bf2d302d667e0f168ca5cb6c9d3c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2507637
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>

bef8124f

Vulkan: Optimize glFramebufferSubInvalidate · 8f36b846

authored Oct 29, 2020

If glFramebufferSubInvalidate() is called with an area that covers the
whole framebuffer, behave as if glFramebufferInvalidate() is called.
This allows deferred clears to be removed for example, and attachment
contents to be marked undefined.

Bug: angleproject:4988
Change-Id: Iff3f291ea6c07abccc2740174d0451b432ac5da8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2508977Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

8f36b846

Metal: prepare to run dEQP GLES3 tests · aff43fa0

authored Oct 25, 2020

Bug: angleproject:2634
Bug: angleproject:4235
Change-Id: I6618b9de94ce88f8cbf81a163d0821b25ab07186
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2494528Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

aff43fa0

Revert "Add a Vulkan feature to compress float32 vertex formats." · 8ace36f8

authored Oct 30, 2020

Bug: b/167404532
Bug: b/161716126
Change-Id: I95157a006d5c1fd2d3c0c2c2be37fa0403c07f93
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2510011Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

8ace36f8

Add option to disable SwiftShader when retracing. · 3fe652d0

authored Oct 29, 2020

Bug: angleproject:5133
Change-Id: I589252d7eb9648a37a98f896c2a14462b2b34c48
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2506492
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>

3fe652d0

Write export labels into replay functions. · 02deb199

authored Oct 29, 2020

This will allow them to be recaptured in such a way that they
can be built into separate modules.

This is building towards separate binaries for each trace.

Bug: angleproject:5133
Change-Id: I306204e69a6d754282193f44055dbc85ccb01e9b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2506491
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>

02deb199

Omit types in EVENT macros. · 42ad0279

authored Oct 24, 2020

The type information is redundant with the parameters. Cleans up both
the debugger and text-based traces.

Bug: b/170249632
Change-Id: I00f96dc1d69ec7a8c5ca24b1a275f3bc7c29d376
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2507636Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

42ad0279

Roll Vulkan-ValidationLayers from a72e7b987746 to f673b4e6ebf3 (1 revision) · e680818d

authored Oct 30, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/a72e7b987746..f673b4e6ebf3

2020-10-29 shannon@lunarg.com build: Reconcile final 158 VUID inconsistencies

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: geofflang@google.com
Change-Id: Icdc92303ef357bdb2f5390402af65c0d8209e82e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2509672Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

e680818d

Roll SwiftShader from c1839ee3cedd to e6c9497255c6 (4 revisions) · a8c01862

authored Oct 30, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/c1839ee3cedd..e6c9497255c6

2020-10-29 capn@google.com Fix LLVM pointer element type
2020-10-29 capn@google.com Avoid false-positive MSan error for thread_local
2020-10-29 capn@google.com Update Marl to 3285a2dfb
2020-10-28 capn@google.com Temporarily support both ORCv1 and ORCv2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: geofflang@google.com
Change-Id: Ibcf37e0128989e89d6e5ec2cf5033f1cf2d599f6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2509671Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

a8c01862

Roll Chromium from 80c364fa8e53 to 1e88b939ff30 (901 revisions) · d811c4e3

authored Oct 30, 2020

https://chromium.googlesource.com/chromium/src.git/+log/80c364fa8e53..1e88b939ff30

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/899545e432..5cdd7aaa22
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/e74c871704..98789ba90c
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/d24a1910b9..dbf0550693
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..24bd418544
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/f9b4a22424..12b3cd36d8
* tools/luci-go: git_revision:576741d3eed0fa33971fb34cd823650e6f5b47fb..git_revision:1a022d3a4c50be4207ee93451255d71896416596
* tools/luci-go: git_revision:576741d3eed0fa33971fb34cd823650e6f5b47fb..git_revision:1a022d3a4c50be4207ee93451255d71896416596
* tools/luci-go: git_revision:576741d3eed0fa33971fb34cd823650e6f5b47fb..git_revision:1a022d3a4c50be4207ee93451255d71896416596
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/1d51f2aa14..88a308c1a4
No update to Clang.

Bug: angleproject:2930,angleproject:3020,angleproject:3111,angleproject:3481,angleproject:5213,angleproject:5227,angleproject:5259
Tbr: geofflang@google.com
Change-Id: I41975759f796173e010b3f986815ff845f3b2da0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2508985Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

d811c4e3

Add a perf test for scissored draw calls · 257b9ad9

authored Oct 29, 2020

Bug: angleproject:4988
Change-Id: I59facc66aaa2af216d3a6c6ef1e4efa934a45cb8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2506779Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

257b9ad9

Capture/Replay: Two cleanups. · 39b777c6

authored Oct 29, 2020

This changes from returning a vector to directly returning a
pointer to the binary data for the serialized state.

The second cleanup is to use a ContextID as a wrapped type
which simplifies the output formatting code.

Bug: angleproject:5247
Change-Id: Ieb8afdb9326a12968dd2d69c05e1ed811b93abff
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2506198Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

39b777c6

Skip InstancingTest.NonIndexed* with non-zero Offset on Mac Mini 8.1 · 04d7be3f

authored Oct 29, 2020

Bug: angleproject:5271
Change-Id: I644b28670ce0501407797f7ae7e749a66a63d84e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2508975Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

04d7be3f

Skip EXTMultisampleCompatibilityTest.DrawAndResolve on Mac Mini 8.1 · 646cf5b2

authored Oct 29, 2020

Bug: angleproject:5270
Change-Id: I11ec5f9eef3989ac99a618bf5ab707484710a254
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2508972Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

646cf5b2

Suppress 2 DepthStencilFormatsTest.DepthStencilReadback on MacMini8.1 · 655aca7b

authored Oct 29, 2020

DepthStencilFormatsTest.DepthStencilReadback_Float/ES2_OpenGL
DepthStencilFormatsTest.DepthStencilReadback_UInt/ES2_OpenGL

Bug: angleproject:5269
Change-Id: I223c80d8c8ac47176d5a4ecdff34f6ce27286284
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2508971Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

655aca7b

Skip ReadPixelsTextureTest.*LayerAttachment*PBO on Mac Mini 8.1 · e77b7624

authored Oct 29, 2020

Bug: angleproject:5267
Change-Id: I41a7c7c07701e0236a85becd93f2d23db2cdaa8d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2508538Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

e77b7624

Skip WebGLCompatibilityTest.EnablePixelBufferObjectExtensions · 2bb6a5d1

authored Oct 29, 2020

Crashes on Mac Mini 8.1

Bug: angleproject:5268
Change-Id: I18cab39a8b6a8703e798cd8fb14d498a3a611eec
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2508969Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

2bb6a5d1

Make sure commit position is a string. · 5c79613f

authored Oct 29, 2020

In Python 3, you have to be careful to distinguish between
bytes and strings when reading from subprocesses; the code
to read the commit position was failing to do that in one place.

Bug: chromium:1112471
Change-Id: Ifbfba6872f762d7e5d7e356772e93b4a7ee1dfeb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2508746
Commit-Queue: Dirk Pranke <dpranke@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

5c79613f

29 Oct, 2020 15 commits

Vulkan: Make DescriptorPoolHelper a Resource · fcd35965

authored Sep 29, 2020

Descriptor pools need to live as long as the descriptor sets that are
allocated from them. Using Serials while building a command to judge a
pool's lifetime is prone to errors, since a command's Serial value
isn't known until the command is submitted, leading to deleting pools
too early relative to when the descriptor set is actually used.

This CL updates DescriptorPoolHelper to inherit from Resource, so the
descriptor pools can be retain()'ed. This allows the Resource's counter
to indicate that a pool is in use until the command's Serial is known
and can be recorded to indicate when the command completes. This
prevents descriptor pools from being destroyed before the command
completes (while the descriptor sets are still in use), or even before
the command has been submitted. Destroying a descriptor pool resets all
of the descriptors that were allocated from it, which can trigger a
variety of VVL errors depending on when it's erroneously performed.

This CL also adds the necessary retain() calls for the descriptor pools.
In particular, the pools need to be retained each time a cached
descriptor set that was allocated from it is re-used. This is relatively
simple with the current design, since we always clear the descriptor set
caches whenever a new pool is allocated, so the descriptor pool binding
is always accurate.

Bug: angleproject:5030
Test: VulkanMultithreadingTest::MultiContextDrawSmallDescriptorPools()
Change-Id: Iac9e7efef338f169a6bf8ac3b2140e03dd326641
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2504457Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>

fcd35965

Skip Instanced MultiDrawTest.MultiDrawArrays on Mac Mini 8.1 · 1070802c

authored Oct 29, 2020

Bug: angleproject:5265
Change-Id: I1d3f1802398472c0da2d00526bd7eb52f6596bea
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2508532Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

1070802c

Gold Tests: Include SHA1 files in trace inputs. · e77e3528

authored Oct 29, 2020

This will force "GN analyze" to pick up changes in the gold tests
when all that GN sees is a new SHA1 file. In effect a SHA1 change
means all the sources in a trace have changed.

Bug: chromium:1143507
Change-Id: Idf44045ebd5d2bda9380b339e95d336b6804ce8a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2508530
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

e77e3528

Vulkan: Add OES_shader_image_atomic support · e895ced6

authored Oct 29, 2020

Add support for shader builtins and enable the extension.

Bug: angleproject:3578
Tests: dEQP-GLES31.functional.*image_atomic*
Change-Id: Idd45b2ee62efe1474c6c5947c77da64ff2221bf6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2505540
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

e895ced6

Disable libcxx_abi_unstable in roll_aosp.sh · 4c5630d0

authored Oct 29, 2020

The definition _LIBCPP_ABI_UNSTABLE breaks std::string in Android AOSP
builds, starting with GetHelperExecutableDir(), but others fail later
if that's worked around. Instead, we'll disable that flag with a GN arg
for AOSP rolls.

Bug: angleproject:5263
Test: Build on AOSP and launch Cuttlefish
Change-Id: Ia4b293a5ce0b09206f4ed87a5a442e544e2021c1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2508529Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>

4c5630d0

Add newline when using OutputDebugStringA logging. · a5c9e672

authored Oct 29, 2020

Prior changes had made it so we no longer were spacing out the output
correctly.

Bug: None
Change-Id: Icf81b579271f2b4c8fa5a1d90d323dc062f23585
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2507635Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

a5c9e672

Roll Vulkan-ValidationLayers from 87b0951f8dba to a72e7b987746 (3 revisions) · a653a9ba

authored Oct 29, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/87b0951f8dba..a72e7b987746

2020-10-28 mark@lunarg.com tests: Add invalid stride test for GetQueryPoolResults
2020-10-28 mark@lunarg.com corechecks: Added 4519 vuid for GetQueryPoolResults stride
2020-10-28 krzysio.kurek@wp.pl stateless: Add a missing "not" to ValidateGreaterThan

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: geofflang@google.com
Change-Id: I3c1003765bf75b46f22781458a81e13378ebe451
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2507093Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

a653a9ba

Roll Vulkan-Loader from 8308d6744d50 to 428654245ad3 (1 revision) · 990684da

authored Oct 29, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/8308d6744d50..428654245ad3

2020-10-28 xantares09@hotmail.com Configure vulkan.pc when pkg-config is available

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-loader-angle-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: geofflang@google.com
Change-Id: Ic3137a446d4e977d94168c2e9abb1fc23d49974b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2507094Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

990684da

Roll VK-GL-CTS from 483a71c5130e to e69b9b7294af (10 revisions) · b2e3a2bd

authored Oct 29, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/483a71c5130e..e69b9b7294af

2020-10-25 alexander.galazin@arm.com Merge vk-gl-cts/opengl-cts-4.6.0 into vk-gl-cts/master
2020-10-25 alexander.galazin@arm.com Merge vk-gl-cts/opengl-es-cts-3.2.6 into vk-gl-cts/master
2020-10-24 alexander.galazin@arm.com Notice of withdrawal of Vulkan CTS 1.1.6.x
2020-10-24 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.4 into vk-gl-cts/master
2020-10-23 mika.vainola@siru.fi ANGLE waiver for GLES XFB array element capture
2020-10-23 siglesias@igalia.com Fix depth/stencil resolve compatibility tests
2020-10-23 ari.suonpaa@siru.fi Fix validation errors in AHB tests
2020-10-23 zzyiwei@google.com Add create and destroy object tests for the VK_EXT_device_memory_report extension
2020-10-23 mikko.tiusanen@siru.fi Add tests for clamping of depth values
2020-10-23 joshua@froggi.es Implement custom border color tests

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC geofflang@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: geofflang@google.com,angle-bots+autoroll-info@google.com
Change-Id: I2cd46cab1b48ccd22233cf4ea938590bab4d0945
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2507709Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

b2e3a2bd

Remove include of nonexistant directory · 30083024

authored Oct 29, 2020

This would include "angle:angle_common" which is not a directory.

Bug: b/171848471
Change-Id: Ic4f03b174a4cd4b81470862b3ed79a58b415ad04
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2507630Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

30083024

Skia Gold: Fix Android stdout parsing. · cb1a3ce5

authored Oct 29, 2020

A recent change in Chromium broke how we were parsing stdout for
capturing system info on Android. Fix the break and also update
some helper scripts to work better when run manually.

Bug: angleproject:5261
Change-Id: Iecc00bbe540461ab50ea31b5245b8b38a7250956
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2507633Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

cb1a3ce5

Revert "ANGLE_platform_angle_device_context_volatile_* extensions" · 68b95b63

authored Oct 29, 2020

This reverts commit e70f6aa6.

Reason for revert: dEQP failures:
dEQP.EGL/functional_get_frame_timestamps_rgb565_no_depth_no_stencil
dEQP.EGL/functional_get_frame_timestamps_rgb565_no_depth_stencil
dEQP.EGL/functional_hdr_metadata_cta861_3
dEQP.EGL/functional_hdr_metadata_smpte2086
dEQP.EGL/functional_mutable_render_buffer_basic
dEQP.EGL/functional_swap_buffers_with_damage_resize_after_swap_buffer_age_clear
dEQP.EGL/functional_swap_buffers_with_damage_resize_after_swap_buffer_age_clear_clear
dEQP.EGL/functional_swap_buffers_with_damage_resize_after_swap_buffer_age_render
dEQP.EGL/functional_swap_buffers_with_damage_resize_before_swap_buffer_age_clear
dEQP.EGL/functional_swap_buffers_with_damage_resize_before_swap_buffer_age_clear_clear
dEQP.EGL/functional_swap_buffers_with_damage_resize_before_swap_buffer_age_render

Original change's description:
> ANGLE_platform_angle_device_context_volatile_* extensions
>
> Change from Kimmo Kinnunen downstream:
> https://bugs.webkit.org/show_bug.cgi?id=216106
>
> Add two extensions for EAGL and CGL backends to declare the
> underlying platform context being "volatile". It means that
> the thread-global current context is being modified behind
> ANGLE. If ANGLE context is marked volatile for a particular
> API, it will sync the underlying context for every EGL
> function that needs the context. Most intuitive use is
> for the client to call eglMakeCurrent before calling any
> gl function if the client knowns the platform state might
> be dirty.
>
> Implement eglReleaseThread for EAGL and CGL backends.
> Releasing thread will unset the platform current context.
>
> Fix a bug of omitting EGL_ANGLE_device_eagl from being
> advertised.
>
> Bug: angleproject:5104
> Change-Id: I1ec98ad35bc0caada23556ae8697fdef20f65b1a
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2486548
> Commit-Queue: James Darpinian <jdarpinian@chromium.org>
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Reviewed-by: Geoff Lang <geofflang@chromium.org>

TBR=geofflang@chromium.org,kbr@chromium.org,jdarpinian@chromium.org,jonahr@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: angleproject:5104
Change-Id: Ib683625a55a582c39e5a4a0466038cfa6e782e6c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2507260Reviewed-by: Geoff Lang <geofflang@chromium.org>

68b95b63

Roll Vulkan-Loader from 8e2b7d03ccfd to 8308d6744d50 (2 revisions) · 3591997b

authored Oct 28, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/8e2b7d03ccfd..8308d6744d50

2020-10-28 shabbyx@gmail.com Generate libvulkan.so.1 on Linux instead of libvulkan.so
2020-10-27 shannon@lunarg.com build: Update known-good files for 1.2.158 header

Bug: angleproject:5216
Change-Id: I74e10c44950f3be05cc12f22b44f1627af08ca81
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2506196Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

3591997b

Revert "Tests: Update COD:Mobile trace" · e3eaa60f

authored Oct 29, 2020

This reverts commit 8442ea94.

Reason for revert: GN messed up and missed the build.
Gold wasn't run so this is likely breaking stuff.

Original change's description:
> Tests: Update COD:Mobile trace
>
> Updates to reflect changes in the application.
>
> Test: angle_perftests --gtest_filter="*cod_mobile*"
> Bug: b/164426913
> Change-Id: I207102c10578abe8eb02fe5ce22aef10b6b1d6f9
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2506076
> Commit-Queue: Cody Northrop <cnorthrop@google.com>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>

TBR=cnorthrop@google.com,courtneygo@google.com,jmadill@chromium.org

Change-Id: I70fec773b7ff3b20eb4ce9d7545f1dc54233e8ab
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: b/164426913
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2506501Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

e3eaa60f

Vulkan: Document how to turn on debug markers · f418c109

authored Oct 28, 2020

Bug: b/170249632
Change-Id: Ie71a2e9699c3da88dd7e285177bb0ce1520f5bbc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2506420
Commit-Queue: Ian Elliott <ianelliott@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

f418c109

28 Oct, 2020 6 commits

Vulkan: App-compat for apps that disable validation & don't link · 5c1d21a1

authored Oct 28, 2020

As seen on Android, when PUBG MOBILE rebuilds all of its shaders, it:

- Disables validation
- Tries to link two shaders that can't be linked
- Calls glUseProgram() for the un-linked program
- Never uses the program

Because validation was disabled, the appropriate error isn't produced
and ANGLE ASSERT's in the post-validation code.  For
application-compatibility, this case is recognized and avoided.

Bug: b/168839960
Change-Id: I521785c741d57d6c228bb60c81abe638d95e8d2d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2505547
Commit-Queue: Ian Elliott <ianelliott@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

5c1d21a1

Tests: Update COD:Mobile trace · 8442ea94

authored Oct 28, 2020

Updates to reflect changes in the application.

Test: angle_perftests --gtest_filter="*cod_mobile*"
Bug: b/164426913
Change-Id: I207102c10578abe8eb02fe5ce22aef10b6b1d6f9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2506076
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>

8442ea94

Tests: Add PUBG Mobile Lite trace · 9f48c420

authored Oct 27, 2020

Test: angle_perftests --gtest_filter="*pubg_mobile_lite*"
Bug: b/165824228
Change-Id: Iaa95b560da7834ff982bc29a2db22f3582d05513
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2504827
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

9f48c420

Work around Mac glGenerateMipmap with missing levels bug. · f02a6e0c

authored Oct 26, 2020

Some Mac GL drivers fail to generate mipmaps if level zero is not set
before the texture is first used, all mipmap data is black.

To work around this, whenever a texture level is allocated, ensure that
level zero is also allocated with at least a 1x1 image.

Bug: angleproject:5223
Change-Id: If1a728e017dec600c77a54f7ae185b719aaaae84
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2497569Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

f02a6e0c

FrameCapture: Disable GL_OES_mapbuffer during capture · 5c2db1c5

authored Oct 27, 2020

Test: Capture PUBG Mobile Lite
Bug: b/159238311
Bug: b/165824228
Change-Id: Idb9c29a963585c2f56e2fd134d77ee72bd2c53cb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2504826
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

5c2db1c5

FrameCapture: Track surface width/height per context · 97a45a9f

authored Oct 27, 2020

Test: Capture PUBG Mobile
Bug: b/159238311
Bug: b/165824228
Change-Id: I7bbc7a80ade4df6b191cbe62e9badac1066ab246
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2503474
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

97a45a9f