Skip to content

A
angle
Switch branch/tag
  1. 11 Sep, 2018 1 commit
  3. 10 Sep, 2018 4 commits
    • Fix 64-bit -> 32-bit implicit conversions in libangle. · 63aa0e5b
      Will Harris authored 
      ../../third_party/angle/src/libANGLE/renderer/gl/StateManagerGL.cpp(910,63):  warning: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long long') to 'GLuint' (aka 'unsigned int') [-Wshorten-64-to-32]
        const gl::ImageUnit &imageUnit = glState.getImageUnit(imageUnitIndex);
                                                 ~~~~~~~~~~~~ ^~~~~~~~~~~~~~
../../third_party/angle/src/libANGLE/renderer/gl/StateManagerGL.cpp(914,30):  warning: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long long') to 'GLuint' (aka 'unsigned int') [-Wshorten-64-to-32]
            bindImageTexture(imageUnitIndex, textureGL->getTextureID(), imageUnit.level,
            ~~~~~~~~~~~~~~~~ ^~~~~~~~~~~~~~
../../third_party/angle/src/libANGLE/renderer/gl/StateManagerGL.cpp(920,30):  warning: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long long') to 'GLuint' (aka 'unsigned int') [-Wshorten-64-to-32]
            bindImageTexture(imageUnitIndex, 0, imageUnit.level, imageUnit.layered, imageUnit.layer,
            ~~~~~~~~~~~~~~~~ ^~~~~~~~~~~~~~

../../third_party/angle/src/tests/gl_tests/VertexAttributeTest.cpp(1080,66):  warning: implicit conversion loses integer precision: 'GLsizeiptr' (aka 'long long') to 'GLuint' (aka 'unsigned int') [-Wshorten-64-to-32]
        glVertexAttribFormat(mTestAttrib, 1, GL_FLOAT, GL_FALSE, inputRelativeOffset);
        ~~~~~~~~~~~~~~~~~~~~                                     ^~~~~~~~~~~~~~~~~~~

BUG=chromium:879657

Change-Id: Ic6e8e5ebc0dc5fd38c15a48a936ceafd5407bba8
Reviewed-on: https://chromium-review.googlesource.com/1208315
Commit-Queue: Will Harris <wfh@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    • Vulkan: Fix FragCoord scaling when a viewport is applied. · 8e9d2340
      Jamie Madill authored 
      We were using the pivot based on the viewport dimensions which is
only valid if the viewport is the size of the framebuffer. The more
correct pivot size is actually based on the Framebuffer height.

Also updates the driver uniforms block to be a bit simpler.

Bug: angleproject:2598
Change-Id: I1cb500cded7141d10e8db6862b6ed29758cc7fb4
Reviewed-on: https://chromium-review.googlesource.com/1214205
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: 's avatarFrank Henigman <fjhenigman@chromium.org>
    • Clean up TextureStorage11_2DMultisample · 480edb8c
      Olli Etuaho authored 
      This de-duplicates functionality from TextureStorage11_EGLImage and
TextureStorage11_2DMultisample. Neither of those supports changing the
associated images or image access in shaders.

Multisampled textures also cannot be compressed, so the size doesn't
need to be adjusted according to block size.

BUG=angleproject:2275
TEST=angle_end2end_tests

Change-Id: I45bc573584065bf4f528f883435fadfbd7281077
Reviewed-on: https://chromium-review.googlesource.com/1216002Reviewed-by: 's avatarCorentin Wallez <cwallez@chromium.org>
Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
    • ES31: Support shader storage block in D3D11 compiler - Part1 · a735ee2f
      Qin Jiajia authored 
      This patch is the first step to implement a basic skeleton to translate
shader storage block to HLSL RWByteAddressBuffer.

In GLSL each shader storage block is just one structured block and in API side
it corresponds to a buffer range where stores the whole structure.
RWStructuredBuffer is an array-like object and can have many structured
elements. The structured element doesn't support unsized array and also have
a small limitation on the element size. So we choose RWByteAddressBuffer as
the counterpart of shader storage block in HLSL.

Due to RWByteAddressBuffer does not support using an index to reference a
specific location, we must use Load and Store to process the read/write
operation of a buffer variable. Moreover, in the compiler tree, since we
can't use variable name to get the resource value in RWByteAddressBuffer,
we have to calculate the offset of buffer variable in a shader storage block,
then call the corresponding wrapper function to get the right value.

In this patch, we only process below situations:
    assign_to_ssbo := ssbo_access_chain = expr_no_ssbo;
    assign_from_ssbo := lvalue_no_ssbo = ssbo_access_chain;

The translation is like below:
    // GLSL
    #version 310 es
    layout(local_size_x=8) in;
    layout(std140, binding = 0) buffer blockA {
        float f[8];
    } instanceA;
    layout(std140, binding = 1) buffer blockB {
        float f[8];
    };
    void main()
    {
        float data = instanceA.f[gl_LocalInvocationIndex];
        f[gl_LocalInvocationIndex] = data;
    }

    // HLSL
    RWByteAddressBuffer _instanceA: register(u0);
    RWByteAddressBuffer _blockB: register(u1);
    float float_Load(RWByteAddressBuffer buffer, uint loc)
    {
        float result = asfloat(buffer.Load(loc));
        return result;
    }

    void float_Store(RWByteAddressBuffer buffer, uint loc, float value)
    {
        buffer.Store(loc, asuint(value));
    }

    void gl_main()
    {
    float _data = float_Load(_instanceA, 0 + 16 * gl_LocalInvocationIndex);
    float_Store(_blockB, 0 + 16 * gl_LocalInvocationIndex, _data);
    }

We will do below things in the following patches:
1. Modify the intermediate tree to flatten all ssbo usages to:
    assign_to_ssbo := ssbo_access_chain = expr_no_ssbo;
    assign_from_ssbo := lvalue_no_ssbo = ssbo_access_chain;
e.g.
    intanceA.a +=1;
  ->tmp = intanceA.a;
    intanceA.a = tmp + 1;

    while(++instanceA.a < 16) {
    }
  ->
    int PreIncrement(out int a)
    {
        a += 1;
        return a;
    }
    tmp = instanceA.a;
    while(PreIncrement(tmp) < 16) {
        instanceA.a = tmp
    }

2. Add offset calculation for structure and array of arrays.
TODOs have been marked in the corresponding places in this patch.

3. Improve helper functions so that they can process all possible types.
TODOs have been marked in the corresponding places in this patch.

4. Process the swizzle situation.
TODOs have been marked in the corresponding places in this patch.
A possible method is to extend current helper functions like below:
    *_Load(RWByteAddressBuffer buffer, uint loc, bool isSwizzle, uint4 swizzleOffset)

Bug: angleproject:1951
Test: angle_end2end_tests

Change-Id: I68ae68d5bb77d0d5627c8272627a7f689b8dc38b
Reviewed-on: https://chromium-review.googlesource.com/848215Reviewed-by: 's avatarOlli Etuaho <oetuaho@nvidia.com>
Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
Commit-Queue: Jiajia Qin <jiajia.qin@intel.com>
  5. 09 Sep, 2018 1 commit
  7. 07 Sep, 2018 5 commits
  9. 06 Sep, 2018 4 commits
  11. 05 Sep, 2018 6 commits
  13. 04 Sep, 2018 3 commits
  15. 03 Sep, 2018 12 commits
  17. 02 Sep, 2018 2 commits
  19. 31 Aug, 2018 2 commits