Linux 32-bit crashes were fixed.

Bug: angleproject:4482
Change-Id: I3efd7c760dfec1f8b909eee2ed84f5f9ebc33c3a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2111970Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

Bug: angleproject:4497
Change-Id: I92e7ad9f0c34fe0b5f67318271ececc218c20757
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2111781Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

This will more easily allow us to detect rendering feedback loops.
We'll need to support feedback loops to enable Manhattan.

Bug: angleproject:4490
Change-Id: I442deebd89dcf0139411688eaa204c5e5b2c2799
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2109334
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>

POPCNT intrinsics cannot be used without hardware support, so a CPUID
check and polyfills are required for some CPUs when using MSVC to
avoid runtime failure.

Other changes include:
- Clang: use builtins on all platforms to provide exact intent to the
compiler;
- MSVC on ARM: use dedicated intrinsics;
- x86/x64 fallback is now branchless and works in constant time.

Bug: angleproject:4462
Change-Id: I00fcabda1c842677d8cb4bfd280d932d0d10c0a5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2102811Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

When converting a vertex buffer by using GPU, the conversion buffer
doesn't need to be host mappable. Hence the conversion buffer can
be allocated on device local memory for faster GPU access times.

Bug: angleproject:3534
Change-Id: I2efabec20186992479920bddd3abd36f9c13babc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2108706
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Goal: enable rendering feedback loop detection for Manhattan.

Making getFramebuffer private prevents direct access to the Framebuffer
internals. Hiding access lets the FramebufferVk class switch up its
implementation to support different VkFramebuffers for feedback loop
cases.

Also this is a general code cleanup.

Bug: angleproject:4490
Change-Id: Ib4f5e34d476ccd8fc43a1adb031933ab347ca7b7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2109333Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/25ede1ced679..18d3896a15fc


Also rolling transitive DEPS:
  third_party/spirv-headers/src a17e17e36da4..f8bf11a0253a

Created with:
  gclient setdep -r third_party/spirv-tools/src@18d3896a15fc

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: courtneygo@google.com
Change-Id: Idc630e487903f425e849f1bed5997bb88875a328
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2109619Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

Type decorations may be ignored when using multiple OpAccessChains.

Bug: angleproject:4492
Change-Id: I2e51af600394a69cb5f7e02228ca7e4fd1c826e0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2105529Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

https://swiftshader.googlesource.com/SwiftShader.git/+log/440fc9959f06..bc98fbeec99b

git log 440fc9959f06..bc98fbeec99b --date=short --first-parent --format='%ad %ae %s'
2020-03-18 amaiorano@google.com Subzero: fix external function calls on x86-32
2020-03-18 amaiorano@google.com Subzero: fix partially initialized ManagedStatic assert
2020-03-17 digit@google.com [vulkan]: Support multiple external semaphore implementations.

Created with:
  gclient setdep -r third_party/SwiftShader@bc98fbeec99b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: angleproject:4482
Tbr: courtneygo@google.com
Change-Id: I09384435c826f4dd4eb3003006da8a8315e7c959
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2109617Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

We were saving "width" bytes instead of "width * pixelSize". This was
causing incorrect rendering in T-Rex and Manhattan.

Bug: angleproject:4488
Change-Id: Ib5d38aaf813fb26905aedc155cc13b9d1597ec4c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2109336Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Change log: https://chromium.googlesource.com/chromium/src/+log/86e00b5dd2..fa9d5805c4
Full diff: https://chromium.googlesource.com/chromium/src/+/86e00b5dd2..fa9d5805c4

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/5d6bdfc4f1..a1cbf6469a
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/feb2d0c562..4164a30562
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/74854b3f7b..3e21eec53c
* third_party/googletest: https://chromium.googlesource.com/chromium/src/third_party/googletest/+log/703ca235f0..c96dc32110
* third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/c2eb8a7f7a..156be8c52f
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/eeaa53b76f..d60a6a8084
DEPS diff: https://chromium.googlesource.com/chromium/src/+/86e00b5dd2..fa9d5805c4/DEPS

Clang version changed c29003813ab9bd6ea7b6de40ea8f1fe21979f13f:9284abd0040afecfd619dbcf1b244a8b533291c9
Details: https://chromium.googlesource.com/chromium/src/+/86e00b5dd2..fa9d5805c4/tools/clang/scripts/update.py

TBR=jmadill@chromium.org,

Bug: angleproject:4484
Change-Id: I4e7bcd3f184ad29a7d9cffc125d58387445052af
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2106453
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/6cd8cbdaab99..caeb15a056a0

git log 6cd8cbdaab99..caeb15a056a0 --date=short --first-parent --format='%ad %ae %s'
2020-03-17 s.fricke@samsung.com tests: Add support for VUID 01762
2020-03-17 s.fricke@samsung.com layers: Add support for VUID 01762
2020-03-17 s.fricke@samsung.com layers: Add support for Map Memory VUIDs
2020-03-17 s.fricke@samsung.com layers: Removed redundant looping in graphics pipeline
2020-03-17 s.fricke@samsung.com tests: Add support for VUID 02801
2020-03-17 s.fricke@samsung.com layers: Add support for VUID 02801
2020-03-17 s.fricke@samsung.com tests: Add support for VUID 01510
2020-03-17 s.fricke@samsung.com layers: Add support for VUID 01510
2020-03-17 s.fricke@samsung.com tests: Add support for VUID 01442
2020-03-17 s.fricke@samsung.com layers: Add support for VUID 01442
2020-03-17 s.fricke@samsung.com tests: Add support for VUID 01188
2020-03-17 s.fricke@samsung.com layers: Add support for VUID 01188
2020-03-17 s.fricke@samsung.com tests: Add support for VUID 00968
2020-03-17 s.fricke@samsung.com layers: Add support for VUID 00968
2020-03-17 jmadill@chromium.org Fix Chromium warning about copying iterators.

Created with:
  gclient setdep -r third_party/vulkan-validation-layers/src@caeb15a056a0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC courtneygo@google.com,jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: courtneygo@google.com,jmadill@google.com
Change-Id: Ib1b355f9b47418f1f360d7a7bbd277a2b548893a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2108103Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>

Update to Vulkan validation layers pointed out that
vkFlushMappedMemoryRanges needs to be called when the memory is mapped.

Bug: b:151820847
Change-Id: I3860306080bca435c063046f9ae20943a8601d17
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2108705Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>

All Vulkan command buffers are only submitted once so we can set the
VK_COMMAND_BUFFER_USAGE_ONE_TIME_SUBMIT_BIT which may help performance.

Bug: angleproject:4304
Change-Id: Ibd116dcac4e78a2c058eb3da54489057d6fa8f44
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2107800Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Commit-Queue: Tobin Ehlis <tobine@google.com>

At Program::unlink we clear out the program's state but forgot
mBufferVariables. That was causing us to hit an assert when trying to
load a shader from cache.
Only see the issue on Android as that's the only platform where shader
caching is supported.

Test: KHR-GLES31.core.explicit_uniform_location.uniform-loc
Bug: angleproject:4132
Change-Id: Iae9c26a3e3b2d11983cc7d90bcd54a10c0fa9934
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2107235Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>

In Manhattan the test generates a bunch of queries that it doesn't
start until later frames. In ANGLE these queries will be stored as
nullptr entries in the QueryMap. By default the QueryMap Iterator skips
over nullptr entries. This manifested later as GL errors during replay.

Fix this by adding a new Iterator type to ResourceMap that does not
skip over nullptr values.

Bug: angleproject:4489
Change-Id: If56b908fb233de0df0445f9ea19fc322f2c42976
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2107762
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>

The prior code was caching the last subImage data. In fact we should be
caching and updating a pixel rectangle. Multiple subImage calls will
update the same rectangle until the final capture call sets up the
replay with the complete initial data.

This was causing an issue with Manhattan and the initial data for 3D
compressed textures. Manhattan uploads these one layer at a time. So
the prior code was trying to pass a single layer's data to the subImage
call for the entire level.

Bug: angleproject:4488
Change-Id: I76765dcea884f9d8ea07908c44e97578ddb0ff0d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2107761
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>

Gives about a 2-3x reduced data file size. Should help reduce the time
we spent transferring trace files on Android.

This feature is implemented as a parameter to the capture/replay tool.
This keeps backwards compatiblity if we ever need to integrate a cpp
replay into an environment that doesn't have access to zlib for
decompression.

We'll need to update the traces to take advantage of the compression.

Bug: angleproject:4484
Change-Id: Id7994efe3c0d529b85fa7e7f1b00444e630dd2cd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2104555
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

glBuffer objects with GL_STATIC_* usage patterns will now request
the storage to be allocated in device local memory. For glBuffer
objects with GL_DYNAMIC_* usage patterns we request a host cached
memory.

Bug: angleproject:4480
Change-Id: I7ca968f5ddfb59e4df3ecd07ae65df2bbf734190
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2102958
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>

Test: ShaderStorageBufferTest31.ShaderStorageBufferReadWriteOffset.
Align kBufferOffset to bufferAlignOffset correctly.

Bug: angleproject:4471
Change-Id: I71084839a845138b32d58d8bd2cf6fed2633a9be
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2100047
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

https://swiftshader.googlesource.com/SwiftShader.git/+log/3a50a43df988..440fc9959f06

git log 3a50a43df988..440fc9959f06 --date=short --first-parent --format='%ad %ae %s'
2020-03-16 swiftshader.regress@gmail.com Regres: Update test lists @ 3a50a43d

Created with:
  gclient setdep -r third_party/SwiftShader@440fc9959f06

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: courtneygo@google.com
Change-Id: I95262d4bfe2eafab7865082de2d7d0fd6a60a69c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2107107Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/9b620aa0c12d..4b2483ee88ab


Created with:
  gclient setdep -r third_party/glslang/src@4b2483ee88ab

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: courtneygo@google.com
Change-Id: Ic397f97c031c67c88ddbf2be63ae1f4dbea05401
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2107108Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/be663d752e45..6cd8cbdaab99

git log be663d752e45..6cd8cbdaab99 --date=short --first-parent --format='%ad %ae %s'
2020-03-16 jbolz@nvidia.com scripts: Add aliased types to handle_types
2020-03-16 jbolz@nvidia.com layers: Fix RayTracing VUIDs to use buffer->createInfo.size
2020-03-16 jbolz@nvidia.com tests: Disable a test case in VkLayerTest.ValidateGeometryNV
2020-03-16 s.fricke@samsung.com tests: Extra test to check multi-planar copies
2020-03-16 s.fricke@samsung.com layers: Add support for 01548
2020-03-16 mark@lunarg.com docs: Update layer config and overview doc
2020-03-16 jakub@okonski.org tracker: Fix work retiring  for queue submissions

Created with:
  gclient setdep -r third_party/vulkan-validation-layers/src@6cd8cbdaab99

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: courtneygo@google.com
Change-Id: Id80bddb98cd6236ed7d7d29e96d03c307726bda7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2107106Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/f1d9f12a19de..64c36933d4f2

git log f1d9f12a19de..64c36933d4f2 --date=short --first-parent --format='%ad %ae %s'
2020-03-16 joshua@froggi.es loader: Handle no surface for surface caps 2 funcs
2020-03-16 joshua@froggi.es loader: Migrate get surface caps 2 funcs to wsi

Created with:
  gclient setdep -r third_party/vulkan-loader/src@64c36933d4f2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-loader-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: courtneygo@google.com
Change-Id: I9a716acb93ba63d7a7b3c2898dd7896b53a4dc14
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2107105Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/c2eb8a7f7a0f..156be8c52f80

$ git log c2eb8a7f7..156be8c52 --date=short --no-merges --format='%ad %ae %s'
2020-03-16 jmadill Fix zlib build on UWP.

Created with:
  roll-dep third_party/zlib

Bug: angleproject:4484
Change-Id: I182ff15c092ed1b327f9622429aa97bdebe45c84
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2106795Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Previously the tool would save to a separate file for every frame and
one additional file for the setup function. Frames without binary data
would not get an "angledata" binary file.

Using a single file has a few advantages:

 - makes it simpler to track the data dependencies in GN
 - should be easier to compress and decompress for speed up transfers
 - no need to wonder if we have frames with missing data files
 - less overhead reading from the HDD since the whole trace is buffered

We might need to worry about extemely huge memory use cases. For now
buffering the whole file into memory on startup is simple and fast.

Also makes the binary data loader function more robust.

Bug: angleproject:4484
Change-Id: Ia74fb0bc65200adf7a21c3143f98aa4da86457b1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2104554
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

This CL restricts the workaround to the trace perf tests. These trace
tests are too big to optimize.

Also includes a fix for a 32-bit Windows warnings. We'll need to update
the build file to remove a suppression once the traces are updated.

Bug: angleproject:3630
Change-Id: Id13a0050fc2a645aa572b8c9079908023b232f28
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2103084
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

Similarly to a prior patch this organizes the common perf test sources
into a single target. This will allow us to more easily support setting
compiler flags on particular perf test sources.

This also fixes some build errors that popped up when new warnings were
enabled.

Bug: angleproject:3630
Change-Id: I866885199f93a5055e8d160e39f72d1f8209bc75
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2103086
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

This reduces code duplication by including a common set of sources in a
single place. New test sets will be a bit easier to add. It also
encapsulates the dependencies a bit better when we pull the test utils
out of the test targets.

Unblocks a follow-up CL that moves the trace perf test sources into
their own file so we can re-enable optimizations in the main perf test
target.

New warnings popped up in a few of the files because of the new source
set enabling more warnings. This CL also fixes all of those.

Bug: angleproject:3630
Change-Id: Ic30cb30fb4288c4dbbbd29f9bdf04be51e8a6b30
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2103083
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/dd3d91691f1e..25ede1ced679


Also rolling transitive DEPS:
  third_party/spirv-headers/src dc77030acc9c..a17e17e36da4

Created with:
  gclient setdep -r third_party/spirv-tools/src@25ede1ced679

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC courtneygo@google.com,ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: courtneygo@google.com,ynovikov@google.com
Change-Id: Ief155818d9aa7a143d36cb05bce5b761b6983d13
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2106235Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

"Montitor"

Bug: angleproject:1944
Change-Id: I4321265e22d7e878ff1f3223a7d8a00959c1db39
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2106454Reviewed-by: Jamie Madill <jmadill@chromium.org>

Adds more info on the amount of testing ANGLE runs and our various
configs. Adds a few other notes and cross-links.

Bug: angleproject:1944
Change-Id: I76e46783bd6a3f84d3e170bd30ea2e6d57911143
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2105715
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

Skip tests if GPU doesn't support vertex shader storage
buffer object.

Bug: angleproject:4466
Change-Id: Icc7b6e686d7b4d5ecd2e05f6f09551f839f5302d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2096740
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

The change to make the trace tests load the data files using a relative
path only worked when running the tests from the "standard" out path.
By setting the CWD to the executable dir in test setup we are able to
run the tests from any local dir when testing.

Also cleans up some repeated code in the test init switch statement.

Bug: angleproject:3630
Change-Id: I8e9e5e6e1e9cd31c5b3c7b2f52420d0ba75cf76b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2104548Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

https://swiftshader.googlesource.com/SwiftShader.git/+log/18daa81e3d3d..3a50a43df988

git log 18daa81e3d3d..3a50a43df988 --date=short --first-parent --format='%ad %ae %s'
2020-03-14 bclayton@google.com SpirvShaderDebugger: Implement scope nesting
2020-03-13 sugoi@google.com Compile Vulkan library with Subzero in Chromium
2020-03-13 bclayton@google.com SpirvShader: Silence warnings of unexpected opcodes
2020-03-13 amaiorano@google.com Subzero: hide dependency on Marl
2020-03-13 amaiorano@google.com BUILD.gn: add missing dependency onto marl for SubzeroReactor
2020-03-13 capn@google.com Consistently use TRUE/FALSE in CMakeLists.txt
2020-03-13 capn@google.com Exclude all static libraries from "all" build target
2020-03-13 amaiorano@google.com Subzero: replace Win32 fibers with Marl for couroutines
2020-03-13 bclayton@google.com SpirvShaderDebugger: Add flag for printing opcodes as they're executed
2020-03-13 bclayton@google.com SpirvShaderDebugger: Make Function extend Scope
2020-03-13 bclayton@google.com SpirvShaderDebugger: Add string helper for debug kinds
2020-03-13 bclayton@google.com SpirvShader: Implement OpenCLDebugInfo100DebugInfoNone
2020-03-13 bclayton@google.com SpirvShaderDebugger: Stub UNIMPLEMENTED() opcodes
2020-03-13 bclayton@google.com SpirvShader: Implement OpenCLDebugInfo100DebugInlinedAt

Created with:
  gclient setdep -r third_party/SwiftShader@3a50a43df988

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: jmadill@google.com
Change-Id: Ia1c5ef7d6f8c9cd9991c71f0aa8aeb2fc0f6ff3c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2104696Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

Started with https://swiftshader-review.googlesource.com/c/SwiftShader/+/42108

Bug: angleproject:4482
Change-Id: I48effe26aa7ce1b574f9df8ad9c3f560cb599cf3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2104406Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

This was missed when our git cl format protection was temporarily
broken. A subsequent change caused the file to get fully formatted so
this CL pulls that diff into a split change.

Bug: angleproject:3630
Change-Id: I14ed53708783b38039e8fa64cb38837e25911893
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2103085Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

The optimization for the large trace perf tests was so costly that in
some configs it would fail to build at all. This could cause build
failures in the ANGLE CQ. Disable optimization to work around this
until we can isolate the compiler flags to just the trace perf tests.

Note: this only applies to the test harness. ANGLE itself is still
optimized in release builds by default.

Trace trimming would also help alleviate this problem. We could also
consider removing a few traces temporarily.

Bug: angleproject:3630
Change-Id: I2bd8fb76f330692aa715249ca8656965b5a29d8c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2103674Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

We were encoding an absolute path into our binaries. This works locally
and breaks horribly when run on the bots. Fix this by rebasing the path
to the root_out_dir.

Bug: angleproject:3630
Change-Id: I4044d1228ee951f2192e83167deb92a0ffe92a52
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2103672Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

When generating the default EGL configs, populate
EGL_NATIVE_VISUAL_ID with AHARDWAREBUFFER formats.

Bug: angleproject:4469
Change-Id: Ifde9df0497cbd4e01219ab6067acd8d97f8460e4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2101577Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>