- 09 Dec, 2020 10 commits
-
-
Charlie Lao authored
The CL crrev/c/2551541 causes intermittent Bot failure. I believe the problem is that from ContextVk::onMakeCurrent call stack, the object state may not in sync or even not completely specified. So instead of accessing fbo state object here to update mGraphicsPipelineDesc, we should insert dirty bit and let state validation code to handle it. Bug: b/175157604 Change-Id: I5f6b9fd901cc4187068f6161bd12836c8bbf8e87 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2580914 Commit-Queue: Ian Elliott <ianelliott@google.com> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by:
Ian Elliott <ianelliott@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
Shahbaz Youssefi authored
Bug: angleproject:5450 Bug: angleproject:5435 Change-Id: I1925a4f926d10c81e5c69cfc62fcb26da2cec81d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2581940 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org>
-
Courtney Goeltzenleuchter authored
Bug: angleproject:4760 Change-Id: Id69f917c27dd2e2b85f434cc19002e644f42a44c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2582465Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
-
Shahbaz Youssefi authored
The sorting algorithm didn't keep the fields in order, which made them receive arbitrary locations. The SPIR-V transformer assigns the location on the whole block instead of individual members, which was incorrect in this situation. The SPIR-V transformer could have been modified to decorate each field of the I/O block with a location. This change instead sorts the fields in such a way that I/O block fields are allocated contiguously, which allows the SPIR-V transformer to function unchanged. Bug: angleproject:3580 Change-Id: I27df9e8122dd4207835bad448ffb8015692a1635 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2581076Reviewed-by:
Tim Van Patten <timvp@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
-
Xinghua Cao authored
We had translated an uniform block only containing a large array member into StructuredBuffer instead of cbuffer on D3D backend for slow fxc compile performance issue with dynamic uniform indexing. This patch throw a warning if a uniform block containing a large array member fails to hit the optimization. Bug: angleproject:3682 Change-Id: I33459b559923f16a8dfb70c6f46ec52f68d96e06 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2552365 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Jiajia Qin <jiajia.qin@intel.com>
-
angle-autoroll authored
https://chromium.googlesource.com/chromium/src.git/+log/a3984b7ec4ae..3fc522ff6579 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/115823df49..7c664f9cb5 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/6302c11756..86a7f72ab1 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/baeb2e9897..7534b563e9 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..e43bd0925d * third_party/libjpeg_turbo: https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git/+log/bbb828223e..e9a659a09e * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/dddd39ba5a..1424e1194e No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: I5e6c022f18dc7c65a354ecc92babe20cde75167f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2581380Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
Shahbaz Youssefi authored
row_major and column_major only apply to uniform and buffer interface blocks per GLSL ES 3.2 spec. Bug: angleproject:3580 Change-Id: Iad0afeffc7ddb7bff2ebaec0ea0ec4eda26171a7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2580191 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
Shahbaz Youssefi authored
When a render pass is closed, render pass queries are paused. The code that pauses queries however is conditioned to the render pass being open. In ContextVk::syncState, when processing gl::State::DIRTY_BIT_DRAW_FRAMEBUFFER_BINDING, `onRenderPassFinished()` is called. Later on, when the render pass is actually finished, the queries are not paused. This change moves the logic to pause render pass queries to onRenderPassFinished(). Bug: angleproject:5427 Change-Id: I3a87db2e4543ff698803ac5e154a370e85ac7985 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2573581 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Charlie Lao <cclao@google.com>
-
Jiawei Shao authored
This patch enables ComputeShaderTest/DrawDispatchDispatchDraw on Intel/Win/Vulkan after the upgrade of Chromium try bots. Bug: angleproject:3871 Change-Id: I3e8d36020cbb01304a7b024d5b74923640402b4e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2580112 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Jiajia Qin <jiajia.qin@intel.com> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org>
-
James Darpinian authored
Need to declare use_xcode_clang when building outside chromium. Bug: angleproject:5440 Change-Id: I4d622c1b6085d89b69c828b2c965d22c1f806f45 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2579750Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: James Darpinian <jdarpinian@chromium.org>
-
- 08 Dec, 2020 14 commits
-
-
Shahbaz Youssefi authored
This query uses the Vulkan transform feedback extension. In GL, GL_TRANSFORM_FEEDBACK_PRIMITIVES_WRITTEN and GL_PRIMITIVES_GENERATED queries can be independently begun/ended. However, Vulkan requires that queries from pools of the same type can only be active one at a time. This forbids the two GL queries from being handled by two VK queries when they are simultaneously begun. This change makes these queries share their QueryHelper objects. The Vulkan transform feedback queries unconditionally retrieve both results anyway, so this is just a matter of making sure the two GL queries are merged as one when they are simultaneously used. The change fixes a number of issues as collateral: - TransformFeedbackPrimitivesWritten queries when !emulated were not released - Stashed queries were never released - If no render pass is open when a query ends, then getResult(no_wait) ended up waiting Bug: angleproject:5404 Change-Id: I8ce13ea76ffd31b3152ded7c713c6466d0315504 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2573580 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Charlie Lao <cclao@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
Jonah Ryan-Davis authored
Right now the GLX backend checks for resize on every SwapBuffers call. If EGL_ANGLE_window_fixed_size is used, it will only resize when signaled by Chrome. Bug: chromium:1132827 Change-Id: Ia4ddbbbf6dcf13f46ad564208eccc517de8be33c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2572886Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
-
Courtney Goeltzenleuchter authored
Some callers of queueSubmitOneOff require that the command being queued to have been sent to the GPU. The new ensureSubmission parameter indicates that behavior and when running with threaded worker will wait for the worker queue to empty before returning. Bug: b/170312581 Change-Id: Ib620fb37f4b9b4431451ccbd10807c0dff1842af Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2579041Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Cody Northrop <cnorthrop@google.com> Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
-
Kenneth Russell authored
This helps the WinCairo port of WebKit use ANGLE; warning messages sent to stdout are causing layout test failures. Bug: angleproject:5432 Change-Id: Idc6d3061a2dbf13d5f118285aa9b8438542966aa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2576038Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
James Darpinian <jdarpinian@chromium.org> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org>
-
Shahbaz Youssefi authored
I/O blocks can specify location for each member of the block separately, in arbitrary fashion. This change fixes up the code that validates varying locations to take this into account. Bug: angleproject:3580 Change-Id: If883347fc5db9f18722e41938d1b61fa64650d0c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2578047Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Mohan Maiya <m.maiya@samsung.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
-
Jamie Madill authored
Requires a custom define for output. Bug: angleproject:3572 Change-Id: I3721c4067c61f3e22ce7c047054b74d3fe468d8f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2578058Reviewed-by:
Tim Van Patten <timvp@google.com> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
Courtney Goeltzenleuchter authored
Had several validation errors with YUV ImageTests using Vulkan back-end. This corrects those issues and tests now pass. Initializing YUV AHardwareBuffers requires Android API 29. The CI bots are not yet to Android 29 so this must be tested locally by compiling with the appropriate api level in args.gn: android32_ndk_api_level = 29 android64_ndk_api_level = 29 Test: ImageTestES3.SourceYUVAHBTargetExternalRGBSampleInitData Note: Some tests can run at api 26: ImageTestES3.ClearYUVAHB ImageTestES3.YUVValidation Bug: angleproject:4852 Bug: b/172649538 Bug: b/175021871 Change-Id: I383d24faa9911f77a71bd9b764232ad519b54e9a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2530454 Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Cody Northrop <cnorthrop@google.com>
-
Shahbaz Youssefi authored
In preparation for support for mid-block location qualifiers. Bug: angleproject:3580 Change-Id: Ia63f20c8dc26e8f0e90371c4f00913585a22267a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2577983Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
-
angle-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/7c84426d2abe..84b9bb6621c7 2020-12-07 ynovikov@chromium.org Add status host to CQ config 2020-12-07 sugoi@google.com Fix some minor tracing mistakes If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: If0873584f3e5416e734c499111d7741dbab8592e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2578666Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/dd69df7f3dac..c594de23cdd7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: Ia325f50d8b8b700c6eb14a261f4ddf4ef57f4614 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2578665Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/chromium/src.git/+log/bbe26af29575..a3984b7ec4ae If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/b7fc8c9ce5..115823df49 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/95c0c5beb0..baeb2e9897 * third_party/Python-Markdown: https://chromium.googlesource.com/chromium/src/third_party/Python-Markdown/+log/ad4fc19d61..2bb7b23b63 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/1e294aea80..29b47fedf0 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..4565794f5e * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/500b2c2243..129acc201e * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/c29ee8c9c3..2c183c9f93 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/9ec0bb3220..36810de981 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/58c3aa7c7b..dddd39ba5a No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: I44b0fdc9faf8d3bf5d978cdd1a210b10dcabbaef Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2578642Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
Shahbaz Youssefi authored
Bug: angleproject:5439 Change-Id: I218a4459897a9d543269effeea4caf05174e1589 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2577984Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
-
Shahbaz Youssefi authored
As extra validation that new tests are indeed correct. Bug: angleproject:3580 Change-Id: I4792bd8e26f96ab6c988f2605f053ce5789a782f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2577818Reviewed-by:
Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
-
Cody Northrop authored
Add it to the list of debug functions we skip. Test: Seven Deadly Sins MEC Bug: b/174965026 Bug: angleproject:5337 Change-Id: Ifa2bd9cf12abda20df0c693c149be50d57ee6e62 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2576814Reviewed-by:
Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
-
- 07 Dec, 2020 9 commits
-
-
James Darpinian authored
libGLESv2 builds with these changes on iOS, iOS Simulator, and Mac Catalyst, using CGL or EAGL as appropriate. Tests will require more work. Fixed several errors in the EAGL code which hadn't been detected because the code wasn't built. Bug: angleproject:4256 Bug: angleproject:5417 Change-Id: I29072d82607ef2500732c5cc00318fdab4a46b31 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2570211Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: James Darpinian <jdarpinian@chromium.org>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/142cb87f803d..dd69df7f3dac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: Ib2c695c9b5b6f6509fd780edfa56ac2cafe5b021 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2572359Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
-
jchen10 authored
The tests IndexBufferOffsetTest.UInt16Index and StateChangeTest. VertexBufferUpdatedAfterDraw can pass 26.20.100.8141 now. Bug: angleproject:2663 Bug: angleproject:2664 Change-Id: I0324767f5c538879d865cf12304da4625d49bd81 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1166598 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
Paul Thomson authored
Test: angle_perftests --gtest_filter="*whatsapp*" Bug: b/174256233 Change-Id: Ie6abb3beae8e184633005a325c5dce51f0afff40 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2574837Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Cody Northrop <cnorthrop@google.com> Commit-Queue: Paul Thomson <paulthomson@google.com>
-
Jamie Madill authored
Geometry shaders weren't being processed in some of the separable shader logic. This CL fixes two cases: one in Program and one in ProgramPipeline. Bug: angleproject:5409 Change-Id: I19adc5c11a54814d28dd20574a5e038ca9dbd021 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2574827 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Tim Van Patten <timvp@google.com> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org>
-
Jamie Madill authored
The 3.2 spec and the dEQP tests are quite clear in only requiring the 'flat' on fragment shader inputs. This restriction remains on older shader versions. Bug: angleproject:5409 Change-Id: Icc4b113b404280c2867a3e0bf6f77256a4316bff Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2574826 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Tim Van Patten <timvp@google.com> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org>
-
jchen10 authored
The failed DepthRangeUpdates case can pass on 26.20.100.8141 now. Bug: angleproject:2844 Change-Id: I1398ab6c4676c1a6bc8f9514b1559ac1e37ed086 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2096337Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
-
angle-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/bae138de13ac..7c84426d2abe 2020-12-05 capn@google.com Remove stlport C++11 extensions 2020-12-04 ynovikov@chromium.org Add CQ configuration. 2020-12-04 amaiorano@google.com Add unit test for ENABLE_RR_EMIT_ASM_FILE 2020-12-04 amaiorano@google.com Kokoro: isolate flag enabling for incremental builds 2020-12-04 amaiorano@google.com Kokoro: upgrade Linux build from gcc 7 to 9 2020-12-04 capn@google.com Fix stringification of macro value 2020-12-04 capn@google.com Allow configuring Reactor's anonymous mmap name 2020-12-04 capn@google.com Remove named anonymous mmap for GL/VK allocations If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I574736428ee405724731a937acdb95e914564f2a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2575507Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/chromium/src.git/+log/6991410be08c..bbe26af29575 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/33d5eb7739..b7fc8c9ce5 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/a2515f6c44..95c0c5beb0 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..88efddc6a1 No update to Clang. Bug: None Tbr: ianelliott@google.com Change-Id: Ic27236790c9e926431a6b1925a7d191cdb29cfea Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2576445Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
- 05 Dec, 2020 4 commits
-
-
Shahbaz Youssefi authored
An in-render-pass clear now pauses transform feedback so it wouldn't contribute to it. Since it's not possible to resume the transform feedback in the same render pass (as it needs a memory barrier for its counter buffer), the render pass is broken after the clear. Bug: angleproject:5426 Change-Id: I1eaf8c153d076bd912a4a08c65960c12f00341ef Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2573579 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Charlie Lao <cclao@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
Zentaro Kavanagh authored
- -Wfinal-dtor-non-final-class warns on classes with final dtors but not final classes. - Error messages are better when the class is marked final. - Fix existing issues in code base Bug: chromium:999886 Test: no errors building Change-Id: I62301f2f0b9108b08e0a749fbe261beb36b1996f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2575923 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org>
-
Shahbaz Youssefi authored
This is simply done by specifying max_vertices=1. Bug: angleproject:5411 Change-Id: I50318128cca0e96a8b7c7e5d01165b9ef46b4db8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2574823 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Tim Van Patten <timvp@google.com>
-
angle-autoroll authored
https://chromium.googlesource.com/chromium/src.git/+log/78187c025ba6..6991410be08c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/b85da6c931..33d5eb7739 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/cd2895768d..a2515f6c44 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..88efddc6a1 * third_party/libjpeg_turbo: https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git/+log/d5148db386..bbb828223e * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/1be42a5a07..500b2c2243 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/9893e506b3..c29ee8c9c3 No update to Clang. Bug: None Tbr: ianelliott@google.com Change-Id: Ie45a97dc9a1523d86e963173c8cbbee2c81be619 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2575916Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
- 04 Dec, 2020 3 commits
-
-
Tim Van Patten authored
There are a few places that will remain std::unordered_map due to build or run-time errors, which will need to be evaluated more closely to determine if they should remain std::unordered_map or if there is another Abseil data structure that would be more efficient while still working correctly. Bug: angleproject:4873 Change-Id: Ib04253e3ad6398e63f4cc2bfe12c0f9e57cb112b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2558873 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Charlie Lao <cclao@google.com>
-
Shahbaz Youssefi authored
When the render pass breaks while transform feedback is active, the subsequent render passes didn't restart transform feedback because of a missing dirty bit. Bug: angleproject:5426 Change-Id: Icee79cbdabbceab96973cea124240ac7ced82d55 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2572878 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Charlie Lao <cclao@google.com>
-
Shahbaz Youssefi authored
Bug: angleproject:5406 Change-Id: Ifb7553e87164c204353e1ed94b8d64f5fb4b7206 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2574822Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
-