Bug: angleproject:2733
Change-Id: Ica4a3d4f53dc1f0b5beb33cfa8f996acbaa496d3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1765890
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

This reverts commit 552f5fcb.

Reason for revert: Causing flakiness in "confirm no-op" CQ step.
See issue for more details.

Bug: chromium:997016

Original change's description:
> Vulkan: Use VK repos' internal BUILD.gn files
> 
> This retires custom BUILD.gn files for the Vulkan Headers, Tools,
> Validation-Layers, and Loader repos. They now have integrated BUILD.gn
> files so switched ANGLE to use those by default.
> Also Validation Layer, Loader, and Tools repos no longer uses codegen
> so this speeds up the build overall.
> Switched over from old VK_LAYER_LUNARG_standard_validation meta-layer
> to VK_LAYER_KHRONOS_validation unified layer.
> 
> This changes includes a temporary workaround to the Vulkan-Loader repo
> to remove its Window's build dependence on WDK. There are plans to
> remove that depenedence in Loader master, but until then we can use
> our custom branch workaround.
> It also includes a custom branch for validation layers that includes
> some build fixes for ANGLE.
> Finally, the layers were crashing on Android when attempting to use
> DebugUtils extension so forcing DebugReport on Android for now.
> 
> Bug: angleproject:2449
> Bug: angleproject:3320
> Bug: angleproject:3852
> Change-Id: I48b36acefcc7f2bc930eb72d6fdbc87bca24f833
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1610438
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Commit-Queue: Tobin Ehlis <tobine@google.com>

TBR=ynovikov@chromium.org,tobine@google.com,syoussefi@chromium.org,jmadill@chromium.org

Change-Id: Iec97ba8cb5c38fa56bfd4c0afb0f7af8d68513ff
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: angleproject:2449, angleproject:3320, angleproject:3852
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1767363Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

This reverts commit 58940f67.

Reason for revert: pixel test failures have been triaged in Gold. Relanding.

Original change's description:
> Revert "Make Mac SystemInfo reflect the currently active GPU on dual GPU machines"
> 
> This reverts commit 720a8bab.
> 
> Reason for revert: pixel test failures per http://crbug.com/984780#c13
> 
> Original change's description:
> > Make Mac SystemInfo reflect the currently active GPU on dual GPU machines
> > 
> > Currently, the GetSystemInfo() function (in gpu_info_util/SystemInfo_mac.mm)
> > on dual GPU Macs always updates the active GPU field of the SystemInfo
> > instance to the first non-Intel GPU it finds. This change overrides the
> > activeGPUIndex field of the SystemInfo instance to reflect the current GPU
> > instead of the non-intel GPU.
> > 
> > Bug: 985486, 984780, angleproject:3701
> > Change-Id: Ia93f38f4a2f7728c05e99c83a940722bd3808766
> > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1752334
> > Commit-Queue: Kenneth Russell <kbr@chromium.org>
> > Reviewed-by: Zhenyao Mo <zmo@chromium.org>
> > Reviewed-by: Kenneth Russell <kbr@chromium.org>
> 
> TBR=zmo@chromium.org,geofflang@chromium.org,kbr@chromium.org,dakshidnani@google.com
> 
> Change-Id: Iacf4b8433ac1aa4d30c51f08ddfc6489af440cc4
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 985486, 984780, angleproject:3701
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1757373
> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>

Bug: 985486, 984780, angleproject:3701
Change-Id: I8f2f26f68329a2826a92742c46471b8c092b36ed
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1765963Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>

Current implementation of built in function lookup uses
autogenerated switch statements. Instead, use the perfect
hash mapping to have the lookup use arrays instead. This
will improve runtime performance.

Bug: angleproject:3805
Change-Id: I6d0ba62d79abd53a7fe818fe675282800781f256
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1756883
Commit-Queue: Clemen Deng <clemendeng@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

This retires custom BUILD.gn files for the Vulkan Headers, Tools,
Validation-Layers, and Loader repos. They now have integrated BUILD.gn
files so switched ANGLE to use those by default.
Also Validation Layer, Loader, and Tools repos no longer uses codegen
so this speeds up the build overall.
Switched over from old VK_LAYER_LUNARG_standard_validation meta-layer
to VK_LAYER_KHRONOS_validation unified layer.

This changes includes a temporary workaround to the Vulkan-Loader repo
to remove its Window's build dependence on WDK. There are plans to
remove that depenedence in Loader master, but until then we can use
our custom branch workaround.
It also includes a custom branch for validation layers that includes
some build fixes for ANGLE.
Finally, the layers were crashing on Android when attempting to use
DebugUtils extension so forcing DebugReport on Android for now.

Bug: angleproject:2449
Bug: angleproject:3320
Bug: angleproject:3852
Change-Id: I48b36acefcc7f2bc930eb72d6fdbc87bca24f833
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1610438Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Tobin Ehlis <tobine@google.com>

Update all Sampler handles to type SamplerID, preparing for midframe
capture of sampler.

Bug: angleproject:3804
Change-Id: I9337919f97d61e28718987612d642c569b90246a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1761780
Commit-Queue: Jiacheng Lu <lujc@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Built in variable gl_DrawID is exposed to ESSL1 with
a suffix, when the variable is the exact same. No need
to do this.

Bug: angleproject:3805
Change-Id: I63c71791bb6a0e8aa7b644171a3f5a81099eddc0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1762359Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Clemen Deng <clemendeng@google.com>

Remove skipping of groupMemoryBarrierAndBarrierTest on NVIDIA.

BUG=angleproject:2280

Change-Id: I9ea72939cd0f828295bb694c9d3515ef554c9a36
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1763948
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

This reverts commit 720a8bab.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Make Mac SystemInfo reflect the currently active GPU on dual GPU machines
> 
> Currently, the GetSystemInfo() function (in gpu_info_util/SystemInfo_mac.mm)
> on dual GPU Macs always updates the active GPU field of the SystemInfo
> instance to the first non-Intel GPU it finds. This change overrides the
> activeGPUIndex field of the SystemInfo instance to reflect the current GPU
> instead of the non-intel GPU.
> 
> Bug: 985486, 984780, angleproject:3701
> Change-Id: Ia93f38f4a2f7728c05e99c83a940722bd3808766
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1752334
> Commit-Queue: Kenneth Russell <kbr@chromium.org>
> Reviewed-by: Zhenyao Mo <zmo@chromium.org>
> Reviewed-by: Kenneth Russell <kbr@chromium.org>

TBR=zmo@chromium.org,geofflang@chromium.org,kbr@chromium.org,dakshidnani@google.com

Change-Id: Iacf4b8433ac1aa4d30c51f08ddfc6489af440cc4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 985486, 984780, angleproject:3701
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1757373Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/0cbdc7a2c35b..aef8f92b2bb6


Created with:
  gclient setdep -r ./third_party/spirv-tools/src@aef8f92b2bb6

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


Bug: None
TBR=jonahr@chromium.org,jonahr@google.com
Change-Id: I6294a75d72198b951506b298e571692e4bcf31c8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1764654Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

WebKit's build process requires that every Objective-C class name begin with the
prefix "Web". While this is unfortunate, we only have one Objective-C class in
the codebase that needs to change so we might as well just do it.

Bug: angleproject:3439
Change-Id: I07d1f5478b067f680971d0f24befe2f63651c735
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1764649Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: James Darpinian <jdarpinian@chromium.org>

Currently, the GetSystemInfo() function (in gpu_info_util/SystemInfo_mac.mm)
on dual GPU Macs always updates the active GPU field of the SystemInfo
instance to the first non-Intel GPU it finds. This change overrides the
activeGPUIndex field of the SystemInfo instance to reflect the current GPU
instead of the non-intel GPU.

Bug: 985486, 984780, angleproject:3701
Change-Id: Ia93f38f4a2f7728c05e99c83a940722bd3808766
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1752334
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>

Bug: angleproject:3611
Change-Id: I65018823a8d7223de0f63ea5bd6a573f62f1c24b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1748884
Commit-Queue: Jiacheng Lu <lujc@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

The first parameter of glGetFramebufferParameterivRobustANGLE should be
`GLenum target`.

Bug: angleproject:3826
Change-Id: Ice4ea265389794a51838d8e61fff774c55588512
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1762714Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jiacheng Lu <lujc@google.com>

Bug: angleproject:2898
Change-Id: I7c8e548a1a449f48225516c37d830ecc201b064d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1762496Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

With updated validation layers Vulkan backend is hitting two new
errors. This CL fixes one and works around (WA) another.

Fixes issue where a Buffer used in vkCmdDispatchIndirect() did
not have VK_BUFFER_USAGE_INDIRECT_BUFFER_BIT set so now setting
that usage bit for all buffers.

WA issue where invalid topologies enabled primitiveRestart so
ignoring that VUID initially until complete fix is implemented.

Bug: angleproject:3832
Change-Id: Ie3f681eaf9e2051c27bdf00a35dc50d8ad4a2528
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1763196Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Tobin Ehlis <tobine@google.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/95609e6d923a..34cccdc65d79


Created with:
  gclient setdep -r ./third_party/glslang/src@34cccdc65d79

The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-angle-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


Bug: None
TBR=jonahr@chromium.org,jonahr@google.com
Change-Id: I081646d2e3a52bf36108313bf531d3308eaed98c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1763168Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/bc62722b80a6..0cbdc7a2c35b


Created with:
  gclient setdep -r ./third_party/spirv-tools/src@0cbdc7a2c35b

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


Bug: None
TBR=jonahr@chromium.org,jonahr@google.com
Change-Id: I18367493052de4c05c85e2e1b6d080e70bee4f5e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1763169Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

When we have xfb descriptor set without buffer bindings it causes
errors in Vulkan validation layer. So we set empty buffer by default.

BUG=angleproject:3681
Tests: dEQP-GLES3.functional.*transform_feedback*
dEQP-GLES3.functional.lifetime.attach.deleted_input.buffer_vertex_array

Change-Id: I4e7c9c9ee661f1fc92bf01fb78a2212c1a423eaa
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1753387
Commit-Queue: Hyunchang Kim <hckim.kim@samsung.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

The android binary size is increased incorrectly because the autogen
kFunction* variables are detected as mutable constants. Rename them to
function* to workaround this.

Bug: angleproject:3823
Change-Id: Ia335d1ae97ce5276a0ff8b9e432b53181cc36680
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1762494Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>

Only use UInt gl_ViewID_OVR from ESSL3
OVR multiview should not be exposed in ESSL1

Bug: angleproject:3822
Change-Id: Ia9d6247e3a717b06db26f1d436e2b33336b12a7d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1759143Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Clemen Deng <clemendeng@google.com>

Make a separate dirty bit DIRTY_ATTRIB_POINTER_BUFFER for vertex
attrib's binding buffer change. So in handling glVertexAttribPointer,
ANGLE will only modify a vulkan graphics pipeline when attrib.format,
attrib.stride or attrib.divisor change. If only the VBO pointer changes,
then Vulkan can update the state via "vkCmdBindVertexBuffers()" without
triggering a pipeline update.

Bug: angleproject:3256
Change-Id: I01e02adde3708963b496a20050a5723e8eb57ab2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1707614Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jiacheng Lu <lujc@google.com>

When an interface block's field is determined to be active, it's
possible that the field is a struct so each of that field's fields need
to be marked active as well.

Bug: angleproject:3596
Test: dEQP-GLES31.functional.program_interface_query.*
Test: end2end ProgramInterfaceTestES31
Change-Id: I0bf550046a7a1d3c92cc08773138a40400e5e73b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1749332Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>

Games:
SkyEngine: Open source on github
The Deep Deep: Geoff's game

Bug: angleproject:3620
Change-Id: I5feee91a94648b385708cafe8d7412e86704ecd0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1721189
Commit-Queue: Clemen Deng <clemendeng@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

Might be related to Goma and C files on Windows.

Bug: chromium:995046
Change-Id: If80168356a1e2a60abe8dfbf89aeed7298fd0a54
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1758998Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Need to rename kVar* variables to just var

Bug: angleproject:3823
Change-Id: I34b9f4eec4ee7829d47dcac2f06f1acc6b35f867
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1758601Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Clemen Deng <clemendeng@google.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/7b4e5bd5ec82..bc62722b80a6


Created with:
  gclient setdep -r ./third_party/spirv-tools/src@bc62722b80a6

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


Bug: None
TBR=syoussefi@chromium.org
Change-Id: Icc053f2d4f640868fa010e835f1c9c98e2b1bdcd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1760588Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

This appears to be caused by the UpdateSubResource call,
which is worked around by enabling the other image upload
path that ANGLE supports.

The workaround doesn't include a driver version, since the
bug is occurring in the most recent driver that is currently
available (15.40.42.5063, released 19th Mar 2019).

Firefox bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1562462

Change-Id: I5135dcf6da6ef530c99124a04003d54f99e4cd7c
Bug: angleproject:3764
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1731975
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

Add a USE_SYSTEM_EGL define to allow compilation on Unix systems
without X11.

Feature detect __popcnt using Microsoft-specific _MSC_VER rather than
_M_X64/_M_IX86, which can be set by the Dinkumware stdlib on
non-Microsoft systems.

Apple's clang is too old to have -Wextra-semi-stmt

Ran generate_parser.sh using Cygwin64 bison 3.0.4, flex 2.6.4

Bug: 3439
Change-Id: Ie0d01a112a17f70ef60c120063a958b8f1a094f4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1759135
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>

This test fails on the Vulkan backend because Vulkan does not allow
arrays of arrays of samplers.

Also adds a few other tests relating to arrays of arrays.

Test: ./angle_end2end_tests --gtest_filter='GLSLTest_ES31.*'
Bug: angleproject:3604
Change-Id: I5c47119b6ba6d26fe30fdd9c6730caac6f222696
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1733476
Commit-Queue: James Dong <dongja@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

Removes the "EVENT: " prefix from every trace message. Also removes the
extra blank line between trace entries. And fixes a missing space in
EGL_WaitSyncKHR.

Bug: angleproject:3815
Change-Id: Id6321357a56477da29de121abb51c721b11d99da
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1756084Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Added GL built-in functions to symbol table autogeneration
Built-in lookup now checks against spec and returns GL
symbols when appropriate.

Bug: angleproject:3719
Change-Id: I74786150f6063b40e13aebcb2eb9ea35e4ecaa53
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1731550Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Clemen Deng <clemendeng@google.com>

Per spec, in eglCreateContext when client version attributes are invalid - set
EGL_BAD_ATTRIBUTE. Set EGL_BAD_MATCH when config is not compatible.
Rename config variables in ValidateCompatibleConfigs to distinguish context
from surface configs. Context config handled differently when EGL_NO_CONFIG.

Bug: angleproject:3755
Test: angle_end2end_tests --gtest_filter=EGLCreateContextAttribsTest*
Change-Id: Iaea57653cf643ff60c8d4eabd3f022306bf1f4ca
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1747298Reviewed-by: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>

These tests are now passing with vulkan backend. Remove
them from the expectations file

Bug: angleproject:3679
Test: dEQP-GLES3.functional.state_query.fbo.framebuffer_attachment_texture_layer
Change-Id: Ifb07b3743bf4ea0a7a98c33ae15cce46f6f2f75b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1758683Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

This should give a more robust replay. Devices are not guaranteed to
return IDs in the same order in each instance of a program. Also for
mid-execution capture we often won't have the same resources available.

Once the Renderbuffer implementation lands we can switch to using more
resource maps for different types of resources.

Bug: angleproject:3611
Change-Id: I84a5b84856be3e8eb13e424e1990a39553adb82e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1719066Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Splitting out two bugs from 3458.  Most of failing tests are failing
because of Vulkan validation errors in the ANGLE glDrawArrays code.
In those csaes, the copy_tex_image test code actually passes, but the
ANGLE test-runner code is marking the tests as failing because of
Vulkan validation errors.

Bug: angleproject:3458
Bug: angleproject:3817
Bug: angleproject:3818
Change-Id: Idd91d9e44fa7eb6f527425dd77d6cbf949aa5e61
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1756816
Commit-Queue: Ian Elliott <ianelliott@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

This Context could already be deleted from another thread. Better to
use save/load with the current thread.

Bug: angleproject:2464
Change-Id: Id7879a53bdfb7d1c86b09bb3e779a87afdefa873
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1756086Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Tobin Ehlis <tobine@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/ff872dc6bf9f..7b4e5bd5ec82


Created with:
  gclient setdep -r ./third_party/spirv-tools/src@7b4e5bd5ec82

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


Bug: None
TBR=syoussefi@chromium.org
Change-Id: Id2cd2aa4e98750f80dc7b023e48d4708c12a6b7d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1757865Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

Split from https://chromium-review.googlesource.com/c/angle/angle/+/1705035/27

This patch adds entrypoints glDrawArraysInstancedBaseInstanceANGLE,
glDrawElementsInstancedBaseVertexBaseInstanceANGLE,
glMultiDrawArraysInstancedBaseInstanceANGLE,
and glMultiDrawElementsInstancedBaseVertexBaseInstanceANGLE

Implementation will come in a later separate patch.

Bug: chromium:891861, angleproject:3402
Change-Id: I18e19b850cddd79be4798b9ae7efe0680a050c7f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1750125
Commit-Queue: Shrek Shao <shrekshao@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

Bug: 993965
Change-Id: I4fd357bdebc73b7256ae4b34bd1c6aa2f4418e27
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1756503Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>