Commits · 20ed6bcbac9becd25e3c4b0ed4bc85bd637f4375 · Chen Yisong / angle

08 Jan, 2020 3 commits

Roll third_party/SwiftShader 068dd89cab31..45a4d0f36bd6 (5 commits) · 20ed6bcb

authored Jan 08, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/068dd89cab31..45a4d0f36bd6

git log 068dd89cab31..45a4d0f36bd6 --date=short --first-parent --format='%ad %ae %s'
2020-01-08 capn@google.com Disable unused function warning
2020-01-07 bclayton@google.com Regres: Apply fix for invalid SPIR-V in 12 tests.
2020-01-07 capn@google.com Disable LLVM & Subzero stack traces and crash handling
2020-01-07 digit@google.com vulkan: use a marl::Event in the VkSemaphore implementation.
2020-01-07 digit@google.com [vulkan] Simplify vk::Semaphore implementation.

Created with:
gclient setdep -r third_party/SwiftShader@45a4d0f36bd6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cwallez@google.com
Change-Id: I5b338a33ea57117912e019075c52f09351badea7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1990982Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

20ed6bcb

Roll third_party/glslang/src 1d258ac34698..1642ca11282a (1 commits) · 90bf5bec

authored Jan 08, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/1d258ac34698..1642ca11282a


Created with:
  gclient setdep -r third_party/glslang/src@1642ca11282a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cwallez@google.com
Change-Id: I6a686ddc411f6e2087b146fbd146c6a63675bf34
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1990984Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

90bf5bec

Roll third_party/vulkan-tools/src 55333361f9a1..2c436960d2c0 (1 commits) · d0788509

authored Jan 08, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/55333361f9a1..2c436960d2c0

git log 55333361f9a1..2c436960d2c0 --date=short --first-parent --format='%ad %ae %s'
2020-01-07 charles@lunarg.com vulkaninfo: Make presentation surface names a set

Created with:
  gclient setdep -r third_party/vulkan-tools/src@2c436960d2c0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-tools-angle-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cwallez@google.com
Change-Id: If653af60cbc98b72138c4e1768ec7ccae4f6543c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1990981Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

d0788509

07 Jan, 2020 10 commits

Vulkan:Roll volk · db49bc7d

authored Jan 07, 2020

Roll volk to the latest version which supports Vulkan 1.1.130.
I'm attempting to upstream our customizations to that version so
this roll is in preparation of those changes hopefully landing.

Bug: angleproject:4225
Change-Id: I02f3bd3808f812c0ec8196b6c815a781e7ab5eeb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1989479Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Tobin Ehlis <tobine@google.com>

db49bc7d

Vulkan: Update number of samples when changing draw framebuffer · c8d7f047

authored Jan 07, 2020

This fixes a crash (preceeded by Vulkan validation errors) when running
the following test:

--gtest_filter=dEQP.KHR_GLES31/core_texture_storage_multisample_FunctionalTests_blitting_multisampled_depth_attachment* --use-angle=vulkan

The problem is that GraphicsPipelineDesc::updateRasterizationSamples()
is rarely called (e.g. glBindFramebuffer).  The above dEQP test changes
between draw attachments that do and don't have multisampling enabled.
The number of samples is set (the first time) to have multisampling
enabled, and never changed, even though other attachments don't have
multisampling.

FramebufferVk::syncState() now calls updateRasterizationSamples().  That
fix uncovered a latent problem: when an application destroys all
framebuffers (including the draw framebuffer), the ContextVk still
points at the old draw framebuffer's FramebufferVk (now freed).  This
is fixed with new plubming to clean-up ContextVk::mDrawFramebuffer.

Bug: angleproject:4240
Change-Id: I151ec40ab821efc07c26323c34275c9165ad2ed5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1983393Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Ian Elliott <ianelliott@google.com>

c8d7f047

Vulkan:Enable DebugUtils extension for Android · 2c63b83c

authored Jan 03, 2020

Enable DebugUtils Vulkan extension for Android.
This rolls VK Validation Layer dep forward to include a fix that
allows this extension to work correctly with Android loader.
Here's the Validation layer fix:
https://github.com/KhronosGroup/Vulkan-ValidationLayers/pull/1464

Bug: angleproject:3852
Change-Id: I74c55c0a66a7ee4db3b623221c8fb6c4433a39af
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1985175
Commit-Queue: Tobin Ehlis <tobine@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

2c63b83c

Suppress VertexAttributeTest.DrawArraysWithBufferOffset on Mac NVIDIA · cbbb3aaf

authored Jan 07, 2020

The test fails with the following at a very low flake rate:
../../third_party/angle/src/tests/gl_tests/VertexAttributeTest.cpp:230: Failure
Expected equality of these values:
  angle::MakeGLColor(255, 255, 255, 255)
    Which is: White
  angle::ReadColor((midPixelX + viewportSize[2]) / 2, midPixelY)
    Which is: Transparent Black

TBR=jmadill@chromium.org
Bug: angleproject:4269
Change-Id: I82752acfbcb2a067ccb35a7a456def03299c359f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1987258Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

cbbb3aaf

Roll third_party/SwiftShader 10a900e5ffaf..068dd89cab31 (7 commits) · ce396c03

authored Jan 07, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/10a900e5ffaf..068dd89cab31

git log 10a900e5ffaf..068dd89cab31 --date=short --first-parent --format='%ad %ae %s'
2020-01-06 bclayton@google.com SPIRV-Tools: Update Android.bp to fix build.
2020-01-06 capn@google.com Limit Vulkan memory allocation size to 1 GiB
2020-01-06 bclayton@google.com IDs: Move inline impls below class.
2020-01-06 bclayton@google.com Pipeline: Store builtins on SpirvRoutine...
2020-01-06 bclayton@google.com Style: clang-format the tests source too
2020-01-06 bclayton@google.com Merge changes Id1120acb,Ifc6afcda,I8b5da04a,I9389ad9e,I35d60f68
2020-01-06 sugoi@google.com Improve 1010102 blend precision

Created with:
gclient setdep -r third_party/SwiftShader@068dd89cab31

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cwallez@google.com
Change-Id: I9df3cbc0059453193adfbee90f767d06c0149fa2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1989339Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

ce396c03

Roll third_party/glslang/src 6334d594f68c..1d258ac34698 (3 commits) · 806b06a2

authored Jan 07, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/6334d594f68c..1d258ac34698


Created with:
  gclient setdep -r third_party/glslang/src@1d258ac34698

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cwallez@google.com
Change-Id: If27787415b62ecdeee7192fdb6663e8b80cdec79
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1989337Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

806b06a2

Roll third_party/vulkan-validation-layers/src 2be3fe0f8471..b416ed86e4b2 (1 commits) · 0d467595

authored Jan 07, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/2be3fe0f8471..b416ed86e4b2

git log 2be3fe0f8471..b416ed86e4b2 --date=short --first-parent --format='%ad %ae %s'
2020-01-06 mark@lunarg.com layers: Added stub functions for instance exts and funcs

Created with:
gclient setdep -r third_party/vulkan-validation-layers/src@b416ed86e4b2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cwallez@google.com
Change-Id: I1b8ae6d289e25c34c731c4acd42c30dead3ea6d4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1989338Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

0d467595

Vulkan: Reorder descriptor sets · 806d812e

authored Jan 03, 2020

This change moves driver uniforms to a set with a lower id than the one
that includes (emulation) transform feedback buffers. Imagine the
following:

- Program 1 with xfb: UniformsSet: 1 VS uniforms buffer, 1 FS uniforms
buffer, 1 xfb buffer
- Program 2 without xfb: UniformsSet: 1 VS uniforms bufer, 1 FS uniforms
buffer.

Previously, UniformsSet was index 0, and DriverUniformsSet was index 3.
When switching from Program 1 to Program 2, the layout of UniformsSet
changes, which means every subsequent set needs to be rebound. This is
a Vulkan pipeline layout compatibility rule. This is done with
invalidateCurrentTextures() and invalidateCurrentShaderResources()
already when handling gl::State::DIRTY_BIT_PROGRAM_EXECUTABLE. The bug
is that the driver uniforms are not invalidated.

This is normally not an issue, because usually when switching from
Program 1 to Program 2, transform feedback is paused, and this state
change does invalidate driver uniforms. However, the following scenario
doesn't do this:

- Begin Xfb
- Pause Xfb
- Use Program 1
- Draw
- Use Program 2
- Draw
- End Xfb

There is no driver state change between the two draw calls, which means
the second draw will attempt to draw using the driver uniforms bound for
the first draw call. There is a Vulkan validation error here due to the
above pipeline layout validation rule.

The issue manifests itself only when the second draw call actually uses
driver uniforms, as otherwise that set is inactive and not validated;
i.e. when line raster emulation is used.

In summary, the validation error manifests itself when:

- Transform feedback and line raster both use emulation
- Transform feedback is paused
- A draw with an xfb program is followed by a non-xfb program
- The second draw is a line draw

A test is added for this.

The solution is to reorder the sets so that DriverUniformsSet is placed
before UniformsSet. This way, changes to the layout of UniformsSet
don't invalidate DriverUniformsSet.

In fact, based on the above, any change in the layout of the program
should have required an invalidation of the driver uniforms. This bug
is probably masked by the fact that
ContextVk::handleDirtyDescriptorSetsImpl() always rebinds the graphics
driver every time any descriptor set needs rebinding. That should be
removed in a follow up change.

Bug: angleproject:4261
Change-Id: I21ad4152b454a1fe70554be02e18a9c94fb3e7a8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1986927Reviewed-by: Tobin Ehlis <tobine@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

806d812e

Suppress flaky failure with MacOS/NVIDIA/OPENGL · 51e653f0

authored Jan 02, 2020

Seeing intermittent failure on this test only on MacOS/NVIDIA/OPENGL.
Suppress for now.

Bug: angleproject:4258
Change-Id: Ibda30954019410e3b6d069986b2cd0ad26533c00
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1984850Reviewed-by: Shrek Shao <shrekshao@google.com>
Commit-Queue: Shrek Shao <shrekshao@google.com>

51e653f0

EGL: Implement EGL_ANDROID_framebuffer_target · 8c0bbfbb

authored Nov 25, 2019

Add attribute to configs.
Add attribute matching logic.
Does not set attribute in Vulkan configs, need solution to
query Android for which formats are valid. anglebug.com/4208
New end2end test.

Bug: angleproject:3961
Test: angle_end2end_tests --gtest_filter=EGLAndroidFramebufferTargetTest*
Change-Id: I7e14c47b39e9539f6181c3c1d75c76fe63ca0f8c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1960508Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>

8c0bbfbb

06 Jan, 2020 8 commits

Vulkan: Update dEQP source for test fixes · 7dfc99e5

authored Dec 18, 2019

Also fix scripts/gen_vk_gl_cts_build.py to always use '/' as file
separator. Otherwise, running the script on Windows uses '\' which
Linux doesn't like.

Test:
  angle_deqp_gles31_tests --use-angle=swiftshader --gtest_filter=dEQP.GLES31/functional_debug_negative_coverage_get_error_vertex_array_draw_range_elements

Bug: angleproject:2324
Bug: angleproject:4234
Change-Id: I3b212e0d0ba97996f1d86f7fc81e58c3b03a9cbb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1975020
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

7dfc99e5

Vulkan: No line raster emulation code if extension · 0721cc8b

authored Jan 03, 2020

A flag is added to the translator to disable generation of Bresenham
line raster emulation code when the Bresenham line raster Vulkan
extension is present.  This is primarily for the sake of conversion of
line raster emulation condition to specialization constant:

- Avoid dead SPIR-V code in every shader
- Avoid ANGLEUniforms being active in every shader stage even if it's
  not used anywhere but in line raster emulation.
- Optimize SPIR-V transformations by both having fewer instructions to
  iterate through, and to avoid generating line raster patches.
- Reduce the severity of anglebug.com/4251 where the location assignment
  of ANGLEPosition can incorrectly overlap a varying array or struct, by
  making only platforms without Bresenham extension afflicted by the
  bug.

Bug: angleproject:3394
Change-Id: Ic0ae6ce0392b4eae0cc79cb94bbcd0805b276a31
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1986379Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

0721cc8b

GL: Enable EXT_gpu_shader5 · f8ae5dc6

authored Dec 20, 2019

Bug: angleproject:3569
Change-Id: I08666bde75ac158e051817e689e2c0b82d6b6f70
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1978579Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

f8ae5dc6

Fix UWP build · d36780ba

authored Jan 02, 2020

Bug: angleproject:4246
Change-Id: Ifcbb6fe51ee2df6baf86a308de74bab640ded834
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1982632
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

d36780ba

Add missing steps in DevSetup · f64ddcfd

authored Jan 06, 2020

Bug: angleproject:4268
Change-Id: Ib7f58ba241c24acb35d8705d994c57422d9b73e4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1987908
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

f64ddcfd

Fix GGP build · 56fd2bce

authored Dec 17, 2019

Bug: angleproject:4246
Change-Id: I80906196ebc3c904e75516e8c53b05dd81c5fa5c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1982633Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

56fd2bce

Metal: fix vertex attribute's conversion lost after changing buffer binding. · ab42afa6

authored Nov 21, 2019

After vertex buffer's attribute is converted and stored in conversion
buffer. Binding the same attribute to another buffer, then binding it
back to previous buffer will result in previous conversion
information lost. The conversion method would skip the conversion due to
buffer's content hadn't been changed, however it didn't reuse the old
conversion result.

This CL also changed the way binding offset is used in Metal backend.
- Previous, the offset would be assigned to the offset field of
  MTLVertexAttributeDescriptor, then the buffer would simply be bound to
  the command encoder with offset=0
  i.e. setVertexBuffer(buffer, index, 0)
- However this approach has several disadvantages. Since Metal doesn't
  allow MTLVertexAttributeDescriptor's offset to be larger than the
  vertex attribute's stride, the old approach would force the back-end
  to convert the attribute and store in conversion buffer.

New approach:
- MTLVertexAttributeDescriptor's offset will be zero. The offset will be
  used to bind the buffer itself to the render command encoder.
  i.e. setVertexBuffer(buffer, index, offset)
  This way the "offset <= stride" restriction no longer exists. The only
  restriction is the offset must be multiple of attribute's size.

Added 3 new tests:
- SimpleStateChangeTest.RebindTranslatedAttribute
- VertexAttributeTest.DrawWithLargeBufferOffset
- VertexAttributeTest.DrawWithLargeBufferOffsetAndLessComponents

Bug: angleproject:2634
Change-Id: I6c2fa8091436e4a24405d791f86d17d97df02d64
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1940009
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>

ab42afa6

update date comments to 2020 · 3311ef65

authored Jan 03, 2020

run_code_generation.py updated comments with 2019 to 2020.
Put all date updates into this one CL.
This also updated hashes.

Bug: angleproject:4262
Change-Id: Ia213dd5e47f155986cbb4161d777724355878af0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1986994
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

3311ef65

04 Jan, 2020 1 commit

Upstream Mac logging changes from WebKit. · 1031d2c6

authored Jan 03, 2020

Use os_log_with_type in ANGLE's logging facility rather than fprintf.

Bug: angleproject:4263
Change-Id: I0c418fc5544001bf4f47ff511d05de2f0ebaa1de
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1987145Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: James Darpinian <jdarpinian@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>

1031d2c6

03 Jan, 2020 4 commits

Workaround EXT_texture_norm16 for OpenGL ES drivers · 81ee4d29

authored Dec 04, 2019

Implement a workaround for widespread bugs calling glReadPixels with
RGBA/UNSIGNED_SHORT against R16/RG16 color attachments. Read back the
data using the GL_IMPLEMENTATION_COLOR_READ_FORMAT, and then rearrange
the read back pixels to fit the RGBA layout.

Also skip RGB16/RGB16_SNORM texture sample test on Nexus 5X/Nexus 6P
due to a another driver bug.

Bug: chromium:1000354, angleproject:4214, angleproject:4215, angleproject:4245
Change-Id: Iedea6f4136878cac5ad0dec3757c77b73502e1cd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1952166Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Shrek Shao <shrekshao@google.com>

81ee4d29

Roll third_party/vulkan-validation-layers/src e4a2b7f22782..2be3fe0f8471 (7 commits) · de97fb4a

authored Jan 03, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/e4a2b7f22782..2be3fe0f8471

git log e4a2b7f22782..2be3fe0f8471 --date=short --first-parent --format='%ad %ae %s'
2020-01-02 jzulauf@lunarg.com layers: Record initial layout on release barriers
2020-01-02 mark@lunarg.com corechecks: Plumb VtxIndex VUIDs through to helper func
2020-01-02 mark@lunarg.com corechecks: Remove obsolete perf warning
2020-01-02 mark@lunarg.com tests: Removed PerfWarning test from VkLayerTest harness
2020-01-02 mark@lunarg.com bestpractices: Use BP VUID in place of corechecks one
2020-01-02 mark@lunarg.com tests: Added test for missing vtx buffers to BP harness
2020-01-02 mark@lunarg.com bestpractices: Added perf warning for missing vtx buffers

Created with:
gclient setdep -r third_party/vulkan-validation-layers/src@2be3fe0f8471

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: courtneygo@google.com
Change-Id: I80a335bf862d776bc1533f366316f5b899fbfb09
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1986605Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

de97fb4a

Vulkan: Support vertex-only line emulation draw with xfb · 93061d4e

authored Dec 30, 2019

The code that patches the line raster emulation directive assumed both
vertex and fragment shaders would be present.  This is invalid if only a
vertex shader is present.

This change adds the directive to any stage that's available.  This
includes the possibility of a missing vertex shader also, which can be
useful for separable shaders and program pipeline objects.

Bug: angleproject:3394
Change-Id: I84555db81b59c318300003f7108a01f330e4259f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1982782
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

93061d4e

Vulkan: Correct error message for VK_ERROR_INVALID_SHADER_NV · 35e6050f

authored Dec 30, 2019

If an invalid shader is generated, generate the appropriate message
instead of "Unknown error".

Bug: angleproject:3394
Change-Id: I586c99e95cd72daeaf74b4d1eff352942e01d8b7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1982783Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

35e6050f

02 Jan, 2020 1 commit

D3D11: Restrict to translate uniform block to StructuredBuffer · 1fdf6ca5

authored Dec 31, 2019

Only translate uniform block to StructuredBuffer when system is
Windows 10 and later.

Bug: angleproject:3682
Change-Id: I27e3f4503392791883a44e1d486ffe9512e04bd8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1984863
Commit-Queue: Xinghua Cao <xinghua.cao@intel.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

1fdf6ca5

31 Dec, 2019 1 commit

Roll third_party/SwiftShader 59465799210b..10a900e5ffaf (1 commits) · cbbfa2f2

authored Dec 31, 2019

https://swiftshader.googlesource.com/SwiftShader.git/+log/59465799210b..10a900e5ffaf

git log 59465799210b..10a900e5ffaf --date=short --first-parent --format='%ad %ae %s'
2019-12-30 chrisforbes@google.com Add assert in GenericValue constant access

Created with:
  gclient setdep -r third_party/SwiftShader@10a900e5ffaf

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: courtneygo@google.com
Change-Id: Id7ec364a7df7c8389d3bab78761f4b1061d93e10
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1984961Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

cbbfa2f2

30 Dec, 2019 5 commits

EGL: Add support for EGL_KHR_gl_colorspace extension · 942d9152

authored Dec 23, 2019

If the Vulkan backend supports VK_EXT_swapchain_colorspace extension,
enable the option for applications to create surfaces with non-linear
formats. Not all formats have non-linear versions and is platform
specific.

Tests: dEQP-EGL.functional.wide_color.*
       angle_deqp_egl_tests --use-angle=vulkan --deqp-gl-context-type=egl --deqp-case=dEQP-EGL.functional.wide_color.*
Bug: angleproject:2514
Change-Id: I441ee797cceef92c84473bfa18605c4fd8180de1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1951963
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

942d9152

Roll third_party/vulkan-headers/src 0e57fc1cfa56..f63dd5c9d874 (1 commits) · c1fc6de8

authored Dec 30, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/0e57fc1cfa56..f63dd5c9d874

git log 0e57fc1cfa56..f63dd5c9d874 --date=short --first-parent --format='%ad %ae %s'
2019-12-28 flibitijibibo@gmail.com GN: Make PLATFORM_XCB optional, based on a user-defined variable.

Created with:
  gclient setdep -r third_party/vulkan-headers/src@f63dd5c9d874

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-headers-angle-autoroll
Please CC ynovikov@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=ynovikov@chromium.org

Bug: None
Change-Id: I57e5f53b741fce8a14d27af4445fcc31ea860c70
Tbr: ynovikov@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1984191Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

c1fc6de8

Vulkan: clean up arguments to glslang wrapper · f02490d1

authored Dec 23, 2019

Some flags were sent as parameters while an Options parameter was added.
This change moves those flags to the GlslangSourceOptions struct.

Bug: angleproject:3394
Change-Id: Iff5c1c83dd564d7bcfcbd84e6df244b7356d669d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1984108Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

f02490d1

Avoid vector copy in BinaryOutputStream::writeIntVector · 7fad424e

authored Dec 30, 2019

Also adds a unit test to make sure readIntVector and writeIntVector
match. It was not immediately clear that writing the vector size in
writeIntVector is writing an int instead of a size_t.

Bug: angleproject:3394
Change-Id: I09a003c169dbc47e40c0cd3e4da6f1d7a905c6da
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1983162Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

7fad424e

Roll third_party/glslang/src 5de15a256eb0..6334d594f68c (4 commits) · 9fac1817

authored Dec 30, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/5de15a256eb0..6334d594f68c


Created with:
  gclient setdep -r third_party/glslang/src@6334d594f68c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC ynovikov@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: ynovikov@chromium.org
Change-Id: I13837b1d19eccf54aae171349dfadd0d37d7ef77
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1984164Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

9fac1817

27 Dec, 2019 2 commits

Roll third_party/glslang/src bd97b6f9f213..5de15a256eb0 (1 commits) · fca5a005

authored Dec 27, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/bd97b6f9f213..5de15a256eb0


Created with:
  gclient setdep -r third_party/glslang/src@5de15a256eb0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC ynovikov@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: ynovikov@chromium.org
Change-Id: I2324cfed3dd1026a11ead024c805b216481d47ea
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1982965Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

fca5a005

Roll third_party/SwiftShader 6e3a387c0159..59465799210b (1 commits) · ebed8559

authored Dec 27, 2019

https://swiftshader.googlesource.com/SwiftShader.git/+log/6e3a387c0159..59465799210b

git log 6e3a387c0159..59465799210b --date=short --first-parent --format='%ad %ae %s'
2019-12-27 capn@google.com Remove Reactor/MutexLock.hpp

Created with:
  gclient setdep -r third_party/SwiftShader@59465799210b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC ynovikov@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: ynovikov@chromium.org
Change-Id: I10048c2c0d1fd7843762ea3636b1ef29b7200359
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1982966Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

ebed8559

25 Dec, 2019 4 commits

Roll third_party/vulkan-tools/src 37af49fa7b55..55333361f9a1 (1 commits) · 01dd6f6c

authored Dec 25, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/37af49fa7b55..55333361f9a1

git log 37af49fa7b55..55333361f9a1 --date=short --first-parent --format='%ad %ae %s'
2019-12-24 charles@lunarg.com vulkaninfo: exit on invalid gpu selected

Created with:
  gclient setdep -r third_party/vulkan-tools/src@55333361f9a1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-tools-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: I3a08dd0ecc6c3745d29a149fa75d825ddd3b7860
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1981930Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

01dd6f6c

Vulkan: EXT_gpu_shader5: textureGatherOffsets · a35aa03a

authored Dec 20, 2019

The validation of the offsets parameter is added in this change.

Bug: angleproject:3569
Change-Id: Ide2ea4b9e88b28ca5ef34d5f3f5203f6e48d5f74
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1979133Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jiajia Qin <jiajia.qin@intel.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

a35aa03a

Vulkan: EXT_gpu_shader5: Fix textureGatherOffsets builtin · beb33691

authored Dec 20, 2019

This function is the only builtin with arrays as parameter.  A new
constexpr constructor is added to TType to support this, and
gen_builtin_symbols is changed to emit the correct type for offsets
parameter of this function.

Bug: angleproject:3569
Change-Id: I55af58b43f24cd605c622ee685b359535e11ef85
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1975431Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

beb33691

Vulkan : Fix maxVertexOutputComponents · 52dae168

authored Dec 19, 2019

GL_MAX_VERTEX_OUTPUT_COMPONENTS should mirror Vulkan's
reported maxVertexOutputComponents; this shouldn't include
any gl_Position adjustments. It was previously set as
maxVaryingVectors * 4.

The workaround for AMD that reserved an extra varying
due to driver instability is no longer required (see:
https://chromium-review.googlesource.com/c/angle/angle/+/1980272)

Bug: angleproject:4233
Change-Id: I8d7b8eafa7edd4c56005dad039fe69e072692fca
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1975851
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

52dae168

24 Dec, 2019 1 commit

Use TSpan for TType's array sizes · 86d9c93a

authored Dec 16, 2019

Until C++20, std::vector doesn't have a constexpr constructor, which
means TType cannot use a `TVector` for `mArraySizes` if an arrayed type
needs to be created constexpr.  This is needed for the upcoming
textureGatherOffsets implementation.

A new TSpan class is introduced, based on std::span (from C++20) that
holds the pointer/size allocated from a TVector without owning it.
Since TVector's allocation are made from a pool, the allocated memory
will live beyond the vector's destruction.  `TType::mArraySizes` is
changed to this type.

This change will allow a new constexpr constructor to be added to TType
that takes a TSpan as array directly, a value which is constexpr
initialized from a static array (instead of TVector).

Bug: angleproject:3569
Change-Id: I78793b0f4c64519e0ebe30cf6e0de995ba70035d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1968260Reviewed-by: Jiajia Qin <jiajia.qin@intel.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

86d9c93a