Commits · 21203702dfed17bd72535e4bf6faf42abf299d28 · Chen Yisong / angle

14 Nov, 2014 1 commit

Fix precision tracking of constructor return values · 21203702

authored Nov 13, 2014

Precision should be set for constructor return values if they are of a
built-in type. Structs should not be precision qualified.

BUG=angle:787

Change-Id: Ie5efd5be25a788ff6f01c5b989254572c00231eb
Reviewed-on: https://chromium-review.googlesource.com/229560Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Nicolas Capens <capn@chromium.org>
Tested-by: Olli Etuaho <oetuaho@nvidia.com>

21203702

13 Nov, 2014 3 commits

Remove redundant rx:: scoping prefixes. · 30d6c255

authored Nov 13, 2014

In many places we can get rid of this scoping operator.

BUG=angle:789

Change-Id: If6c40c435a97473d2fd9d6f1fb5a2c709393eb00
Reviewed-on: https://chromium-review.googlesource.com/225566Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

30d6c255

Remove the unused Renderer client version methods. · b38f2e5d

authored Nov 13, 2014

Previous patches enable us to get rid of this workaround. We should
in subsequent patches also try to clean up code that uses the
internal Renderer-only version of the context caps.

BUG=angle:789

Change-Id: Ic054090303cdc3f7ee8e45e4577c157559955472
Reviewed-on: https://chromium-review.googlesource.com/227714Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

b38f2e5d

Pass GL context data into shader creation. · 245d3602

authored Nov 13, 2014

This allows us to remove the hack where we store the current GL
client version in the Renderer.

BUG=angle:789

Change-Id: I6526f11eaa922325a9a41df0df48b2152e022e26
Reviewed-on: https://chromium-review.googlesource.com/227713Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

245d3602

12 Nov, 2014 1 commit

Use the [[flatten]] attribute only when a loop is present. · 80bacde5

authored Nov 10, 2014

Flattening branch-heavy shaders that contained no loops caused regressions.
As a temporary workaround we only flatten ifs when there exists a loop.

BUG=395048

Change-Id: I95c40f0249643b98c62304a0f2a4563561d1fbbc
Reviewed-on: https://chromium-review.googlesource.com/228722Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

80bacde5

11 Nov, 2014 7 commits

Fix ProgramBinary being disabled when it should be enabled. · 560eef16

authored Nov 11, 2014

Change-Id: I6a21bca32ae5bf1e0e638c0cf46102bd964cd066
Reviewed-on: https://chromium-review.googlesource.com/229064Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

560eef16

Refactor Framebuffer attachment application. · ab75a056

authored Oct 15, 2014

Instead of passing texture and renderbufer IDs which requires a call to
gl::getNonLostContext to resolve the objects, pass the Texture and Renderbuffer
objects directly.

BUG=angleproject:733

Change-Id: Ia500a781643e43a17c8e9cea9f95847a7ff7b25d
Reviewed-on: https://chromium-review.googlesource.com/228280Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

ab75a056

Pass GL caps and version to compiler. · de8892b4

authored Nov 11, 2014

This allows us to get rid of some of the reliance on storing the
current context client version in the Renderer. A subsequent
patch will allow us to remove the client version ugly hack.

BUG=angle:789

Change-Id: I139e0f66e1d39e5cd41a484c841a7101b1f29540
Reviewed-on: https://chromium-review.googlesource.com/227712Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

de8892b4

Move the Context ReadPixels logic into RendererD3D. · 87f6da1f

authored Nov 11, 2014

BUG=angle:789

Change-Id: I0a678f8fe31a3e7ddd9a675a0e3cb0342299b0e3
Reviewed-on: https://chromium-review.googlesource.com/226064Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

87f6da1f

Move BlitFramebuffer logic into RendererD3D. · a93bef2e

authored Nov 11, 2014

BUG=angle:789

Change-Id: Ib3f830ba2f915a5fa4fa552dccc13c24575aa843
Reviewed-on: https://chromium-review.googlesource.com/226063Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

a93bef2e

Split the RenderTarget classes based on if they are backing a SwapChain. · 1bd642c5

authored Nov 04, 2014

bug=angle:824

Change-Id: I89e475d4065102dbaa7fa1f1bfd02c7207def75c
Reviewed-on: https://chromium-review.googlesource.com/227600Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

1bd642c5

Fix compilation failure with Visual Studio 14. · df8fafef

authored Nov 11, 2014

Change-Id: If009cec928318c90a2f6d445ea8b4b06c4e45209
Reviewed-on: https://chromium-review.googlesource.com/228919Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

df8fafef

10 Nov, 2014 5 commits

Pass 0 for the sample count to RenderTarget when there is no multisampling. · 23419d56

authored Nov 07, 2014

BUG=angle:520

Change-Id: Idc9a19ece620d107b87110dac8e1ef7a24f565cc
Reviewed-on: https://chromium-review.googlesource.com/228551Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

23419d56

Move Clear logic into RendererD3D. · a153d4b0

authored Nov 06, 2014

BUG=angle:789

Change-Id: I56d4398e4c49fe980f649327b105cdba9d944a00
Reviewed-on: https://chromium-review.googlesource.com/226062Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>

a153d4b0

Move Context draw call logic into RendererD3D. · d9e58303

authored Nov 06, 2014

Also move a lot of supporting code.

BUG=angle:789

Change-Id: I098bf7d072ece1f414605783c32ec5354ba63e19
Reviewed-on: https://chromium-review.googlesource.com/226061Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>

d9e58303

Fixes a bug in program ID validation for GetUniform* calls. · 4de4fd6e

authored Nov 07, 2014

BUG=angle:571

Change-Id: I7080f0f7ea0def29d1b67c9d954ee5d9d41fb348
Reviewed-on: https://chromium-review.googlesource.com/228560Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Shannon Woods <shannonwoods@chromium.org>

4de4fd6e

MANGLE the ANGLE Renderer class. · 93e13fbf

authored Nov 06, 2014

BUG=angle:789

Change-Id: Ib6d9d47a9353ea3c1a931b793baba85a2698b659
Reviewed-on: https://chromium-review.googlesource.com/225472Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

93e13fbf

07 Nov, 2014 5 commits

Fix zero texture application. · e6382c3b

authored Nov 07, 2014

Patch https://chromium-review.googlesource.com/#/c/227711/ would
allow NULL Textures sometimes from State::getSamplerTexture. Fix
this by always setting the zero "Default" textures instead of NULL
in the State.

This was breaking the ES2-CTS test 'framebuffer_objects' on Windows.

BUG=angle:826

Change-Id: Ie08a89cff0555f21c769759e0c0ed73456a2f91c
Reviewed-on: https://chromium-review.googlesource.com/228275Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>

e6382c3b

Remove the gl::error function. · b28126ef

authored Oct 03, 2014

BUG=angle:520

Change-Id: Iefd4345aa347041143d5452cc2fcf48c071d494b
Reviewed-on: https://chromium-review.googlesource.com/222839Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

b28126ef

Add error handling to RenderTarget creation. · bafefdf3

authored Oct 10, 2014

 * RenderTarget9/11 don't create any resources themselves anymore.
 * Pass the real internal format to RenderTarget creation so that it is
   not lost by converting to D3D formats and back.

BUG=angle:520

Change-Id: If420970d42f0bf6ce392d64f9cb7efa4df0b8f8e
Reviewed-on: https://chromium-review.googlesource.com/222838Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

bafefdf3

Regenerate projects. · 468d7a1e

authored Nov 07, 2014

Disabled warnings were reordered.

Change-Id: I29772c1522e7428c3e66607fda82d14d2b182702
Reviewed-on: https://chromium-review.googlesource.com/228273Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

468d7a1e

Fix possible crash when the info log length is zero. · 981afd7f

authored Nov 05, 2014

BUG=angle:822

Change-Id: I01cb590cc9c1ba05f4d63dd088eef7e176a09d2f
Reviewed-on: https://chromium-review.googlesource.com/227264Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

981afd7f

06 Nov, 2014 5 commits

Add RendererD3D as a layer between GL and Renderer9/11. · ad65a13c

authored Nov 06, 2014

BUG=angle:789

Change-Id: I6107e6cbdeb5e3466f96a4bdf98181b8e5a25467
Reviewed-on: https://chromium-review.googlesource.com/225471Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

ad65a13c

Use Context caps in Framebuffer completeness check. · 48faf80a

authored Nov 06, 2014

This frees the Framebuffer from any dependency on the Renderer.

BUG=angle:789

Change-Id: I0e9ae0edf93674e32ae4f6538a934cddbdc804d5
Reviewed-on: https://chromium-review.googlesource.com/225470Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

48faf80a

Add a base for GL essential data. · 1e9ae079

authored Nov 06, 2014

The data holds the GL state, caps, extensions, texture caps, and
current client version.

BUG=angle:789

Change-Id: Icd15d806e14490f39041dea663ab2461a6a76090
Reviewed-on: https://chromium-review.googlesource.com/226060Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>

1e9ae079

Merge zero textures into the state texture map. · dedd7b95

authored Nov 05, 2014

We can treat these textures the same as the rest, saving a bit of
code and complexity cost.

BUG=angle:789

Change-Id: I14b426c817cbe3c5bb737410378b6a80e274689b
Reviewed-on: https://chromium-review.googlesource.com/227711Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>

dedd7b95

Fix platform if defined build error on Linux. · d46275f9

authored Nov 06, 2014

Using #if instead of #if defined() was giving an error when
ANGLE_PLATFORM_WINDOWS was undefined. Instead of defining it as
zero for all platforms, use #if defined() to ensure our legacy
usage of #ifdef doesn't get messed up by #define <value> 0.

BUG=angle:825

Change-Id: Ibad51c45c4337a30feb68561b6cf54ed5dc05d9d
Reviewed-on: https://chromium-review.googlesource.com/228270Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

d46275f9

05 Nov, 2014 7 commits

Switch to new APIs in samples/translator/translator.cpp · 0bdc0f3e

authored Nov 04, 2014

Also, fix a few issuse for ninja build "all" to finish.

BUG=angle:775
TEST=translator.cc compiles OK

Change-Id: I6507e9143882a628a7737dd139efb6d8d358b0db
Reviewed-on: https://chromium-review.googlesource.com/227490Tested-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

0bdc0f3e

Fixes for Angle to build with Windows GN. · 657cd684

authored Nov 05, 2014

Change-Id: Id38c4b11dba31b2779efa7beade481cd50f3d935
Reviewed-on: https://chromium-review.googlesource.com/227692Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Shannon Woods <shannonwoods@chromium.org>

657cd684

Fix fuzzy color check in ClearTest. · 9abdc2d8

authored Nov 05, 2014

This test was failing on some systems because of overly stringent
color expectations.

BUG=angle:809

Change-Id: I817de315ff6de46fb87f8ed1c21e3bb62c133176
Reviewed-on: https://chromium-review.googlesource.com/225262Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>

9abdc2d8

Fixes for Angle to build with Windows GN. · 330f0ade

authored Nov 05, 2014

Change-Id: I5af7a1305e5a190de5367ad940186edd6baee5bc
Reviewed-on: https://chromium-review.googlesource.com/227665Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

330f0ade

Use an ES3 shader spec for ES3 contexts. · 0af0b38e

authored Nov 05, 2014

BUG=angle:823

Change-Id: I377b4483b3835660e7fd45d923bf7f560cf2e5f6
Reviewed-on: https://chromium-review.googlesource.com/227593Tested-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Nicolas Capens <capn@chromium.org>

0af0b38e

Fixed a typo in generatePointSpriteHLSL. · a22cd47e

authored Nov 05, 2014

Change-Id: I104bbca6442835ab5e8e78580c6cbbb58d32a9b2
Reviewed-on: https://chromium-review.googlesource.com/227570Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

a22cd47e

Name mangle function prototypes and print them in interm output · 76acee83

authored Nov 04, 2014

This patch changes function prototype handling so that they get assigned
the same kind of a mangled name as function definitions and function
calls. This name is now also printed in interm output so that function
prototypes can be accurately identified in the interm output.

BUG=angle:821
TEST=compiler_tests

Change-Id: Ia150b8ac5b816b8096c964767cd8666bdee28539
Reviewed-on: https://chromium-review.googlesource.com/227390Reviewed-by: Nicolas Capens <capn@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Olli Etuaho <oetuaho@nvidia.com>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>

76acee83

04 Nov, 2014 3 commits

Changes gl::RenderbufferStorage to rx::RenderbufferImpl · e2632d24

authored Oct 17, 2014

BUG=angle:782

Also eliminates Colorbuffer/DepthStencilBuffer and related friends
and adds the RenderbufferD3D implementation of RenderbufferImpl.

This version fixes problems with the prior CL's handling of
render target serial issuance.

Change-Id: I7ddfbec1097723d7ea6ce93a9c034f941349108a
Reviewed-on: https://chromium-review.googlesource.com/227195Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Shannon Woods <shannonwoods@chromium.org>

e2632d24

Fix an incorrect iteration over EGL attributes. · bd7fd7f9

authored Nov 04, 2014

BUG=angle:490

Change-Id: If7a86ee0a5226f2b45e26bbadf4a84f8f605d1c2
Reviewed-on: https://chromium-review.googlesource.com/227231Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

bd7fd7f9

Added ISwapChainPanel support · 980eb8f3

authored Oct 22, 2014

Change-Id: I26faa32804ee47cb6ad8458c90abeb93a01dfbdf
Reviewed-on: https://chromium-review.googlesource.com/224991Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

980eb8f3

03 Nov, 2014 3 commits

Regenerate projects. · 45b474d8

authored Nov 03, 2014

BUG=angle:820

Change-Id: Ifb392fbfc7399ee504fc20abbe63218668a0574b
Reviewed-on: https://chromium-review.googlesource.com/227165Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

45b474d8

Update ANGLE_platform_angle to allow requesting of Renderer versions. · 0d3683c4

authored Oct 23, 2014

Added enums to allow users to request major and minor versions of the
underlying API and if a WARP device is used.

BUG=angle:490

Change-Id: I0bfb2ac8d327da28a47cc8e6346300e47ab9538c
Reviewed-on: https://chromium-review.googlesource.com/225081Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

0d3683c4

Added an egl::Error class and updated libEGL to use it. · 6b0cf996

authored Oct 06, 2014

BUG=angle:520

Change-Id: I792c8ddd8e8b76184f566294196d089bc9d1902a
Reviewed-on: https://chromium-review.googlesource.com/223270Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

6b0cf996