Commits · 2935c581e61e9de67d3e3ec137b2b7fc6ec5405c · Chen Yisong / angle

13 Apr, 2015 1 commit

Simplify code related to variable declaration · 2935c581

authored Apr 08, 2015

Rename nonInitErrorCheck to declareVariable to clarify that it declares
variables. Merge arrayErrorCheck with that so that logic that is common
between array and non-array declarations is only in one place. This
will simplify adding array initializer handling. This also enables
redeclaring gl_LastFragData using ESSL3 array type syntax.

Comments in executeInitializer claimed that the TVariable object was
needed for error recovery, but that was not actually true, so it can also
use the new declareVariable method. Make "variable" a local variable
instead of a parameter to executeInitializer, since the parameter was
never used by callers of the function.

TEST=angle_unittests, WebGL conformance tests
BUG=angleproject:941

Change-Id: Ie133be62afc3e1f997370803cf21cada4e738935
Reviewed-on: https://chromium-review.googlesource.com/264674Tested-by: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

2935c581

10 Apr, 2015 13 commits

Skip Pbuffer tests depending on Pbuffer support. · 1c906c2e

authored Apr 10, 2015

BUG=angleproject:890

Change-Id: Ie10276453c35c65ffa0e26f8039db3ec3e65064e
Reviewed-on: https://chromium-review.googlesource.com/265187Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

1c906c2e

Revert "Support constant folding of trigonometry built-ins" · b4a058bb

authored Apr 10, 2015

Part of a chain breaking the clang build:

http://build.chromium.org/p/chromium.gpu.fyi/builders/GPU%20Linux%20Builder/builds/33588

This reverts commit af930db1.

Change-Id: Ic0bf09b4088a1ee285fed0fbd77dfc4c682fcd12
Reviewed-on: https://chromium-review.googlesource.com/265144Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

b4a058bb

Revert "Support constant folding of exponential built-ins" · 50b7178d

authored Apr 10, 2015

Part of a chain breaking the clang build:

http://build.chromium.org/p/chromium.gpu.fyi/builders/GPU%20Linux%20Builder/builds/33588

This reverts commit 1c89caef.

Change-Id: I36e080d8f64d4d4ca5de04bebbd119db83956d0e
Reviewed-on: https://chromium-review.googlesource.com/265185Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

50b7178d

Revert "Support constant folding of common built-ins" · 3cf271fe

authored Apr 10, 2015

Part of a chain breaking the clang build:

http://build.chromium.org/p/chromium.gpu.fyi/builders/GPU%20Linux%20Builder/builds/33588

This reverts commit 0273c68c.

Change-Id: I00d7617a7c380f2a5ea3f38ec14948a598aa5c1a
Reviewed-on: https://chromium-review.googlesource.com/265184Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

3cf271fe

Revert "Use nullptr consistently in TIntermConstantUnion::fold" · 7c9e8c96

authored Apr 10, 2015

Part of a chain breaking the clang build:

http://build.chromium.org/p/chromium.gpu.fyi/builders/GPU%20Linux%20Builder/builds/33588

This reverts commit 5f2feee4.

Change-Id: I5ad54b05148ae2d4f19e50a67aded2bad4f55f91
Reviewed-on: https://chromium-review.googlesource.com/265143Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

7c9e8c96

Add tests for FenceNV and FenceSync objects. · b811e1a2

authored Apr 08, 2015

BUG=angleproject:888

Change-Id: Ic5eca4d88854f8127114d6b54666f32d5d6df9f2
Reviewed-on: https://chromium-review.googlesource.com/264588Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

b811e1a2

Fix issues with computing discontinuous loops · 3873cd0b

authored Apr 10, 2015

AST analysis to narrow down usage of [[loop]] and [[unroll]] failed to account
for break statements inside switch statements. Add switch statement handling.
This fixes asserts/crashes in dEQP tests.

BUG=angleproject:937
TEST=dEQP-GLES3.functional.shaders.switch.*

Change-Id: I04fdfe4733772a2a234934123bbfacf0376df562
Reviewed-on: https://chromium-review.googlesource.com/265191Tested-by: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

3873cd0b

Use nullptr consistently in TIntermConstantUnion::fold · 5f2feee4

authored Apr 08, 2015

Newly added code in TIntermConstantUnion::fold uses nullptr where as
remaining part of the function uses NULL. This change removes NULL and
consistently uses nullptr in complete function.

Change-Id: Ieaada3cf46bf3e16d3ef91b300c86537f778c33f
Reviewed-on: https://chromium-review.googlesource.com/264632Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Olli Etuaho <oetuaho@nvidia.com>
Tested-by: Olli Etuaho <oetuaho@nvidia.com>

5f2feee4

Support constant folding of common built-ins · 0273c68c

authored Apr 06, 2015

This change adds constant folding support for unary common built-ins:
abs, sign, floor, trunc, round, roundEven, ceil and fract.

BUG=angleproject:913
TEST= dEQP tests
dEQP-GLES3.functional.shaders.constant_expressions.builtin_functions.common*
(80 out of 210 tests started passing with this change)

Change-Id: I09f2f99b3108e0d2fb1919a0631e4317b6a28be3
Reviewed-on: https://chromium-review.googlesource.com/263709Reviewed-by: Olli Etuaho <oetuaho@nvidia.com>
Tested-by: Olli Etuaho <oetuaho@nvidia.com>

0273c68c

Support constant folding of exponential built-ins · 1c89caef

authored Apr 06, 2015

This change adds constant folding support for unary exponential
built-ins - exp, log, exp2, log2, sqrt and inversesqrt.

BUG=angleproject:913
TEST= dEQP tests
dEQP-GLES3.functional.shaders.constant_expressions.builtin_functions.exponential*
(48 out of 56 tests started passing with this change)

Change-Id: I22af56876d1b7ce305697bf9bf43ad9ec5d8a3a5
Reviewed-on: https://chromium-review.googlesource.com/263708Reviewed-by: Olli Etuaho <oetuaho@nvidia.com>
Tested-by: Olli Etuaho <oetuaho@nvidia.com>

1c89caef

Support constant folding of trigonometry built-ins · af930db1

authored Apr 02, 2015

This change adds constant folding support for trigonometry built-in
functions. Constant folding for these functions also fixes constant
expression issues where constant initializer is a built-in trignometry
function whose arguments are all constant expressions.

BUG=angleproject:913
TEST= dEQP tests
dEQP-GLES3.functional.shaders.constant_expressions.builtin_functions.angle_and_trigonometry*
(112 out of 120 tests pass with this change)

Change-Id: I2ed4360532469fe0d70048d5f2300a8db6f9fcda
Reviewed-on: https://chromium-review.googlesource.com/263679Reviewed-by: Olli Etuaho <oetuaho@nvidia.com>
Tested-by: Olli Etuaho <oetuaho@nvidia.com>

af930db1

Clean up arrayErrorCheck · 6ed7bbe8

authored Apr 07, 2015

Remove some unnecessary TPublicType/TType conversions from the code, and
clean up code style. voidErrorCheck is changed to take TBasicType so that
it can be used with both TType and TPublicType.

TEST=angle_unittests
BUG=angleproject:941

Change-Id: I6f6cbc0761a4fc971299bad48864309009c54e7f
Reviewed-on: https://chromium-review.googlesource.com/264673Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Olli Etuaho <oetuaho@nvidia.com>

6ed7bbe8

Fix a bunch of mistakes in MalformedShaderTest · 43ce600c

authored Apr 09, 2015

A number of mistakes had slipped in to this test that made the
compilation of some shaders always fail regardless of the semantic checks
applied by the parser.

TEST=angle_unittests
BUG=angleproject:941

Change-Id: I9906792e2c7fe3805288255b855afb46840a77a7
Reviewed-on: https://chromium-review.googlesource.com/264811Tested-by: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

43ce600c

09 Apr, 2015 10 commits

Remove now unused DetectDiscontuinity.h/.cpp · 4176cd64

authored Apr 02, 2015

BUG=angleproject:937
BUG=395048

Change-Id: Ie8e520267d594a595201cb7c2438a2202d9adf25
Reviewed-on: https://chromium-review.googlesource.com/263745Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

4176cd64

Ignore visual studio profiler and nsight files. · 029c78cd

authored Apr 09, 2015

Change-Id: I01cb029300760341262fb27cafc32d4366d161c0
Reviewed-on: https://chromium-review.googlesource.com/265005Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

029c78cd

WGL Pbuffer implementation. · 0305320f

authored Apr 09, 2015

BUG:angleproject:890

Change-Id: Id6e04117ddf7bde3ffb0d9e4cef6db3d07039a54
Reviewed-on: https://chromium-review.googlesource.com/261410Reviewed-by: Kenneth Russell <kbr@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

0305320f

Use the AST analyses to narrow the usage of [[loop]] and [[unroll]] · 1239ee94

authored Mar 19, 2015

These attributes are now used exactly in the loops and ifs
that require them, limiting the number of failed compilations
due to excessive unrolling and flattening.
Also output Lod0 functions only when needed.

Adds unit tests for LOOP, FLATTEN and Lod0 generation.

The patch was tested against the WebGL CTS 1.0.4 for which all the
failures existed prior to this patch and seem to be unrelated to this
change. It also works correctly on the following sites that had trouble
with [[loop]] and [[unroll]]:
 * dev.miaumiau.cat/rayTracer "Skull Demo"
 * The turbulenz engine particle demo
 * Lots of ShaderToy samples (including "Volcanic" and "Metropolis")
 * Google Maps Earth mode
 * Lots of Chrome Experiments
 * Lagoa
 * madebyevan.com/webgl-water
 * SketchFab
 * Unit Tests

BUG=angleproject:937
BUG=395048

Change-Id: I856de9025f10b79781929ec212dbffc2064a940e
Reviewed-on: https://chromium-review.googlesource.com/264791Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

1239ee94

Fix and enable warning C4244 (Conversion from 'type1' to 'type2', possible loss of data) · 794e0009

authored Apr 07, 2015

Change-Id: Id0e06d7d6600344d858f00dabc219d79289bbc82
Reviewed-on: https://chromium-review.googlesource.com/265020Tested-by: Minmin Gong <mgong@microsoft.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

794e0009

Revert "Fix and enable warning C4244 (Conversion from 'type1' to 'type2', possible loss of data)" · b3584fb4

authored Apr 09, 2015

Causing a build failure on Mac/Clang:

./Tokenizer.cpp:551:7: error: extra tokens at end of #else directive [-Werror,-Wextra-tokens]
#else if defined(_MSC_VER)

http://build.chromium.org/p/chromium.gpu.fyi/builders/GPU%20Mac%20Builder/builds/29136

This reverts commit 3b26e231.

Change-Id: I2d11ddcc18130d908fd2ec3d6f5ab890cfccd5e7
Reviewed-on: https://chromium-review.googlesource.com/264983Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

b3584fb4

Add tests of basic Pbuffer functionality. · 0ca42a5f

authored Apr 07, 2015

BUG=angleproject:890

Change-Id: I8f82414d1875f80269bd9dd1f629e5b7903cb584
Reviewed-on: https://chromium-review.googlesource.com/264380Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

0ca42a5f

Fix and enable warning C4244 (Conversion from 'type1' to 'type2', possible loss of data) · 3b26e231

authored Apr 07, 2015

Change-Id: I73d9a2b9ad16f032be974b9c819de0dc1247c2ea
Reviewed-on: https://chromium-review.googlesource.com/264533Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

3b26e231

authored Apr 08, 2015

It should not be possible to redeclare arrays. This seems to be another
thing left over from earlier erroneous code which allowed declaring
unsized arrays.

TEST=angle_unittests
BUG=angleproject:941

Change-Id: I711565230b35df077f268cec6fdeac6c4c03b4cd
Reviewed-on: https://chromium-review.googlesource.com/264672Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Olli Etuaho <oetuaho@nvidia.com>

47fadcb9

Make checking for array non-constness depend on input version · 3739d235

authored Apr 08, 2015

First, remove duplicate check for const qualifier on arrays. Only keep
the check inside arrayQualifierErrorCheck().

Second, ESSL3 will introduce array initializers and by extension constant
arrays, so it should allow const qualifier on arrays. These checks are
somewhat superfluous in ESSL1 as well, since the parser already checks
for missing initializers, but it's useful to keep the informative error
messages around.

Add a few tests to make sure that when the ESSL3 implementation
progresses, it still checks for missing initializers on constant arrays.

TEST=angle_unittests
BUG=angleproject:941

Change-Id: Id871c872c5b92e2a5bf81c00080ac23004916a75
Reviewed-on: https://chromium-review.googlesource.com/264671Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Olli Etuaho <oetuaho@nvidia.com>

3739d235

08 Apr, 2015 15 commits

Revert "Use the AST analyses to narrow the usage of [[loop]] and [[unroll]]" · 938f0029

authored Apr 08, 2015

Caused linking failures on mac because the unit test asks for TranslatorHLSL which is not compiled.

This reverts commit 3342e01f.

Change-Id: I02b2f54ca5b90611f11b7a549e75bf2e8310639d
Reviewed-on: https://chromium-review.googlesource.com/264790Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

938f0029

Use the AST analyses to narrow the usage of [[loop]] and [[unroll]] · 3342e01f

authored Mar 19, 2015

These attributes are now used exactly in the loops and ifs
that require them, limiting the number of failed compilations
due to excessive unrolling and flattening.
Also output Lod0 functions only when needed.

Adds unit tests for LOOP, FLATTEN and Lod0 generation.

The patch was tested against the WebGL CTS 1.0.4 for which all the
failures existed prior to this patch and seem to be unrelated to this
change. It also works correctly on the following sites that had trouble
with [[loop]] and [[unroll]]:
 * dev.miaumiau.cat/rayTracer "Skull Demo"
 * The turbulenz engine particle demo
 * Lots of ShaderToy samples (including "Volcanic" and "Metropolis")
 * Google Maps Earth mode
 * Lots of Chrome Experiments
 * Lagoa
 * madebyevan.com/webgl-water
 * SketchFab
 * Unit Tests

BUG=angleproject:937
BUG=395048

Change-Id: If7baddae1cdae0b3a414aa49e5a4c4babedbfe50
Reviewed-on: https://chromium-review.googlesource.com/261263Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

3342e01f

Temporarily disable the RenderToMipmap on Intel OpenGL. · 1a0847ca

authored Apr 08, 2015

BUG=angleproject:905

Change-Id: If398b7f3cb60f3efdafce0f3709f965120977603
Reviewed-on: https://chromium-review.googlesource.com/264665Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

1a0847ca

Implement GL_VENDOR and GL_RENDERER strings for RendererGL. · e42753b2

authored Apr 08, 2015

Change-Id: Ib83faa605fd1b992e19ddc2b72c7917d82245d32
Reviewed-on: https://chromium-review.googlesource.com/264664Tested-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

e42753b2

Implement discontinuous loops AST analysis · 50931459

authored Mar 19, 2015

This will allow narrowing down which usages of
[[flatten]] and [[unroll]] are actually useful.

BUG=angleproject:937
BUG=395048

Change-Id: I091e647e3053d22edadd0cabb7c50bd5efa690b2
Reviewed-on: https://chromium-review.googlesource.com/263776Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

50931459

Implement gradient operation AST analysis · f4eab3b9

authored Mar 18, 2015

This will allow narrowing down which usages of
[[flatten]] and [[unroll]] are actually useful.

BUG=angleproject:937
BUG=395048

Change-Id: Ib8d7b98431b8cd3563e1eff8ecc9ed5df1a9b7d6
Reviewed-on: https://chromium-review.googlesource.com/263775Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

f4eab3b9

Add a compiler option to prune unused function and prototypes · a094a8a9

authored Apr 07, 2015

Also adds a simple unit test checking the pruning

BUG=angleproject:937
BUG=395048

Change-Id: I88440378f66178dcebebcd596f8f80235903f20e
Reviewed-on: https://chromium-review.googlesource.com/264568Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

a094a8a9

Revert "Add a compiler option to prune unused function and prototypes" · 78b3a8b9

authored Apr 08, 2015

Compile error on Mac:

http://build.chromium.org/p/chromium.gpu.fyi/builders/GPU%20Mac%20Builder/builds/29051

This reverts commit e423d9ca.

Change-Id: Ie08d7f2bf86089a006f3177480aa7491a9405257
Reviewed-on: https://chromium-review.googlesource.com/264585Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

78b3a8b9

Add a compiler option to prune unused function and prototypes · e423d9ca

authored Apr 07, 2015

Also adds a simple unit test checking the pruning

BUG=angleproject:937
BUG=395048

Change-Id: I49904c34d1a72949cdc579569967d99c736c7237
Reviewed-on: https://chromium-review.googlesource.com/264415Reviewed-by: Kenneth Russell <kbr@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

e423d9ca

Implemented a CallDAG to allow for more AST analysis · 71d147f6

authored Feb 11, 2015

The CallDAG preprocesses the AST to construct a DAG of
functions that can be used for several analyses.
Use it to implement check for recursion and max call
depth. It will also be used to limit the usage of
[[flatten]] and [[unroll]].

BUG=angleproject:937
BUG=395048

Change-Id: I8578703f2d49513f315aecccbcff34914562e4ff
Reviewed-on: https://chromium-review.googlesource.com/263774Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Nicolas Capens <capn@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

71d147f6

Add UBO offset emulation for D3D11.0 and below. · 9102e3ab

authored Mar 23, 2015

BUG=angleproject:507

Change-Id: I6c5028930051a2af0bd6ffa0ee213e692d3892ef
Reviewed-on: https://chromium-review.googlesource.com/261824Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

9102e3ab

Split Buffer::map into map and mapRange to match the API. · cc6f55dd

authored Mar 20, 2015

BUG=angleproject:681

Change-Id: Ia4bf2b81134a922265ca762f33ac85d9ddbf1a7c
Reviewed-on: https://chromium-review.googlesource.com/261890Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

cc6f55dd

Add support for GL_OES_fbo_render_mipmap with OpenGL. · 8a6f19d7

authored Apr 02, 2015

BUG=angle:905

Change-Id: Idde35172cfa495c8b74b961f4ab8c4e657653074
Reviewed-on: https://chromium-review.googlesource.com/263763Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

8a6f19d7

Replace setArray function in TPublicType with functions from TType · 693c9aa0

authored Apr 07, 2015

Having only one way of setting or clearing arrayness of types clarifies
code dealing with arrays.

TEST=angle_unittests
BUG=angleproject:941

Change-Id: I98cb7c44fd66440c9de8b4c6c4a02827e9300db7
Reviewed-on: https://chromium-review.googlesource.com/264361Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Olli Etuaho <oetuaho@nvidia.com>

693c9aa0

Remove half-baked non-sized array support · 93a90fd0

authored Apr 07, 2015

ANGLE used to accept shaders with non-sized arrays in initializer lists.
Fix this. Proper support for implicitly sized arrays will be implemented
later for ESSL3.

TEST=angle_unittests
BUG=angleproject:941

Change-Id: I53c5ccf0f7ef09ad30e142f8350812959fc4846c
Reviewed-on: https://chromium-review.googlesource.com/264360Tested-by: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

93a90fd0

07 Apr, 2015 1 commit

Temporarily disable TextureTest with OpenGL. · 5c60031e

authored Apr 07, 2015

Failures seen on some FYI bots.

Change-Id: I4853438c34ce55a1d803d3a7edf3b3e077905264
Reviewed-on: https://chromium-review.googlesource.com/264462Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

5c60031e