Commits · 2a2b4b135a862ebfc979edee7edb950b2ad2e2a4 · Chen Yisong / angle

10 Jul, 2020 6 commits

Vulkan: Force flush staged updates for external textures · 2a2b4b13

authored Jul 09, 2020

For textures that are backed by external memory,
immediately flush sub image updates instead of
staging them.

Bug: angleproject:4828
Tests: angle_end2end_tests --gtest_filter=ImageTest.UpdatedExternalTexture*
Change-Id: I51e5bd0cb5df7df3af21f0cdb3007eebc1be29cd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2290490Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>

2a2b4b13

Roll Vulkan-ValidationLayers from 3bae90706d26 to 94f1ce331e85 (10 revisions) · 0a768f24

authored Jul 10, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/3bae90706d26..94f1ce331e85

2020-07-09 lionel.g.landwerlin@intel.com layers: fix image/view with modifier format feature storage
2020-07-09 shannon@lunarg.com build: Fix VUID inconsistencies for 1.2.146 header
2020-07-09 shannon@lunarg.com build: Update known-good files for 1.2.146 header
2020-07-09 tony@lunarg.com layers: Fix log message
2020-07-09 tony@lunarg.com gpu: Fix enabling of required features
2020-07-09 tony@lunarg.com tests: Add PhysicalDeviceFeatures to device profile api
2020-07-09 s.fricke@samsung.com layers: Move some sparse VU to stateless
2020-07-09 40687079+rumblehhh@users.noreply.github.com Update BUILD.md to use correct helper.cmake path
2020-07-08 s.fricke@samsung.com tests: Add VUID 02711
2020-07-08 s.fricke@samsung.com layers: Add VUID 02711

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: syoussefi@google.com
Change-Id: Ie785c2a96631396eddff2a3af035d32de99d572d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2291930Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

0a768f24

Roll glslang from 29c9135d06f1 to 5aaa0c2bc821 (1 revision) · 1d8240d8

authored Jul 10, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/29c9135d06f1..5aaa0c2bc821

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: syoussefi@google.com
Change-Id: I56a48b5a6caf96b3d83106b447b017bd8d18dca6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2290809Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

1d8240d8

Roll SPIRV-Tools from 7afbc0c8be3f to 94667fbf66ee (6 revisions) · fc9a340e

authored Jul 10, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/7afbc0c8be3f..94667fbf66ee

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: syoussefi@google.com
Change-Id: I4c5b033f8d38beef39a5b0f4ddd1b06e8d478fa1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2290808Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

fc9a340e

Roll SwiftShader from 28159ee9c8e3 to 6cd27bab06f4 (7 revisions) · eb0f83b8

authored Jul 10, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/28159ee9c8e3..6cd27bab06f4

2020-07-09 capn@google.com Remove unsupported formats
2020-07-09 sdefresne@chromium.org Convert GN libs lists to frameworks
2020-07-08 amaiorano@google.com Update llvm 10 Darwin config
2020-07-08 amaiorano@google.com Update llvm 10 Linux config
2020-07-08 amaiorano@google.com Enable Kokoro LLVM 10 builds on Windows
2020-07-08 amaiorano@google.com Add llvm-10 configs for Windows
2020-07-08 amaiorano@google.com Copy and modify update.py for LLVM 10

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: syoussefi@google.com
Change-Id: I3f97ac0bad1677af046422230e01dc5059ec9bb9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2290807Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

eb0f83b8

Vulkan: Add driverUniform's buffer to mResourceUseList · fe36a647

authored Jul 08, 2020

There is a bug with mDriverUniforms' dynamicBuffer that we never add it
to context's mResourceUseList to let it hold onto it until GPU
completes. This causes old buffer gets recycled prematurely and gets
overwritten, result in rendering corruption. This CL adds current buffer
to the mResourceUseList so that it will be waited properly before gets
recycled.

Bug: b/160777679
Change-Id: I7707442e0f5ba408f5f28337422274e0c23b6bfb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2288325
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Ian Elliott <ianelliott@google.com>

fe36a647

09 Jul, 2020 5 commits

Add support for VK_KHR_sampler_ycbcr_conversion · f61272fb

authored Jun 17, 2020

This adds ability for applications to import Android Hardware Buffers
(AHBs) as OpenGL images which in turn can be sampled from and/or
written.

This was specifically tested with the common use case of importing a
buffer created by an media decoder and using that as a texture source to
include that video content on the screen. Tested with:
- Angry Birds 2 video player (for ads) requires YUV conversion.
- Basic Media Decoder example:
    https://github.com/android/media-samples/tree/master/BasicMediaDecoder

Bug: b/155487768
Change-Id: I9255450f81aa4daa2aace7205d4f6c3f225abcca
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2175103
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

f61272fb

Vulkan: Warm up glslang on startup · b549be96

authored Jul 02, 2020

As soon as glslang is initialized (which is done when EGL is
initialized), try to compile a simple shader.  This will warm up
glslang's internals to avoid hitches on first shader compilation when a
WebGL application starts.

Potential future optimization is to use a worker thread to do this.

Bug: chromium:1091440
Change-Id: I6ac22e982d748af52a6e8b61239889425edc2edb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2280401Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

b549be96

Don't build vulkan_validation_layers on macOS. · fac68170

authored Jul 08, 2020

angle_enable_vulkan_validation_layers is false on is_mac,
so it looks like they were built by accident. Guard the dep
on $angle_root/src/common/vulkan:vulkan_validation_layers by
angle_enable_vulkan_validation_layers instead of angle_enable_vulkan,
and only define the target if angle_enable_vulkan_validation_layers
is true (because src/common/vulkan/BUILD.gn gets loaded due to deps
on other targets in it, and when a .gn file is loaded all the
targets in it get defined).

Since vulkan_validation_layers doesn't currently build on
arm macs, this happens to fix a build problem there, but it
also makes the build on intel macs a bit smaller.

This sidesteps comment 13 on the bug. If we ever want to use
the validation layers on mac, we'll have to do a real fix then.

Bug: chromium:1098741
Change-Id: I8164ff13de98d34ed875c6e6d0550eae64b2d0dd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2289042
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

fac68170

Vulkan: Rotate damage rects for 90/270 rotation · a740b193

authored Jul 08, 2020

ANGLE supports the EGL_KHR_swap_buffers_with_damage extension by using
the Vulkan-equivalent VK_KHR_incremental_present extension.  The
damage rectangles need to be rotated for 90/270-degree rotations.

Test: Aztec Ruins with VVL
Bug: b/157667116
Change-Id: I9a43594b30bc67ca80aeff7705b4350659207d09
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2289035Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>

a740b193

Remove angle_libjpeg_turbo_dir fallback after Chromium side fix · 58afe4cb

authored Jul 08, 2020

This is a follow up of crrev.com/c/2282277. To avoid ANGLE roll failure,
crrev.com/c/2285839 should be landed first.

Bug: None
Change-Id: I41ece21af4b689150d82b0b1bc7eaae21ce23fed
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2286811Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jiajie Hu <jiajie.hu@intel.com>

58afe4cb

08 Jul, 2020 10 commits

Capture/Replay: Fix default uniform array capture · 13859945

authored Jun 26, 2020

The pointer from vector::data() already reflects the size of the
underlying type, so no need to include sizeof.  This caused us to
write beyond the vector bounds when reading multiple values.

We were also missing component count.

Test: MEC of NBA2K20
Bug: b/160014453
Change-Id: I51fc3f5f80c732221d6ea4b4bd1afde635e410a1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2270909Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Manh Nguyen <nguyenmh@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

13859945

Serialize d/s buffers + use color buffers' impl format for readPixels · 900c7e87

authored Jul 07, 2020

Adds serialization of depth/stencil buffer contents

Currently, readPixels on color buffers uses the gles front-end format,
which can be different from the implementation format used in the
backend. This can cause seg fault crashes when the number of bytes in
a pixel differs between the two format. Changes so that readPixels for
color buffers always use the backend format.

Bug: angleproject:4817
Change-Id: I62d5deb1320ea38ee46143b2aa97f372ba01baeb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2284451Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Manh Nguyen <nguyenmh@google.com>

900c7e87

Skip MultithreadingTest.MultiCreateContext on Ozone · 514c8f64

authored Jul 08, 2020

This tests crashes on Ozone, skip for now.

Bug: chromium:1103009
Change-Id: Ie686e69d937710b43b615372251801e83b7bde20
TBR=geofflang@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2288334Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>

514c8f64

Roll Vulkan-Headers from db06fce926b0 to 2a164e9680a5 (3 revisions) · a3f6dc2f

authored Jul 08, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/db06fce926b0..2a164e9680a5

2020-07-07 caramelli.devel@gmail.com Update vk_icd.h for VK_EXT_directfb_surface extension
2020-07-07 oddhack@sonic.net Updates from @mark-lunarg
2020-07-07 oddhack@sonic.net Enumerate originating repository for all files in this repo.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-headers-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Change-Id: I21ad8c0e57af9f5642bac17218d3726578e1411b
Bug: None
Tbr: syoussefi@google.com
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2287289Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

a3f6dc2f

Roll Vulkan-ValidationLayers from e8b96e86fe2e to 3bae90706d26 (2 revisions) · eb34cb96

authored Jul 08, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/e8b96e86fe2e..3bae90706d26

2020-07-07 mark@lunarg.com objtracker: Don't report undestroyable objects
2020-07-07 mark@lunarg.com threading: Audit VkDisplay, VkDisplayMode object handling

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: syoussefi@google.com
Change-Id: I3b5b36cd8cbdc0d3e77602491f61e1dca1840e00
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2287269Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

eb34cb96

Roll glslang from f5ed7a69d5d6 to 29c9135d06f1 (3 revisions) · de19f275

authored Jul 08, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/f5ed7a69d5d6..29c9135d06f1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: syoussefi@google.com
Change-Id: I7bc2229226ae522a81a4eef168037d00c15c3606
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2287272Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

de19f275

Roll Vulkan-Tools from abc9dff824c3 to 68bfbc219497 (1 revision) · ae681217

authored Jul 08, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/abc9dff824c3..68bfbc219497

2020-07-06 shannon@lunarg.com build: Update known-good files for 1.2.146 header

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-tools-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: syoussefi@google.com
Change-Id: I0b017b35dc432e12e2a20f11be715537171facfc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2287271Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

ae681217

Roll SwiftShader from f6f11215cd93 to 28159ee9c8e3 (1 revision) · d6e12133

authored Jul 08, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/f6f11215cd93..28159ee9c8e3

2020-07-07 swiftshader.regress@gmail.com Regres: Update test lists @ f6f11215

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: syoussefi@google.com
Change-Id: I24efee8e954996c8f3048afa7cf6921e16da85de
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2286777Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

d6e12133

Roll SPIRV-Tools from 6a4da9da4215 to 7afbc0c8be3f (3 revisions) · 6783c53e

authored Jul 08, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/6a4da9da4215..7afbc0c8be3f

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: syoussefi@google.com
Change-Id: Ic409e40ee92fee5ba96190130052e2921f355162
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2287270Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

6783c53e

Roll Vulkan-Loader from 4c6019a855e9 to 145050bf2b98 (3 revisions) · e6a6e45f

authored Jul 08, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/4c6019a855e9..145050bf2b98

2020-07-07 caramelli.devel@gmail.com Remove duplicate key / value in scripts/common_codegen.py
2020-07-07 shannon@lunarg.com build: Update known-good files for 1.2.146 header
2020-07-07 caramelli.devel@gmail.com loader: Add support for directfb surface extension

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-loader-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: syoussefi@google.com
Change-Id: I91524416216eddd12582a0254dc88accf188a2f0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2286776Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

e6a6e45f

07 Jul, 2020 11 commits

Fix bugs in angle_end2end_tests and frame capture · 3688cb36

authored Jun 28, 2020

1. CaptureGetShaderInfoLog_infoLog method should not require shader
object to be compiled
2. glCompressedTexImage3D's parameter locations are off by 1
3. EGLContextSharingTest.DisplayShareGroupObjectSharing test should not
delete buffers it has no access to since it will crash when running
capture replay

Bug: angleproject:4801
Change-Id: I0d407cdb44eb41eea4209eebab0996d3dd8ae5f5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2272862
Commit-Queue: Manh Nguyen <nguyenmh@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

3688cb36

Remove a few hardcoded path to libjpeg_turbo · 9b8ee0ff

authored Jul 06, 2020

Use the predefined GN override instead.

Also sort the predefined override alphabetically.

Bug: None
Change-Id: I92d0dda5ab416389398d0e88f8b3b9636752486d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2282277Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

9b8ee0ff

Enable the use of chromium worker pool · 75b59e7d

authored Jun 30, 2020

This CL is a revert of:
  https://chromium-review.googlesource.com/c/chromium/src/+/2276245

The issue with CFI was fixed here:
  https://chromium-review.googlesource.com/c/chromium/src/+/2276245

Bug: chromium:1091259
Change-Id: I601112b106e63a96144191263ac6a867d77154d8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2277099
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

75b59e7d

Fix typos in comment · 6fc53fdb

authored Jun 30, 2020

This CL fix typo in a comment introduced recently.
There is no functional change.

Bug: chromium:1091259
Change-Id: I56f1963514b87b2a93859a6db707be093e865e28
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2276748
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

6fc53fdb

Roll Vulkan-Headers from 8188e3fbbc10 to db06fce926b0 (1 revision) · dcd57068

authored Jul 07, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/8188e3fbbc10..db06fce926b0

2020-07-04 oddhack@sonic.net Update for Vulkan-Docs 1.2.146

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Change-Id: I399b1bccafada63ed83d384501747ba63aa80544
Bug: None
Tbr: syoussefi@google.com
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2284423Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

dcd57068

Roll Vulkan-ValidationLayers from 5c38b18ab460 to e8b96e86fe2e (2 revisions) · f74d3418

authored Jul 07, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/5c38b18ab460..e8b96e86fe2e

2020-07-06 sam.walls@arm.com tests: Add test for Arm perfdoc check 23
2020-07-06 sam.walls@arm.com practices: Add passing implementation of Arm perfdoc check 23

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: syoussefi@google.com
Change-Id: Ia6ca63cca036eadaeda25a039a1ad432b06d80e0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2284622Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

f74d3418

Roll Vulkan-Loader from a173c025f8fe to 4c6019a855e9 (4 revisions) · 650b3e5b

authored Jul 07, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/a173c025f8fe..4c6019a855e9

2020-07-06 alexbatashev@outlook.com loader: Fix symbol lookup order
2020-07-06 sdefresne@chromium.org Convert GN libs lists to frameworks
2020-07-06 charles@lunarg.com loader: fix wrongly returned error code
2020-07-06 charles@lunarg.com loader: fix TSAN warning

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: syoussefi@google.com
Change-Id: I9f1af9891b92312218b55905e1c0b77a1e516a9c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2283916Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

650b3e5b

Roll SPIRV-Tools from 2c1ff230c26d to 6a4da9da4215 (2 revisions) · aeec3e76

authored Jul 07, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/2c1ff230c26d..6a4da9da4215

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: syoussefi@google.com
Change-Id: I2dbb9ee2c7e05bd76f8a9964929172a35ccc1459
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2284623Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

aeec3e76

Roll SwiftShader from 3121585acce2 to f6f11215cd93 (7 revisions) · b7d30b57

authored Jul 07, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/3121585acce2..f6f11215cd93

2020-07-07 capn@google.com Implement shaderStorageImageExtendedFormats support
2020-07-07 capn@google.com Implement scatter/gather for 1- and 2-byte texels
2020-07-07 capn@google.com Fix float-to-half conversion
2020-07-06 capn@google.com Eliminate large image specialization
2020-07-06 capn@google.com Refactor texel buffer reads
2020-07-06 capn@google.com Implement SNORM uniform texel buffer support
2020-07-06 capn@google.com Implement B10G11R11_UFLOAT_PACK32 uniform texel buffer support

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: syoussefi@google.com
Change-Id: I5685762632bfa46669a2bc8f1a03844803c9a531
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2283917Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

b7d30b57

Remove debug info from SPIR-V · 8b80e852

authored Jun 25, 2020

When dcheck_always_on=false, the SPIR-V transformer will strip all debug
information to reduce the SPIR-V binary size.

Running T-Rex shows about 27% reduction in the SPIR-V binary size.

Bug: angleproject:4680
Test: CQ
Change-Id: Id9d0189cdc9c12fa5a1741cf62ef549a533cdf93
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2267358
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

8b80e852

Build specialized version of glslang · b291ad09

authored Jul 03, 2020

Bug: angleproject:4763
Change-Id: Ibb98c872a1283b9d6acde958a7c5212cf79e72df
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2281618Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tobin Ehlis <tobine@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

b291ad09

06 Jul, 2020 8 commits

Vulkan: Compress internal shaders · 36a97db1

authored Jul 02, 2020

Shaves ~200KB in binary size.  The compressed SPIR-V blobs are in most
cases a little smaller than 1/3 of the original size.

The internal shader blobs at this point take ~100KB.

Bug: angleproject:2022
Change-Id: I1a2cec073cb1f330632c8dce7a550a0cca1e373d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2280945
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

36a97db1

Fix multiDraw* with DYNAMIC_DRAW buffer usage · 9349e262

authored Jun 25, 2020

Specialized Context11 impl to prevent promote Dynamic during MultiDraw.
Add different buffer usage to MultiDraw and BaseVertexBaseInstance
tests.

Bug: angleproject:3402, angleproject:4754
Change-Id: I50e1a6fd6c8b6fd48f130c43545b895335d2e55b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2268581
Commit-Queue: Shrek Shao <shrekshao@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

9349e262

MultiDraw Refactor · 796df76c

authored Jun 25, 2020

Refactor MultiDraw* from general Context to different ContextImpl.
Move general multiDraw code to renderer_utils.cpp.

Bug: angleproject:3402
Change-Id: I85cb4b781afa2b3a8beb382a9c735910057f2ebe
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2268580
Commit-Queue: Shrek Shao <shrekshao@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

796df76c

Fix import paths for //scripts/run_gtest_angle_test.py. · ba584cf7

authored Jul 06, 2020

We added run_gtest_angle_test.py in a86c8547, but didn't
actually check that it worked :(. This CL adds the
missing sys.path imports needed to find the rest of
the Chromium test script modules.

Bug: chromium:816629, angleproject:3162
Change-Id: I4c381bda334df4d2e648aab65ca4cc0310d840bf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2283694Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>

ba584cf7

Vulkan: Query aspect flag from the image · 69fa4d23

authored Jun 30, 2020

When transferring images across queues we need
to query the aspect of the image instead of
hardcoding it to VK_IMAGE_ASPECT_COLOR_BIT

Bug: angleproject:4791
Bug: angleproject:4818
Tests: angle_end2end_tests --gtest_filter=ImageTest.SourceAHBTarget2DDepth*
Change-Id: Ia43a00262085dab492935c0c299635f3af468b50
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2274868
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

69fa4d23

EGL: Add basic multithreading support · 3c8f6094

authored Jun 26, 2020

Adds first step to allowing multithreaded contexts: letting multiple
threads use ANGLE as long as only one thread has a current context at
a time.

Bug: angleproject:4724
Bug: angleproject:4725
Change-Id: I4f606bdb15386cff9e3cb84d4120781e24e15fe4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2269864Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>

3c8f6094

Test Runner: Batch tests by config. · acbe145c

authored Jul 02, 2020

This CL sorts tests into subprocesses organized by a single config.
It will allow for the test runner to use a single EGL display per
process in most cases. It doesn't implement the display sharing right
now, that'll be in a forthcoming CL. It assumes test configs are split
between / and (optional ending) __ characters.

Bug: angleproject:3162
Change-Id: I28e8b4687640da6e501f08b8b9347185c99ce30f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2280403Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

acbe145c

Fix end2end intermittent crash on macOS if custom OSWindow is used. · 10ef43ce

authored Jul 06, 2020

In MultisammpleTest, a custom OSWindow object is created. Sometimes this
window's internal Objective-C window object is not released after the
test finishes, thus input events such as mouse/keyboard are still
forwarded to this window. However its content view is already released
causing the crash.

call [mWindow setContentView:nil] inside OSXWindow::destroy() seems to
fix this bug.

Bug: angleproject:4815
Change-Id: If00398ff0082624ade5e8be8ad3b0f91d17c23ed
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2281782
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

10ef43ce