- 10 Aug, 2020 11 commits
-
-
Manh Nguyen authored
Implement glGetUniform calls to fix crashes in UniformTest test group. Tests: UniformTest test group Bug: angleproject:4817 Change-Id: I132c61e053665b0642667aad51f1f3220d101d14 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2339542 Commit-Queue: Manh Nguyen <nguyenmh@google.com> Reviewed-by:
Cody Northrop <cnorthrop@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
Le Hoang Quyen authored
Bug: angleproject:4930 Bug: angleproject:2634 Change-Id: I9fd958aa1dd872855be06a14bdbba4c6624dc934 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2340396 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Jonah Ryan-Davis <jonahr@google.com>
-
Manh Nguyen authored
Updates CaptureAndReplay.md with how to run capture_replay_tests.py. Explains certain important flags and their effects on the behavior of the script. Bug: angleproject:4817 Change-Id: I628edf57cde51d2a6f667fbfd7dc937964badbac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2336188 Commit-Queue: Manh Nguyen <nguyenmh@google.com> Reviewed-by:
Cody Northrop <cnorthrop@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
Manh Nguyen authored
New result types: Passed, Failed, TimedOut, Crashed, CompileFailed, Skipped. They divide the results of tests more clearly. Results are now immediately logged to the stdout once a test batch completes. Flags, with the exception of --gtest_filter now use "-" instead of "_". Bug: angleproject:4817 Change-Id: I9616b23ef70026818e22126a251e1e2341de641d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2340787 Commit-Queue: Manh Nguyen <nguyenmh@google.com> Reviewed-by:
Cody Northrop <cnorthrop@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
Tim Van Patten authored
The following tests started failing on Android (Pixel 2 and 4) running ToT master: dEQP-GLES2.functional.fbo.render.recreate_colorbuffer.rebind_rbo_rgba4 dEQP-GLES2.functional.fbo.render.recreate_colorbuffer.rebind_rbo_rgba4_stencil_index8 dEQP-GLES2.functional.fbo.render.recreate_colorbuffer.no_rebind_rbo_rgba4 dEQP-GLES2.functional.fbo.render.recreate_colorbuffer.no_rebind_rbo_rgba4_stencil_index8 dEQP-GLES2.functional.fbo.render.recreate_depthbuffer.rebind_rbo_rgba4_depth_component16 dEQP-GLES2.functional.fbo.render.recreate_depthbuffer.no_rebind_rbo_rgba4_depth_component16 dEQP-GLES2.functional.fbo.render.recreate_stencilbuffer.rebind_rbo_rgba4_stencil_index8 dEQP-GLES2.functional.fbo.render.recreate_stencilbuffer.no_rebind_rbo_rgba4_stencil_index8 We aren't sure how these failures got through CQ, so I'm suppressing them for now to unblock other CLs. Bug: angleproject:4944 Test: dEQP-GLES2.functional.fbo.render.recreate_* Change-Id: I2b35e07babf3257a3de8d27f6c161c0cb796d8ff Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2342267Reviewed-by:
Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by:
Ian Elliott <ianelliott@google.com> Commit-Queue: Tim Van Patten <timvp@google.com>
-
Jamie Madill authored
We can check the RenderPass CB helper directly instead of caching a separate variable. Bug: angleproject:4911 Change-Id: Ic953c101c64fd5142e2dedfd06e3fea287331fd4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2341761Reviewed-by:
Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by:
Charlie Lao <cclao@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
Manh Nguyen authored
When grouping tests to test batches, instead of grouping neighboring tests together, use striping so that slow tests are fanned out into multiple batches. This way, no test batch is too slow. Bug: angleproject:4817 Change-Id: I7825539e401ea53b5a31167f206d1f5bfb07bdbf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2339540Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Cody Northrop <cnorthrop@google.com> Commit-Queue: Manh Nguyen <nguyenmh@google.com>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/aba3ab0ce72f..61bf3be73c1e 2020-08-07 lenny@lunarg.com loader: Make invalid std val layer an error If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-loader-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I92cfca9ecebd9643ef07e3271c18d20d132f3b33 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2345297Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/a1c21580f50b..1590d46aaaeb 2020-08-07 jeremyk@lunarg.com build: Update MoltenVK version in known-good.json 2020-08-07 caramelli.devel@gmail.com Fix formatting errors 2020-08-07 caramelli.devel@gmail.com Add support for VK_EXT_directfb_surface extension If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-tools-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I1835cad8400acdac27aec09dba7b2a7d40077fb6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2345298Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/9ba1bc28d878..b399fb08896a 2020-08-07 tony@lunarg.com layers: Fix check for 00683 2020-08-07 mark@lunarg.com layers: Clarify assumptions in layer settings text file If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I983e1d88cf02361d97f0e8afd114acc964a9542e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2345299Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/a6d08c75d219..8446db62f194 2020-08-07 lenny@lunarg.com Add a loader features interface 2020-08-07 lenny@lunarg.com Add missing ifdef for extern "C" 2020-08-07 lenny@lunarg.com Update vk_icd.h with proper extern "C" declaration 2020-08-07 lenny@lunarg.com Update vk_icd.h with typedefs and prototypes If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-headers-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Change-Id: Ie6f308d81af5072659064d099e4895e907f31894 Bug: None Tbr: geofflang@google.com Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2345720Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
- 08 Aug, 2020 2 commits
-
-
Tim Van Patten authored
TextureCommand::GenerateMipmap can be moved into gl::Command allowing us to remove TextureCommand. Bug: angleproject:4753 Test: CQ Change-Id: Idc546df519e199ffd3a8b8e03b9868cd9152e9ef Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2338823 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Charlie Lao <cclao@google.com>
-
Tim Van Patten authored
A new enum is being created that contains command types, which are then passed to each dirty object when they are synced. This allows the syncState() methods to perform special handling for each command type. This change is in preparation for optimizing resolving multisample images with glBlit, since the render pass needs to be updated before it's ended. Bug: angleproject:4753 Change-Id: I77701f79418d35cff689e864c8a8b47b6fca0255 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2327335 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by:
Charlie Lao <cclao@google.com> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org>
-
- 07 Aug, 2020 17 commits
-
-
Cody Northrop authored
Still seeing long link times for NBA2K20 trace. Breaking up SetupContext into even smaller chunks helps. Test: Compile and link NBA2K20 trace for Android Bug: b/160014453 Bug: angleproject:4048 Change-Id: Ic8f6d7e8d1c35cbee986da670c0beeb4b77c4e7c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2339853 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by:
Manh Nguyen <nguyenmh@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
Cody Northrop authored
Hadn't been tested since previous fixes. Test: Release build of Capture/Replay sample Bug: angleproject:4048 Change-Id: I7fbb8b08edc2596e19469ecbacb02dc6f0e66ca1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2342275Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
-
Cody Northrop authored
This CL will track whether a string has already been declared and written in the output file. This cuts the shader string count in NBA2K20 trace by 85%, eliminating about 300K lines of code from setup. Test: Compile and link NBA2K20 trace for Android Bug: b/160014453 Bug: angleproject:4048 Change-Id: Id854b3314644c1e4aae41cd6bb4157f92e9b1945 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2339852Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
-
Cody Northrop authored
Significantly reduce setup for this trace. First frame drops from ~430K lines to ~150K lines of code. Compile/link times should be bearable. TBR: ianelliott@google.com,jmadill@chromium.org Test: angle_perftests --gtest_filter="TracePerfTest.Run/*nba*" Bug: b/160014453 Change-Id: Ia33941012e02ec5488d039501f592dc48e9acfe4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2343454Reviewed-by:
Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
-
Cody Northrop authored
Primarily fix the width/height of the drawing surface, but also pull in changes from July 2020 update. TBR: courtneygo@google.com,jmadill@chromium.org Test: angle_perftests --gtest_filter="*Trace*" Bug: b/157672184 Change-Id: Ia6e16f6d695954f50b3d2a4e8aaaa88514b461d1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2343453Reviewed-by:
Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
-
Shahbaz Youssefi authored
Frequently causes failures as such: [...:ERROR:drawing_buffer.cc(854)] Initialization failed to allocate backbuffer. [...:INFO:CONSOLE(197)] "Unable to initialize webgl context.", source: (197) Bug: chromium:1112986 Bug: angleproject:4937 Change-Id: I5058f78434c0ac49345fe1167043f2dca759b1b9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2341350Reviewed-by:Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
-
Shahbaz Youssefi authored
If a texture is simultaneously attached to two FBOs, one where it's a normal texture and another where it's multisampled-render-to-texture, different render targets must be created for it. If a texture is simultaneously attached to two FBOs, both as multisampled-render-to-texture but with different sample counts, two implicit multisampled images need to be created as well as different render targets. Bug: angleproject:4913 Change-Id: I584ba327e4cb2099ef62f86f5d88719dc156ce13 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2335810 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Tim Van Patten <timvp@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
Courtney Goeltzenleuchter authored
Running with ASAN there are several use after free issues because a eglDestroyContext destroys the context right away even though it's in use in other thread(s). Adding reference count to context so that it's not destroyed until all users are done using it. Bug: b/162609728 Change-Id: I00b24b53d760e38ff61dd9ce652a49b1f32f0cd2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2336447 Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by:
Tobin Ehlis <tobine@google.com> Reviewed-by:
Geoff Lang <geofflang@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/5fd92a7e0c84..7b2dd11dda7a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: Id98eed0912d87b1a709e03b2c3e0f2c013366f1c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2342749Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/c967a2ddf18b..9ba1bc28d878 2020-08-07 yevhenii.kharchenko@globallogic.com tests: Add tests for VUID 01778 check 2020-08-07 yevhenii.kharchenko@globallogic.com layers: Add check for VUID 01778 2020-08-06 mark@lunarg.com tests: Add test for Set/GetPrivateData 2020-08-06 mark@lunarg.com dispatch: Unwrap Set/GetPrivateDataEXT object handles 2020-08-05 locke@lunarg.com tests: subpass input not bound descriptorSet 2020-08-05 locke@lunarg.com layers: Add vkCmdDraw-None-02686 2020-08-05 mark@lunarg.com layers: Revert "layers: Add check for VUID 01778" 2020-08-05 mark@lunarg.com tests: Revert "tests: Add check for VUID 01778" 2020-08-05 mark@lunarg.com tests: Avoid ProtectedResources crash on ShieldTV 2020-08-05 locke@lunarg.com tests: Fix wrong hazard log 2020-08-05 locke@lunarg.com layers: Fix wrong hazard log 2020-08-05 s.fricke@samsung.com tests: Add Protected clear attachment 2020-08-05 s.fricke@samsung.com layers: Add Protected clear attachment 2020-08-05 yevhenii.kharchenko@globallogic.com tests: Add check for VUID 01778 2020-08-05 yevhenii.kharchenko@globallogic.com layers: Add check for VUID 01778 2020-08-04 bob@lunarg.com tests: avoid more dialog boxes 2020-08-03 32918197+jorgep31415@users.noreply.github.com tests: Add test for VUID 00824 2020-08-03 32918197+jorgep31415@users.noreply.github.com layers: Add check for VUID 00824 2020-08-03 mark@lunarg.com tests: Add test for multiinstance mapmem VUID 2020-08-03 mark@lunarg.com corechecks: Add check for MultiInstance heaps in MapMemory If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: Icdf3e3429356e9b8c9adbc4e6e1cf5390e612166 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2342750Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/be7c55a2a8ce..59b4828f293e 2020-08-07 swiftshader.regress@gmail.com Regres: Update test lists @ a202c209 2020-08-06 capn@google.com Refactor discerning image view types 2020-08-06 capn@google.com Don't use 2D coordinates for 1D sampling 2020-08-06 capn@google.com Specialize 1D sampling LOD calculation 2020-08-06 capn@google.com Treat the array coordinate separately 2020-08-06 capn@google.com Refactor sampling code 2020-08-06 capn@google.com Zero out texel index after sample and layer offset If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: Ia799779f9c088ae2e65a8d9f11e571d800a20a1e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2342748Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/ef36eedb0d09..aba3ab0ce72f 2020-08-06 dorian.apanel@gmail.com loader: fix memory leak of failed to load layers 2020-08-06 lenny@lunarg.com docs: Pass inst handles when getting func pointers If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-loader-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: Iece120cf282f0351618a5985b6f862225d69da28 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2342747Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
Shahbaz Youssefi authored
Bug: angleproject:1323 Change-Id: I704bd2aff98ff334a4ada54a0c465a16109b9cbb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2341764Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
-
Geoff Lang authored
VVL added a new error that ANGLE hits on AMD Windows due to the way VMA allocates memory. Supressing to allow VVL to roll forward while we investigate. Bug: angleproject:4928 Change-Id: I4afeb3fcc2e9fed96ff8276898a8c96c77206d3b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2339539Reviewed-by:
Geoff Lang <geofflang@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
-
Jamie Madill authored
This method will no longer end the RenderPass in a following CL. Renaming it in a split CL makes the review diff simple. Bug: angleproject:4911 Change-Id: Id48257884dccb7c86f7de2cc9ca95e651fb68df7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2340788 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Courtney Goeltzenleuchter <courtneygo@google.com>
-
Jamie Madill authored
Cleanup/refactoring only. Bug: angleproject:4911 Change-Id: I4fe06a86a6ecaafa16fd900b6f6229f09ab56a9f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2334092 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Courtney Goeltzenleuchter <courtneygo@google.com>
-
Shahbaz Youssefi authored
Bug: angleproject:2273 Change-Id: I27109b873a290133cf3d016f612e1fd1de9d354c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2341763Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
-
- 06 Aug, 2020 10 commits
-
-
Jamie Madill authored
This is owned by the ImageHelper. We'll use it in tracking used images in RenderPasses. Bug: angleproject:4911 Change-Id: Ic71cef2b16eefb86c73c9c5e1e38ee7cd6a60adb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2332895 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Tim Van Patten <timvp@google.com> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org>
-
Jamie Madill authored
Uses an unordered_map in the CommandBufferHelper to track buffer reads and writes. Buffer barriers are tracked specially in the CommandBufferHelper class as a barrier we execute immediately when we execute the commands into the primary. So when we run into an incompatible buffer access we must start a new command buffer. The rules for an incompatible access are: - when we are reading a buffer, any prior write in the same command buffer is incompatible. - when we are writing a buffer, any prior read or write in the same command buffer is incopatible. Also adds a regression test using a new performance counter. Bug: angleproject:4429 Change-Id: I393a4ed87314f955eb998940b877ba76ea15a7b8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2334091Reviewed-by:
Tim Van Patten <timvp@google.com> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Charlie Lao <cclao@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
Jamie Madill authored
Adds a counter for the secondary command buffers (non-RenderPass). We'll use this in an upcoming test that validates that ANGLE only issues a single barrier (CB) in some buffer read/write scenarios. Also adds a PerfCounters struct. Bug: angleproject:4429 Change-Id: Iaf75ca89da3d02753897cb4066e2c56db497417e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2334090Reviewed-by:
Tim Van Patten <timvp@google.com> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/4b40207be32d..b2be8f165978 2020-08-06 Alexander.Galazin@arm.com Merge "Merge vk-gl-cts/opengl-cts-4.6.0 into vk-gl-cts/master" 2020-08-06 karolina.palka@mobica.com Add tests for VK_EXT_global_priority 2020-08-06 Alexander.Galazin@arm.com Merge "Merge vk-gl-cts/vulkan-cts-1.2.3 into vk-gl-cts/master" 2020-08-06 rgarcia@igalia.com Check per-sample copy results in multisample copy tests 2020-08-06 toni.salmivalli@siru.fi Add a batch of GraphicsFuzz tests 2020-08-06 alexander.galazin@arm.com Update KC CTS 2020-08-06 airlied@redhat.com Fix pixel pack/unpack in nearest edge tests 2020-08-06 airlied@redhat.com fix 1d depth component 16 sizing in layout locations tests. 2020-08-06 paulthomson@google.com Convert GraphicsFuzz vkscript to AmberScript 2020-08-05 toni.salmivalli@siru.fi dEQP-VK.graphicsfuzz.stable-rects-vec4-clamp-conditional-min-mix 2020-08-05 lionel.g.landwerlin@intel.com Test imported signaled sync fd 2020-08-05 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.3 into vk-gl-cts/master 2020-08-04 alexander.galazin@arm.com Restore dual source blending tests 2020-08-03 alexander.galazin@arm.com Update Vulkan headers 2020-08-03 paulthomson@google.com Delete excluded graphicsfuzz test 2020-08-03 wojciechx.zoltowski@intel.com Throw an error on missing cmake in build config 2020-07-31 itoral@igalia.com Fix shaderCullDistance limit checks 2020-07-31 rgarcia@igalia.com Test mipmaps with linear tiling 2020-07-30 rgarcia@igalia.com Enable random descriptor writes for storage buffers 2020-07-30 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.3 into vk-gl-cts/master 2020-07-29 rgarcia@igalia.com 1D and 3D image copy and blitting tests 2020-07-29 alexander.galazin@arm.com Merge vk-gl-cts/opengl-es-cts-3.2.6 into vk-gl-cts/master 2020-07-29 james.glanville@imgtec.com Stop 10bit formats requiring GL_SRGB encoding 2020-07-29 ruiling.song@amd.com Disable a test that access uninitialized variable 2020-07-29 paulthomson@google.com Update Amber to fix regression 2020-07-24 michal.m.pawlowski@mobica.com Support for VkPhysicalDeviceVulkan1{1,2}Properties in framework 2020-07-24 zzyiwei@google.com Let requireDeviceFunctionality support Android AHB extension 2020-07-24 lionel.g.landwerlin@intel.com Add timeline semaphore polling tests 2020-07-24 ari.suonpaa@siru.fi Test 3D image blit with differing depth 2020-07-23 alexander.galazin@arm.com Update the date in the notice of withdrawal 2020-07-23 alexander.galazin@arm.com Notice of withdrawal of Vulkan CTS 1.1.5.x 2020-07-22 rgarcia@igalia.com Allow Bresenham for single-sample non-strict lines If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-bots+autoroll-info@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: angle-bots+autoroll-info@google.com,geofflang@google.com Change-Id: Ie9c01a3c47d77bd9f896194c30750b5bffc4eef2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2338820Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/bfe4f378aee6..ef36eedb0d09 2020-08-05 charles@lunarg.com loader: fix override paths leaking in VerifyAllMetaLayers If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-loader-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I54a665cca6ad4eed75198dc726bb9f612cd75c4c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2340882Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/8bc27a1cfbc1..5fd92a7e0c84 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I932e4e5248727f98216e54505b3a5f44a8e48798 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2339299Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/a4505d37ffe7..a1c21580f50b 2020-08-05 charles@lunarg.com vulkaninfo: add `--summary` option that shows basic system info If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-tools-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I744b8bdc9b1b7e80e875ffc0fc7cf707cb45d62e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2340546Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
Tim Van Patten authored
Update StateCache::updateActiveShaderStorageBufferIndices() and StateCache::updateActiveImageUnitIndices to get the storage buffers and image bindings from the ProgramExecutable, respectively. This requires updating the ProgramPipeline's ProgramExecutable to build up its vector of buffers/images from each Program's ProgramExecutable. Bug: angleproject:4869 Test: VertexAttributeTestES31.UsePpoComputeShaderToUpdateVertexBuffer Test: SimpleStateChangeTestES31.InvalidateThenStorageWriteThenBlendPpo Change-Id: I68b7d23eedda910c3dcbf5f9c50b74b5e80134d8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2327701 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Charlie Lao <cclao@google.com>
-
Shahbaz Youssefi authored
Bug: angleproject:4913 Change-Id: Ic78a26be4c2f3fa96ef77deffc239dbb7310065e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2339543Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Tim Van Patten <timvp@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
-
Shahbaz Youssefi authored
Bug: angleproject:4912 Bug: fuchsia:52759 Change-Id: I8883d65ecac763cf46d792cc69bce98dc53121d4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2340174Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
-