- 24 Nov, 2020 3 commits
-
-
Jamie Madill authored
Using a dynamic year isn't fully supported as it makes the auto- generation depend on the date. Also we do not need to update the year in the copyright notices for any files in ANGLE. Bug: angleproject:2621 Change-Id: I123864e77bffe8e04e5b299f0c58853c89287372 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2552980 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Cody Northrop <cnorthrop@google.com> Reviewed-by:
Courtney Goeltzenleuchter <courtneygo@google.com>
-
Jamie Madill authored
Instead of using an egl::Error return value, errors are recorded on the egl::Thread immediately at the call site. This makes the code work the same way as in the GL entry points. Updates the EGL "try" macros to include a special handler for the EGL validation entry points. Uses a special ValidationContext helper class to preserve the existing info. Bug: angleproject:5378 Change-Id: I897f221a41fe406676950600e4ac559081b9f541 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2551790 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Cody Northrop <cnorthrop@google.com> Reviewed-by:
Tim Van Patten <timvp@google.com>
-
Jamie Madill authored
This matches the extension spec. Previously we were exposing the ext as a normal display extension. The extension should work without needing a display. Because the extension requires a non-null device for every display we also add a MockDevice class to handle back-ends which don't implement any attribute query extensions. By default the device query ext does not expose any way to use devices so this works fine. Bug: angleproject:5372 Change-Id: I474310a86aff6a83bd6f9a6b21c8a07c649f306d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2551543Reviewed-by:
Jonah Ryan-Davis <jonahr@google.com> Reviewed-by:
Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
- 23 Nov, 2020 8 commits
-
-
Charlie Lao authored
The specialization constant crrev.com:/c/2514773 was hitting test failures on pixel2 devices but not able to reproduce on pixel4. Now I think the problem is likely attribute to QC driver bug http://b/173636783. And we have disabled specialization constant code path on older driver. This CL is to re-enable those tests that we skipped in that CL so that they gets tested. Bug: b/173636783 Change-Id: I3452abee26ebc6b8e81e68831fb2c698e464cf07 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2555858 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by:
Tim Van Patten <timvp@google.com>
-
Jamie Madill authored
The upstream issue was marked fix so these tests should be passing. Bug: angleproject:2898 Change-Id: Ib5db7d3e06d2925730dcf691cf02d92b10983b99 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2553790Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
Mohan Maiya authored
When we check to see what formats we can reinterpret for sRGB extensions, we need to make sure we can match the image usage flags as well. If the original format supports framebuffer attachment usage, we need to make sure that the reinterpreted format can support it as well. Bug: angleproject:5309 Change-Id: I7e84d01004504f854a3e22227e99b1740ed1a2b2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2549156 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
Jamie Madill authored
WebGLCompatibilityTest.R16FTextures/ES3_OpenGL WebGLCompatibilityTest.RG16FTextures/ES3_OpenGL WebGLCompatibilityTest.RGB16FTextures/ES3_OpenGL WebGLCompatibilityTest.RGBA16FTextures/ES3_OpenGL WebGLCompatibilityTest.RGBA32FTextures/ES3_OpenGL Bug: angleproject:5357 Change-Id: I63a98fc1dc7316db0a5203e3bc814d8751c1bf58 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2553789Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/ec5cd38a0ca6..0ec6b066bfbc 2020-11-21 marky@lunarg.com build: Fix clang warnings 2020-11-18 shannon@lunarg.com build: Update known-good files for 1.2.161 header If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: Ie598d39836343edff790eadf116cc56f451062bf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2553895Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/de9e649438ed..6d612051c083 2020-11-20 amaiorano@google.com Kokoro: add Windows x86 (Win32) debug builds 2020-11-20 amaiorano@google.com marl: fix extra ';' warning 2020-11-20 amaiorano@google.com Make vk-unittests load/unload swiftshader only once per suite 2020-11-20 bclayton@google.com Vulkan: Fix use-after-destruction of VkFence event If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I707af9a2c8c89cc2b2e17c0d576add852d827709 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2553894Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/chromium/src.git/+log/bfc1b42ff141..a41860e83258 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/afc55ca8f3..fe03ecff2c * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..91c1a7c2dc * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/d2979b278f..d685b9def8 No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: I4a2dd310aac643feb6c73ca9696cf57b03a9c50c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2554351Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
Yuly Novikov authored
Crashes: OpenGL: MemoryObjectTest.MemoryObjectQueries MemoryObjectTest.MemoryObjectShouldBeMemoryObject MemoryObjectTest.ShouldFailValidationOnImportFdUnsupportedHandleType UniformBufferTest.SizeOverMaxBlockSize VulkanExternalImageTest.ShouldClearOpaqueFdWithSemaphores VulkanExternalImageTest.ShouldDrawOpaqueFdWithSemaphores VulkanExternalImageTest.WaitSemaphoresRetainsContentOpaqueFd Vulkan: MultisampledRenderToTextureTest.2DColorDepthMultisampleDrawTest MultisampledRenderToTextureTest.DepthReadWriteToggleWithStartedRenderPass MultisampledRenderToTextureES3Test.RenderbufferClearDrawCopyThenBlendWithDepthStencilSameProgram MultisampledRenderToTextureES3Test.RenderbufferDepthStencilClearDrawCopyThenBlend MultisampledRenderToTextureES3Test.RenderbufferDepthStencilDrawCopyClearThenBlend MultisampledRenderToTextureES3Test.RenderbufferUnresolveColorAndDepthStencilThenTwoColors MultisampledRenderToTextureES3Test.RenderbufferUnresolveColorAndDepthThenTwoColors MultisampledRenderToTextureES3Test.RenderbufferUnresolveColorAndStencilThenTwoColors SimpleStateChangeTest.RebindTranslatedAttribute Failures: OpenGL: GLSLTest_ES31.MixedRowAndColumnMajorMatrices_WriteArrayOfArray GLSLTest_ES31.MixedRowAndColumnMajorMatrices_WriteSideEffect PixmapTest.BindTexImage ReadPixelsPBONVTest.Basic SimpleStateChangeTestES31.InvalidateThenStorageWriteThenBlend StateChangeTestES3.DrawPausedXfbThenNonXfbLines Bug: angleproject:5379, angleproject:5380, angleproject:5381 Bug: angleproject:5382, angleproject:5383, angleproject:5384 Bug: angleproject:5385, angleproject:5386, angleproject:5387 Bug: angleproject:5388, chromium:1004356 Change-Id: I73c6ba193ef230f576c804e8880f326ac5eabe0d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2552940Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
-
- 22 Nov, 2020 1 commit
-
-
angle-autoroll authored
https://chromium.googlesource.com/chromium/src.git/+log/62214500294f..bfc1b42ff141 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC cnorthrop@google.com,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/0e1eb49be6..afc55ca8f3 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/a71d13aa1c..5da61f6a14 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..91c1a7c2dc * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/e84c9a3fd7..9893e506b3 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/2d30d8744f..41850cbe98 * tools/luci-go: git_revision:1a022d3a4c50be4207ee93451255d71896416596..git_revision:6cbe3f56e9f00b8f65eae21f01838a8b58191a47 * tools/luci-go: git_revision:1a022d3a4c50be4207ee93451255d71896416596..git_revision:6cbe3f56e9f00b8f65eae21f01838a8b58191a47 * tools/luci-go: git_revision:1a022d3a4c50be4207ee93451255d71896416596..git_revision:6cbe3f56e9f00b8f65eae21f01838a8b58191a47 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/a63101d578..d046f3d4cb No update to Clang. Bug: angleproject:3647,angleproject:5328 Tbr: cnorthrop@google.com,jmadill@google.com Change-Id: I915e98f9a6bdc1043dcaa91ec7397c6148ac7ee4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2553402Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
- 21 Nov, 2020 2 commits
-
-
Cody Northrop authored
TBR: jmadill@chromium.org,courtneygo@google.com Test: angle_perftests --gtest_filter="*google_maps*" Bug: b/172977194 Change-Id: I1e2a2ed7af95069d30fd4d0fede036555688e98b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2530456Reviewed-by:
Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
-
Charlie Lao authored
Right now context does not know which specialization constant is used by the shader. Whenever a specialization constant changes, we assume shader program is using it, we always reach into vulkan driver to ask for a new program. Instead we can track shader's usage of specialization constant so that context can utilize this information to avoid recompile pipeline program if an unused specialization constant has changed. This CL implements the plumbing the usage bits form compiler to program object, it does not actually utilize the usage bits to avoid unnecessary compilation yet. Bug: b/173461931 Change-Id: Iebc9d0638c17b1a282c8b6093ce6bae154246e57 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2542866Reviewed-by:
Ian Elliott <ianelliott@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
-
- 20 Nov, 2020 12 commits
-
-
Cody Northrop authored
Requires GL_EXT_shadow_samplers which is not exposed by Qualcomm's native driver on Pixel 4 XL. Test: angle_perftests --gtest_filter="*lego_legacy*" Bug: b/161716126 Bug: angleproject:5373 Bug: angleproject:5374 Change-Id: Ifff9c5e878b7fe9a3ade684ae5f8e57167f01a25 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2477441 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Courtney Goeltzenleuchter <courtneygo@google.com>
-
James Darpinian authored
These fixes are necessary for ANGLE to work on iOS. I made these while updating ANGLE in WebKit. Unless we make an iOS bot, there will likely be small fixes like this every time we roll ANGLE in WebKit. Bug: angleproject:4613 Change-Id: Ia0ed432c82d0a43b9514c26ddb65c168c393d50d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2551537 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org>
-
Courtney Goeltzenleuchter authored
SharedFences are now only used by CommandQueue so move fence recycler to live there instead of RendererVk. Bug: b/170312581 Change-Id: Ib055ec50fbebe675a0064e1059089720e63b96b3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2551792 Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by:
Tim Van Patten <timvp@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
Cody Northrop authored
From testing on the bots, the limit of 8 is required. Also happens to be the most common limit per gpuinfo.org. Test: LEGO MEC Bug: b/161716126 Change-Id: I76447a02c5546bda9085a179b123640d2a93474d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2552557Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
-
Jamie Madill authored
Previously we were using a separate mechanism to capture screen shots. This would cause very long traces to replay the entire trace before normal execution. The Maps trace used hundreds of frames and this was timing out the test step. Instead we can capture a screenshot after the first time we run a trace. This will normally not interfere with performance work because we don't usually capture screenshots and do performance work at the same time. Bug: b/172977194 Change-Id: I12cfe2d051d41f1e000a98ac8aef16eb153879c0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2552925Reviewed-by:
Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
Mohan Maiya authored
Add support for gl_SampleMask for single-sampled targets. When dealing with a single-sampled target, gl_SampleMask is always be set to 0xFFFFFFFF. And when the target is single-sampled, sample shading is disabled to enable Bresenham line rasterization. Bug: angleproject:3588 Tests: dEQP-GLES31.functional.shaders.sample_variables. sample_mask.discard_half_per_pixel.* sample_mask.discard_half_per_sample.* sample_pos.correctness.* sample_mask_in.bit*_per_two_samples.* sample_mask.discard_half_per_two_samples.* sample_mask.inverse_per_* Change-Id: Ibb471261b8451ff01fab3dc43f2e965ae2999610 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2477909Reviewed-by:Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/3f73b676d6e8..524e5bcfba33 2020-11-20 venni.ihanakangas@siru.fi Update tests to not trigger undefined behaviour in framebuffer_fetch cases 2020-11-20 antto.makinen@siru.fi Add a batch of GraphicsFuzz coverage tests 2020-11-20 piotr.byszewski@mobica.com Add tests for empty structs in UBOs and SSBOs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC cnorthrop@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com,angle-bots+autoroll-info@google.com Change-Id: Iefb4f6764338906e64f87ea070448ffd9cf2054f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2552421Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/282aa417236a..de9e649438ed 2020-11-19 capn@google.com Fix GN build for aarch64 2020-11-19 zzyiwei@google.com AHB: minor clean up to avoid build failures on different platforms If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: Ia7d5f3eb5efb5bf6245c1b9bf80fad730be35737 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2552224Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
Shahbaz Youssefi authored
This VK extension exposes features that are not necessary for GL_OES_shader_image_atomic. Instead, support for necessary features for VK_FORMAT_R32_SFLOAT is used to determine support for this GL extension. Bug: angleproject:5342 Change-Id: Ia504cba69ffe51cfd7da69df28f58563cb1f0744 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2536908 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Mohan Maiya <m.maiya@samsung.com>
-
Brandon Schade authored
When doing an EXT_copy_image copy, renderbuffers were being recreated due to a mismatch in sample count values. Bug: angleproject:3593 Test: dEQP-GLES31.functional.copy_image.*renderbuffer* Change-Id: Ic6b85ea098ab6382b56520b1ca6b76ac25801b54 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2538076Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
-
Cody Northrop authored
Test: LEGO MEC Bug: b/161716126 Change-Id: I15e34bbeafe79c921ee01e99425555badad36fe4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2551538Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
-
Charlie Lao authored
It appears that older Qualcomm driver has some serious performance issue with specialization constant. This does not happen with latest development driver. This adds a feature flag to pick driver uniform path for older driver. Bug: b/173636783 Change-Id: Ia494fedbb1e0e69fbd8c44f8457c1bc30bc9fa4b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2547809Reviewed-by:
Tim Van Patten <timvp@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Ian Elliott <ianelliott@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
-
- 19 Nov, 2020 14 commits
-
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/4fe17f3425ee..3f73b676d6e8 2020-11-19 alexander.galazin@arm.com Merge vk-gl-cts/opengl-es-cts-3.2.6 into vk-gl-cts/master 2020-11-19 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.4 into vk-gl-cts/master 2020-11-18 zzyiwei@google.com Add external memeory tests for the VK_EXT_device_memory_report extension 2020-11-18 rgarcia@igalia.com Enable random writes for storage images 2020-11-18 rgarcia@igalia.com Fix depth/stencil image logging in renderpass tests 2020-11-18 adam.jereczek@intel.com Fix initial layout of depth stencil attachment 2020-11-18 arkadiusz.sarwa@amd.com Fix tests dEQP-VK.draw.depth_clamp 2020-11-18 rgarcia@igalia.com Avoid advertising disabled robustness2 features 2020-11-18 slawomir.cygan@intel.com Fix regressions in renderpass tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC cnorthrop@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com,angle-bots+autoroll-info@google.com Change-Id: I286bac4e33496b1aebaa7a5e2b576e3b5771d201 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2551395Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
Geoff Lang authored
Gclient sync would get stuck if the deps were left in a bad state from a previous failed roll. Pass the same args as the Chrome bots to forcefully sync. Bug: b/150458033 Change-Id: I6bd1aefbd7e4db22dd08acf781b6a08985f600da Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2551533Reviewed-by:
Geoff Lang <geofflang@chromium.org>
-
Shahbaz Youssefi authored
Take the following situation: 1. Start RP with D/S undefined: loadOp = DONT_CARE, storeOp = STORE * At this point, onDepthStencilWrite calls image->onWrite, setting depth/stencil contents defined. 2. At endRP, observe depth/stencil is not used: storeOp = DONT_CARE 3. Start another RP with D/S: loadOp = LOAD, storeOp = STORE Because the call to image->onWrite was done at startRP, the contents of the depth/stencil image is marked as defined, and the next render pass is loading these data. This change moves image->onWrite to endRenderPass, and only calls it if storeOp = STORE, taking advantage of all the opportunistic optimizations that try to set storeOp to another value. Bug: angleproject:4836 Change-Id: I9858e5caa6b1f67f841a5c6356e66927356ef469 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2548319Reviewed-by:Jamie Madill <jmadill@chromium.org> Reviewed-by:
Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
-
Geoff Lang authored
ESSL1 states that it is an error to have a non-preprocessor token before an extension pragma but ANGLE would mark a non-preprocessor token as seen even if it was in a disabled if-block. Bug: b/161716126 Change-Id: I782224bee211bc7214a2d1d98d4829b4c94101bd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2547205Reviewed-by:
Cody Northrop <cnorthrop@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
-
James Darpinian authored
This change was made downstream in WebKit: https://bugs.webkit.org/show_bug.cgi?id=218303 It turns out we must use EAGL in macCatalyst on Apple Silicon in all cases, not just in-process in iOS apps (the problem is not just about coexistence of the two GLs, but actually about our ability to load the accelerated renderer /at all/ in macCatalyst processes). I left the runtime switching in place, because there is a future in which we /can/ use CGL in non-iOS-app processes, but that future is not now. Bug: angleproject:5369 Change-Id: I9a523d038eeeeef81efa3b97771443db857e97c8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2548316Reviewed-by:
Jonah Ryan-Davis <jonahr@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: James Darpinian <jdarpinian@chromium.org>
-
Shahbaz Youssefi authored
Bug: angleproject:3647 Change-Id: I8af7d21ae7b25586b9e3bb77bb64f033fc6cafce Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2548861Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
-
Jamie Madill authored
This outputs the GL_RENDERER string in each test when using the --verbose-logging command-line flag. Bug: b/173518650 Change-Id: Id966294d50aaba0c8a1f3e010f76d5560e6f1288 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2545403Reviewed-by:
Charlie Lao <cclao@google.com> Reviewed-by:
Courtney Goeltzenleuchter <courtneygo@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
Jonah Ryan-Davis authored
Texture buffers were missing from the query, which was crashing the GPU process immediately on startup when ANGLE was used on Mac. Bug: angleproject:3573 Change-Id: I02657964de1be700b604b7259f3ea10361614f86 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2548741 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
Mohan Maiya authored
Add support for access to gl_SampleMask or gl_SampleMaskIn with non-constant index. Replace gl_SampleMask with ANGLESampleMask and reassign ANGLESampleMask to gl_SampleMask in the end. Bug: angleproject:3588 Tests: dEQP-GLES31.functional.shaders.sample_variables.sample_mask. discard_half_per_pixel.* discard_half_per_sample.* Change-Id: Ie668c3ccf4d40352574db57f5e43b2f17ef6d8b8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2477908 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by:Shahbaz Youssefi <syoussefi@chromium.org>
-
Mohan Maiya authored
Enable OES_sample_variables extension on Vulkan backend. Add support for built-in variables, uniform state and constants - gl_SampleId, gl_SamplePosition, gl_SampleMask, gl_SampleMaskIn - gl_NumSamples - gl_MaxSamples Bug: angleproject:3588 Tests: dEQP-GLES31.functional.shaders.sample_variables.* KHR-GLES31.core.sample_variables.* Change-Id: Idf37c7b4ccb0331dbda7acd6389ff4e1022ba959 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2477907 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by:Shahbaz Youssefi <syoussefi@chromium.org>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/67d0fc6389ff..6ef69fbda85b 2020-11-18 shannon@lunarg.com build: Update known-good files for 1.2.161 header 2020-11-18 charles@lunarg.com vulkaninfo: add option to always open details for HTML If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-tools-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: If9a6d0533d535ed5c6218bc9430fe55507ef6b6b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2549143Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/1f2fcddd3963..671914c28e82 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I70b848a7c882428a6ea8f017b267d044260e0165 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2549142Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/169d0c7f8a7b..ec5cd38a0ca6 2020-11-18 jeremyg@lunarg.com syncval: Use correct raster order for depth/stencil resolve 2020-11-18 mark@lunarg.com lifetimes: Correct for non-device parent objects If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I53de712fbb837e450556865c567aa8b04d552969 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2549144Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/bb96f79d0e15..282aa417236a 2020-11-19 capn@google.com Add GN builds for Reactor unit tests 2020-11-18 zzyiwei@google.com Add baseline VK_EXT_device_memory_report support 2020-11-18 capn@google.com Only lower MSan codegen optimization for LLVM JIT 2020-11-18 rnk@google.com Use pragmas to work around MSVC x86_32 debug miscompile bug 2020-11-18 caramelli.devel@gmail.com Subzero: inconsistency in registered threads option for the CommandLine with external LLVM If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: Ie40bcac8a261a5058f569ab92068781c45335896 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2549141Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-