Commits · 34120d075d3ef04cb32da8ddbedd5554c5b746f3 · Chen Yisong / angle

28 Aug, 2020 12 commits

Capture/Replay: Track groups of strings · 34120d07

authored Aug 27, 2020

When string counters were added, it accidentally broke
transform feedback varyings.

All the strings were combined, resulting in:

  const char *glTransformFeedbackVaryings_varyings_0[] = {
      R"(out_Posout_Aout_Bout_C)"
   };

Instead, generate the counter for the entire group.

This CL results in:

  const char *glTransformFeedbackVaryings_varyings_0[] = {
      R"(out_Pos)",
      R"(out_A)",
      R"(out_B)",
      R"(out_C)",
   };

Test: Manhattan MEC works again
Bug: angleproject:4941
Change-Id: Ie605395942c9105ba234009989f41a2a1cd8c53e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2381565Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

34120d07

Metal: Implement ANGLE_robust_resource_initialization. · 91004654

authored Aug 25, 2020

Bug: angleproject:4929
Bug: angleproject:2634
Change-Id: Ib99b810059420e69d939f1bbb644c2b95de62850
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2374826
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>

91004654

Vulkan: Use 4 MB as preferredLargeHeapBlockSize for allocator. · 9a19a996

authored Aug 26, 2020

This reduces preferredLargeHeapBlockSize from the default
value of 256 MB to 4 MB, which reduces the initial block
size from 32 MB to 512 KB.

4 MB is the same size as used by Chromium and Skia. It seems
to be a good compromise of not wasting unused allocated space
and not making too many small allocations.

This change is limited to non-Qualcomm GPUs as a number of
tests are failing on Qualcomm after this change and the
initial investigation indicates a potential driver bug. See
http://anglebug.com/4995 for more details.

Bug: chromium:1122718
Bug: fuchsia:58959
Change-Id: Ifdaf863ef38e72098a04ee57dec46ee71cab6ac3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2376891Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: David Reveman <reveman@chromium.org>

9a19a996

Vulkan: Fixes to transform feedback emulation path · 167a0f22

authored Aug 25, 2020

Two bugs were affecting the following scenario:

- Create program with xfb and no default uniforms
- Draw without xfb
- Begin xfb
- Draw with xfb
- End xfb
- map and validate

The first bug was that the descriptor set that contains the xfb buffers
and default uniforms was never allocated for the first draw call
resulting in VVL errors and crashes.

The second bug was that "Begin xfb" was not setting the xfb buffers
dirty bit, which meant that after the first draw call bound dummy
buffers to the descriptor set, they would not get updated.  This was
simultaneously fixed in 5d3a4ca4, but the added test nevertheless tests
this.

Bug: angleproject:4660
Change-Id: I16eee315e39ec5a657481e54ecd0491581e886aa
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2376172Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

167a0f22

Roll Vulkan-ValidationLayers from cac2574c240a to af56d31487bb (5 revisions) · 5c8601ed

authored Aug 28, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/cac2574c240a..af56d31487bb

2020-08-27 s.fricke@samsung.com layers: Better timeline semaphore error messages
2020-08-27 s.fricke@samsung.com layers: Label VUID 01413
2020-08-27 s.fricke@samsung.com layers: Label pipeline stype-stype VUs
2020-08-27 s.fricke@samsung.com layers: Label VUID 01260
2020-08-27 s.fricke@samsung.com layers: Label VUID 04121

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: courtneygo@google.com
Change-Id: I4965eda51ac41e8cf1106ee7056e1c696663997f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2381208Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

5c8601ed

Roll Vulkan-Loader from 0654095b63fb to d846ea5a2427 (4 revisions) · 20c9dd62

authored Aug 28, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/0654095b63fb..d846ea5a2427

2020-08-28 charles@lunarg.com docs: Remove mention of old layers
2020-08-27 shannon@lunarg.com build: Update known-good files for 1.2.152 header
2020-08-27 lenny@lunarg.com tests: Change license to Apache 2.0
2020-08-27 jmadill@chromium.org GN: Add missing header dependencies.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-loader-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: courtneygo@google.com
Change-Id: I837d6fa6e592d0d26b76d56d1420052269099b06
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2381296Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

20c9dd62

Roll Vulkan-Tools from c472fa2f0330 to 1b0bbd1550ed (1 revision) · 5828d7b6

authored Aug 28, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/c472fa2f0330..1b0bbd1550ed

2020-08-27 jmadill@chromium.org Update GN to include header dependencies.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-tools-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: courtneygo@google.com
Change-Id: I77bb70778e9a5a7d30e2fe22cf8daafcdb6c1ae0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2381293Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

5828d7b6

Roll SwiftShader from 1f48854dae26 to ec3650f56ca2 (1 revision) · 2c669c63

authored Aug 28, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/1f48854dae26..ec3650f56ca2

2020-08-27 srisser@google.com Add getPhysicalDeviceFeatures2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: courtneygo@google.com
Change-Id: I464a5cee3853aead1cf401fc661bd976aa3c8203
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2381294Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

2c669c63

Roll SPIRV-Tools from bceab9fab4bc to 08291a3a9e22 (3 revisions) · 1af5b0d2

authored Aug 28, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/bceab9fab4bc..08291a3a9e22

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: courtneygo@google.com
Change-Id: I69d6081a115bfc9d2484aba8e25ebc9be900f58c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2381295Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

1af5b0d2

Revert "Vulkan:Clean up best practices exceptions" · fde4d2f7

authored Aug 28, 2020

This reverts commit 15438d3f.

Reason for revert: Running end2end tests on Linux, this validation error pops a lot.

Original change's description:
> Vulkan:Clean up best practices exceptions
> 
> Assign new bug ID for clean-up work. It appears that the
> UNASSIGNED-BestPractices-vkCreateCommandPool-command-buffer-reset
> error was already fixed.
> 
> Bug: b/166641492
> Change-Id: I536017e0386cf5f57bb53bcba32d5df048050343
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2380510
> Reviewed-by: Tim Van Patten <timvp@google.com>
> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
> Commit-Queue: Tobin Ehlis <tobine@google.com>

TBR=tobine@google.com,courtneygo@google.com,timvp@google.com,syoussefi@chromium.org,jmadill@chromium.org

Change-Id: I90ee856b8bcac3e3f2b8104fb8642185a26f3e63
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: b/166641492
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2381077Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

fde4d2f7

Fix ASAN error with test · d3eba1db

authored Aug 27, 2020

Test was not creating large enough vertex attributes for the DrawQuad
call and thus hitting ASAN error when trying to copy the 6 vertices
worth of data from an array of 3.

Bug: b/166617516
Change-Id: Ia05909ada12cafa48e70c6b4ecdbbf729bbb71be
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2380234
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tobin Ehlis <tobine@google.com>

d3eba1db

Fix warnings that show up in Skia with MSVC. · dfddb983

authored Aug 27, 2020

Bug: skia:7647
Change-Id: I6951dcfc1eacd0426dfa7f8142780a5065fae1b0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2380715Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

dfddb983

27 Aug, 2020 17 commits

Workaround GN bug · a1d05e35

authored Aug 27, 2020

Works around a bug in `gn desc` where values can sometimes be reported
as strings when we would expect them to be lists. This was causing
issues with the migration to abseil, as scripts/export_targets.py
did not have a workaround for this bug.

Bug: angleproject:4873
Change-Id: I69994e2cd68a563110fcb98072a24f59f70a06d3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2380716
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

a1d05e35

Fix badly formatted dEQP test expectation · bb33c7cb

authored Aug 27, 2020

Bug: angleproject:4996
Change-Id: Ib96c8fe05e715df32390378443e1394b8df74833
TBR=jmadill@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2380247Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>

bb33c7cb

Revert "Vulkan: restore mContentDefined at endRP()" · a08495d9

authored Aug 27, 2020

This reverts commit 53ee431e.

Bug: chromium:1122621
Change-Id: Ifd63aa0694e00ed6ef74b385466b874604355e79
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2380610Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>

a08495d9

Vulkan: Fix whitebox test to end render pass · 44df3fa9

authored Aug 27, 2020

Since the RAII-based GLRenderbuffer goes away at the end of the test
function, we should end the render pass before ending the test.

Bug: chromium:1122621
Change-Id: I5aaf2a0b4fd63a38fc5018830ee4e9d7d93f0c81
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2380248Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>

44df3fa9

Vulkan:Clean up best practices exceptions · 15438d3f

authored Aug 27, 2020

Assign new bug ID for clean-up work. It appears that the
UNASSIGNED-BestPractices-vkCreateCommandPool-command-buffer-reset
error was already fixed.

Bug: b/166641492
Change-Id: I536017e0386cf5f57bb53bcba32d5df048050343
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2380510Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Commit-Queue: Tobin Ehlis <tobine@google.com>

15438d3f

Suppress functional_shaders_indexing_tmp_array_*_const_* on Metal · 1e068e1d

authored Aug 27, 2020

These tests were recently added, and fail on the Metal backend.

Bug: angleproject:4996
Change-Id: Iadffa25ab5b6c1372874c82f8356f7f19c76d1e0
TBR=jmadill@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2380244Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>

1e068e1d

Vulkan:Use roundUpPow2 where possible · d7276586

authored Aug 26, 2020

Utility function roundUpPow2 is more optimal than roundUp so use it.

Bug: b/166462979
Change-Id: I616fa9f487b818137b1b496d93e292c3bd1f428c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2377119Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Tobin Ehlis <tobine@google.com>

d7276586

Disable forceOldRewriteStructSamplers on Mali. · 7bb75ff6

authored Aug 26, 2020

The nested_array.*sampler2D_* tests can pass on Mali with disabled
forceOldRewriteStructSamplers.

Test: dEQP-GLES31.functional.uniform_location.nested_array.*sampler2D_*
Bug: angleproject:2703
Change-Id: I34368d6ce14b81e873e2a3d60a73da4a8a866884
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2377627
Commit-Queue: Amy Liu <Amy.Liu@arm.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

7bb75ff6

Roll Vulkan-ValidationLayers from 7a71abb602a2 to cac2574c240a (1 revision) · 28259677

authored Aug 27, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/7a71abb602a2..cac2574c240a

2020-08-26 locke@lunarg.com layers: Get imageview from imageless framebuffer

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: courtneygo@google.com
Change-Id: I0e78a36cfff84f883219601b62f516970bbbdd97
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2377077Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

28259677

Roll Vulkan-Headers from 834673eaa34a to ced848d699b5 (1 revision) · 68048170

authored Aug 27, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/834673eaa34a..ced848d699b5

2020-08-26 oddhack@sonic.net Update for Vulkan-Docs 1.2.152

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-headers-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Change-Id: Id9950d584ada693a8a1a12699345706b725bbc2a
Bug: None
Tbr: courtneygo@google.com
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2379233Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

68048170

Roll VK-GL-CTS from 94ee680cab4c to 11fcbbf5d7cc (1 revision) · 0c7ea948

authored Aug 27, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/94ee680cab4c..11fcbbf5d7cc

2020-08-27 alexander.galazin@arm.com Merge pull request #223 from jpark37/colorspace-common-instance

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC courtneygo@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: courtneygo@google.com,angle-bots+autoroll-info@google.com
Change-Id: I27f7fba863ee772efa2edb143d10a99099a853c8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2379234Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

0c7ea948

Roll Vulkan-Loader from e1c7eaa74142 to 0654095b63fb (3 revisions) · b74fc289

authored Aug 27, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/e1c7eaa74142..0654095b63fb

2020-08-26 lenny@lunarg.com repo: Prevent cmake name mismatch warning
2020-08-26 rharrison@google.com Fix formatting
2020-08-26 rharrison@google.com Move variables into scope they are referenced within

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: courtneygo@google.com
Change-Id: I9549c05967e687f230258c06e91bb70f2a0cfb02
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2377081Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

b74fc289

Roll SPIRV-Tools from 2205254cfb50 to bceab9fab4bc (3 revisions) · ad3fec0a

authored Aug 27, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/2205254cfb50..bceab9fab4bc

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: courtneygo@google.com
Change-Id: I7ea2bad1481eafeb1a06963680015c310c8fa165
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2377079Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

ad3fec0a

Roll glslang from 983698bb34ec to 517f39eee46f (1 revision) · 2e9a7892

authored Aug 27, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/983698bb34ec..517f39eee46f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: courtneygo@google.com
Change-Id: I27a71506052a5cd1eca7ad48d4f13a3692976008
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2377080Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

2e9a7892

Roll Vulkan-Tools from dda8dabe9eb3 to c472fa2f0330 (4 revisions) · 600836dc

authored Aug 27, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/dda8dabe9eb3..c472fa2f0330

2020-08-26 nathbappai@gmail.com cube: satisfy clang-format
2020-08-26 nathbappai@gmail.com vulkaninfo: Check if NOMINMAX is already defined
2020-08-26 nathbappai@gmail.com cube: Check _MSC_VER instead of _WIN32 for pragma directive
2020-08-26 nathbappai@gmail.com CMake: Check MSVC while deciding MSVC_VERSION

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: courtneygo@google.com
Change-Id: I42b2ba08ec405a0857ce7939f19e90ecb81a4b88
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2377076Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

600836dc

Roll SwiftShader from 622558b02e1a to 1f48854dae26 (3 revisions) · 521118db

authored Aug 27, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/622558b02e1a..1f48854dae26

2020-08-26 capn@google.com Refactor image extent retrieval
2020-08-26 capn@google.com Refactor image view extent retrieval
2020-08-26 capn@google.com Refactor image query instructions

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: courtneygo@google.com
Change-Id: Ib1dbbab2d4cabe177b7330c0b0edee5370546c5e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2377078Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

521118db

Revert "Vulkan: Only count descriptor set resources once" · 97013e85

authored Aug 27, 2020

This reverts commit 3c2454b8.

Reason for revert:
Causes rendering issues in Manhattan 3.1.

Original change's description:
> Vulkan: Only count descriptor set resources once
> 
> The descriptor set resource counts for monolithic programs already have
> all of the counts combined for all shader stages, rather than needing to
> loop through and combine them all like program pipeline objects.
> 
> Bug: angleproject:3570
> Test: CQ
> Change-Id: Ib8a2fe7af991a8d9d5edcef346352c7bac0703fd
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2375869
> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Commit-Queue: Tim Van Patten <timvp@google.com>

TBR=courtneygo@google.com,timvp@google.com,jmadill@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: angleproject:3570
Change-Id: I4150d5adf65ace293cb08876e4a62ae3216096b6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2378564Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>

97013e85

26 Aug, 2020 11 commits

Vulkan: More perf warnings · 68c8ed7a

authored Aug 25, 2020

Perf warnings added in the CPU path for unpack buffers, as well as CPU
readback of images.

Bug: angleproject:3461
Bug: angleproject:4900
Change-Id: I0f716a1ea6110ba8e779903a7d5913d5f6df0ce9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2376905Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

68c8ed7a

Add support for P010 IOSurfaces · 710e408e

authored Aug 25, 2020

Add test coverage of multi-plane IOSurfaces.

Bug: chromium:1115621
Change-Id: Ib2150c4221a3e49f01ab016cebba4830194ab2b5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2376174Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

710e408e

Fix Linux build with Skia. · 8970ad3f

authored Aug 26, 2020

Bug: skia:7647
Change-Id: I6bb33a98d69400c9d95fb9d028d29a3e470067e3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2377291Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

8970ad3f

Generalize zlib utils dir for Skia build. · 35d3c416

authored Aug 26, 2020

Bug: skia:7647
Change-Id: I3664355d183c1aec87ffd35ab23f594cdd1766c3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2376716Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

35d3c416

Fix SwANGLE suppressions of EGLIOSurfaceClientBufferTest · b89e9611

authored Aug 19, 2020

Suppressions were missing for several texture formats. This slipped
through because angle_end2end_tests are not run on SwANGLE on Mac.

Bug: angleproject:4369
Change-Id: I0cbafe5daab591da15f86f2658c4edc724ae2561
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2364190Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>

b89e9611

Vulkan: Fix TRex performance regression · 1ea22c31

authored Aug 25, 2020

TRex invalidates depth but doesn't disable depth before the render
pass ends. The render pass isn't ended, but a storeOp of STORE was
used instead of DONT_CARE, which causes a performance regression.

Bug: b/163854287
Change-Id: Iebd9999ef66c11ff334db3eef2943f58eb2d5053
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2377105Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>

1ea22c31

Roll VK-GL-CTS from fb86cfb19849 to 94ee680cab4c (10 revisions) · 143193d5

authored Aug 26, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/fb86cfb19849..94ee680cab4c

2020-08-21 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.3 into vk-gl-cts/vulkan-cts-1.2.4
2020-08-20 alexander.galazin@arm.com Allow Vulkan CTS 1.2.4.0
2020-08-20 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.3 into vk-gl-cts/master
2020-08-20 chrgau01@arm.com Fix incorrect buffer type in some protected memory tests
2020-08-20 tzlatinski@nvidia.com Fix Image layout transitions for diff_attachments_*
2020-08-20 venni.ihanakangas@siru.fi Fix creation of signaled fences in swapchain tests
2020-08-18 peter.quayle@imgtec.com Disable interval watchdog during long shader compiles
2020-08-14 anholt@google.com gles2: Add temporary constant-data shader indexing tests.
2020-08-14 vkushwaha@nvidia.com Add tests for floating-point atomic operations
2020-08-13 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.3 into vk-gl-cts/master

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: courtneygo@google.com,angle-bots+autoroll-info@google.com
Change-Id: I9cf79e76d876ad0359c0d37923a664154d1fe9b3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2377407Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

143193d5

Roll third_party/vulkan_memory_allocator/ 431d6e572..065e73907 (5 commits) · 3d160951

authored Aug 26, 2020

https://chromium.googlesource.com/external/github.com/GPUOpen-LibrariesAndSDKs/VulkanMemoryAllocator/+log/431d6e57284a..065e739079d9

$ git log 431d6e572..065e73907 --date=short --no-merges --format='%ad %ae %s'
2020-08-26 jmadill Suppress two override suggestion warnings.
2020-06-25 thakis mac: Only call system aligned_alloc() with the 11.0+ SDK.
2020-06-25 thakis Only use system aligned_alloc on mac/ios if the SDK has them.
2020-06-25 thakis Fix argument order for aligned_alloc on mac.
2020-06-25 thakis Make vulkan_memory_allocator build with the MacOSX11.0 SDK.

Created with:
  roll-dep third_party/vulkan_memory_allocator

Bug: skia:7647
Change-Id: Ia87c1c2d47547c170ab1f9a3bc84825b1716337d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2376892Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

3d160951

Roll SPIRV-Tools from 12df3cafeee0 to 2205254cfb50 (4 revisions) · bc993b27

authored Aug 26, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/12df3cafeee0..2205254cfb50

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: courtneygo@google.com
Change-Id: I8ce381fe7b7d11c15aa9fbcae7da4ecc977e5ed4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2377647Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

bc993b27

Roll Vulkan-ValidationLayers from e798df982b1b to 7a71abb602a2 (7 revisions) · 5eaba134

authored Aug 26, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/e798df982b1b..7a71abb602a2

2020-08-26 locke@lunarg.com tests: Check shader feature enable
2020-08-26 locke@lunarg.com layers: Add has_atomic_descriptors
2020-08-25 s.fricke@samsung.com tests: Add ProtectedSubmitInfo VUs
2020-08-25 s.fricke@samsung.com layers: Add ProtectedSubmitInfo VUs
2020-08-25 s.fricke@samsung.com layers: Label bind2 protected VUs
2020-08-25 s.fricke@samsung.com layers: Label import fence VUs
2020-08-25 s.fricke@samsung.com layers: Label ValidateFenceForSubmit VUs

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: courtneygo@google.com
Change-Id: If9d99d2e6d56e1983168a1e6b1d1442312c3dd97
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2377509Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

5eaba134

Vulkan: Fix optimizeRenderPassForPresent regression. · c5b9c49c

authored Aug 25, 2020

gfxbench clears the depth buffer right before the swap. Even though the
last draw call that presents the frame didn't ever read or write to
depth, the tracking we added thought this depth write meant we had to
keep the LOAD_OP as CLEAR. Instead we can refine our check to treat
clears specially when enabling the depth-stencil read-only mode instead
of changing how the tracking works for clears. This way the tracking
can not affect other apps that don't use depth-stencil read-only loops.

Also adds a regression test that counts the clears after a swap.

Bug: angleproject:4959
Bug: angleproject:4979
Change-Id: I12ece6474019f7519a467f827110ad817f7d4df7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2370364
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

c5b9c49c