This patch series optimizes programs that use the pattern:

for (;;) {
  glVertexAttribPointer(...)
  glDraw(...)
}

Change 2: Micro-optimize XFB resume CPU overhead.

We don't need to set resume on every new command buffer. We only need
to set the dirty bit when we have an unexpected pause.

In total the patch series reduces test iteration time by 25%.

Test: DrawCallPerfBenchmark.Run/vulkan_attrib_change
Bug: angleproject:5045
Bug: b/168493024
Change-Id: I8f6c68ff0513be4f405276e395d80bc1a185a061
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2409174
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

This patch series optimizes programs that use the pattern:

for (;;) {
  glVertexAttribPointer(...)
  glDraw(...)
}

Change 1: Don't null out pipeline on state change.

This allows us to use the transition table for reduced CPU overhead.
Note that we don't use a transition table for compute pipelines.

In total the patch series reduces test iteration time by 25%. This is
the most significant patch, reducing test time by 20%.

Test: DrawCallPerfBenchmark.Run/vulkan_attrib_change
Bug: angleproject:5045
Bug: b/168493024
Change-Id: I3823bb7d83bc2c66357fc5eb8f5dc3e4e54f6a17
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2407340
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

These are additional tests that were written when trying to refactor
mContentDefined and move it from RenderTargetVk to ImageHelper for
depth/stencil attachments.  We still want to land the tests.

Bug: b/167275320
Change-Id: I12f6bf8cece6499e4474a8f114b177626c1aa4d5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2419117Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>

Bug: b/168744476
Change-Id: I26205e7d29260ffdefbd5b2971b570c8bff7187f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2416236
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

This will allow automated notification of any vulnerabilities
reported against rapidjson. Prior commit history suggests that
this is only used for outputting test results and is therefore
unlikely to be security-critical, but we're gradually aiming to
get 100% coverage of all our dependencies and this should be an
easy one.

See
https://chromium.googlesource.com/chromium/src.git/+/master/docs/adding_to_third_party.md#add-a-readme_chromium

Bug: chromium:895969
Change-Id: Ie3f0db3fed525e81e4fa6e84fe96fe6c72575046
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2419035Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

It's possible for multiple threads to touch mFenceRecycler so need to
protect it with a mutex to prevent race conditions.

Bug: b/168744476
Change-Id: I9898d2e9ebf0974581a1074cbda5be41a09cd790
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2415401Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>

This is necessary to run angle_end2end_tests with sanitizers. We
don't currently support building the VVL in sanitized configs.

Bug: b/168744561
Change-Id: If16a25ac5786f5f5aeb8ae50d9f7fa22c6c87995
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2415513Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

This function is more useful if it takes just the min filter mode
instead of the entire sampler struct to read a single member.

Bug: b/167404532
Change-Id: Ie8c01c4095a615f06fe046fb175cdfb92fa54cbf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2419111Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

The trace tests aren't strictly for performance. Since we'll be using
them for correctenss testing as well it makes sense to move them out
of the perf_tests/ folder.

Also renames RestrictedTraceTests.md to README.md so it'll load
automatically in gitiles.

Bug: angleproject:4090
Bug: b/168049670
Change-Id: I8be9f1d831489a9abf534d049a93441687850142
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2416913
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

Was looking at the Chromium path instead of the ANGLE path.

Bug: skia:10572
Change-Id: I7f5dba011a5d446b8f1ef814f89421edfd0f7b95
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2418420Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/6ccc0d9ba0ff..c9f4fb2fccda

2020-09-18 alexander.galazin@arm.com Merge vk-gl-cts/github-master into vk-gl-cts/master
2020-09-18 michal.m.pawlowski@mobica.com Issues detected by synchronization validation layer fix
2020-09-18 gleese@broadcom.com Fix memory barriers in image_subresrouce tests
2020-09-18 slawomir.cygan@intel.com Bump fence timeout in Amber test cases to infinity
2020-09-18 anholt@google.com vulkan: Add temporary constant-data shader indexing tests.
2020-09-18 ari.suonpaa@siru.fi Add transform feedback test with NULL offset array
2020-09-14 jessehall@google.com Fix small errors in external/openglcts/README.md

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC jmadill@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: jmadill@google.com,angle-bots+autoroll-info@google.com
Change-Id: I0549c327a93685a748e10505f7f0f6a4954eed45
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2418233Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/399f7fd741f7..a148cdd49041

2020-09-17 charles@lunarg.com Revert "loader: Return error if layer loading failed"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-loader-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: jmadill@google.com
Change-Id: I565f036b5aefb25958059a83a40972d3210303fc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2418353Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/46fc663a1cb3..d6935becabad

2020-09-17 lionel.g.landwerlin@intel.com corechecks: Fix validation of VU 03227
2020-09-17 lionel.g.landwerlin@intel.com tests: Fix QueryPerformanceResetAndBegin test
2020-09-17 lionel.g.landwerlin@intel.com tests: Fix QueryPerformanceIncompletePasses
2020-09-17 lionel.g.landwerlin@intel.com tests: Fix QueryPerformanceReleaseProfileLockBeforeSubmit test
2020-09-17 s.fricke@samsung.com tests: Add VUID 03311 and 03312
2020-09-17 s.fricke@samsung.com layers: combine renderpass create logic

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: jmadill@google.com
Change-Id: I6db2f85ac027cba303fd8d7ced01d2bd6c3e2b79
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2418351Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/34ef0c3fdc8e..50ae4c5f4427

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: jmadill@google.com
Change-Id: Ie557a8f0936e468539aa3852c0f66eb22db4ed32
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2418352Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/b045bf7d3b6a..6ccc0d9ba0ff

2020-09-18 alexander.galazin@arm.com Merge pull request #227 from kusma/nearest-edge-8-bit-precision

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC jmadill@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: jmadill@google.com,angle-bots+autoroll-info@google.com
Change-Id: Iaa532dd819fb8265bbe256d9b924d2d80d839ced
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2417977Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

When vkCreateSwapchainKHR is called with a valid oldSwapchain, the
Android framework destroys the images in oldSwapchain.  This is not
correct, as it should be deferred to the actual vkDestroySwapchainKHR
call performed later by ANGLE.  This is because rendering to the
oldSwapchain could still be in progress.

While this issue affects all of Android, currently only ARM shows any
symptoms.  A workaround is added for ARM to vkDeviceWaitIdle before
recreating the swapchain if oldSwapchain is valid.

Bug: angleproject:5061
Change-Id: I308e4798c6418d7891d880218b0ebcfd7a795643
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2416238Reviewed-by: Sunny Sun <sunny.sun@arm.com>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

Uses the display global mutex.

Caught with angle_end2end_tests MultithreadingTest and TSAN.

Bug: b/168744561
Change-Id: I5a60346cb5f95ff506dc166604eeae501863a774
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2415182Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Bug: angleproject:3461
Change-Id: Id80ccc81db3cb66438b6b5e6d504eda613f481d1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2416244
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Leveraging the fact that there are only a handful of depth/stencil
formats, the last element of RenderPassDesc::mAttachmentFormats can
contain other information in addition to the depth/stencil format ID.

The FormatID enum is rearranged such that depth/stencil formats are
placed first, as a result occupying values in [1, 7].  These values take
up 3 bits in an element of RenderPassDesc::mAttachmentFormats (which
could be the last element if all color draw buffers are attached).

As a result, the upper 5 bits of the last element of
RenderPassDesc::mAttachmentFormats is unused.  It is intended for these
bits to be used in the implementation of multisampled-render-to-texture
depth/stencil renderbuffers.

Bug: angleproject:4836
Change-Id: I0786e0712539cdbbf5494ec83aeee1dd93f936dd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2413165
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Expose the "debug" mutex so insertPerfWarning can use it.

This was detected using TSAN and MultithreadingTest.

Bug: b/168744561
Change-Id: Idde95a7b217f21f007893192a4a1f0a69b4ed3a9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2415184
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>

Use a mutex to guard against the object init. The accesses to the
cache internals are internally synchronized. There is a Vulkan ext
that allows for external cache synchronization that we could
investigate at some point.

Detected by looking at MultithreadingTest with TSAN enabled.

Bug: b/168744561
Change-Id: I1d4744e1aa970bcd57cac49f7ecaf8c238ea61c2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2415183
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>

We introduce a new Display Global Mutex in egl::Display that
can guard access to gActiveCompilers in Compiler.cpp.

Was detected by running MultithreadingTest against TSAN.

Bug: b/168744561
Change-Id: I97866b60a173f60899cd0406fe0f71000035c0cf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2415181
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

Currently, ANGLE calls vkAcquireNextImageKHR() immediately after
calling vkQueuePresentKHR(), which can cause the process to stall
(even with multi-threading).  Delay it until it is absoluately needed.

Test: angle_end2end_tests --gtest_filter=*EGLPreRotationSurfaceTest*/*
Test: angle_white_box_tests --gtest_filter=VulkanPerformanceCounterTest.*Invalidate*/*
Test: angle_deqp_egl_tests --gtest_filter=dEQP.EGL/functional_query_context_get_current_display_rgba8888_window* --use-angle=vulkan
Test: angle_perftests --gtest_filter=GenerateMipmapBenchmark.Run/vulkan_webgl
Bug: angleproject:5064
Bug: b/162082698
Change-Id: I466df9237136dd59a9556faa8cf2dbad94e076fe
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2399509Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Ian Elliott <ianelliott@google.com>

Color renderbuffers are similar to multisampled-render-to-texture
textures, but much simpler.  The same mechanism is used to implement
them.

Bug: angleproject:4836
Change-Id: I298529c9fd1b03e78b1e37cdbe595e66166ee130
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2412847
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

This also isolates headers for D3D9 / D3D11 from each other.

Bug: angleproject:3943
Change-Id: I04edbe7db68461ae4fc78ac7f9c22451debcb768
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2405807
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

This EGL extension will add support for creating EGLClientBuffer
backed by an Android window buffer (struct ANativeWindowBuffer)
which can be later used to create an EGLImage.

Bug: angleproject:5018
Tests: angle_end2end_tests --gtest_filter=ImageTest.SourceNativeClientBufferTarget*
Change-Id: If78ed7b80ad09629b8c5f5b5a0eb07a548e82e6e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2404320Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>

Move the offset aligning code to stencilBlitResolveNoShaderExport
to avoid affecting color blit.

Test: dEQP-GLES3.functional.fbo.blit.default_framebuffer.*_linear_*
Bug: angleproject:5044
Change-Id: Ic2ebef94091853146424d567b0035161611ba32d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2416008
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/e8ce4355ae1c..34ef0c3fdc8e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: jmadill@google.com
Change-Id: Iabc9534322647983574c505a99b926782df6a904
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2416109Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/f105898a102f..46fc663a1cb3

2020-09-16 s.fricke@samsung.com layers: Add function name to renderpass stateless
2020-09-16 s.fricke@samsung.com tests: DisabledProtectedMemory 1.1 check
2020-09-16 s.fricke@samsung.com tests: Fix UnsupportedPnextApiVersion on 1.0
2020-09-16 s.fricke@samsung.com tests: ToolingExtension devsim check

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: jmadill@google.com
Change-Id: I282762e32f84fa3ff551dfb61c761fe77b220fd0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2416108Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://swiftshader.googlesource.com/SwiftShader.git/+log/b33e0b36a08c..fe878dedd5ad

2020-09-16 hidehiko@google.com Expand is_linux to is_linux || is_chromeos.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: jmadill@google.com
Change-Id: I57f8a3c9d7170b41fb80f9c457d75d8105a62071
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2416110Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/chromium/src.git/+log/e4cbd27e4a55..d9fa0d469f57

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/42cbd32cfb..ff80cb1d7c
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/1d2f486547..5b99869e59
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/e73d966652..3a81ef17d6
* third_party/libjpeg_turbo: https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git/+log/8ca19625de..d5148db386
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/e075ddd622..92b3622380
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/552c4cfa71..894c57e360
No update to Clang.

Bug: angleproject:3162
Tbr: jmadill@google.com
Change-Id: I64cc3bf35e95add19696b72f12566cb1578e1a2e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2415853Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

Suspect possible NVIDIA driver issue as unable to repro on some NVIDIA,
Windows, NVIDIA configurations.

Test:
    angle_end2end_tests --gtest_filter=GLSLTest.NestedPowStatements/ES3_Vulkan

Bug: chromium:1127866
Change-Id: Ic6a95915af72aab086753a0e0199ac1dee8bfb62
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2410560Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

The parameter linkedShaderStages is passed to
GlslangGetShaderSpirvCode(), but is unused. This CL uses the parameter,
rather than gl::AllShaderTypes().

This CL also removes the unused parameter variableInfoMap from the call
chain.

Bug: angleproject:3570
Change-Id: Ic60084e87cb2aa2a245e3e963598851331379e89
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2412364
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

This config is unfortunately not covered on the ANGLE CQ.

Test: local GN CrOS build
Bug: angleproject:3943
Bug: chromium:1129075
Change-Id: Ie1a9b2fdfb47f2a4631e118ab88eccfb7ad7eaf8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2415186Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

When a descriptor pool is created, a list of descriptor types and counts
are given to vkCreateDescriptorPool(). Later, when allocating a
descriptor set from the pool, we pass along a descriptor set layout to
vkAllocateDescriptorSets() which is used to determine how many of each
type of descriptor (i.e. binding) to allocate from the pool.

In order for our "free descriptor set" counts to be accurate for each
pool, the descriptor pools need to be created with descriptor counts
that match the descriptor set layout binding counts.

This change fixes a bug where the descriptor set layouts were created
with more bindings than the descriptor pool sizes, causing the "free
descriptor set" count to be inaccurate, leading to allocating too many
descriptor sets from a pool.

Bug: angleproject:3570
Test: VulkanDescriptorSetTest
Change-Id: I660bf02d29a1291391fb15f39e6479bf348d0f83
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2391114
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

When the standalone tests shut down they would not wait for
the watchdog thread to exit cleanly. Fix this by setting a
flag that shuts down the watchdog and attempting to wait.

This was detected by running angle_end2end_tests with TSAN.

Bug: angleproject:3162
Bug: b/168744561
Change-Id: I765ce7a21c3be11703619470a81adb1882b009e4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2415175
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

Required an upstream fix:
https://github.com/KhronosGroup/Vulkan-Tools/pull/437

Also a workaround filed as an issue:
https://github.com/KhronosGroup/Vulkan-Tools/issues/445

Bug: angleproject:4950
Change-Id: I21333464d2a8e52d5d85d35654f0e6372f9650db
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2358517Reviewed-by: Tobin Ehlis <tobine@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

This was causing a build break on ChromeOS builers and brekaing the
ANGLE roll into Chromium.

Bug: chromium:1129075
Bug: angleproject:3943
Change-Id: Ic7976c0b506f5af67823da8de1f8c850e43abee0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2415169Reviewed-by: Jamie Madill <jmadill@chromium.org>

The location index of a vertex shader input's layout qualifier must be
less than GL_MAX_VERTEX_ATTRIBS to link successfully. We can check for
this during shader compilation to not rely on other layers to handle
pathological cases.

While strictly speaking only 'active' attributes are considered during
shader linking, this is merely intended to allow for 'uber' shaders to
declare more inputs than GL_MAX_VERTEX_ATTRIBS but only use a subset of
them. There is no known reasonable use case for a manually specified
location to exceed the valid range.

Note that according to http://opengl.gpuinfo.org, the highest
GL_MAX_VERTEX_ATTRIBS value at the time of writing is 32. Also,
D3D12_VS_INPUT_REGISTER_COUNT = 32. Hence the unit test's value of 1000
should be sufficiently future proof.

Also address the case where the uniform location might be close to
INT_MAX and not be detected as out-of-range due to numeric overflow.

Bug: chromium:1110800
Change-Id: I9985c8eab3bb8a2a59b8f985e8f5b6884756383c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2405368Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Nicolas Capens <capn@chromium.org>

These were messing up the test runner when used in combination
with the test runner's specific args.

Make it an error if the arguments are used together.

Bug: angleproject:3162
Change-Id: I6fa1c0fb346a8c376ca455f7f4bf0492cfc0198a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2414931Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>