Commits · 47fadcb975e91ff33527cc5f460eb08a97d2a0ff · Chen Yisong / angle

09 Apr, 2015 2 commits

authored Apr 08, 2015

It should not be possible to redeclare arrays. This seems to be another
thing left over from earlier erroneous code which allowed declaring
unsized arrays.

TEST=angle_unittests
BUG=angleproject:941

Change-Id: I711565230b35df077f268cec6fdeac6c4c03b4cd
Reviewed-on: https://chromium-review.googlesource.com/264672Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Olli Etuaho <oetuaho@nvidia.com>

47fadcb9

Make checking for array non-constness depend on input version · 3739d235

authored Apr 08, 2015

First, remove duplicate check for const qualifier on arrays. Only keep
the check inside arrayQualifierErrorCheck().

Second, ESSL3 will introduce array initializers and by extension constant
arrays, so it should allow const qualifier on arrays. These checks are
somewhat superfluous in ESSL1 as well, since the parser already checks
for missing initializers, but it's useful to keep the informative error
messages around.

Add a few tests to make sure that when the ESSL3 implementation
progresses, it still checks for missing initializers on constant arrays.

TEST=angle_unittests
BUG=angleproject:941

Change-Id: Id871c872c5b92e2a5bf81c00080ac23004916a75
Reviewed-on: https://chromium-review.googlesource.com/264671Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Olli Etuaho <oetuaho@nvidia.com>

3739d235

08 Apr, 2015 15 commits

Revert "Use the AST analyses to narrow the usage of [[loop]] and [[unroll]]" · 938f0029

authored Apr 08, 2015

Caused linking failures on mac because the unit test asks for TranslatorHLSL which is not compiled.

This reverts commit 3342e01f.

Change-Id: I02b2f54ca5b90611f11b7a549e75bf2e8310639d
Reviewed-on: https://chromium-review.googlesource.com/264790Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

938f0029

Use the AST analyses to narrow the usage of [[loop]] and [[unroll]] · 3342e01f

authored Mar 19, 2015

These attributes are now used exactly in the loops and ifs
that require them, limiting the number of failed compilations
due to excessive unrolling and flattening.
Also output Lod0 functions only when needed.

Adds unit tests for LOOP, FLATTEN and Lod0 generation.

The patch was tested against the WebGL CTS 1.0.4 for which all the
failures existed prior to this patch and seem to be unrelated to this
change. It also works correctly on the following sites that had trouble
with [[loop]] and [[unroll]]:
 * dev.miaumiau.cat/rayTracer "Skull Demo"
 * The turbulenz engine particle demo
 * Lots of ShaderToy samples (including "Volcanic" and "Metropolis")
 * Google Maps Earth mode
 * Lots of Chrome Experiments
 * Lagoa
 * madebyevan.com/webgl-water
 * SketchFab
 * Unit Tests

BUG=angleproject:937
BUG=395048

Change-Id: If7baddae1cdae0b3a414aa49e5a4c4babedbfe50
Reviewed-on: https://chromium-review.googlesource.com/261263Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

3342e01f

Temporarily disable the RenderToMipmap on Intel OpenGL. · 1a0847ca

authored Apr 08, 2015

BUG=angleproject:905

Change-Id: If398b7f3cb60f3efdafce0f3709f965120977603
Reviewed-on: https://chromium-review.googlesource.com/264665Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

1a0847ca

Implement GL_VENDOR and GL_RENDERER strings for RendererGL. · e42753b2

authored Apr 08, 2015

Change-Id: Ib83faa605fd1b992e19ddc2b72c7917d82245d32
Reviewed-on: https://chromium-review.googlesource.com/264664Tested-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

e42753b2

Implement discontinuous loops AST analysis · 50931459

authored Mar 19, 2015

This will allow narrowing down which usages of
[[flatten]] and [[unroll]] are actually useful.

BUG=angleproject:937
BUG=395048

Change-Id: I091e647e3053d22edadd0cabb7c50bd5efa690b2
Reviewed-on: https://chromium-review.googlesource.com/263776Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

50931459

Implement gradient operation AST analysis · f4eab3b9

authored Mar 18, 2015

This will allow narrowing down which usages of
[[flatten]] and [[unroll]] are actually useful.

BUG=angleproject:937
BUG=395048

Change-Id: Ib8d7b98431b8cd3563e1eff8ecc9ed5df1a9b7d6
Reviewed-on: https://chromium-review.googlesource.com/263775Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

f4eab3b9

Add a compiler option to prune unused function and prototypes · a094a8a9

authored Apr 07, 2015

Also adds a simple unit test checking the pruning

BUG=angleproject:937
BUG=395048

Change-Id: I88440378f66178dcebebcd596f8f80235903f20e
Reviewed-on: https://chromium-review.googlesource.com/264568Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

a094a8a9

Revert "Add a compiler option to prune unused function and prototypes" · 78b3a8b9

authored Apr 08, 2015

Compile error on Mac:

http://build.chromium.org/p/chromium.gpu.fyi/builders/GPU%20Mac%20Builder/builds/29051

This reverts commit e423d9ca.

Change-Id: Ie08d7f2bf86089a006f3177480aa7491a9405257
Reviewed-on: https://chromium-review.googlesource.com/264585Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

78b3a8b9

Add a compiler option to prune unused function and prototypes · e423d9ca

authored Apr 07, 2015

Also adds a simple unit test checking the pruning

BUG=angleproject:937
BUG=395048

Change-Id: I49904c34d1a72949cdc579569967d99c736c7237
Reviewed-on: https://chromium-review.googlesource.com/264415Reviewed-by: Kenneth Russell <kbr@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

e423d9ca

Implemented a CallDAG to allow for more AST analysis · 71d147f6

authored Feb 11, 2015

The CallDAG preprocesses the AST to construct a DAG of
functions that can be used for several analyses.
Use it to implement check for recursion and max call
depth. It will also be used to limit the usage of
[[flatten]] and [[unroll]].

BUG=angleproject:937
BUG=395048

Change-Id: I8578703f2d49513f315aecccbcff34914562e4ff
Reviewed-on: https://chromium-review.googlesource.com/263774Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Nicolas Capens <capn@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

71d147f6

Add UBO offset emulation for D3D11.0 and below. · 9102e3ab

authored Mar 23, 2015

BUG=angleproject:507

Change-Id: I6c5028930051a2af0bd6ffa0ee213e692d3892ef
Reviewed-on: https://chromium-review.googlesource.com/261824Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

9102e3ab

Split Buffer::map into map and mapRange to match the API. · cc6f55dd

authored Mar 20, 2015

BUG=angleproject:681

Change-Id: Ia4bf2b81134a922265ca762f33ac85d9ddbf1a7c
Reviewed-on: https://chromium-review.googlesource.com/261890Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

cc6f55dd

Add support for GL_OES_fbo_render_mipmap with OpenGL. · 8a6f19d7

authored Apr 02, 2015

BUG=angle:905

Change-Id: Idde35172cfa495c8b74b961f4ab8c4e657653074
Reviewed-on: https://chromium-review.googlesource.com/263763Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

8a6f19d7

Replace setArray function in TPublicType with functions from TType · 693c9aa0

authored Apr 07, 2015

Having only one way of setting or clearing arrayness of types clarifies
code dealing with arrays.

TEST=angle_unittests
BUG=angleproject:941

Change-Id: I98cb7c44fd66440c9de8b4c6c4a02827e9300db7
Reviewed-on: https://chromium-review.googlesource.com/264361Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Olli Etuaho <oetuaho@nvidia.com>

693c9aa0

Remove half-baked non-sized array support · 93a90fd0

authored Apr 07, 2015

ANGLE used to accept shaders with non-sized arrays in initializer lists.
Fix this. Proper support for implicitly sized arrays will be implemented
later for ESSL3.

TEST=angle_unittests
BUG=angleproject:941

Change-Id: I53c5ccf0f7ef09ad30e142f8350812959fc4846c
Reviewed-on: https://chromium-review.googlesource.com/264360Tested-by: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

93a90fd0

07 Apr, 2015 14 commits

Temporarily disable TextureTest with OpenGL. · 5c60031e

authored Apr 07, 2015

Failures seen on some FYI bots.

Change-Id: I4853438c34ce55a1d803d3a7edf3b3e077905264
Reviewed-on: https://chromium-review.googlesource.com/264462Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

5c60031e

Disable all copy image tests on Intel. · bde666a9

authored Apr 07, 2015

Change-Id: I5412daf42777caeac37de4bdc661b01480d887fd
Reviewed-on: https://chromium-review.googlesource.com/264451Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

bde666a9

Fix GN Windows component build. · a662abb5

authored Apr 07, 2015

The translator_static dependency is missing from libANGLE.
GYP has this dependency.

Change-Id: I30165a041f88f7e3c6f550744d2c7a4103d0f520
Reviewed-on: https://chromium-review.googlesource.com/264425Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

a662abb5

Add stubs for GL_OES_fbo_render_mipmap. · 95663914

authored Apr 02, 2015

BUG=angle:905

Change-Id: Idd4964bd2d9d07cd98137770e1cc57397f1dd3a6
Reviewed-on: https://chromium-review.googlesource.com/263762Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

95663914

Add texture format utilities for GL and generate GL texture caps. · dab84368

authored Mar 02, 2015

BUG=angleproject:884

Change-Id: Ib1b13f59a6b21399c4b35695c704c369f572914e
Reviewed-on: https://chromium-review.googlesource.com/264399Tested-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

dab84368

Revert "Add texture format utilities for GL and generate GL texture caps." · d16daa29

authored Apr 07, 2015

This reverts commit 69bde01a.

Change-Id: If21c22e91cf5d72364839bbcc21cb83901a3f2cd
Reviewed-on: https://chromium-review.googlesource.com/264418Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

d16daa29

Add Platform methods for event tracing. · ae2d8a3a

authored Apr 07, 2015

Event tracing requires pulling in timing counters, so we can sync
with Chromium's timestamps. It may require a bit more tricky stuff
to sync ANGLE's GPU timestamps with trace timestamps, but should
allow us to add GPU trace events in the future.

BUG=chromium:436191
BUG=angleproject:966

Change-Id: Ie1dc2981650d96888f988fa74b6fa435fbe8edc2
Reviewed-on: https://chromium-review.googlesource.com/263781Reviewed-by: Brandon Jones <bajones@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

ae2d8a3a

Implement copyImage and copySubImage in TextureGL. · fbfa47c4

authored Mar 31, 2015

BUG=angleproject:885
BUG=angleproject:884

Change-Id: I083b72059c55157e2a3ee00ec778f819a100be7b
Reviewed-on: https://chromium-review.googlesource.com/263179Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

fbfa47c4

Add texture format utilities for GL and generate GL texture caps. · 69bde01a

authored Mar 02, 2015

BUG=angleproject:884

Change-Id: Iba0108b22e6a404842ec1013d22c00d206c865d3
Reviewed-on: https://chromium-review.googlesource.com/255512Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

69bde01a

Only check dynamic type in Impl casting helpers. · 8c25cdec

authored Apr 01, 2015

We can use the Impl casting helper methods to clean up dynamic type
casting.

Change-Id: I5706da74eedd9f3cdc5a728420074a91ad7c95cb
Reviewed-on: https://chromium-review.googlesource.com/263520Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

8c25cdec

Use GetAs/GetImplAs whenever possible. · f4bf3811

authored Apr 01, 2015

This patch cleans up the rest of our custom casting helper
functions.

Change-Id: I41975c736765fca855c4498acca31116df3e8317
Reviewed-on: https://chromium-review.googlesource.com/263477Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>

f4bf3811

Don't delete sysmem storage if it is the latest storage. · c5b8b59c

authored Apr 02, 2015

BUG=angleproject:965

Change-Id: I9b4b042e3f9bde3ce713a02aa353b5f3a5cff49e
Reviewed-on: https://chromium-review.googlesource.com/263711Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Gregoire Payen de La Garanderie <Gregory.Payen@imgtec.com>

c5b8b59c

Support assigning array constructors in HLSL output · 9638c352

authored Apr 01, 2015

This adds support to the following type of shader code, where an array
constructor is used as a source of assignment:

float a[3];
a = float[3](0.0, 1.0, 2.0);

The assignment gets replaced in the HLSL code by a function call where
the array is an out parameter and the constructor parameters are regular
parameters.

Constructors cannot yet be used in initializers.

With this change in place, some of the relevant dEQP tests start passing.

TEST=dEQP-GLES3.functional.shaders.arrays.constructor.*
BUG=angleproject:941

Change-Id: I13ed603c02a30d9f9950a61c4d562ae9fac058ec
Reviewed-on: https://chromium-review.googlesource.com/263403Reviewed-by: Olli Etuaho <oetuaho@nvidia.com>
Tested-by: Olli Etuaho <oetuaho@nvidia.com>

9638c352

Add basic support for array constructors · f40319e9

authored Mar 10, 2015

Add limited support for parsing array constructors and writing them out as
GLSL code.

Still missing from this version: HLSL output, array support in
initializer lists, arrays with implicit size.

BUG=angleproject:941

Change-Id: I7febf80923c4cd0b730399f1f49f9456cf3668e9
Reviewed-on: https://chromium-review.googlesource.com/260572Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Olli Etuaho <oetuaho@nvidia.com>

f40319e9

06 Apr, 2015 1 commit

Give Timer a virtual destructor as it's deleted polymorphically. · 51a1db16

authored Apr 06, 2015

Found by clang:

..\..\third_party\angle\src\common/angleutils.h(66,5) :  error: delete called on 'Timer' that is abstract but has non-virtual destructor [-Werror,-Wdelete-non-virtual-dtor]
    delete resource;
    ^
..\..\third_party\angle\src\tests\perf_tests\ANGLEPerfTest.cpp(26,5) :  note: in instantiation of function template specialization 'SafeDelete<Timer>' requested here
    SafeDelete(mTimer);
    ^

BUG=chromium:82385

Change-Id: I69033b1802b5dffbdf2d80889aca7019d710d481
Reviewed-on: https://chromium-review.googlesource.com/264061Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

51a1db16

02 Apr, 2015 8 commits

Revert "Implement gradient operation AST analysis" · 711d8663

authored Apr 02, 2015

This reverts commit 2fc57a2a.

Change-Id: I619297090c8441c1b90099437f8764263cdd68cc
Reviewed-on: https://chromium-review.googlesource.com/263728Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

711d8663

Revert "Implement discontinuous loops AST analysis" · c457e7bb

authored Apr 02, 2015

This reverts commit f30a9ba9.

Change-Id: I577cfd1e7d5d6138413c29205cbf4d35b6861226
Reviewed-on: https://chromium-review.googlesource.com/263754Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

c457e7bb

Revert "Implemented a CallDAG to allow for more AST analysis" · 186160b2

authored Apr 02, 2015

failures in angle_unittests and compilation failure on clang (see: https://build.chromium.org/p/chromium.gpu.fyi/builders/GPU%20Mac%20Builder%20%28dbg%29/builds/30016/steps/compile/logs/stdio) .
This reverts commit b34d1d12.

Change-Id: Ia995fb2db0e891294f3461de01617cb13e5ae381
Reviewed-on: https://chromium-review.googlesource.com/263727Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

186160b2

Return a ref for FBO attachment image indexes. · 8cf4a39b

authored Apr 02, 2015

This cleans up the syntax somewhat. Also place some more of the
helper methods in the header.

BUG=angleproject:963

Change-Id: I62419095a7b65486f54d74791027594e8e595e48
Reviewed-on: https://chromium-review.googlesource.com/263629Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

8cf4a39b

Move the texture index to attachment base. · 7936a6d3

authored Apr 02, 2015

This will let us squash the attachment types in a follow-up patch.

BUG=angleproject:963

Change-Id: I1efb2e41aa08766189499995b3150aec6fd61c4e
Reviewed-on: https://chromium-review.googlesource.com/263486Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

7936a6d3

Implement discontinuous loops AST analysis · f30a9ba9

authored Mar 19, 2015

This will allow narrowing down which usages of
[[flatten]] and [[unroll]] are actually useful.

BUG=angleproject:937
BUG=395048

Change-Id: Icc37abf51a1407c9e7bc708dc08d3ba4050a496a
Reviewed-on: https://chromium-review.googlesource.com/261189Tested-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

f30a9ba9

Implement gradient operation AST analysis · 2fc57a2a

authored Mar 18, 2015

This will allow narrowing down which usages of
[[flatten]] and [[unroll]] are actually useful.

BUG=angleproject:937
BUG=395048

Change-Id: Ic31e434c7b5bb6c32eff2336e5949391bfee25a5
Reviewed-on: https://chromium-review.googlesource.com/260930Reviewed-by: Nicolas Capens <capn@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

2fc57a2a

Implemented a CallDAG to allow for more AST analysis · b34d1d12

authored Feb 11, 2015

The CallDAG preprocesses the AST to construct a DAG of
functions that can be used for several analysis.
Use it to implement check for recursion and max call
depth. It will also be used to limit the usage of
[[flatten]] and [[unroll]].

BUG=angleproject:937
BUG=395048

Change-Id: I643e0ed605ad095e4fd7da4977d842be5e6a12e0
Reviewed-on: https://chromium-review.googlesource.com/229352Reviewed-by: Nicolas Capens <capn@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

b34d1d12