Implement capturing GLES1 specific state by checking the difference to
the default state using getEnableFeature.

When getEnableFeature is called from a context version higher than 1 and
a GLES1 state is requested, an assertion is hit. Therefore the context
version needs to be determined before calling getEnableFeature.

Use the available isTextureTargetEnabled function to determine
GL_TEXTURE_2D and GL_TEXTURE_CUBE_MAP states in getEnableFeature.

Return false in isTextureTargetEnabled when mTextUnitEnables is empty,
so the vector is not accessed when not initialized, which was the case
for a default state.

Bug: angleproject:5893
Change-Id: I66ee41c3bf7a8e1f04a8a4ce0461fddc16f9a013
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2877237Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>

In CommandBufferHelper::endRenderPass(), we are checking depth stencil's
initialLayout to change storeOp to None if the layout is read only. But
the layout was set after that check, which essentially voids the
optimization.  This CL moves the finalizeDepthStencilImageLayout() call
before the layout is used.

This CL also moves the depth stencil loadOp/storeOp to a new function
finalizeDepthStencilLoadStoreOp(). When depthImage gets deleted before
renderpass ends, we could also apply the same load/store optimization
just like we did at endRenderPass() time.

Bug: b/187425444
Change-Id: I89814274352f09cbf1f7b58a91bbaf131b983fb1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2877933Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>

Bug: angleproject:5114
Change-Id: I3b7255cc06bffd177f0b5ee8cad12bf2aad3089e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2885382
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

MultithreadingTest.MultiContextClear/ES3_Vulkan_NoVirtual is flaky on
linux-clang-rel NVIDIA, so it's being suppressed for now.

Bug: angleproject:5945
Change-Id: I9ef142c57b3fcf5224732edcea1650634ecc18ca
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2887905
Commit-Queue: Tim Van Patten <timvp@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

When loading vulkan, we can be running from any directory. We need
to change to the module directory to ensure the swiftshader ICD is
loaded properly. For example, in some Chrome releases, libGLESv2.dll
and libvk_swiftshader.dll are in a subdirectory relative to chrome.exe

Bug: chromium:1198567
Change-Id: I9e68927e512b239728fb2903d1a04702508a4948
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2873452
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

These will trigger tests on the Pixel 4 in standalone. For
now we do not specify any tests.

Patch Series:

1. This CL
2. http://crrev.com/c/2885346
3. http://crrev.com/c/2885383
4. http://crrev.com/c/2885384

Bug: angleproject:5941
Change-Id: Iad1bc27c316724b244fbfbf694f6e83fdf5c0507
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2885381
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

Since an internal default shader is created and captured here in the
GLES1 case, we need to check for the context version to skip capturing
glUseProgram and emit an update call in GLES1 traces.

Bug: angleproject:5893
Change-Id: Iac9bc05234fbc87c1f64264b5c12b9b117522bad
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2877236
Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

https://chromium.googlesource.com/vulkan-deps.git/+log/d3354ebca460..055e71b2a367

Changed dependencies:
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/5ef1ec1b87..0aca21bce7

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: timvp@google.com
Change-Id: I75ea4a8ae6a21e51b274f6a1dcff80c1aa924ab7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2885449
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://swiftshader.googlesource.com/SwiftShader.git/+log/e260190edbd2..dcb33711bd4b

2021-05-10 srisser@google.com Allow unrestricted depth bounds
2021-05-10 srisser@google.com Make clang-format-all.sh git aware
2021-05-10 sugoi@google.com Reduce size of SampledImageDescriptor

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: timvp@google.com
Change-Id: I3e0bdad486c078fa765c7a4ba980c89257cdbb11
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2886667
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

Don't capture these on GLES1, due to the unavailability of
glVertexAtrrib4fv.

Bug: angleproject:5893
Change-Id: Iafbc9219cfc0a0c1d0a55e112ee88d7180ed94f7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2877235
Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

Implement CaptureVertexPointerES1 that captures specific GLES1 vertex
pointer functions depending on the attribute index.

Use GLES1 capture functions in CaptureVertexArrayData by detecting the
current context version.

Implement VertexArrayType function in GLES1Renderer to get a
ClientVertexArrayType enum from a vertex attrib index.

Bug: angleproject:5893
Change-Id: I442b2e29475ca817860388cafc120db90a0fb9c4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2846838Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>

Add third_party/android_platform and tools/python from the Chromium git
to satisfy dependencies for the build/android/tombstones.py script.

Bug: angleproject:5933
Change-Id: Ie19eec46c8cab208cde5064118ae655303e12fa7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2878848Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>

https://chromium.googlesource.com/chromium/src.git/+log/518c3462c0a9..fff9d6fb8ddf

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/9afdbde777..4ff4105cd8
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/af6ff0bdef..504fae9f10
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..1fbada9f29
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1039f6ca14..cb17bc6028
* third_party/r8: 9JovxpDv8ZqFl60_eHo4hT-Ez0CelcMCoM9Cv5UJMz4C..gXyBDv_fM87KnLcxvF5AGV5lwnm-JXIALYH8zrzdoaMC
* third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/eb9ce8c993..618ddecd59
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/dbcffda598..e76c8f17cf
* tools/luci-go: git_revision:91769f0e2541d15de294dfc780205e98b49f7431..git_revision:1b50bbe2f93441dd227ad6e6684fa9be4ab0dec2
* tools/luci-go: git_revision:91769f0e2541d15de294dfc780205e98b49f7431..git_revision:1b50bbe2f93441dd227ad6e6684fa9be4ab0dec2
* tools/luci-go: git_revision:91769f0e2541d15de294dfc780205e98b49f7431..git_revision:1b50bbe2f93441dd227ad6e6684fa9be4ab0dec2
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/d9766067a3..df10bb0bf8
* tools/skia_goldctl/linux: UV02xIZDvNaCcrummY2Hd5zNO4S7F3pl_ZatqFmeRboC..EWfIod1MP71b48GlHnS5Rv9JpBzeTRQ6viIPDfFUSFEC
* tools/skia_goldctl/mac: aG3drSoyskf8FOxdSDXo_p3ub85yK9mX_DmXJa605cUC..5o7ziB6qRrSdtYJwKop8-5OFmvVQcxuNkGY1DRYggMsC
* tools/skia_goldctl/win: OB_O_MOYSLYScAVrzlIsc9a0JIf54AiYzG1WNNSCtyIC..O2WsBEJgyjTsib6LvzoNqqXwfSylJFfTRxEKYr-IsocC
No update to Clang.

Bug: None
Tbr: timvp@google.com
Change-Id: I70f2c157f5165905a9d3aca98dfccb7768b87d0e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2885448
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

As suggested by Jamie

Bug: angleproject:5849
Change-Id: I3e548935a9119b7ca7ca392c50bcb0f58ae3e974
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2882578
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Skip the the test TransformFeedbackTest::EndWithDifferentProgram() on
Vulkan + Pixel 2 since it appears to be flaky.

Test: TransformFeedbackTest::EndWithDifferentProgram()
Bug: chromium:1207380
Change-Id: Iedfe1e96a204eca5954097be9e61820b775eb0b0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2886358Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

This will allow us to load ANGLE libraries without needing
LD_LIBRARY_PATH.

Bug: None
Change-Id: Iaa389b3a42fed37216e175bee080a9f8fde3eb0b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2884418
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

This target doesn't exist in Skia.

Bug: angleproject:5940
Change-Id: I0095b771c0d57ec45bfd9294962c540d70679e6a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2884700Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Similar to --max-steps-performed, don't do any calibration and
just run flat out for a fixed amount of time.

Also rename --test-time to --max-trial-time to reflect what the
parameter actually does, limiting each trial to a ceiling.

Also remove a redundant check in doRunLoop.

Test: angle_perftests --fixed-test-time 20
Test: angle_perftests --max-trial-time 2
Bug: angleproject:5935
Change-Id: I854799a734cd6c019399f5a1444b4ef5f659ddf4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2878937Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

In order to hide the status bar and hopefully prevent any layers from
rendering on top of our traces, make all Android tests run fullscreen.

Test: angle_perftests
Bug: angleproject:5937
Change-Id: I649104a7d95b7f056b411e180632524a85b7c4f2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2880335Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

A new AST validation is added to ensure that the same TStructure or
TInterfaceBlock is not redundantly defined.  This helps with SPIR-V
generation by allowing the id to be used as key in a hash map that looks
up the corresponding SPIR-V type id.

A bug is fixed where the Vulkan driver uniform declaration created two
identical declarations for ANGLEDepthRangeParams.

A number of other bugs are also fixed in this change, where if a
variable declaration is eliminated (for example due to constant folding,
or inactive interface variable removal) and it contained a struct
specifier, the struct declaration was also removed.  OutputGLSLBase had
a hack where structs were declared on first encounter, which was
incorrect as the scope of the declaration could change.  Those bugs are
fixed and this hack is removed.

Bug: angleproject:2733
Bug: angleproject:4889
Bug: angleproject:5936
Change-Id: I8e13748c0bf552ae8b052249282769a1f0775603
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2881942Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

When finding a compatible memory index for an external buffer,
we need to have a fallback path that requires just the
VK_MEMORY_PROPERTY_DEVICE_LOCAL_BIT property.

Bug: angleproject:5909
Change-Id: Id3faffb3e357be2e5e6f5fce9e64f0f2889d199a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2862561Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>

The Settings GUI is being removed from the AOSP build to turn the ANGLE
APK into essentially a container APK containing the necessary libraries.
This reduces the APK size and reduces the risk of users enabling ANGLE
by accident.

Additionally, ANGLE is being marked product-specific to remove it from
all AOSP builds.

Bug: b/187345862
Change-Id: I6e1acb9c6e07b419d40aee43d7260060027999ec
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2876213Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>

Removes duplicate Linux, Win and Mac testing.
These are superceded by the standalone bots now.
Android is still entirely Chromium-based.

Bug: angleproject:5114
Change-Id: I745758547b2eaa5f82779b11e7f3a8512c3cdd94
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2872072Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

https://swiftshader.googlesource.com/SwiftShader.git/+log/e839645bb9a6..e260190edbd2

2021-05-07 sugoi@google.com Obtain all sampler parameters through SamplingRoutineCache::Key
2021-05-06 swiftshader.regress@gmail.com Regres: Update test lists @ 04c037ac

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ianelliott@google.com
Change-Id: I4d1a116358713f00ebd92d78ddb62e0a7b47baf6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2883237
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/vulkan-deps.git/+log/13d25088cdc6..d3354ebca460

Changed dependencies:
* glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/41e39c615b..9431c53c84
* spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/72a2ec4c1b..418542eaef
* vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/3f437c4a94..9af411e83f
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/157c4bfe15..5ef1ec1b87

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ianelliott@google.com
Change-Id: I1d9cf668527a0d1e7f31ab2e212bebcd42fbcbeb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2883081
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/chromium/src.git/+log/5f1f8ce65c68..518c3462c0a9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/7ca66f4b1c..9afdbde777
* buildtools/linux64: git_revision:7b23bd91f996722e5e55e0ccf0c80c0a984efca5..git_revision:39a87c0b36310bdf06b692c098f199a0d97fc810
* buildtools/mac: git_revision:7b23bd91f996722e5e55e0ccf0c80c0a984efca5..git_revision:39a87c0b36310bdf06b692c098f199a0d97fc810
* buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/5f51521620..767de317f9
* buildtools/win: git_revision:7b23bd91f996722e5e55e0ccf0c80c0a984efca5..git_revision:39a87c0b36310bdf06b692c098f199a0d97fc810
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/ce51767483..af6ff0bdef
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..98fd7ff368
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/360f981956..1039f6ca14
* tools/luci-go: git_revision:fa78eb7ab25ca5d574c0741c8c1a02d6fd7ed66d..git_revision:91769f0e2541d15de294dfc780205e98b49f7431
* tools/luci-go: git_revision:fa78eb7ab25ca5d574c0741c8c1a02d6fd7ed66d..git_revision:91769f0e2541d15de294dfc780205e98b49f7431
* tools/luci-go: git_revision:fa78eb7ab25ca5d574c0741c8c1a02d6fd7ed66d..git_revision:91769f0e2541d15de294dfc780205e98b49f7431
No update to Clang.

Bug: None
Tbr: ianelliott@google.com
Change-Id: I3d7b01d99898b9a087e62d4ec65a21837a7cb9cb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2882480
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

Delete Textures, Renderbuffers and Framebuffers that were created in the
SurfaceType::Offscreen case, when they were initialized.

This caused a crash when replaying traces using GLES 1 contexts
on native GLES Android implementations.

Bug: angleproject:5932
Change-Id: Ice4bcec620a6c3530044986ce39230b030a901ab
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2877234Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

Add failing OpenGL ES 1.0 capture / replay tests to expectations list.
The remainging 65 test pass on ES1 SwiftShader.

Test: python3 src/tests/capture_replay_tests.py --gtest_filter="*/ES1_Vulkan_SwiftShader"
Bug: angleproject:5751
Change-Id: If5157a3ac0ccebc904316ae08c54e670119384e4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2877233Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

Add a vertex buffer example for GLES1 and 2.

Bug: angleproject:5751
Change-Id: If039451ff85dfffd8915497e9aaaab6e4ff71181
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2859827
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Bug: angleproject:4932
Change-Id: Ie210a9dd342581adb71af4782383be2bb3ffd6a3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2880667Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

CaptureVertexPointerGLES1 was expecting only client-side vertex arrays
and not checking whether a vertex buffer was bound. This patch fixes
offsets in vertex buffers for GLES1, which can be seen in apps like
Dr. Driving.
The mClientVertexArrayMap index is now retrieved by entrypoint name, as
the arrayClientPointerIndex is unset in the vertex buffer case.

Bug: angleproject:5751
Change-Id: If40cae56bcdbed57885e83c49291cb000a884b0e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2859826Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

There is no such thing as image2DRect in GLSL.  imageRect (the right
type) is present, but the code was mistakenly using image2DRect.

Bug: angleproject:4889
Change-Id: I42bacd2ad8866c715af0d9711bebc95897607354
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2878095Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

- Fallbacks for formats that have required vertex attribute support are
  removed.
- Fallbacks are changed to ones with smaller sizes
- A bug is fixed where CopyNativeVertexData wasn't initializing the
  alpha channel appropriately, which was not exercised due to fallback
  to 32-bit float formats.

Bug: b/184163871
Change-Id: Icd9afa49d94c65545d1f3fcf521881726d64529d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2809441Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

Currently, no ANGLE platform flag is enabled for Lacros Chrome.
GL is selected as default by this change for ChromeOS in general.

Based on change by Eriko Kurimoto <elkurin@chromium.org>

Bug: chromium:1203176
Change-Id: I539a459b6d3db60da191570e933afd8d06d3c3eb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2877010Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

https://chromium.googlesource.com/chromium/src.git/+log/f4228a4b663d..5f1f8ce65c68

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC ianelliott@google.com,ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/a5d4757ed0..7ca66f4b1c
* buildtools/linux64: git_revision:6771ce569fb4803dad7a427aa2e2c23e960b917e..git_revision:7b23bd91f996722e5e55e0ccf0c80c0a984efca5
* buildtools/mac: git_revision:6771ce569fb4803dad7a427aa2e2c23e960b917e..git_revision:7b23bd91f996722e5e55e0ccf0c80c0a984efca5
* buildtools/win: git_revision:6771ce569fb4803dad7a427aa2e2c23e960b917e..git_revision:7b23bd91f996722e5e55e0ccf0c80c0a984efca5
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/7359f2c06d..ce51767483
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..c92267a4b7
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5009fd68ac..360f981956
* third_party/libjpeg_turbo: https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git/+log/24e310554f..b7bef8c05b
* tools/luci-go: git_revision:1b257aacd4934e5a8b2508b240ffc7d866df9273..git_revision:fa78eb7ab25ca5d574c0741c8c1a02d6fd7ed66d
* tools/luci-go: git_revision:1b257aacd4934e5a8b2508b240ffc7d866df9273..git_revision:fa78eb7ab25ca5d574c0741c8c1a02d6fd7ed66d
* tools/luci-go: git_revision:1b257aacd4934e5a8b2508b240ffc7d866df9273..git_revision:fa78eb7ab25ca5d574c0741c8c1a02d6fd7ed66d
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/9c6e20569c..d9766067a3
* tools/skia_goldctl/linux: qFSgTPN6Qn1vdxIOe4gDnS7rsfvJpQ63e0fEOHdwwK8C..UV02xIZDvNaCcrummY2Hd5zNO4S7F3pl_ZatqFmeRboC
* tools/skia_goldctl/mac: wEpZZg5Ap8EImS0KyVLAaILjjArMqHjI4T4y2MKKd5MC..aG3drSoyskf8FOxdSDXo_p3ub85yK9mX_DmXJa605cUC
* tools/skia_goldctl/win: kT3OqAqb0i8bSfls2rf77GfIiw0YSfqm97knAwMxkCcC..OB_O_MOYSLYScAVrzlIsc9a0JIf54AiYzG1WNNSCtyIC
No update to Clang.

Bug: None
Tbr: ianelliott@google.com,ynovikov@google.com
Change-Id: I0ec0452805b7872f52ca997bb83f4ca8adcbc739
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2878570
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

When importing external buffers, Vulkan ICDs could choose to
import the memory into a memoryType that doesn't support the
VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT property. Account for this
possibility.

Bug: angleproject:5073
Bug: angleproject:5909
Change-Id: Ied063b38fa48d0c8508c4aaca9214cc526f393ad
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2783669
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Changes since the revert:

 - Include runtime_deps: http://crrev.com/c/2878093
 - Add missing perf scripts: http://crrev.com/c/2877011
 - Include build_properties: http://crrev.com/c/2878373

Bug: angleproject:5114
Change-Id: If7d1e5693c4ade72d3f45f5d60635cb27de7599e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2877012Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Removed redundant OpenCL ICD library, using regular OpenCL library
instead.

Bug: angleproject:5908
Change-Id: I1ecf5347557106511aed3c5c4a4bfa35590a559a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2877240Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: John Plate <jplate@google.com>

Capture glLight, glLightModel and glMaterial and adjust size by enum.

Bug: angleproject:5751
Change-Id: I2fcf35575e344703033bf426c3ed0046dfe93337
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2859825Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

When user specifies GL_MAP_PERSISTENT_BIT_EXT bit for an external
buffer but we are unable to import it into a memoryType that supports
host visibility, error out with GL_INVALID_OPERATION error.

Bug: angleproject:5073
Bug: angleproject:5909
Change-Id: I03e5477266dfb705bfb0a1bce5ca003049ef4c7a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2862560
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>