sampler2DRect was placed under ESSL while sampler2DArrayShadow was
placed under desktop GLSL.  They are swapped.

Bug: angleproject:3569
Change-Id: Ibf39868d4cd702d9d1da7fc286171bb70b80d6df
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1975430Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

GetLocationCount() is currently returning the number of rows in the
matrix, rather than the columns, which leads to shader validation
errors (and test failures).   This fix returns the number of columns
in a matrix.

Bug: angleproject:4200
Test: dEQP-GLES31.functional.separate_shader.random.63
Change-Id: I8d25eb3733c2ddbe53ff54794f480c1d43e22a88
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1952173Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>

Bug: angleproject:4099
Bug: angleproject:4100
Bug: angleproject:4102
Change-Id: I975485baea3ff6ec8247cbb5c92efdb907974ebc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1974271Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>

Bug: angleproject:4147
Change-Id: I4ace1221d32631cdb14a95c71ee9a1617837a5ea
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1970495Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tobin Ehlis <tobine@google.com>
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>

WEBGL_video_texture is an extension that will improve uploading video frame to WebGL performance.
(https://www.khronos.org/registry/webgl/extensions/proposals/WEBGL_video_texture/)

This extension introduced a new texture type TEXTURE_VIDEO_IMAGE_WEBGL and a new sampler type
samplerVideoWEBGL to sample it.

In chromium implementation, TEXTURE_VIDEO_IMAGE_WEBGL maps to different native texture type
based on platform. On desktop, it maps to GL_TEXTURE2D(Currently supported). On Android, it
should map to GL_TEXTURE_EXTERNAL(TODO). SamplerVideoWEBGL needs to be mapped to sampler2D or
samplerExternalOES according to TEXTURE_VIDEO_IMAGE_WEBGL implementation.

This patch implements samplerVideoWEBGL in Angle to support WEBGL_video_texture on desktop. In
this case, samplerVideoWEBGL should map to sampler2D.

Bug: chromium:776222, angleproject:3889
Change-Id: Idb0a5fcde37ca75ccc1181226b91f257212e7500
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1866274
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

https://swiftshader.googlesource.com/SwiftShader.git/+log/fbbfeb700295..21be09d8e699

git log fbbfeb700295..21be09d8e699 --date=short --first-parent --format='%ad %ae %s'
2019-12-18 sugoi@google.com Enable samplerAnisotropy
2019-12-18 chrisforbes@google.com Advertise variableMultisampleRate feature
2019-12-17 bclayton@google.com clang-format the src/WSI directory
2019-12-17 bclayton@google.com clang-format the src/Vulkan directory
2019-12-17 bclayton@google.com clang-format the src/System directory
2019-12-17 bclayton@google.com clang-format the src/Reactor directory
2019-12-17 bclayton@google.com clang-format the src/Pipeline directory
2019-12-17 bclayton@google.com clang-format the src/Device directory
2019-12-17 bclayton@google.com Start a custom .clang-format rule
2019-12-17 capn@google.com Remove spaces after control statements keywords
2019-12-17 sugoi@google.com Enable blending for 32FP formats
2019-12-17 capn@google.com Make use of vec<T, N> vector broadcasts
2019-12-17 capn@google.com Replace vector() and replicate() with float4 constructors
2019-12-17 capn@google.com Create a generic vec<T, N> class
2019-12-17 capn@google.com Typedef int4/float4 from a vec4<T> template
2019-12-17 capn@google.com Prefer alignas() over ALIGN()
2019-12-17 sugoi@google.com R11G11B10F support

Created with:
  gclient setdep -r third_party/SwiftShader@21be09d8e699

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: jmadill@google.com
Change-Id: Iff5532b2838a657d66fc51751fd95036d35f3f30
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1973467Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/0c2618b2c31e..9c5719ab7149

git log 0c2618b2c31e..9c5719ab7149 --date=short --first-parent --format='%ad %ae %s'
2019-12-17 charles@lunarg.com vulkaninfo: safely handle device groups not supported

Created with:
  gclient setdep -r third_party/vulkan-tools/src@9c5719ab7149

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-tools-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: jmadill@google.com
Change-Id: Idca41eac95939e072b5e9317ffbfbcce57646ff6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1973466Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

Use latest Khronos gl.xml file and re-sort format
enums that angle had already added to this file

Bug: angleproject:4093
Change-Id: Ic5c1abc2a79fec14f3c53856a429c9b2489e3275
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1972199
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Bug: angleproject:4101
Bug: angleproject:4105
Change-Id: Ida462f69660a55e13b48ebea22ffc2a6b6bfe867
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1972202Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>

The ANGLE_ENABLE_VULKAN_VALIDATION_LAYERS_BY_DEFAULT define shouldn't
be being checked in tests. Enable the debug layers by default.

Bug: angleproject:4227
Bug: angleproject:4229
Change-Id: I9717cb1c611ebd585a5c03ba2057036e1b086001
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1972497
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>

This makes the code more consistent and allows for the Query
constructor to generate a Serial.

Bug: angleproject:4223
Change-Id: I6cc683b11ed364f13d303f97aa0984e63260953e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1969061Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Move libvulkan to a data_dep as we no longer statically
link it.

Bug: angleproject:4225
Change-Id: I96458d4727d2d47d8c259ec51d91fd852067c059
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1972192
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

This will let the front-end access them without pulling in the rest
of renderer_utils. The Serial class in particular will be useful for
capture/replay.

Also adds a very minimal unit test.

Bug: angleproject:4223
Change-Id: I9e63b8a8227a245b20a8f024b960fcf60c7840db
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1954611
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

Makes them consistent with the rest of the code. Will allow
the Sync class to call methods in GLImplFactory to generate
a resource Serial.

Also updates the unit test to the new design.

Bug: angleproject:4223
Change-Id: Ic5ba69c3a6a51d4b51d876c3b5e7eb7bc44a9ae8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1969060
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

The change introduced in
https://chromium-review.googlesource.com/c/angle/angle/+/1951523
removes inactive shader interface declarations.  That automatically
resolves an issue where glslang wrapper doesn't handle inactive SSBO
declarations with unsized arrays, by removing those declarations at
translation time altogether.

Bug: angleproject:3714
Change-Id: I710d59546d716bfb5bc0112b5152fed20a810a52
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1954615
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Disabling SwiftShader in the GN build led to a compile error
when trying to use ANGLE_VK_SWIFTSHADER_ICD_JSON.

Bug: angleproject:4223
Change-Id: I076a88e6bc58adf1e34bbb7286b1f46028cd021a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1969059
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

This change includes preparatory work for textureGatherOffsets as well,
though that requires special handling which is addressed in a follow-up
change.  This special handling is due to the fact that this family of
functions is the only built-in with an array parameter, and our built-in
table generation doesn't handle it correctly.

Bug: angleproject:3569
Change-Id: Ic1c8dd03878a184be00f578ab9fc42af8f6e47ea
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1965435Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jiajia Qin <jiajia.qin@intel.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

Specifying the project name is now mandatory.  This helps avoid
accidentally referring to chromium bugs by forgetting the project name.
At the same time, it ensures the project name is not misspelled.

Bug: angleproject:4184
Change-Id: I6bbfe1751e2fd0baf424be38018374cce360df5d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1969067Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

The translator emulates atomic counters with a storage buffer array
during translation to Vulkan GLSL.  Glslang wrapper then should assign
set/binding to this buffer.  However, if the atomic counters are
actually unused in the shader, this assignment is never done.

This change adds a small tree transformation for Vulkan that removes any
uniform or interface block declaration that's not active.  In
particular, this makes atomic counter emulation a no-op if no atomic
counters are used.  It also has the benefit of not requiring glslang
wrapper to remove such inactive resources.

Bug: angleproject:4190
Change-Id: I286c199854ec2379558ad1ec48b4d2c4bf5544d0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1951523
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/96354f5047bf..38d7fbaad0a3


Created with:
  gclient setdep -r third_party/spirv-tools/src@38d7fbaad0a3

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: jmadill@google.com
Change-Id: I81d302d7aaf865489f50fa722791efdb5fbb6a05
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1971254Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

Re-land #2 changes:

 * export labels are fixed for the CFI build
 * crash test disabled because of flakiness and issues with asan

Re-land changes:

 * Unit test is suppressed in ASAN
 * --deqp-case is fixed
 * Debug layer errors should correctly work with failure expectations

Original message:

The ANGLE test harness is a harness around GoogleTest that provides
functionality similar to the Chromium test harness. It supports:

 * splitting a test set into shards
 * catching and reporting crashes and timeouts
 * outputting to the Chromium JSON test results format
 * multi-process execution

Unit tests are added in test_utils_unittest.cpp.

Bug: angleproject:3162
Bug: chromium:1030192
Change-Id: I71d66a407ea0e53d73cbe75b5b4bfb9e73791534
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1965091
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>

Add a whitebox test to log all supported GLES formats
for the active Vulkan ICD. The test object is
dependent on libANGLE's gl_enum_util.* files as
we need it to print out human readable values in
the PrintAllFormatSupport test.

Test: angle_white_box_tests --gtest_filter=*PrintAllSupportedFormats*
Bug: angleproject:4093
Change-Id: I99d74935b705b2984f6320ed80a0e977c8fcd4be
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1930607
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

This source set target lets other targets import the test utils without
needing to export them. They get built into angle_util. They also get
compiled into the various tests and samples. The change also fixes
export issues.

Moves some of the GN logic into the util/ subfolder.

Bug: angleproject:3162
Bug: chromium:1030192
Change-Id: If99d201092ad8541c0de60b3bd893ac9b5875270
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1968259Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Bug: angleproject:4093
Change-Id: I979b54e12c1e897ccfa116f332bf9146dcd00cae
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1965644
Commit-Queue: Brandon Schade <b.schade@samsung.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

We were hitting onImageStateChange with no texture active and hitting
the assert in that function for needing a texture.
There are times when we call onImageStateChange where there is no
texture bound, early exit in those cases.

Test:
  angle_deqp_khr_gles31_tests --user-angle=swiftshader --gtest_filter=dEQP.KHR_GLES31/core_layout_binding_image2D_layout_binding_imageLoad_*
  also:
  --gtest_filter=dEQP.KHR_GLES31/core_layout_binding_atomic_uint_layout_binding_atomic_ComputeShader
  --gtest_filter=dEQP.KHR_GLES31/core_layout_binding_buffer_layout_binding_atomicAdd_ComputeShader
  --gtest_filter=dEQP.KHR_GLES31/core_layout_binding_block_layout_binding_block_ComputeShader
  --gtest_filter=dEQP.KHR_GLES31/core_layout_binding_sampler2D_layout_binding_texture_ComputeShader

Bug: angleproject:4124
Change-Id: I027cf4ecb6a5d6aea874c306bf3e67b95a75af62
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1965027
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

Thanks to Jamie Madill for some fixes to get all CI test passing w/ volk.

This change updates all ANGLE targets that use Vulkan to dyanmically
link all of the VK entrypoints using the volk OSS library from
https://github.com/zeux/volk.

It's only two source files so baking them directly into ANGLE repo.
Also it's used in both the tests and libANGLE trees so added to
src/common/third_party/volk dir.

Updated volk and the renderer to track latest instance and device
that were loaded and renderer will refresh vk* function pointers if
the current and previous device and/or instance don't match. This
prevents errors in the test framework as we transition between
backends, especially between VK HW & SwiftShader ICDs.

This change rolls the Vulkan Loader forward to use the latest loader
version which no longer allows static linking but requires dynamic
linking.

Bug: angleproject:3740
Bug: angleproject:4092
Bug: angleproject:4162
Bug: angleproject:4210
Bug: angleproject:4225
Change-Id: I8a0b7d24c9545bbfdfaa4b9357a9bfe6793e0140
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1965640
Commit-Queue: Tobin Ehlis <tobine@google.com>
Reviewed-by: Tobin Ehlis <tobine@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Bug: angleproject:4093
Change-Id: Ib69f0553f79d0e5dfbcc9165ad71a42be3e6d55d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1965643
Commit-Queue: Brandon Schade <b.schade@samsung.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

Also cleanup shader storage blocks.

Test: angle_deqp_khr_gles31_tests --use-angle=swiftshader --gtest_filter=dEQP.KHR_GLES31/core_explicit_uniform_location_uniform*

Bug: angleproject:4132
Bug: angleproject:4217
Change-Id: Ie0375ab9226f3f49cb0c0d208ac08f99d98dad8d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1963139Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>

https://swiftshader.googlesource.com/SwiftShader.git/+log/ebb0bec91552..fbbfeb700295

git log ebb0bec91552..fbbfeb700295 --date=short --first-parent --format='%ad %ae %s'
2019-12-13 chrisforbes@google.com Add missing source file to android build
2019-12-13 swiftshader.regress@gmail.com Regres: Update test lists @ ebb0bec9

Created with:
  gclient setdep -r third_party/SwiftShader@fbbfeb700295

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC ianelliot@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: ianelliot@google.com
Change-Id: I93e47bb372477b074173951ded4f0af35269e206
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1969219Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/c1a7421f0f93..0c2618b2c31e

git log c1a7421f0f93..0c2618b2c31e --date=short --first-parent --format='%ad %ae %s'
2019-12-13 jeremyk@lunarg.com build: Update glslang version in known_good.json

Created with:
  gclient setdep -r third_party/vulkan-tools/src@0c2618b2c31e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-tools-angle-autoroll
Please CC ianelliot@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: ianelliot@google.com
Change-Id: Iaddfe799d5fb0e3e444eea4cc3cf4a3852be7f1c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1969218Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/d2c3daeb56e9..2b19f3916726

git log d2c3daeb56e9..2b19f3916726 --date=short --first-parent --format='%ad %ae %s'
2019-12-13 mark@lunarg.com tests: Add tests for DescTemplates fixes and new VUIDs
2019-12-13 mark@lunarg.com objlifetimes: Fix CreateDescUpdateTemplates object val
2019-12-13 mark@lunarg.com build: Update glslang & VulkanTools known-good IDs
2019-12-13 geecandrey@gmail.com corechecks: Invalid error message in vkCmdPipelineBarrier
2019-12-13 mark@lunarg.com tests: Add positive test for tooling ext query
2019-12-13 mark@lunarg.com chassis: Support tooling queries in khronos layer
2019-12-13 mark@lunarg.com chassis: Add physicaldevice support for tools info API
2019-12-13 mark@lunarg.com stateless: Update for new struct_type_array case
2019-12-13 mark@lunarg.com chassis: Implement GetPhysicalDeviceProcAddr layer func
2019-12-13 jeremyk@lunarg.com layers: Fix issue 1416

Created with:
  gclient setdep -r third_party/vulkan-validation-layers/src@2b19f3916726

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC ianelliot@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: ianelliot@google.com
Change-Id: Idadb73efcc3bdf73f0dfd41d4f1793eb93e3b0b1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1969220Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

Also added Depth32 & Depth16 texture data upload tests.

Bug: angleproject:2634
Change-Id: I103f1cda1dc915f0dc8b04f7aaa2d8c0f9220cda
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1919281
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Per standard glDisable(GL_DEPTH_TEST) will disable depth write
also regardless of the value of glDepthMask()

Tests done:
- dEQP.GLES2/functional_fragment_ops_depth_stencil_stencil_*_no_depth

Bug: angleproject:2634
Change-Id: I3b101b8c0b3060f5ddbb18d3f97d7d6889cdec01
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1966184
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Previously spirv-cross had problems translate mat2 to equivalent
Metal type. See the reported issue:
https://github.com/KhronosGroup/SPIRV-Cross/issues/1200

It has been fixed on upstream repo.
DEQP tests using mat2 should pass now.

Bug: angleproject:2634
Change-Id: I68e871965c7004ae34dc0fa92c926905cb0c14cf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1966183
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Since semaphore has been supported, the code for changing
external texture layout and queue family is not necessary
anymore. So remove them.

Bug: angleproject:3289
Change-Id: I5470fa4bf7db7ee4c68f157674cf907a8e455d75
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1964655
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Michael Spang <spang@chromium.org>

The SDK has renamed some targets, so update to the new names.

Bug: chromium:1033597
Change-Id: Id346f5fb0094e4b71f8ec3b8c302eaa362529c06
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1967958
Commit-Queue: Michael Spang <spang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Instead of multiple ifs that test for various combination of shader
stages and calling AssignVaryingLocations for the appropriate pairs,
that function loops over all stages and assigns a location to the
varying in any stage it is active.

This change will help keep this code simpler with the introduction of
tessellation shaders.

Bug: angleproject:3571
Change-Id: Iaf3ee67990bd219080314237b314bd2770a43085
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1961096Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

This is in preparation of textureGatherOffsets support.

Bug: angleproject:3569
Change-Id: I4ce5a1e102790181c8f843735961b9c249a69221
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1965720Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

Currently, when assigning varying locations, we assign in/out qualifiers
based on whether the varying name is present between different shader
stages.

This is broken for separate shader objects as there is possibly no pair
of shaders to be able to tell which is input and which is output (by
trying to find the same varying in a stage before or after the shader).

Bug: angleproject:3571
Change-Id: Id928a3eaa16e917c81bae0b3414c41842eb2b664
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1961993
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

Also adds compiler tests for dynamic indexing of SSBOs and images.

Bug: angleproject:3569
Change-Id: I84b90813840ffad5a9a3cd8e7f12bd637a57b327
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1961095Reviewed-by: Jiajia Qin <jiajia.qin@intel.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>