- 12 Mar, 2021 8 commits
-
-
Yuly Novikov authored
mac-angle-chromium-try + mac-angle-try replace mac-angle-rel, adding dEQP testing on top of it Bug: angleproject:4483 Change-Id: I477b3ef884e4e92c9ab11a55d7a8a3f4f4e0c02b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2753491Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
Jason Macnak authored
When running Android on certain GPUs, there are problems creating Vulkan image siblings of AHardwareBuffers because it's currently assumed that the underlying driver can create linear tiling images that have input attachment usage, which isn't supported on NVIDIA for example, resulting in failure to create the image siblings. Yet, we don't currently take advantage of linear elsewhere in ANGLE. To maintain maximum compatibility on Android for such drivers, use optimal tiling for image siblings. Note that while we have switched to optimal unconditionally in this path versus linear, it's possible that previously compatible linear usages might become uncompatible after switching to optimal. However, from what we've seen on NVIDIA/AMD/Intel/Samsung GPUs so far, formats generally have more possible usages in optimal tiling versus linear tiling: http://vulkan.gpuinfo.org/displayreport.php?id=10804#formats_linear http://vulkan.gpuinfo.org/displayreport.php?id=10804#formats_optimal http://vulkan.gpuinfo.org/displayreport.php?id=10807#formats_linear http://vulkan.gpuinfo.org/displayreport.php?id=10807#formats_optimal http://vulkan.gpuinfo.org/displayreport.php?id=10809#formats_linear http://vulkan.gpuinfo.org/displayreport.php?id=10809#formats_optimal http://vulkan.gpuinfo.org/displayreport.php?id=10787#formats_linear http://vulkan.gpuinfo.org/displayreport.php?id=10787#formats_optimal Also, as an aside, in terms of what's generally expected from the Vulkan ICD in Android when determining AHB compatibility, if the vendor wants to declare a particular combinatino of format/tiling/usage/etc as not supported AHB-wise, it's up to the ICD vendor to zero out bits in supportedHandleTypes in the vkGetPhysicalDeviceImageFormatProperties2 query: ``` * [VUID-VkImageCreateInfo-pNext-00990](https://www.khronos.org/registry/vulkan/specs/1.2-extensions/html/vkspec.html#VUID-VkImageCreateInfo-pNext-00990) If the pNext chain includes a VkExternalMemoryImageCreateInfo structure, its handleTypes member must only contain bits that are also in VkExternalImageFormatProperties::externalMemoryProperties.compatibleHandleTypes, as returned by vkGetPhysicalDeviceImageFormatProperties2 with format, imageType, tiling, usage, and flags equal to those in this structure, and with a VkPhysicalDeviceExternalImageFormatInfo structure included in the pNext chain, with a handleType equal to any one of the handle types specified in VkExternalMemoryImageCreateInfo::handleTypes ``` Bug: angleproject:5709 Change-Id: I67b65ab830505a9df4665ccea8e2ba1ca409e0b5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2729243Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Lingfeng Yang <lfy@google.com>
-
Jeff Vigil authored
Implementation of EGL_IMG_context_priority was missing attribute check in ValidateQueryContext Add test case. Test: angle_end2end_test --gtest_filter=EGLCreateContextAttribsTest Bug: angleproject:5746 Change-Id: Idf5df29fcb343d969a031675b6c5985a9be0a705 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2752891 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
angle-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/a2fe8e1b2111..3c4fd15fb075 2021-03-11 capn@google.com Implement timestamp query support 2021-03-11 srisser@google.com Expose Vulkan 1.2 support If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: Ib6b2cce9056177b7b490d650c3344351a010d3d5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2756348 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/vulkan-deps.git/+log/a4e10bfde719..ea8c29e1ee20 Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/77eb2b608e..5d8c40399e * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/be60dd27b1..f648a59e1c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: Ic58ad0ced49c9ba102605bd14d24dd5466d2ed4d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2756088 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/chromium/src.git/+log/9e42f9e4abc6..e90a7a4d378a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/cb067b2df4..8b3a30a92c * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/368c7dd2c9..69cc9b8a3a * buildtools/linux64: git_revision:dfcbc6fed0a8352696f92d67ccad54048ad182b3..git_revision:e0358b49272c8b354eda0a595e1d7887343fab27 * buildtools/mac: git_revision:dfcbc6fed0a8352696f92d67ccad54048ad182b3..git_revision:e0358b49272c8b354eda0a595e1d7887343fab27 * buildtools/win: git_revision:dfcbc6fed0a8352696f92d67ccad54048ad182b3..git_revision:e0358b49272c8b354eda0a595e1d7887343fab27 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/32c9b4b55a..09e6844f48 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..cf138ce6bf * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/348acca950..09490503d0 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/e65f1a7cc3..e645571320 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/4bd62b06a2..3164db0bf1 * tools/skia_goldctl/linux: X8zqgmHchz43Cvw6xwn3VRL5keLdpA3cD_DqweHLRqMC..B61Q7uQOsOlRtaowXXUUrD_eSjWCpiKEcrtjT3VFg-cC * tools/skia_goldctl/mac: 9B5ePukmYbotGUjJuMV-DdjKGW5K0MtKrz8eOpXftu8C..RY1cs6o9Gi3j3iBE9XxPDZcR1n4Xvo27QvF_F3wL2r4C * tools/skia_goldctl/win: tC_p4_R9hLfNMczJQbjawF5kzgXRVNF-XVcN7bJxrEYC..j4rOmbVNLoVaUWWPvzH9y8NIrbGae5OxIInpCD89q0QC No update to Clang. Bug: None Tbr: ianelliott@google.com Change-Id: I740c584e817bf2208aaf3f70211e101d8aa6f826 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2756087 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
Cody Northrop authored
Test: angle_perftests --gtest_filter="*plants_vs_zombies_2*" TBR: jmadill@google.com,timvp@google.com Bug: b/182512556 Bug: angleproject:5749 Change-Id: Ib6c279f49ac95964f34e430d311a49600928166b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2752898Reviewed-by:
Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
-
James Darpinian authored
This reverts commit e44595f2. Reason for revert: build/mac_toolchain.py still fails with my local Python 3.9. Let's not make this change until the top level Chromium DEPS file does. Original change's description: > Update DEP actions for Python 3 > > build/mac_toolchain.py was fixed for Python 3 in > https://crrev.com/c/2727724 > > Bug: angleproject:5707 > Change-Id: I2f233157bedc3cc298250b8efc9bd68ac45cdc28 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2731707 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Jamie Madill <jmadill@chromium.org> Bug: angleproject:5707 Change-Id: Ib955a6343d886d273d7e949815fba5366b169386 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2753335 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: James Darpinian <jdarpinian@chromium.org>
-
- 11 Mar, 2021 16 commits
-
-
Cody Northrop authored
Test: angle_perftests --gtest_filter="*lineage_m*" TBR: jmadill@google.com,timvp@google.com Bug: b/182491024 Bug: angleproject:5748 Change-Id: I901b68eef1ddac98ce6e1a4640e2b034d1027a45 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2752894Reviewed-by:
Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
-
Shahbaz Youssefi authored
The translator outputs intermediate shaders for Vulkan that are later to be modified by the SPIR-V transformer. glslang has no business trying to link them. Bug: angleproject:5740 Change-Id: I9ae418f54b91312b5fd0ef794acbc46a40261a0e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2753096 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Ian Elliott <ianelliott@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
Cody Northrop authored
Test: Genshin Impact MEC Bug: b/182307835 Bug: b/181794064 Change-Id: Iedaecb6aa7ab7af189534f620549727f60b69ee8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2746657Reviewed-by:
Tim Van Patten <timvp@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
-
Ian Elliott authored
MultithreadingTest.MultiContextDrawWithSwapBuffers/ES3_Vulkan_SwiftShader_NoVirtual Bug: angleproject:5099 Change-Id: I12ab4a6fb7fff8d6bc7358e6017cb10e46362b88 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2752893Reviewed-by:
Ian Elliott <ianelliott@google.com> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Ian Elliott <ianelliott@google.com>
-
Yuly Novikov authored
Bug: chromium:1173237 Change-Id: I93810cb7cbaae847848eae0dc050c2c00df956af Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2753144Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Ian Elliott <ianelliott@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
-
John Plate authored
Bug: angleproject:5745 Change-Id: Icbfab0d0bd4b1510b98d5ed746f4d3ddfa5ec36e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2752746 Commit-Queue: John Plate <jplate@google.com> Reviewed-by:
Cody Northrop <cnorthrop@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
Alexey Knyazev authored
Bug: angleproject:5360, angleproject:5731 Change-Id: Ia883d2d319d7ce4659f4e1e99b5eccf0e01a45e1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2752747Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
-
John Plate authored
Bug: angleproject:1944 Change-Id: I89867c20c724c8db4d8edeb15fa4e32769f2a578 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2749596 Commit-Queue: John Plate <jplate@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
Alexey Knyazev authored
Add a new "emulatedEtc1" limitation. Bug: chromium:1048244 Change-Id: Ia04746773db3ad75781a8adfda988d36bd2c57f7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2718865Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
-
Alexey Knyazev authored
Compressed formats are rejected earlier with ValidateCopyTexImageParametersBase Bug: angleproject:5731 Change-Id: I7809140af84f2c565008e211adf0f998a0e57e91 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2741580 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Geoff Lang <geofflang@chromium.org>
-
Ian Elliott authored
This fixes visual problems with Android games that use eglSwapBuffersWithDamageKHR(). In 90/270-degree cases, the damage rectangles are being double-rotated, leaving them 90-degrees out of alignment with the window. On Android, VK_KHR_incremental_present is built on top of the same platform code as eglSwapBuffersWithDamageKHR(). The platform code rotates all damage rectangles (assuming they are application-provided). Therefore, ANGLE should not also pre-rotate damage rectangles. Test: Black Desert Mobile Test: Grand Theft Auto: San Andreas Test: Extreme Car Driving Simulator Bug: b/181796746 Change-Id: I6510e7540bb00afc75863e8ae8a9ea3841d1641d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2744984Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Cody Northrop <cnorthrop@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
-
Lubosz Sarnecki authored
Rename local variable, so using subprocess.Timeout does not result in an exception. This patch fixes the test timeout counter. Bug: angleproject:5742 Change-Id: Ib6991bc58df6ea653f765dfe9f6117add75b85db Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2748339 Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com> Reviewed-by:
Cody Northrop <cnorthrop@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
angle-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/023914a27b63..a2fe8e1b2111 2021-03-10 srisser@google.com Add Vulkan 1.2 entry points If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: Ia8aba9350c1c0476441da7f9c5eb20a22dfbfe54 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2752214 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/vulkan-deps.git/+log/6691fcec0bce..a4e10bfde719 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/159b057080..a36d91e5ac * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/d57ab68a21..60aa24566e * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/7d514cf1c7..77eb2b608e * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/4fe5828a02..89d366355e * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/237d3dcb5c..1353e80d87 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/461b33cfa2..d1cd265394 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/0ec2c7a693..be60dd27b1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: I65c8200a79763bdcbc0e32d60d7cac0f89ca786b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2752528 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
Lubosz Sarnecki authored
Since we are only interested in the difference to non-default states, bindings with a zero ID should not be serialized. This resolves the comparision error in the GetTexLevelParameterTest.* tests. The test now do not need to be skipped. Bug: angleproject:5645 Change-Id: I887bc22b52a201c467c00c42f6ddb3b38895a7c4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2739726Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Cody Northrop <cnorthrop@google.com> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
-
angle-autoroll authored
https://chromium.googlesource.com/chromium/src.git/+log/075d29b4983b..9e42f9e4abc6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/389d3f34d2..cb067b2df4 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/fb41d7ef20..32c9b4b55a * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/357278b25a..8e820e32d0 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..7a3a7363a7 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/fc54e6b87c..e65f1a7cc3 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/d850327d94..4bd62b06a2 * tools/skia_goldctl/linux: fRRnk-3C4PCCGCwZ4hZCeqm9_BnqznTyThRH4XqRVIIC..X8zqgmHchz43Cvw6xwn3VRL5keLdpA3cD_DqweHLRqMC * tools/skia_goldctl/mac: OLq_hZKAgzddlvSP4YR1TK0_2hzZipwLepMP3lOfS28C..9B5ePukmYbotGUjJuMV-DdjKGW5K0MtKrz8eOpXftu8C * tools/skia_goldctl/win: 5CX5n_psRKwMH74v7aAH4AHynDeTitubHLzeWYyCKv8C..tC_p4_R9hLfNMczJQbjawF5kzgXRVNF-XVcN7bJxrEYC No update to Clang. Bug: angleproject:5739 Tbr: ianelliott@google.com Change-Id: Ia21d911e770be49fd98c757feeb87d58bc5d5a1e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2750565 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
- 10 Mar, 2021 12 commits
-
-
Mohan Maiya authored
When separable programs are linked, varyings at the separable program's boundary need to be treated as active. Bug: angleproject:5557 Test: ProgramPipelineTest31.VaryingIOBlockSeparableProgram* Change-Id: I28af2bdf6478a408b3a7155ab4376ed6a19192f4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2742659 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Tim Van Patten <timvp@google.com>
-
Ian Elliott authored
This reverts commit 2aed567f. Reason for revert: Per https://bugs.chromium.org/p/angleproject/issues/detail?id=5741, the glslang change causes tests to fail with internal-linker errors. Original change's description: > Roll vulkan-deps from 6691fcec0bce to 32692e5de307 (12 revisions) > > https://chromium.googlesource.com/vulkan-deps.git/+log/6691fcec0bce..32692e5de307 > > Changed dependencies: > * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/159b057080..84e11a858c > * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/d57ab68a21..fb1f295aaf > * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/7d514cf1c7..c6da5e343c > * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/4fe5828a02..89d366355e > * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/0ec2c7a693..d1de19fea5 > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/vulkan-deps-angle-autoroll > Please CC ianelliott@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Bug: None > Tbr: ianelliott@google.com > Change-Id: I2bf77ebe46a52a285da0e8911a09f3e22067351a > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2745003 > Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> > Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bug: None Change-Id: I17f29c93e3a778395c02831740684f0e4aeb342f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2746842Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Ian Elliott <ianelliott@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
-
Jonah Ryan-Davis authored
On M1 Macs we need to extract Apple's vendor ID. Bug: chromium:1131248 Change-Id: Ie0e4006c3005e0a252d7a27a069a3be47ef4a7d5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2745703Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
-
Ian Elliott authored
This reverts commit b2f547f4. Reason for revert: Reverting this CL so that I can revert another CL that is causing tests to crash (see: http://anglebug.com/5741). A glslang change causes tests to fail with internal-linker errors. The upstream bug is: https://github.com/KhronosGroup/glslang/issues/2567 Bug: angleproject:5740 Change-Id: I8cde0d6c7004b03c130114af67b791e2871b8459 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2748966Reviewed-by:
Ian Elliott <ianelliott@google.com> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Ian Elliott <ianelliott@google.com>
-
Mohan Maiya authored
When BufferVk::acquireAndUpdate calls into acquireBufferHelper to allocate a new buffer helper we were passing in the update size instead of the full buffer size. Modified acquireAndUpdate's parameter to better reflect intent. Bug: angleproject:5689 Change-Id: Ic4fbc015651491ec028d747da5d45670264b93fa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2746066Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
-
angle-autoroll authored
https://chromium.googlesource.com/vulkan-deps.git/+log/32692e5de307..28d8c3478e4c Changed dependencies: * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/fb1f295aaf..60aa24566e * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/c6da5e343c..4a59fd4763 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/d1de19fea5..be60dd27b1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: I68384f61f4d3290089441645ee456b9bffa808f5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2748474 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/chromium/src.git/+log/031d7b5c5879..075d29b4983b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/f33045737d..389d3f34d2 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/786c1103e3..fb41d7ef20 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..4f82770e78 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/5f9e9dff87..d850327d94 * tools/skia_goldctl/linux: pVWUmcQ85_lx3kRUwR24iSVp_YTL6Oa3ZUVqn33pXqUC..fRRnk-3C4PCCGCwZ4hZCeqm9_BnqznTyThRH4XqRVIIC * tools/skia_goldctl/mac: P0qLgrCL8oP-jPdw9rs0tWhuvsx8cVqnV8C1DBI4TNAC..OLq_hZKAgzddlvSP4YR1TK0_2hzZipwLepMP3lOfS28C * tools/skia_goldctl/win: MKEUDKNT8DcyLZqnGZ2-o5TvzpNJbgsYtzzVAxVi2v4C..5CX5n_psRKwMH74v7aAH4AHynDeTitubHLzeWYyCKv8C No update to Clang. Bug: angleproject:5739 Tbr: ianelliott@google.com Change-Id: Icbaff9c118bfc065c5a9afd5fe86b83c0f289aa3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2747458 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
Lubosz Sarnecki authored
Move both SemaphoreTests to crashing. Don't skip passing VulkanExternalImageTest.*. Explicitly list VulkanExternalImageTest.* tests that still crash. All these tests compile now. Bug: angleproject:5721 Change-Id: Ib529dff8895496925001e4649aabcae78ce77236 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2739725 Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com> Reviewed-by:
Cody Northrop <cnorthrop@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
Lubosz Sarnecki authored
Move RobustClientMemoryTest.* to crashed tests, as it builds now. Bug: angleproject:5721 Change-Id: I590f4bd679374ee3302fc985a53747ddd60dd429 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2739724 Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com> Reviewed-by:
Cody Northrop <cnorthrop@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
Shahbaz Youssefi authored
Bug: angleproject:5070 Change-Id: Ic0c3de4380d02d150e2f52690ded9dfcc07b4575 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2747854Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Ian Elliott <ianelliott@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
-
Shahbaz Youssefi authored
For use by the translator. Bug: angleproject:4889 Change-Id: Ie95cafd3cfcdde50acc5d26d3c00e6574186a805 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2737276 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Tim Van Patten <timvp@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
Shahbaz Youssefi authored
Per issue 4889, dependency to glslang is being dropped. This change generates the unresolve UtilsVk shader directly in SPIR-V. This shader is trivial and contains repeating patterns per attachment. As a result, generating its SPIR-V is exceptionally simple. The SPIR-V in this change is first generated by glslang validator and is then adapted for autogeneration. See comments in the code for details. Bug: angleproject:4889 Change-Id: I48dd77ae04e1035c05a8aef7bf2f161e105ae2a4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2407179 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Tim Van Patten <timvp@google.com>
-
- 09 Mar, 2021 4 commits
-
-
Mohan Maiya authored
Buffers with dynamic usage will have frequent CPU updates. Don't CPU unmap such buffers after every update. Commits b5af8bde and 58c35d42 took care of performing an unmap when we release the buffer either to the renderer or mBufferFreeList. Bug: angleproject:5689 Change-Id: Ib6b8f6a7d0cb36583140e67bf164e074af098b8b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2741688Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
-
Cody Northrop authored
Test: angle_perftests --gtest_filter="*extreme_car_driving_simulator*" TBR: jmadill@google.com, timvp@google.com Bug: b/180419767 Bug: angleproject:5735 Change-Id: I5c197a71354a0cb3b907718b7ae7161037f7266f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2743806Reviewed-by:
Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
-
Cody Northrop authored
We were only tracking one image per level of cube map textures. Instead, we need to track one per face (6). Test: MEC for Extreme Car Driving Simulator Bug: b/180419767 Bug: angleproject:5735 Change-Id: I59e6a5e83a60666a29f44d0a1e1993a1b461e8e7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2744293Reviewed-by:
Tim Van Patten <timvp@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
-
Mohan Maiya authored
ANGLE only collects inactive varyings by instance name. The SPIR-V transformer expects I/O blocks to be identified by block name. If an I/O block is inactive, an assertion would fire because the block name is not in the shader variable info map. Bug: angleproject:5676 Test: GLSLTest_ES31.VaryingIOBlockNotDeclaredIn*Shader* Change-Id: I40e51c9770b03457e3896dcb2afa4e9525b098d8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2742658Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
-