- 17 Jan, 2020 9 commits
-
-
Shahbaz Youssefi authored
dEQP queries resource limits in all formats, including float. When INT_MAX is queried as float, the resulting value is INT_MAX+1 due to floating point imprecision. dEQP casts this value back to int for verification, and trips up on the resulting negative number. This change limits every ridiculously-large limit to INT_MAX/2 instead of INT_MAX. Bug: angleproject:4309 Change-Id: I11018c2c5a0c8bfb410928b0a4c34c526fab2269 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2006813 Commit-Queue: Ian Elliott <ianelliott@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Ian Elliott <ianelliott@google.com>
-
angle-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/5fc197dc7669..2cb1db08e5f1 git log 5fc197dc7669..2cb1db08e5f1 --date=short --first-parent --format='%ad %ae %s' 2020-01-17 bclayton@google.com SpirvShaderDebugger: Implement OpenCL.Debug.100 2020-01-16 capn@google.com Remove the GL_NV_read_depth_stencil extension Created with: gclient setdep -r third_party/SwiftShader@2cb1db08e5f1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: Ia3eec3b9c7cfc377451b8aa284f836fedbaa2c07 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2006716Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/ab883b9d257e..41a96d15fd99 git log ab883b9d257e..41a96d15fd99 --date=short --first-parent --format='%ad %ae %s' 2020-01-16 rpalandri@fb.com tests: Add test for VUID 02531 2020-01-16 rpalandri@fb.com corechecks: Add val for FBCreateInfo non-zero viewmasks 2020-01-16 mikes@lunarg.com Fix GN build 2020-01-16 s.fricke@samsung.com tests: Added 01589/01590 to InvalidMemoryRequirements 2020-01-16 s.fricke@samsung.com layers: Added support for VUID 01589/01590 Created with: gclient setdep -r third_party/vulkan-validation-layers/src@41a96d15fd99 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: Ic57a869b6b1a7578728900088d9f327674de49cd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2006717Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/4792a6854238..b6ac1e60cd3a git log 4792a6854238..b6ac1e60cd3a --date=short --first-parent --format='%ad %ae %s' 2020-01-16 jeremyk@lunarg.com build: Update glslang commit ID in known_good.json 2020-01-16 charles@lunarg.com vulkaninfo: Support VK_EXT_tooling_info 2020-01-16 mikes@lunarg.com Fix GN build Created with: gclient setdep -r third_party/vulkan-tools/src@b6ac1e60cd3a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-tools-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: Id8b2bc19aabe281c5319ce3c080687d6570413d1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2006715Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/3ed344dd784e..b0ada80356ca Created with: gclient setdep -r third_party/glslang/src@b0ada80356ca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: Id3affd6b1da4d58e350221c044dcb4172efaf4a0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2006719Reviewed-by:
-
Shahbaz Youssefi authored
Bug: angleproject:4309 Bug: angleproject:4310 Bug: angleproject:4311 Bug: angleproject:4312 Bug: angleproject:4313 Bug: angleproject:4314 Bug: angleproject:4315 Bug: angleproject:4316 Change-Id: Ibda4eac6a49ad7a8fcf0ec68b6dd199a3f66ebb0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2006812Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
-
Alexis Hetu authored
Implemented DetermineBGRAReadFormatSupport in order to allow enabling readFormat when possible with the Vulkan backend. While reading the spec, I realized that ANGLE only seems to care about BGRA8888 and not the new types mentioned in the extension. Logged a new issue (http://anglebug.com/4302) to track this. Bug: angleproject:4294 Change-Id: I071ed89574de9b4088df2301c317d3769cb31ce6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2003237 Commit-Queue: Alexis Hétu <sugoi@chromium.org> Reviewed-by:
-
Alexis Hetu authored
DetermineFloatBlendSupport was added to be able to set floatBlend to true if requirements are met. Essentially GL_EXT_float_blend complements GL_EXT_color_buffer_float by making any non-blendable formats blendable. Bug: angleproject:4291 Change-Id: I40d6bb7a93b8847a63de2d25c6a8dc411d6d8fbb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2001479 Commit-Queue: Alexis Hétu <sugoi@chromium.org> Reviewed-by:
Geoff Lang <geofflang@chromium.org>
-
Alexis Hetu authored
Added stubs for these soon to be added extensions: - GL_OES_depth_texture_cube_map - GL_EXT_read_format_bgra - GL_NV_depth_buffer_float2 - GL_NV_read_depth - GL_NV_read_stencil Bug: angleproject:4293 Bug: angleproject:4294 Bug: angleproject:4295 Change-Id: I56cf1fda377e48521f30bd11f5776409bfb88701 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2001480 Commit-Queue: Alexis Hétu <sugoi@chromium.org> Reviewed-by:
-
- 16 Jan, 2020 19 commits
-
-
Alexis Hetu authored
The GL_EXT_color_buffer_float spec https://www.khronos.org/registry/OpenGL/extensions/EXT/EXT_color_buffer_float.txt mentions that some of the formats must be blendable: "Blending applies only if the color buffer has a fixed-point or floating-point format. If the color buffer has an integer format, proceed to the next operation. Furthermore, an INVALID_OPERATION error is generated by DrawArrays and the other drawing commands defined in section 2.8.3 (10.5 in ES 3.1) if blending is enabled and any draw buffer has 32-bit floating-point format components." So any non 32-bit floating-point must be blendable. Bug: angleproject:4291 Change-Id: I850fb13b71e4ad03fd07e2a265896c9106bc0ce1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2001478 Commit-Queue: Alexis Hétu <sugoi@chromium.org> Reviewed-by:
-
Rafael Cintron authored
The last render-to-texture commit broke FL10_0 multisampling by unconditionally asking for D3D11_STANDARD_MULTISAMPLE_PATTERN quality setting. Per the documentation on https://docs.microsoft.com/en-us/windows/win32/api/d3d11/ne-d3d11-d3d11_standard_multisample_quality_levels applications can only request the standard multisample pattern on feature levels 10_1 and above. For feature levels 10_0 and below, we'll stick with asking for a quality level of 0 like the code previous did. Bug: chromium:1036367 Change-Id: I0dd7704cf144ebce952e1f7d5e148d3382891aed Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2003238 Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com> Reviewed-by:
-
Jonah Ryan-Davis authored
Started failing on Jan 11, 2020 Bug: chromium:1041672 Change-Id: Ie51c0d363b49025c607c32a1858cdaf8c38ebf87 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2003013Reviewed-by:
-
Mohan Maiya authored
Add support for floating point configs. On backends that support rendering to floating point formats, add them to EGL's frambuffer config list Bug: angleproject:3958 Tests: dEQP-EGL.functional.wide_color.*fp16* angle_end2end_tests --gtest_filter=EGLFloatSurfaceTest* Change-Id: Ie65f63013483267985c2b308567bf5025acf750e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1993686 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: -
Alexis Hetu authored
- Added a blendable check to InternalFormat - Set the blendable check to the same as the Renderbuffer check for most formats, except true integer formats and 32F formats - True integer formats never support blending - 32F formats support blending based on the GL_EXT_float_blend Bug: angleproject:4291 Change-Id: Icffdd3e6d8791303bdfdad9ec01cfd9a1d511af0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1999495Reviewed-by:
-
Jamie Madill authored
This moves the resource use tracking functionality out of CommandGraph. Making the list a separate class helps the implementation avoid tricky circular include problems. Bug: angleproject:4029 Change-Id: I3288fc685b21e949f12b0796109a2b7bb117c249 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2002931Reviewed-by:
-
James Darpinian authored
ANGLE_STATE_VALIDATION_ENABLED is expensive, adding a lot of overhead to draw calls in debug mode. It's causing some of WebKit's layout tests to time out. Instead of enabling it for all debug builds, let's only enable it when ANGLE_ENABLE_DEBUG_TRACE is specified. Bug: angleproject:3900 Change-Id: I9866d7afbb5666f35c56539820d591953bdf7650 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1994440Reviewed-by:
Jonah Ryan-Davis <jonahr@google.com> Reviewed-by:
-
James Darpinian authored
WebKit's tools don't like literal tab characters in their repo. Bug: angleproject:3439 Change-Id: Ifd26e0bbcfaa604ed26f6a42dd7d2248e94dfeaa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2003929Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
-
Jamie Madill authored
This abstracts away the ResourceUse tracking from CommandGraph. Pulling it out will allow us to more easily swap resource use tracking into ContextVk. The command graph is eventually going away so we need to move functionality out of CommandGraph. Bug: angleproject:4029 Change-Id: Icc3bcc824510b03e91f8ff010a82751a81516bfa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2002930 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/2c436960d2c0..4792a6854238 git log 2c436960d2c0..4792a6854238 --date=short --first-parent --format='%ad %ae %s' 2020-01-15 charles@lunarg.com vulkaninfo: handle previous driver versions 2020-01-15 charles@lunarg.com build: Update known good for 1.2.131 Vulkan Header and Loader 2020-01-15 mikes@lunarg.com scripts: Tweak extension detection Created with: gclient setdep -r third_party/vulkan-tools/src@4792a6854238 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-tools-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I21a0c7f08ed37f247e11de9d42a67beee6681825 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2003122Reviewed-by:
-
Alexis Hetu authored
Vulkan distinguishes between a texture format that can be used as a render target (VK_FORMAT_FEATURE_COLOR_ATTACHMENT_BIT) and one that supports blending (VK_FORMAT_FEATURE_COLOR_ATTACHMENT_BLEND_BIT). This cl adds a blendable capability and sets it based on the appropriate bit. It also adds the check in GetFormatSupportBase(), but all uses of it are currently set to false. In terms of behavior, this cl should be noop. Bug: angleproject:4291 Change-Id: Ib151ac8ab7b69311b7fdef15ad87186d13e3ed78 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1999494 Commit-Queue: Alexis Hétu <sugoi@chromium.org> Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/f63dd5c9d874..881bbb347a08 git log f63dd5c9d874..881bbb347a08 --date=short --first-parent --format='%ad %ae %s' 2020-01-15 oddhack@sonic.net Update for Vulkan-Docs 1.2.131 Created with: gclient setdep -r third_party/vulkan-headers/src@881bbb347a08 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-headers-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=jonahr@google.com Bug: None Change-Id: I2f78b6d68988172304e50fb17ed882b117faa77c Tbr: jonahr@google.com Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2004368Reviewed-by:
-
Jonah Ryan-Davis authored
The passthrough ASAN fuzzer was hitting a null-dereference trying to call glBlitFramebuffer when ANGLE was not exposing it. The fuzzer uses the NULL backend so we can just expose it. Bug: chromium:1029829 Change-Id: I0f65c65284756fa21821155559a6404d95e25647 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2003230Reviewed-by:
-
Mohan Maiya authored
Dynamic buffers are used to perform staged updates to BufferVk objects instead of recreating staging buffers for each update. Bug: angleproject:4292 Change-Id: I0f64c821c97e0e6014e9df1d4f99e2f495838025 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2001461 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
Corentin Wallez authored
The previous implementation of the function had an incorrect comment that implied XQueryTree was a great way to check if a Window is valid. Any X11 function taking a Window is a good candidate, what we need to be careful about is X11 exiting the program on any error. Replace it with a call to XGetWindowAttributes while ignoring X11 errors. This fix was found while implementing similar functionality in Dawn. Bug: dawn:269 Change-Id: I777e59cddbe94baf63286d11887b58c63ac2b66c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2001301Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/d203754bc116..3ed344dd784e Created with: gclient setdep -r third_party/glslang/src@3ed344dd784e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: Idd8bccd67ffcda6115477f0e9fb3bcac97ea7dff Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2003821Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/834baaf8b227..ab883b9d257e git log 834baaf8b227..ab883b9d257e --date=short --first-parent --format='%ad %ae %s' 2020-01-15 mark@lunarg.com tests: Added tests for ycbcr sampler validation check 2020-01-15 mark@lunarg.com stateless: Added YCBCR sampler checks 2020-01-14 mark@lunarg.com tests: Add destroy null handle tests to best practices 2020-01-14 mark@lunarg.com bestpractices: Check for null handle when freeing memory 2020-01-14 petr_kraus@email.cz layers: Fix the logic in VUID links generation Created with: gclient setdep -r third_party/vulkan-validation-layers/src@ab883b9d257e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I58971f69536be68f387694c357d9e9d77c318074 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2003125Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/8013d477aeac..323a81fc5e30 Created with: gclient setdep -r third_party/spirv-tools/src@323a81fc5e30 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I7edd382098175d998315e8b4d9665aa09124330a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2003123Reviewed-by:
-
angle-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/488d35ac0b1c..5fc197dc7669 git log 488d35ac0b1c..5fc197dc7669 --date=short --first-parent --format='%ad %ae %s' 2020-01-15 jonahr@google.com Disable MSVC warning 4065 2020-01-15 bclayton@google.com Vulkan: Disable SPIR-V preprocessing when debugging 2020-01-15 capn@google.com Produce less debug info in Kokoro builds 2020-01-15 capn@google.com Refactor binary group operations 2020-01-15 capn@google.com Replace positive/negative_inf() with infinity() 2020-01-15 bclayton@google.com SpirvShader: Stub OpenCL.DebugInfo.100 2020-01-15 bclayton@google.com System/Types.hpp: Make vec(T replicate) constexpr 2020-01-15 bclayton@google.com SpirvShaderDebugger: Add flag for printing opcodes 2020-01-15 bclayton@google.com SpirvShader: 2-way imported extensions lookup 2020-01-15 bclayton@google.com .vscode: Add spirv-tools-ext to include path 2020-01-14 bclayton@google.com C++14: Use enum class builtin hashing 2020-01-14 bclayton@google.com C++14: Use std::enable_if_t instead of our own 2020-01-14 chrisforbes@google.com Add initial stub implementation of AHB Created with: gclient setdep -r third_party/SwiftShader@5fc197dc7669 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: angleproject:4299 Tbr: jonahr@google.com Change-Id: I0badcf80f1be1ca17654a1d2f09f420e313dd540 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2003124Reviewed-by:
-
- 15 Jan, 2020 2 commits
-
-
Ian Elliott authored
Bug: angleproject:3569 Bug: angleproject:3596 Bug: angleproject:4106 Bug: angleproject:4108 Bug: angleproject:4300 Change-Id: Iab88bf5db19af802ad41ef8bf68f643420857989 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2003233Reviewed-by:
-
Artem Bolgar authored
Found two issues when native OVR_multiview and OVR_multiview2 extensions are generated. 1. OVR_multiview got replaced by the OVR_multiview2 in the translated shader (ESSL & GLSL) 2. Duplicate #extension OVR_multiview2 (for Fragment & Vertex) and 'layout (num_views=x)' (for Vertex) got generated into the translated shader. Bug: angleproject:4247 Change-Id: I9a550883eeb326d95af4557578f8202a9493f4ec Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1983802Reviewed-by:
Rafael Cintron <rafael.cintron@microsoft.com> Reviewed-by:
-
- 14 Jan, 2020 10 commits
-
-
Kenneth Russell authored
Originally authored in the WebKit repository: https://bugs.webkit.org/show_bug.cgi?id=205618 Has been tested with WebKit's WebGL backend on top of ANGLE inside the iOS Simulator. TODOs will be addressed in forthcoming CLs. Bug: angleproject:4263 Change-Id: Ic879866aaee5f933599d956b0646d0c01db55d0d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1995824Reviewed-by:
-
Shahbaz Youssefi authored
Bug: angleproject:3829 Change-Id: I872118f145886eecaed1680268e95419385b9d9e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2001237Reviewed-by:
-
Shahbaz Youssefi authored
This was done based on the incorrect assumption that Vulkan GLSL doesn't allow layout qualifiers on interface block fields. This was due to glslang compile failures in some shaders that included mixed row- and column-major fields in interface blocks. However, the failures were only in the case the interface block is inactive, in which case glslang wrapper previously replaced the layout/qualifier of the interface block with |struct|, which left the shader with an unused struct definition with fields that have layout qualifiers; an invalid shader. The change introduced in https://chromium-review.googlesource.com/c/angle/angle/+/1951523 removes inactive shader interface declarations. The above scenario thus never occurs, rendering the row- to column-major transformation unnecessary. Bug: angleproject:3443 Change-Id: Ice34a0fc6e047b79a4d44f04b730ec59bdfafe33 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1961098Reviewed-by:
Cody Northrop <cnorthrop@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
-
jchen10 authored
Makes sure P010 stream can work correctly. Bug: chromium:1033416 Change-Id: I1b49568cd667697337335a0eca74504bd0e36f5c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1996912Reviewed-by:
Jie A Chen <jie.a.chen@intel.com> Reviewed-by:
-
Jamie Madill authored
Previously we were still calling GoogleTest directly. This change switches the test main funtions to call the standalone harness. Only affects standalone and shouldn't affect the tests in Chromium or on the current test setup. Bug: angleproject:3162 Change-Id: Ia5a5a73d47c0b47b4df8f54cd6df71da2d878847 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1998661 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
Jamie Madill authored
Adds special handling for the DISABLED_ GTest test name. Fixes the test for the test suite harness itself when run with the new "--bot-mode" flag. Bug: angleproject:3162 Change-Id: Idf34098d2d6bcb78263773be7b01c55df9ec624b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1998660 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org>
-
Jamie Madill authored
Reorganizes the build files to work with a more divided setup. It is unclear if we'll ever be able to run tests in a UWP config. This at least sets up the organization so it would at some point be possible. Bug: angleproject:4182 Change-Id: I49dddfcdc0118b11466fe171f949c28d101ac6a2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1953484 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
Shahbaz Youssefi authored
Bug: angleproject:4211 Change-Id: I9e9cdacd4f24131101029d17932625e2e3c7d7e0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1957836 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
-
Jamie Madill authored
Prepratory clean up for WinUWP support. Bug: angleproject:4182 Change-Id: I97cc6cb42a50c6b57ca7d375d1e0a6b3da7aa9d7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1998673 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/b96d6528883e..834baaf8b227 git log b96d6528883e..834baaf8b227 --date=short --first-parent --format='%ad %ae %s' 2020-01-13 petr_kraus@email.cz layers: Default vuid links to spec repo search Created with: gclient setdep -r third_party/vulkan-validation-layers/src@834baaf8b227 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: Id4efc3fd3e1d19026e52bcbb27ef7c0e260f2797 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1999621Reviewed-by:
-
