Skip to content

A
angle
Switch branch/tag
  1. 02 Nov, 2020 10 commits
  3. 01 Nov, 2020 4 commits
  5. 31 Oct, 2020 5 commits
  7. 30 Oct, 2020 18 commits
  9. 29 Oct, 2020 3 commits
    • Vulkan: Make DescriptorPoolHelper a Resource · fcd35965
      Tim Van Patten authored 
      Descriptor pools need to live as long as the descriptor sets that are
allocated from them. Using Serials while building a command to judge a
pool's lifetime is prone to errors, since a command's Serial value
isn't known until the command is submitted, leading to deleting pools
too early relative to when the descriptor set is actually used.

This CL updates DescriptorPoolHelper to inherit from Resource, so the
descriptor pools can be retain()'ed. This allows the Resource's counter
to indicate that a pool is in use until the command's Serial is known
and can be recorded to indicate when the command completes. This
prevents descriptor pools from being destroyed before the command
completes (while the descriptor sets are still in use), or even before
the command has been submitted. Destroying a descriptor pool resets all
of the descriptors that were allocated from it, which can trigger a
variety of VVL errors depending on when it's erroneously performed.

This CL also adds the necessary retain() calls for the descriptor pools.
In particular, the pools need to be retained each time a cached
descriptor set that was allocated from it is re-used. This is relatively
simple with the current design, since we always clear the descriptor set
caches whenever a new pool is allocated, so the descriptor pool binding
is always accurate.

Bug: angleproject:5030
Test: VulkanMultithreadingTest::MultiContextDrawSmallDescriptorPools()
Change-Id: Iac9e7efef338f169a6bf8ac3b2140e03dd326641
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2504457Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
Reviewed-by: 's avatarCourtney Goeltzenleuchter <courtneygo@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>
    • Skip Instanced MultiDrawTest.MultiDrawArrays on Mac Mini 8.1 · 1070802c
      Yuly Novikov authored 
      Bug: angleproject:5265
Change-Id: I1d3f1802398472c0da2d00526bd7eb52f6596bea
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2508532Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
    • Gold Tests: Include SHA1 files in trace inputs. · e77e3528
      Jamie Madill authored 
      This will force "GN analyze" to pick up changes in the gold tests
when all that GN sees is a new SHA1 file. In effect a SHA1 change
means all the sources in a trace have changed.

Bug: chromium:1143507
Change-Id: Idf44045ebd5d2bda9380b339e95d336b6804ce8a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2508530
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: 's avatarYuly Novikov <ynovikov@chromium.org>
Reviewed-by: 's avatarCody Northrop <cnorthrop@google.com>