https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/eea340047eca..a0eb5efd2bad


Created with:
  gclient setdep -r ./third_party/glslang/src@a0eb5efd2bad

The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-angle-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


Bug: None
TBR=geofflang@google.com
Change-Id: Ifc6b5debeccd4e74fc1eb2c1a5ad9079fedab981
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1732791Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

Chrome uses rectangle textures on mac to copy data.  ANGLE's frontend allowed
them as CopyTexture sources but did not implement them in the backend.

TEST=Any WebGL test on Mac

BUG=982294

Change-Id: If2e40292b22c4f49676e3ece8cc6fa126c5b7b94
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1726849Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

The tests need to be run with --deqp-gl-config-name=rgba8888d24s8ms4 for
deqp to even try them.  They pass and the removal of suppressions was
missing from:

https://chromium-review.googlesource.com/c/angle/angle/+/1639749

Bug: angleproject:3204
Change-Id: I77cb528da090d1374152e2e32f86e974df70358a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1726850Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

Changes default uniform block layout generation to only remove the first
array subscript, which causes arrays of arrays to be recognized
correctly.

Bug: angleproject:3604
Test: ./angle_deqp_gles31_no_gtest --deqp-egl-display-type=angle-vulkan -n 'dEQP-GLES31.functional.shaders.arrays*'
Test: ./angle_deqp_gles31_no_gtest --deqp-egl-display-type=angle-vulkan -n 'dEQP-GLES31.functional.program_interface_query.*array*array*'
Change-Id: Ifacc665cae87c651253e5cb8d929178d7fc92817
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1724906Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: James Dong <dongja@google.com>

This change does two things:

 * only call validation functions once per entry point.
 * move the capture call after the entry point call.

Moving the capure after the call allows us to process the results of
the call. Also we can clean up the validation double call by doing a
bit of entry point refactoring. The code changes shouldn't impact the
resulting code size when capture is disabled.

Bug: angleproject:3611
Change-Id: I9e74ba0a8266903d3e9d1f2eac6acdd2932e5743
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1706561
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

Second attempt at fixing this bot:

https://ci.chromium.org/p/chromium/builders/ci/Win10%20FYI%20x64%20Release%20%28AMD%20RX%20550%29

Bug: angleproject:3738
Change-Id: I8e8626cc911df9dae82c542b2dde8696f10e49bc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1731130Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

For capture, we'd ideally like to know the return value of a function
when we capture it. The first step will be to intercept the return
value instead of returning directly.

Bug: angleproject:3611
Change-Id: I68c21aea323a71c6a9f1be613862158a37e2beae
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1706560Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Image load and store are incoherent memory access
operations, so need to use memoryBarrier to ensure
the visibility of incoherent memory access operations
with other operations.

Bug: angleproject:3044
Change-Id: I4d474d260a3199c026911de8d20878cd327d16c6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1677420
Commit-Queue: Xinghua Cao <xinghua.cao@intel.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

TextureBorderClampIntegerTestES3.TextureBorderClampInteger/ES3_OpenGL
TextureBorderClampIntegerTestES3.TextureBorderClampInteger2/ES3_OpenGL
failing on Win10 FYI x64 Release (AMD RX 550).

Bug: angleproject:3760
Change-Id: I0ccd56f190b1a3775f6a9a0448ca3003baa331ac
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1729564Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

Adds a build option to use the capture libraries in the default output
location for libGLESv2. With |angle_with_capture_by_default| enabled,
libGLESv2 will have capture enabled and the non-capture libGLESv2 is
built as libGLESv2_no_capture.

Also moves the FrameCapture to be owned by gl::Context. Rearranges the
code a bit so that we don't require a separate version of libANGLE for
capture.

Also implements a read pixels entry point parameter.

Bug: angleproject:3611
Change-Id: Ic528e43e4779f794c8b6d0bf35410166dacc81b1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1719064Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Use bit operation to compute memory alignment round up.
Tested with T-Rex, hotspot in roundUp resolved.

Bug: angleproject:3744
Change-Id: I55db941f588401a1d2d3d93f4d6b810e6b1aa95f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1725118
Commit-Queue: Jiacheng Lu <lujc@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/f04f1f93a70f..eea340047eca


Created with:
  gclient setdep -r ./third_party/glslang/src@eea340047eca

The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-angle-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



Bug: None
TBR=geofflang@google.com
Change-Id: I5d672794fb0ff90519363cad5172a614e8705347
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1728332Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

Some test cases use wrong barriers when calling glMemoryBarrier.

Bug: angleproject:2280
Change-Id: I0750c1eba84ed8af32091f7ecd5bdbd2b32fd397
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1687591Reviewed-by: Jiajia Qin <jiajia.qin@intel.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Xinghua Cao <xinghua.cao@intel.com>

1. only do isSampler checking when update int uniforms
2. inline some simple methods of LinkUniform

This fix reduce CPU time spent on `isSampler` call from 70ms to 30ms in
T-Rex bench on specific platform.

Bug: angleproject:3743
Change-Id: I98ef3c892df27e08d54ed40946d924b5a50c796c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1725114
Commit-Queue: Tobin Ehlis <tobine@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

This allows the GL backend to import Vulkan resources.

BUG=angleproject:3656

Change-Id: Ie5e55ce3e1ba05e917619e3f192c13dcc36c3739
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1688507Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Clemen Deng <clemendeng@google.com>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

BUG=angleproject:3656

Change-Id: I360d5a0eda820a4138e5400614332ae919216db6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1688506Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Clemen Deng <clemendeng@google.com>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

When a local shared library should be loaded, resolve its full path
before calling dlopen.

This logic matches SwiftShader's library loading.

This is a speculative fix for Chrome being unable to load ANGLE libraries
when they are distributed as part of a Chromium.app and have a different
path than the executable.

BUG=982294

Change-Id: Ib70096eac7460417ea7ea32941e2273dd368e6ac
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1724910
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Clemen Deng <clemendeng@google.com>

Color attachment output ordering applies to commands recorded within a
render pass subpass.  We still need execution barriers between render
passes (and subpasses, but we don't use them).

Bug: angleproject:3347
Change-Id: Ifaddaeac35347d8a35e771f46a29047d52c9541c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1713085Reviewed-by: Fei Yang <fei.yang@arm.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/9559cdbdf011..ac3d131054ac


Created with:
  gclient setdep -r ./third_party/spirv-tools/src@ac3d131054ac

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



Bug: None
TBR=geofflang@google.com
Change-Id: I88f21fb37e85379603e48bbbf221d9088b7cfaaf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1725336Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/7fc868349143..f04f1f93a70f


Created with:
  gclient setdep -r ./third_party/glslang/src@f04f1f93a70f

The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-angle-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



Bug: None
TBR=geofflang@google.com
Change-Id: Ife87ce07871fed4270585054a7ce29b17c0ae313
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1725526Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

Android requires the same line rasterization for Vulkan, so this CL will
enabled that workaround.

Bug: angleproject:2830
Test: dEQP-GLES2.functional.rasterization.primitives.line*
Change-Id: Ic28dd2e54c5cb9b29f8592952b2c0f29a5f97fd5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1715207Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>

The libEGL_angle.so and libGLESv2_angle.so libraries are typically
loaded into the same process each time, so we need to make sure there
aren't any duplicated symbols which could violate ODR and lead to
crashes or undefined behavior.   In this case, the libEGL_angle.so
function pointer names were colliding with libGLESv2_angle.so function
names, causing crashes at runtime.   The fix here is to mark the
libEGL_angle.so function pointer symbols 'hidden', so they don't appear
in the symbol table for other executables/libraries to see and can't be
overridden by other symbols.

Bug: angleproject:3751
Test: Embed ANGLE within dEQP.apk and verify no crashes
Change-Id: Ibb78369374a4a68b3489a7dd7775c52e29fa37e0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1724909
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Initial attempt to give desktop ETC/EAC formats support.

Bug: angleproject:3676
Change-Id: Id147b0c1808e30df77097d0c7ff6a06534554b93
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1699307
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

Remove the dirty checking of matrix uniform update at frontend and
always let backend update whenever glUniformMatrix* is called. Profiled
with UniformsBenchmark/* with vulkan backend, performance increases
around 6% when data being updated is changing and performance increases
around 2% when data being updated stays same.

Bug: angleproject:3705
Change-Id: I8eaf6a1231e634b69c6dc540db1b9d3a312bf45d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1709725
Commit-Queue: Jiacheng Lu <lujc@google.com>
Reviewed-by: Tobin Ehlis <tobine@google.com>

Handles the ES 3.1 relative offset parameter in vertex attributes by
adding it to the binding offset.

Test: ./angle_deqp_gles31_no_gtest --deqp-egl-display-type=angle-vulkan -n dEQP-GLES31.functional.vertex_attribute_binding.usage.single_binding.unaligned_offset_elements_1_aligned_elements
Bug: angleproject:3598
Change-Id: Idbbd5ba4868a4dfc8f99188a84a5cd1374e09065
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1724453Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: James Dong <dongja@google.com>

1. Compare updating values with active ones at frontend when
depth&stencil related gl call happens and do not set any unnecessary
dirty bits.
2. Remove d3d and gl backends' checking of depth&stencil states when
detect any dirty bits, as it is now being done at frontend.
3. Modification to graphics pipeline description update, make sure it
syncs with gl::State initial value.
4. Change gl_vk::CullMode return type to VkCullModeFlagBits, as it only
represents single value.

Bug: angleproject:3700
Change-Id: Id3aa5186455ee3a10a9c147edad13944e3e41098
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1706903
Commit-Queue: Jiacheng Lu <lujc@google.com>
Reviewed-by: Tobin Ehlis <tobine@google.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/42f813401bdf..7fc868349143


Created with:
  gclient setdep -r ./third_party/glslang/src@7fc868349143

The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-angle-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



Bug: None
TBR=jmadill@chromium.org,jmadill@google.com
Change-Id: I91cbab4ec63909cf62892905d0e6500e22261855
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1723835Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/f54b8653dd9d..9559cdbdf011


Created with:
  gclient setdep -r ./third_party/spirv-tools/src@9559cdbdf011

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



Bug: None
TBR=jmadill@chromium.org,jmadill@google.com
Change-Id: I27a15130e7b8786e1d2404a2cfa6954f9ddd339f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1723834Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

(on behalf of RewriteAtomicFunctionExpressions)
The compile will occasionally choose to inline all instances of this
function, and therefore not export this entrypoint into the object file,
leaving other TUs (RewriteAtomicFunctionExpressions) with missing
link symbols.

Bug: angleproject:3752
Change-Id: Ida778bcd897a85567680911a88aae88a3797aa93
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1721954
Commit-Queue: Jeff Gilbert <jgilbert@mozilla.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Bug: angleproject:3209
Change-Id: I82e67345ce9f70b1b1d211b00b23d95dd53a44e7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1721188Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>

We are currently returning a 3.0 context for Vulkan backends (issue
3425).   However, we aren't quite 3.0 conformant yet, so this bug
will drop that back down to 2.0 in getMaxConformantESVersion().

Bug: angleproject:3734
Test: dEQP
Change-Id: I2c5a6ee0ddb3bd52fdc92fdc9b12cf3c6d8e0510
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1716244
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Recent changes allow these to all run and pass!

Bug: angleproject:3190
Change-Id: I6349b8d9aa90297e676f170361f468ac04b3150d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1721171Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Ian Elliott <ianelliott@google.com>

ClearTestES3.RepeatedClear/ES3_Vulkan
ShaderStorageBufferTest31.LoadAndStoreBooleanValue/ES3_1_D3D11

Bug: angleproject:3748, angleproject:3749
Change-Id: I54c6259d36c9993250e961d92a6d4b8e4349ed57
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1721185Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

1. add '-Wfloat-conversion' in compiler flag for clang
2. fix existed implicit float conversion

Bug: angleproject:3728
Change-Id: I0dc07eeb74c5d6dc480c6f0aa88bc75ab98e4292
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1713741
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Includes changes from jmadill to align with Vulkan backend design.

Correctly setting layer count and depth when the texture type is
2Darray. Vulkan requires depth of 1 for 2Darray textures.

Bug: angleproject:3189
Change-Id: I0d58c33fcd75b1d768ea0308ac6e54230d8cfcc5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1721169Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

When handling dirty bindings, we were treating binding indices as if
they were attribute indices, causing strange behavior. This change fixes
the dirty bit handler to use the provided index properly and update the
attributes that correspond to the binding index.

Test: ./angle_end2end_tests --gtest_filter='VertexAttributeTestES31.OnlyUpdate*/ES3_1_Vulkan'
Bug: angleproject:3598
Change-Id: I2bc3cd4da5f639a1301776fcf057a74368812c56
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1718786
Commit-Queue: James Dong <dongja@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

The charts were regenerated, update the docs to point to the new charts.
Also remove some redundancy (we don't need the overview to track differences in vendors)

Bug: angleproject:3713
Change-Id: I2005031c4ca960d7f9afd80562957d31af795d61
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1721190Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>

Translation buffers weren't being marked dirty after running a compute
shader in which they are bound as SSBOs.
This change invalidates all SSBOs after a draw or compute call.

Bug: angleproject:3739
Change-Id: I66b56df7e619b55afc7e3da6b5613b6d050e06bb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1717144Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: James Dong <dongja@google.com>

Bug: angleproject:3611
Change-Id: Idba4d49d36274db8545f2526f19f045f97031379
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1721173Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Other small fixes for desktop compatibility

Bug: angleproject:3620
Change-Id: I8e75bce1f850fb891c8bb6e16f79302a6d59276c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1707932
Commit-Queue: Clemen Deng <clemendeng@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>