Commits · 6067e9ce8bb3bde028dfa613af4d7b1ac41391e3 · Chen Yisong / angle

12 Nov, 2020 1 commit

Tests: Fix async queue feature comparision. · 6067e9ce

authored Nov 11, 2020

This bug was incorrectly causing the Async Queue configs to be
classified as the same as ordinary Vulkan configs.

This bug did not affect test grouping in the test runner.
It did affect how we enable/disable configs.

Bug: b/172704839
Change-Id: Ibf6f04fc1a719464201f77884b2a0b3ab1fab78c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2533813Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

6067e9ce

11 Nov, 2020 11 commits

Suppress BestPractices-vkCreateDevice-specialuse-extension · 52f77eed

authored Nov 11, 2020

Suppress the VVL warning:
UNASSIGNED-BestPractices-vkCreateDevice-specialuse-extension

ANGLE uses the extension to match OpenGL ES line rasterization behavior,
so this warning doesn't apply and is being suppressed.

Bug: angleproject:5336
Change-Id: I2f0e086a7ff392e13b6a1da0a55b0e1b81953b2e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2533437Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

52f77eed

Suppress Additional MultisampledRenderToTextureES3Test · 3c3edc3b

authored Nov 11, 2020

The following tests are generating the VVL error
VUID-VkSubpassDescriptionDepthStencilResolve-stencilResolveMode-parameter

MultisampledRenderToTextureES3Test
- BlitFramebufferTest()
- RenderbufferUnresolveColorAndDepthThenTwoColors()
- RenderbufferUnresolveColorAndStencilThenTwoColors()

Suppressing them for now.

Bug: angleproject:5331
Change-Id: Ia97def4a798677e0b5f663ba7679de61c673b0c8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2532710Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>

3c3edc3b

Vulkan: Support VK_KHR_image_format_list for PbufferSurfaces · 15d5965d

authored Nov 10, 2020

PbufferSurfaces are now created with VK_KHR_image_format_list
extension support enabled.

Bug: angleproject:2514
Bug: angleproject:5281
Test: PbufferTest.ClearAndBindTexImageSrgb*Vulkan
Change-Id: I8977484c958328d00f688faa7adffff85a37a3b8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2530535
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

15d5965d

Suppress RenderbufferBlitFramebufferTest · 4a74427e

authored Nov 11, 2020

The test
MultisampledRenderToTextureES3Test::RenderbufferBlitFramebufferTest() is
generating VVL errors with the latest VVL roll:
VUID-VkSubpassDescriptionDepthStencilResolve-stencilResolveMode-parameter

Suppressing the test rather than the VVL error, so the VVL can still
catch any new cases of this error while the test is investigated.

Bug: angleproject:5331
Test: MultisampledRenderToTextureES3Test.RenderbufferBlitFramebufferTest
Change-Id: I473ee57fe16c1f5cf325004912ef2bc5b9ced0d7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2532658
Commit-Queue: Tim Van Patten <timvp@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

4a74427e

Suppress VulkanPerformanceCounterTest::DepthStencilTextureClearAndLoad · 89653b97

authored Nov 11, 2020

The test
VulkanPerformanceCounterTest::DepthStencilTextureClearAndLoad() is flaky
on the Windows AMD bots, so suppressing for now.

Bug: angleproject:5329
Test: VulkanPerformanceCounterTest.DepthStencilTextureClearAndLoad
Change-Id: I546cd18e319c0b73554fb3ce1e70c75be2168015
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2532703
Commit-Queue: Tim Van Patten <timvp@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

89653b97

Improve stack backtraces on Linux. · 2edec864

authored Oct 25, 2020

This switches the Linux crash handler to use addr2line when it
is available. Addr2line is much better at converting addresses
into readable information. The downside is that we must use a
system call to a binary since it's not easy to integrate with
addr2line source.

Bug: angleproject:5239
Change-Id: I13cbaa4ba30166718fb12d924c76ba4f2675453c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2515265Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>

2edec864

Vulkan: Enable async feature in end2end_tests. · 38016632

authored Nov 11, 2020

This adds a new async-command-queue-enabled config that we run against
most of the GLES tests in angle_end2end_tests. The tests now test
both with and without the threaded command queue.

Bug: b/172704839
Change-Id: Ife75f8328f23ac150cddf8ad8a6c4b8fc2d83986
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2532655Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

38016632

Revert "Vulkan: Let shader use rotation specialized constant" · c3607098

authored Nov 11, 2020

This reverts commit 47b3db22.

Reason for revert:
Broke the ANGLE roll into Chromium:
https://chromium-review.googlesource.com/c/chromium/src/+/2531069

[1875/27343] SOLINK ./libGLESv2.so
FAILED: libGLESv2.so libGLESv2.so.TOC 
/b/s/w/ir/cipd_bin_packages/cpython/bin/python "../../build/toolchain/gcc_solink_wrapper.py" --readelf="readelf" --nm="nm"  --sofile="./libGLESv2.so" --tocfile="./libGLESv2.so.TOC" --output="./libGLESv2.so" -- ../../third_party/llvm-build/Release+Asserts/bin/clang++ -shared -Wl,-soname="libGLESv2.so" -Wl,--fatal-warnings -Wl,--build-id -fPIC -Wl,-z,noexecstack -Wl,-z,relro -Wl,-z,defs -Wl,--as-needed -fuse-ld=lld -Wl,--color-diagnostics -Wl,--no-call-graph-profile-sort -m64 -Werror -nostdlib++ --sysroot=../../build/linux/debian_sid_amd64-sysroot -L../../build/linux/debian_sid_amd64-sysroot/usr/local/lib/x86_64-linux-gnu -L../../build/linux/debian_sid_amd64-sysroot/lib/x86_64-linux-gnu -L../../build/linux/debian_sid_amd64-sysroot/usr/lib/x86_64-linux-gnu -Wl,-rpath=\$ORIGIN -Wl,--export-dynamic -Wl,-rpath=\$ORIGIN -o "./libGLESv2.so" @"./libGLESv2.so.rsp"
ld.lld: error: undefined symbol: sh::TranslatorVulkan::GetDriverUniformFlipXYRef(sh::TVariable const*)
>>> referenced by RewriteDfdy.cpp:134 (../../third_party/angle/src/compiler/translator/tree_ops/RewriteDfdy.cpp:134)
>>>               translator/RewriteDfdy.o:(sh::(anonymous namespace)::Traverser::visitUnaryWithRotation(sh::Visit, sh::TIntermUnary*)) in archive obj/third_party/angle/libtranslator.a
>>> referenced by RewriteDfdy.cpp:200 (../../third_party/angle/src/compiler/translator/tree_ops/RewriteDfdy.cpp:200)
>>>               translator/RewriteDfdy.o:(sh::(anonymous namespace)::Traverser::visitUnaryWithoutRotation(sh::Visit, sh::TIntermUnary*)) in archive obj/third_party/angle/libtranslator.a

ld.lld: error: undefined symbol: sh::TranslatorVulkan::GetDriverUniformFragRotationMatrixRef(sh::TVariable const*)
>>> referenced by RewriteDfdy.cpp:136 (../../third_party/angle/src/compiler/translator/tree_ops/RewriteDfdy.cpp:136)
>>>               translator/RewriteDfdy.o:(sh::(anonymous namespace)::Traverser::visitUnaryWithRotation(sh::Visit, sh::TIntermUnary*)) in archive obj/third_party/angle/libtranslator.a
clang: error: linker command failed with exit code 1 (use -v to see invocation)


Original change's description:
> Vulkan: Let shader use rotation specialized constant
>
> If use rotation specialized constant is enabled via compiler options,
> this CL will use rotation specialized constant to generate flipXY,
> rotation matrix and negFlipXY. This allows the driver to optimize for
> the minimum instructions for rotation.
>
> Bug: b/171750979
> Change-Id: I9851ac999d4d35b9f230f796e5445bca0dcb1e77
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2514773
> Commit-Queue: Charlie Lao <cclao@google.com>
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> Reviewed-by: Ian Elliott <ianelliott@google.com>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Reviewed-by: Tim Van Patten <timvp@google.com>

TBR=ianelliott@google.com,timvp@google.com,syoussefi@chromium.org,jmadill@chromium.org,cclao@google.com

Change-Id: Id3976259d1f4049aa62b679ad5b25c2ac337c92b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: b/171750979
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2532702Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>

c3607098

Revert "Created test and fixed texture storage bug in d3d11" · 246de6ba

authored Nov 11, 2020

This reverts commit 03f3ba5b.

Reason for revert: Suspected for causing Dawn tests failure:
SharedImageGLBackingProduceDawnTest.Basic

https://chromium-review.googlesource.com/c/chromium/src/+/2530246

Original change's description:
> Created test and fixed texture storage bug in d3d11
>
> Bug: b/172489285
> Change-Id: If7d88cf50d99da3380082c60fb3936ae0b20c4e5
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2519876
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Reviewed-by: Geoff Lang <geofflang@chromium.org>
> Commit-Queue: Jamie Madill <jmadill@chromium.org>

TBR=geofflang@chromium.org,jmadill@chromium.org,vantablack@google.com

Change-Id: Ic0be42e070c9b9b986b724d2aa74cfdeff375245
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: b/172489285
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2532654Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

246de6ba

Roll Chromium from 902580740a6e to ca966cfbaa65 (459 revisions) · 4849da87

authored Nov 11, 2020

https://chromium.googlesource.com/chromium/src.git/+log/902580740a6e..ca966cfbaa65

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/3514e7b890..9ba508af67
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/7d4fe53baa..94f020f403
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..994d3835f5
* tools/skia_goldctl/linux: O3XpMr3WCt1GviS8wGsldM7NCVb2wabpHx0lJZEemjIC..F1V3MxURYBy3ZkQCqWrW-_qo1aZFer1oyHdGOjT_CZoC
* tools/skia_goldctl/mac: 9ofAReQA7h1bDa9kU-Rmr4_0AEQli7Pnj3lsid5AisAC..Z_FxtkL4vnfqaGkZhy2qkTcVwRXIfMzIP0gDJO5O6HkC
* tools/skia_goldctl/win: lSgrnuo5FQl_aJkQyR7BSuMSrKb37G40wPe4xQBmTnEC..qZ2Cb5DPSSKjIrxhfYGgVzooq2ElNVLxNOVjsMKgfV0C
No update to Clang.

Bug: None
Tbr: timvp@google.com
Change-Id: Iab2aced9fb42ff181c31c41f5a55e6147712cce1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2531461Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

4849da87

Vulkan: Let shader use rotation specialized constant · 47b3db22

authored Nov 02, 2020

If use rotation specialized constant is enabled via compiler options,
this CL will use rotation specialized constant to generate flipXY,
rotation matrix and negFlipXY. This allows the driver to optimize for
the minimum instructions for rotation.

Bug: b/171750979
Change-Id: I9851ac999d4d35b9f230f796e5445bca0dcb1e77
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2514773
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

47b3db22

10 Nov, 2020 12 commits

Vulkan: Remove hasPrimaryCommands(). · 8a90378c

authored Nov 07, 2020

We now create empty primary command buffers when there are
no existing commands to submit. The main reason to remove this
is so that we don't have to make a synchronous call to
CommandQueue or the async command processor to determine if there
are queued primary commands.

Bug: b/172704839
Change-Id: I53f65eaa187b618e4ed82a5d2805a76e6a9e036c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2524547
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>

8a90378c

Created test and fixed texture storage bug in d3d11 · 03f3ba5b

authored Nov 04, 2020

Bug: b/172489285
Change-Id: If7d88cf50d99da3380082c60fb3936ae0b20c4e5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2519876Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

03f3ba5b

Vulkan: Add specialization constants for surface rotation · b22f8e8e

authored Oct 29, 2020

This plumbing through the specialization constant for surface rotation
from ContextVk to pipeline program creation. It has not been used yet,
so expecting no real functional change. This CL also converts
lineRasterEmulation to use the same specialization constant path as
surface rotation.

Bug: b/171750979
Change-Id: Ic08c4f8bb576424d1752015e874d0977a58d78bb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2508837
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

b22f8e8e

Vulkan: Move CommandQueue to CommandProcessor.h. · 9d65420c

authored Nov 07, 2020

This will facilitate moving this class from the ContextVk to
RendererVk. Also cleans up some redundant vk:: prefixes.

Bug: b/172704839
Change-Id: I789c9984c0df7fc376e2373530e48afde354d30b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2524546
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>

9d65420c

Add tests to show bad waitSync/flush behavior · 8305ebd4

authored Nov 03, 2020

Add the following tests to show ANGLE's poor behavior with
glWaitSync/glFlush leading to a vkQueueSubmit each time:

FenceSyncTest::MultipleFenceDraw
MultithreadingTestES3::MultithreadFenceDraw
MultithreadingTestES3::MultithreadFenceTexImage

Bug: angleproject:5306
Test: FenceSyncTest::MultipleFenceDraw
Test: MultithreadingTestES3::MultithreadFenceDraw
Test: MultithreadingTestES3, MultithreadFenceTexImage
Change-Id: I16f653af028677e3c621c3b9a7fd5963fa03d656
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2519092Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>

8305ebd4

Vulkan: Merge command paths in submitFrame. · 9a0284e8

authored Nov 07, 2020

This makes the CommandQueue and CommandProcessor paths nearly the
same in submitFrame. The end goal is to make them take identical
input parameters.

Bug: b/172704839
Change-Id: If3ef2752534de1c3dcaefa5730b308aea46e549e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2524545
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>

9a0284e8

Vulkan: Support VK_KHR_image_format_list for RenderBuffers · a391674c

authored Nov 09, 2020

RenderBuffers are now created with VK_KHR_image_format_list
extension support enabled. We only enable those tests where
the EGL image's source is a RenderBuffer but not those tests
where the EGL image's target is a RenderBuffer. There are some
corner cases related to glReadPixles that need to be resolved
to unblock those tests.

Bug: angleproject:3756
Bug: angleproject:5281
Test: ImageTest.SourceRenderbuffer*Vulkan
Change-Id: I643a9d74d14473cc7df59fa6e25acab7d1c9aad1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2528475Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>

a391674c

Capture/Replay: Split into separate shared libaries. · 98035e11

authored Nov 09, 2020

This will produce several smaller shared libs rather than one very
large one. Involves moving the trace loader to its own shared module
as well. Because the traces didn't have export labels on most of the
affected functions I had to use a "force include" argument on the
compiler. We can remove this once we re-capture.

This is a first step towards testing one trace at a time on an Android
device.

Includes a complete set of new regenerated traces.

Bug: angleproject:5133
Change-Id: If984de34af21fce48b0832401dbe5aa4b002ce95
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2506199
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Ian Elliott <ianelliott@google.com>

98035e11

Roll Vulkan-Tools from bd0ebb680792 to df1edd1738a6 (1 revision) · 9828732b

authored Nov 10, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/bd0ebb680792..df1edd1738a6

2020-11-09 orbea@riseup.net cmake: Silence warnings.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-tools-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: timvp@google.com
Change-Id: I35a029c0a87cdc8c33f40bc38b3d05424075f00e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2528183Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

9828732b

Roll Chromium from 61aafe6377ea to 902580740a6e (438 revisions) · a89c6b9a

authored Nov 10, 2020

https://chromium.googlesource.com/chromium/src.git/+log/61aafe6377ea..902580740a6e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/6dd14a4537..3514e7b890
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/2de3a18349..7d4fe53baa
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..434681c237
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/192a0edbbe..a37c0858a6
No update to Clang.

Bug: angleproject:5305
Tbr: timvp@google.com
Change-Id: I2abb73a82e6b3b12ad6b7efe50532ba920ac2b8f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2527572Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

a89c6b9a

Vulkan: Fix PBO assuming color images · 36787dcb

authored Nov 04, 2020

Bug: b/172354898
Change-Id: I777eaa33ddac853492d38a03c16caeddad0c2d16
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2520108
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Ian Elliott <ianelliott@google.com>

36787dcb

Vulkan: Bug fix in texture respecification code · 72001c7d

authored Nov 07, 2020

When a target texture is created from an EGL image, respecification
of the texture needs to take into account the fact that it din't own
the ImageHelper. Refactor copy and stage code to account for this
possibility as well.

Bug: angleproject:3756
Bug: angleproject:5281
Test: ImageTest.Source2DTarget2DTargetTextureRespecify*
Change-Id: I2e3bd5d1d64e85da521a841423cfe24673efe88f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2524703
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

72001c7d

09 Nov, 2020 14 commits

Vulkan: Move ExtensionNameList out of the class. · 528ae31e

authored Nov 08, 2020

Mostly a consistency change where now the list never needs to be
prefixed with RendererVk:: and always prefixed with vk::.

Also we can respect the style guide's member ordering suggestion.

Bug: b/172704839
Change-Id: I758bf324573e5585be6842b3455feab0c23c9d4a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2525142Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

528ae31e

Vulkan: Move primary command buffer to CommandQueue. · c8a7c033

authored Nov 07, 2020

This brings CommandQueue one step closer to the worker thread.

Bug: b/172704839
Change-Id: I35225c5f302e34e3feb38a35c22b6d8e6f4ad10c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2524543Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

c8a7c033

Traces: Use 4 download threads. · 580b775f

authored Nov 09, 2020

This should significantly speed up checkout on dev machines.

Bug: angleproject:5133
Change-Id: Iba20182c600ea8e17de47bb4e84b2e4191d301d3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2527721Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

580b775f

Perf Tests: Trace multiple threads. · 489f2c83

authored Nov 06, 2020

This uses a little helper list to map thread IDs into simple serials
that we output as 'tid' in our trace JSON file. We can use this to
analyze the behaviour of the command processor thread.

Bug: b/172704839
Change-Id: Ic1b5f3ec8427cb310833d1f589503daec4812681
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2524542
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

489f2c83

Vulkan: Make feature names consistent. · 2e74c452

authored Nov 06, 2020

This gives the features the exact same name as the member variable.
It fixes a bunch of inconsistencies between the variable name and the
external string identifier.

Ideally these could be auto-generated from JSON.

Bug: b/172704839
Change-Id: Id75c01db544672234435c3dd727c927027b9236d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2524541Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

2e74c452

Fix expectations file for prerotation dEQP executables · 3806696c

authored Nov 06, 2020

Bug: angleproject:4901
Change-Id: Ibc930a27887a3ba710168a9b122d46aac1530984
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2523548Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

3806696c

Vulkan: Rewrite interpolateAtOffset to account for Y-flip · 34130c2e

authored Nov 07, 2020

In order to fully suppot OES_shader_multisample_interpolation
rewrite interpolateAtOffset's offset parameter to account for
Y-coordinate flip.

Bug: angleproject:3589
Tests: dEQP-GLES31.functional.shaders.multisample_interpolation.
        interpolate_at_offset.*.default_framebuffer
Change-Id: I6bf72ceb1c0466ff5d4a92b72d1ec9e2552d6f2a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2524711
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

34130c2e

Fix trace writing in angle_perftests. · 06eaaac5

authored Nov 06, 2020

We can use this to produce AGI-like reports in standalone desktop.

Bug: b/172704839
Change-Id: Ifc510232e3da81210e22429b6cea9800e2723e06
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2524540Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

06eaaac5

Vulkan: Support VK_KHR_image_format_list for AHB backed EGL image · a5e0a4bc

authored Nov 08, 2020

AHB backed EGL images create the VkImage through external sibling
images. Create those images with VK_KHR_image_format_list extension
support enabled.

Bug: angleproject:3756
Bug: angleproject:5281
Test: angle_end2end_tests.exe
          --gtest_filter=ImageTest*SourceAHB*Colorspace*Vulkan
Change-Id: I28c22f9d2f2423daa9228e4d42772b380ab7b8b9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2525109Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>

a5e0a4bc

Vulkan: add explicit template specialization for barrierImpl · eaab2e34

authored Nov 09, 2020

ImageHelper::barrierImpl with secondary command buffer is used in
other translation units. Linking fails if compiler has optimized
out symbol for secondary command buffer.

Bug: angleproject:5324
Change-Id: I588d0d949a9b2eee04d8103effc485ab23d679c6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2526082Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

eaab2e34

Vulkan: Add EXT_external_buffer entry points · 9217d49d

authored Nov 08, 2020

Addition of the entry points for EXT_external_buffer extension.

Bug: angleproject:5073
Change-Id: I5dc9f74dfd68c1e83e17ca15166df4cd4c20fca2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2525104
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

9217d49d

Roll SwiftShader from 612ded0654a0 to 4ed9d3498dcf (2 revisions) · 40c5e53e

authored Nov 09, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/612ded0654a0..4ed9d3498dcf

2020-11-06 vhau@google.com Modify gralloc0 implementation
2020-11-06 jaebaek@google.com SpirvShaderDebugger: Correct member index for DebugValue

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: courtneygo@google.com
Change-Id: I1ecdb3394c4fe8c52c3f09ab03ccbe178c495fcf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2526363Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

40c5e53e

Roll Vulkan-Headers from 87451c55aa8b to 670ffea9d61b (1 revision) · 2e236c33

authored Nov 09, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/87451c55aa8b..670ffea9d61b

2020-11-09 oddhack@sonic.net Update for Vulkan-Docs 1.2.160

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-headers-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Change-Id: Ia6d4d889cf62e7dc38a9fcb6de223fb256f21bbd
Bug: None
Tbr: courtneygo@google.com
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2525861Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

2e236c33

Roll Chromium from 52d33a46255e to 61aafe6377ea (506 revisions) · 46f5f438

authored Nov 09, 2020

https://chromium.googlesource.com/chromium/src.git/+log/52d33a46255e..61aafe6377ea

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/dc348c17b4..6dd14a4537
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/c8d7f9564e..2de3a18349
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/2d8c1340f0..0fe1450acb
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..434681c237
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/df43926725..aa9ff5db33
* tools/skia_goldctl/linux: GVpht0r-QjWXa70RBjnj16oVOukePZsPqR9WjoyczEQC..O3XpMr3WCt1GviS8wGsldM7NCVb2wabpHx0lJZEemjIC
* tools/skia_goldctl/mac: E1HzztCcEvl2qwMi8jlWEeRipywovPX1tvzNMap-XFgC..9ofAReQA7h1bDa9kU-Rmr4_0AEQli7Pnj3lsid5AisAC
* tools/skia_goldctl/win: DsHjiYrgPxP5IjJ3QDF-DgcQwV_lMq60ESSU1CwXBSkC..lSgrnuo5FQl_aJkQyR7BSuMSrKb37G40wPe4xQBmTnEC
No update to Clang.

Bug: None
Tbr: courtneygo@google.com
Change-Id: If41692440b822876d6e49350b507daac47fa0e6f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2525680Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

46f5f438

08 Nov, 2020 1 commit

Gold Trace Tests: Fix JSON output with empty test set. · d4439824

authored Nov 08, 2020

Previously we would leave an empty test suite name with no tests run.
According to the JSON test results spec this is likely a malformed
output and we should instead include just an empty "tests" key.

Bad:

"tests": {
  "angle_restricted_trace_gold_tests": {}
}

Good:

"tests": {}

Bug: angleproject:5299
Change-Id: I459da593df150d804130f9c63e05d031e77a16a3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2525147Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

d4439824

07 Nov, 2020 1 commit

Fix return value of cube map array imageStore. · aca3d408

authored Nov 05, 2020

Should be void according to the spec. Noticed while working on texture
buffer.

Bug: angleproject:3584
Change-Id: I79a671c82fa117bab69bc2e6b35c840aa30429c5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2521241
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

aca3d408