Commits · 69ca1982c18e8abe3b60c745dc548ed4e33c1c8e · Chen Yisong / angle

03 Jul, 2020 5 commits

Roll glslang from 57002d0447df to 4728509962e6 (5 revisions) · 69ca1982

authored Jul 03, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/57002d0447df..4728509962e6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ianelliott@google.com
Change-Id: Iaba10389e92c8dcf647677b7b76d5eb087148d19
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2280826Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

69ca1982

Roll SPIRV-Tools from fba90d6b0a23 to 2c1ff230c26d (2 revisions) · c6a12971

authored Jul 03, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/fba90d6b0a23..2c1ff230c26d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ianelliott@google.com
Change-Id: I6150a2e88d63d09535cf100567884997ef60d83f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2280825Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

c6a12971

Roll SwiftShader from 2d6b37bbda59 to 3121585acce2 (2 revisions) · d561f468

authored Jul 03, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/2d6b37bbda59..3121585acce2

2020-07-02 sugoi@google.com ASTC Decoder: Trim unused struct members
2020-07-02 capn@google.com Fix /DEBUG:FASTLINK usage

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ianelliott@google.com
Change-Id: Ib62019d73da7b873ef816ec2ac469651cbceec55
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2280823Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

d561f468

Convert GN libs lists to frameworks · bae95f81

authored Jul 02, 2020

GN recently added support for Apple frameworks to link, rather than
overloading the libs lists. This pulls .frameworks out of the libs
lists, so that GN can stop supporting .frameworks in libs in the
future.

Bug: chromium:1052560
Change-Id: I3aed298db01bdb5f6e7f37a74c1bbc06f99d760c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2279931Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

bae95f81

Vulkan: Create sRGB views only when needed · cbdb76b0

authored Jul 02, 2020

Creating sRGB views was conditioned to
VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT being necessary, but that flag can be
set for reasons other than sRGB override, such as when recreating the
image to be used as a storage image.

Bug: angleproject:4551
Change-Id: I6f94a1c898b599d4333d74608c7451b4ce4f71f0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2279134Reviewed-by: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

cbdb76b0

02 Jul, 2020 9 commits

Add missing data deps to angle test executables. · a86c8547

authored Jul 02, 2020

Currently the Chromium build defines some wrapper test
targets for ANGLE (//chrome/test:angle_perftests
and //chrome/test:standalone_angle_unittests) that seem to
exist only to specify some extra data dependencies. By moving
those data dependencies into angle, this removes a couple of
targets in Chromium that are otherwise problematic for
my planned changes for crbug.com/816629.

Bug: chromium:816629
Change-Id: Ic0d50132f102f39749c92b062eec38a529db2c1b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2280255Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>

a86c8547

Add end2end test for readonly feedbackloop · 89c88559

authored Jun 20, 2020

Bug: angleproject:4778
Test: ./angle_end2end_tests --gtest_filter=ReadOnlyFeedbackLoopTest*
Change-Id: I1c2500395d261c1686e5d325aad173462311c8c3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2252543Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>

89c88559

Serialize framebuffers + compare contexts for CaptureReplayTests · dce37b7d

authored Jun 21, 2020

Adds to frame capture the ability to serialize a frame's pre-swap
GL state and store it in the binary data file
Adds to CaptureReplayTests the ability to compare its serialized GL
state with the serialized state pulled from the binary data file
Adds a serialization module that serializes framebuffers' GL states
and the contents of their color attachments
Adds checks to automation script so that it would skips tests that
do not produce the expected trace files
Adds exception handling to automation script so that it will not crash
when a replay build crashes

Bug: angleproject:4779
Change-Id: I40a02e018073749e79f0ddbfd3d4065745548f46
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2258295
Commit-Queue: Manh Nguyen <nguyenmh@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

dce37b7d

Fix CopyTexture3D test to remove Nvidia workaround · 5fec8ecf

authored Jul 02, 2020

Bug: angleproject:4748
Change-Id: I8e66fda3c9fd234451ad765c8777cd75b4fc44fc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2279136Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

5fec8ecf

Vulkan: Cleanup extension properties and features · 65f7ab79

authored Jul 02, 2020

Bug: angleproject:4551
Change-Id: Iae6b94027cfaca6c72318203a286865c2e3b19a9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2279133Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

65f7ab79

Vulkan: Featurize shadow buffers · 62ff54eb

authored May 12, 2020

Shadow buffers help reduce the latency of glMap* operations
at the cost of CPU overhead. It might not be desirable to
incur such an overhead for all usecases. Featurize it but
enable it by default.

Bug: angleproject:4339
Change-Id: I6374618bf99677eef55fd50a139fb86f5ea70791
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2278102Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>

62ff54eb

Vulkan: Use mipmap hint when generating mipmaps · cf63d872

authored Jul 02, 2020

If the application asks for GL_FASTEST, this uses VK_FILTER_NEAREST
instead of VK_FILTER_LINEAR.

Bug: angleproject:4551
Change-Id: I6c10758104bd63dd477ea853a3b0464665f371ed
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2279132Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

cf63d872

Roll Vulkan-ValidationLayers from 7ff733fd65d7 to bda422c594d4 (5 revisions) · 45c22722

authored Jul 02, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/7ff733fd65d7..bda422c594d4

2020-07-01 s.fricke@samsung.com tests: Fix AHB Test not covering 02251
2020-07-01 s.fricke@samsung.com layers: Fix YCbCr Format VUIDs
2020-07-01 tony@lunarg.com gpu: Remove incorrect descriptor set requirement
2020-07-01 tony@lunarg.com layers: Add more custom border color checks
2020-07-01 tony@lunarg.com gpu: Handle destroyed pipeline layout

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ianelliott@google.com
Change-Id: Ib75dad0044e758e221687da3e88fca4f9d3e09e1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2278879Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

45c22722

Roll glslang from dca47063ccd2 to 57002d0447df (8 revisions) · cf107ade

authored Jul 02, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/dca47063ccd2..57002d0447df

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ianelliott@google.com
Change-Id: Ifce7b8aa2c0ebdcf51b10cebc8aa5d09c8647792
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2278881Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

cf107ade

01 Jul, 2020 6 commits

Broaden EGLFeatureControlTest Linux AMD suppression · cbcc500f

authored Jun 26, 2020

After the initial suppression the bot started failing on the next test.
Use GTEST_SKIP in testSetUp to make all tests using the fixture skipped.

Bug: chromium:1097750
Change-Id: Ic993d7cd274e1328684571c5ba1a1520b9cb80d5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2270020Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

cbcc500f

Roll SwiftShader from b3240d0c355a to 2d6b37bbda59 (2 revisions) · 2cc63fef

authored Jul 01, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/b3240d0c355a..2d6b37bbda59

2020-07-01 pcc@google.com Start reserving x18 by default on Android targets.
2020-06-30 srisser@google.com Fix debug assert from happening in release build

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ianelliott@google.com
Change-Id: I5c881031b6b3d80dba723cf1d8894b53cc268b65
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2277609Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

2cc63fef

Update JsonCpp usage · 1265dbe6

authored Jun 24, 2020

This patch updates usages of the JsonCpp library, including the
following changes:

1. Removed unused version variable from the DEPS file.
2. Removed deprecated writer and reader usages, in favor of the new
   builder pattern inside JsonCpp.
3. Modernized usage of the Json::Value types, including some rewrites to
   avoid unnecessary heap allocations, and using the new foreach
   iterators.

Bug: chromium:983223
Change-Id: If26abc8be677d905183a23498fbb81256854525c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2265093Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

1265dbe6

Roll Vulkan-ValidationLayers from 7c1434b8ea35 to 7ff733fd65d7 (6 revisions) · 8804d35c

authored Jul 01, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/7c1434b8ea35..7ff733fd65d7

2020-06-30 s.fricke@samsung.com tests: Add VUID 00995
2020-06-30 s.fricke@samsung.com layers: Add VUID 00995
2020-06-30 s.fricke@samsung.com tests: Add External Import handleType VUIDs
2020-06-30 s.fricke@samsung.com layers: Add External Import handleType VUIDs
2020-06-30 s.fricke@samsung.com tests: Add maxExtent VUIDs
2020-06-30 s.fricke@samsung.com layers: Add maxExtent VUIDs

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ianelliott@google.com
Change-Id: I33b0595c9df6d768071232dca19cf995d706c902
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2277610Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

8804d35c

Roll SPIRV-Tools from fc0dc3a9c734 to fba90d6b0a23 (2 revisions) · 518a1e33

authored Jul 01, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/fc0dc3a9c734..fba90d6b0a23

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ianelliott@google.com
Change-Id: I7f1698096e261c70e9a2fa7680416a4ebf77d517
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2277611Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

518a1e33

Vulkan: Update "fragment_ops" failures on Android · d2ca995f

authored Jun 30, 2020

A Qualcomm driver bug causes certain
"dEQP-GLES3.functional.fragment_ops*" tests to fail.  On Pixel 4 XL,
this only occurs when the device is rotated 90 or 270 degrees.

Bug: angleproject:4344
Bug: b/157933198
Change-Id: Iedb7e8c76fbe55795537cab3e821a410899fdea3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2277103Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>

d2ca995f

30 Jun, 2020 15 commits

Disable the use of chromium worker threads · 2761f01d

authored Jun 30, 2020

The use of worker thread is chromium is triggering CFI error.

This CL disables the use of chromium worker pool to avoid
blocking the roll-deps:
  https://chromium.googlesource.com/angle/
      angle.git/+log/1be395fe..a935c65a

The intend is to avoid the effects of the fix from that CL:
  https://chromium-review.googlesource.com/c/angle/angle/+/2262573
Instead of reverting the CL (with is an obvious mistake) we disable
the feature.

Bug: chromium:1091259
Change-Id: I4e473ec42be2a82e47e2e4c882f75ba33bcd9476
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2275730Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>

2761f01d

Fix blendable FP32 texture caps on ES2 contexts · 1ae8d2dd

authored Apr 29, 2020

Although the EXT_float_blend extension is defined only for ES 3.0+,
ANGLE exposes it on ES 2.0 client contexts.

Bug: angleproject:4595
Change-Id: I7451062ed8b1ab4eb18a8c7c1d37ee7383c8ea4b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2172738
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

1ae8d2dd

Vulkan: Fix off-by-1 180/270-rotated CopyTexImage · 28300e6f

authored Jun 30, 2020

The rotation calculations are a little different for this code (that
uses a special shader) than for other pre-rotation cases. I also
modified the CopyTexImageTestES3.2DArraySubImage test to make future
bugs a little easier to diagnose.

Test: Test: angle_end2end_tests --gtest_filter=*CopyTexImageTestES3.2DArraySubImage*Vulkan*
Test: Test: angle_end2end_tests --gtest_filter=*WebGLReadOutsideFramebufferTest.CopyTexSubImage2D*Vulkan*
Bug: b/158245571
Change-Id: I497ec541cae5cd4085c3e9d596ee20943f5510f9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2275733Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Ian Elliott <ianelliott@google.com>

28300e6f

Vulkan: Don't store transformed SPIR-V · 68e60a92

authored Jun 26, 2020

Since the original SPIR-V is never store after being modified, we don't
need to keep the transformed SPIR-V either.

Bug: angleproject:4513
Test: CQ
Change-Id: I4b70cfa355a08107e6a27377f6258cbf9e4072be
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2270718
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

68e60a92

Tests: Add scripts/common.py to standalone data. · 4f2fb80b

authored Jun 30, 2020

This file is needed by the bots to run as an isolated script.

Bug: angleproject:3162
Change-Id: I1bb87b3622613334b379896a3c124a6007676346
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2275729Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

4f2fb80b

Vulkan: Skip repeated VkCmdClear call with the same value · 34eb401b

authored Jun 19, 2020

Some apps actually do this. One of them is gfxbench. This helps
performance by dropping the redundant clear calls.

Bug: b/159489614
Change-Id: Ib7958042f081b8fd58c5bc912fbb45bb223aec0f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2255643Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Charlie Lao <cclao@google.com>

34eb401b

Roll Vulkan-ValidationLayers from d8b1aa1c3830 to 7c1434b8ea35 (19 revisions) · a52834d8

authored Jun 30, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/d8b1aa1c3830..7c1434b8ea35

2020-06-29 szilard.papp@arm.com practices: Adding test for robustBufferAccess
2020-06-29 szilard.papp@arm.com practices: Adding check for robustBufferAccess
2020-06-29 s.fricke@samsung.com layers: Label VUID 02251
2020-06-29 s.fricke@samsung.com tests: Add VK_EXT_astc_decode_mode
2020-06-29 s.fricke@samsung.com layers: Add VK_EXT_astc_decode_mode
2020-06-29 s.fricke@samsung.com layers: Add HDR ASTC formats
2020-06-29 tony@lunarg.com tests: Fix unexpected custom border color error
2020-06-29 mark@lunarg.com chassis: Fix inadvertant StateTracker VO state-sharing
2020-06-29 rgarcia@igalia.com corechecks: Use all locations for samplerYcbcrConversion
2020-06-29 dev@kikijiki.com docs Add reference to the --dir option
2020-06-29 dev@kikijiki.com docs: Fix CMake update_deps/build instructions
2020-06-29 rgarcia@igalia.com Use conversion format in some Ycbcr conversion VUs
2020-06-29 jeremyk@lunarg.com layers: Fix vkCmdTraceRaysKHR VUID Mixup
2020-06-29 mark@lunarg.com docs: Update CONTRIBUTING.md with some new details
2020-06-29 mark@lunarg.com docs: Added message limit to layer settings file
2020-06-29 mark@lunarg.com tests: Add duplicate message limit test
2020-06-29 mark@lunarg.com chassis: Add config steps for reading dup msg limits
2020-06-29 mark@lunarg.com layers: Add duplicate message limit infrastructure
2020-06-29 mark@lunarg.com corechecks: Prevent null ptr access for GetSwapchainImages

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ianelliott@google.com
Change-Id: I26203dd98b05ed2a6ee3462951cb66990faac121
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2274687Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

a52834d8

Roll SPIRV-Tools from 91c50e3fc993 to fc0dc3a9c734 (1 revision) · 98a51fde

authored Jun 30, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/91c50e3fc993..fc0dc3a9c734

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ianelliott@google.com
Change-Id: I6d7b48346be2b9323631b74b558f2d3fc5b675ab
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2275630Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

98a51fde

Restrict member types for StructuredBuffer · d1bf23d7

authored Jun 23, 2020

Std140 storage layout has some rules for uniform block, must
pad StructuredBuffer element type explicitly to match std140
layout rules when translating std140 uniform block to
StructuredBuffer. In this CL, restrict member types which are
not needed to add paddings according std140 layout rules.

Bug: angleproject:4783
Change-Id: I50130da64ad6865083849bf55b76525f3d2835a8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2259226
Commit-Queue: Xinghua Cao <xinghua.cao@intel.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jiajia Qin <jiajia.qin@intel.com>

d1bf23d7

Roll Vulkan-Tools from ff825d988fe8 to abc9dff824c3 (1 revision) · 1f71f41c

authored Jun 30, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/ff825d988fe8..abc9dff824c3

2020-06-29 jeremyk@lunarg.com build: Update MoltenVK version in known-good.json

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-tools-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ianelliott@google.com
Change-Id: Ie846df10da5613342d65cbc17b2ebccca6c8ddc1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2274688Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

1f71f41c

Roll glslang from 27e915ed4f20 to dca47063ccd2 (2 revisions) · d7d187d1

authored Jun 30, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/27e915ed4f20..dca47063ccd2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ianelliott@google.com
Change-Id: I86e12ab8e9ef5220362635b5f078cdffe02a2850
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2274689Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

d7d187d1

Vulkan: Only transform SPIR-V once · 774cd1b2

authored Jun 25, 2020

Prior to this change, the SPIR-V would be transformed as part of
GlslangGetShaderSpirvCode() and then possibly another time afterward to
disable the early fragment test optmization (for monolithic programs) or
to update the descriptor set/binding values (for PPOs). By storing the
original SPIR-V in the ProgramVk and the transformed SPIR-V in the
ProgramExecutableVk, we can now remove the SPIR-V transformation from
GlslangGetShaderSpirvCode() and only perform it once in
ProgramInfo::initProgram() for monolithic programs and PPOs.

Bug: angleproject:4513
Test: CQ
Change-Id: I4e7240b2abe7c796c46cf531948dad0e37c1419a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2267537
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

774cd1b2

Skip failing test on NVIDIA Shield · 8ea72e86

authored Jun 29, 2020

Bug: chromium:1100613
Change-Id: I1e05b2b7829ee790f878bf99976310c8a697faa2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2274520Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

8ea72e86

Add a test for copying from one mip to another · 06462add

authored Jun 04, 2020

Bug: angleproject:2914
Change-Id: Ib39f8599a613cbb85688c230cf8a72e23d8e1c1c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2231618
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>

06462add

Vulkan: Store transformed SPIR-V in ProgramExecutableVk · 7993f34d

authored Jun 24, 2020

The original SPIR-V is specific to a ProgramVk while the transformed
SPIR-V is specific to a ProgramExecutableVk. This CL keeps the original
SPIR-V in the ProgramVk::mOriginalShaderInfo and the transformed SPIR-V
in ProgramExecutableVk::mTransformedShaderInfo. This allows us to skip
an extra copy that was occurring during PPO link().

Bug: angleproject:4513
Test: CQ
Change-Id: I796dcd6bcfb2df08d9b8f1a5295b2821a4096f16
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2265484
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

7993f34d

29 Jun, 2020 5 commits

Fix disable_native_parallel_compile workaround condition. · e2de2c1c

authored Jun 25, 2020

This workaround should only be enabled when ANGLE is built with TSAN
on.

Bug: chromium:1094869
Change-Id: If527457c11ce744b543ac69761cc64235d2f1dd8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2267420Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>

e2de2c1c

Refactor frame_capture_utils.h to frame_capture_test_utils.h · bdf91e5f

authored Jun 29, 2020

frame_capture_utils.h is only used in tests so changing the name to be
frame_capture_test_utils.h is more appropriate. Also
frame_capture_utils.h will now be a file in libANGLE_with_capture
library where serialization code is stored.

Bug: angleproject:4806
Change-Id: I7482693a75b2d0edda7e84ae9b777fd3f46f1855
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2273917
Commit-Queue: Manh Nguyen <nguyenmh@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

bdf91e5f

Vulkan: Set new layout based on VkImageUsageFlags · 58ff77a8

authored Jun 27, 2020

When transferring vkImages between queues, the new layout
needs to be set based on the usage flags of the vkImage
instead of hardcoding it to AllGraphicsShadersReadWrite

Bug: angleproject:4791
Change-Id: I3b543a6280e6c2317cc11bf65dc4c337bc5f90b1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2271563
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

58ff77a8

Vulkan: Implement invalidate for color buffers · b31a1939

authored Jun 25, 2020

This will set the color buffer load_op to DONT_CARE if the application
has invalidated the color buffers prior to drawing.
Will also set load_op to DONT_CARE for depth & stencil, though this
isn't likely a common use case.

Tests:
    angle_deqp_gles3_tests --gtest_filter=dEQP.GLES3/functional_fbo_invalidate_* --use-angle=vulkan
    angle_end2end_tests --use-angle=vulkan --gtest_filter=StateChangeRenderTestES3.InvalidateNonCurrentFramebuffer/ES3_Vulkan

Bug: b/150458520
Bug: angleproject:4444
Change-Id: I6ce3d20fc1e9f4ab7ba3af9755c5ddc544f58ddd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2267057
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>

b31a1939

Vulkan: Remove superseded updates when flushing to image · b0245f68

authored Jun 23, 2020

Especially with emulated formats and robust resource init, a clear is
staged that's often superseded by a data upload to the same subresource.
This change ensures that superseded updates are dropped to avoid
unnecessary GPU work.

Bug: angleproject:4691
Change-Id: I697ccd438b92fd2fff17a5800550694658c95c54
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2262574
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

b0245f68