Skip to content

A
angle
Switch branch/tag
  1. 19 Feb, 2019 1 commit
  3. 16 Feb, 2019 3 commits
  5. 15 Feb, 2019 7 commits
  7. 14 Feb, 2019 4 commits
  9. 13 Feb, 2019 7 commits
    • Revert "Vulkan: Implement debug markers" · 0c01e367
      Shahbaz Youssefi authored 
      This reverts commit 983e4469.

Reason for revert: Depends on a CL that's reverted: https://chromium-review.googlesource.com/c/angle/angle/+/1470605

Original change's description:
> Vulkan: Implement debug markers
> 
> Covers both GL_KHR_debug and GL_EXT_debug_marker.
> 
> Debug markers are used to specify events or hierarchically categorize a
> set of commands within the command buffer.  When debugging, this allows
> for quicker navigation to the draw calls of interest, and otherwise
> provides context to debug output.
> 
> Bug: angleproject:2853
> Change-Id: Id65e11fc877d9e70b6fd0fae7f0bbbcb1164bf10
> Reviewed-on: https://chromium-review.googlesource.com/c/1403956
> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Reviewed-by: Geoff Lang <geofflang@chromium.org>

TBR=geofflang@chromium.org,jmadill@chromium.org,syoussefi@chromium.org

Change-Id: I7fcfc8683195d396aec61848719f52c0fa049ece
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: angleproject:2853
Reviewed-on: https://chromium-review.googlesource.com/c/1470606Reviewed-by: 's avatarShahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
    • Revert "Roll Vulkan repos" · 3805122b
      Shahbaz Youssefi authored 
      This reverts commit 55ea947c.

Reason for revert: Seems to be causing a memory corruption on Windows/Intel bots.

Original change's description:
> Roll Vulkan repos
> 
> Bug: angleproject:3095
> Change-Id: I6ae9d61304981223f9e2f1869ed32612aa38952c
> Reviewed-on: https://chromium-review.googlesource.com/c/1405714
> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

TBR=ynovikov@chromium.org,jmadill@chromium.org,syoussefi@chromium.org

Change-Id: I61879770c9bb16ac2231b081bda08e6211ba6831
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: angleproject:3095
Reviewed-on: https://chromium-review.googlesource.com/c/1470605Reviewed-by: 's avatarShahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
    • Vulkan: Discard scissored clears where scissor is null · 6fc22a13
      Courtney Goeltzenleuchter authored 
      If a clear becomes a no-op because the scissor has a width and height
of 0, return early and skip the draw.
This also works around a driver issue on some devices where it was
ignoring a null scissor and drawing the clear anyway. Found with deqp
test:
adb shell am start -n com.drawelements.deqp/android.app.NativeActivity \
    -e cmdLine '"deqp --deqp-case=dEQP-GLES2.functional.color_clear.* \
    --deqp-log-filename=/sdcard/dEQP-Log.qpa"'
run_angle_end2end_tests --gtest_filter=ClearTest.EmptyScissor/ES2_VULKAN

Bug: angleproject:3114
Change-Id: I6cf2716bd93bb332f74b44c7250e363c68cc614f
Reviewed-on: https://chromium-review.googlesource.com/c/1436841
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: 's avatarGeoff Lang <geofflang@chromium.org>
    • Vulkan: Implement debug markers · 983e4469
      Shahbaz Youssefi authored 
      Covers both GL_KHR_debug and GL_EXT_debug_marker.

Debug markers are used to specify events or hierarchically categorize a
set of commands within the command buffer.  When debugging, this allows
for quicker navigation to the draw calls of interest, and otherwise
provides context to debug output.

Bug: angleproject:2853
Change-Id: Id65e11fc877d9e70b6fd0fae7f0bbbcb1164bf10
Reviewed-on: https://chromium-review.googlesource.com/c/1403956
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
Reviewed-by: 's avatarGeoff Lang <geofflang@chromium.org>
    • Roll Vulkan repos · 55ea947c
      Shahbaz Youssefi authored 
      Bug: angleproject:3095
Change-Id: I6ae9d61304981223f9e2f1869ed32612aa38952c
Reviewed-on: https://chromium-review.googlesource.com/c/1405714
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: 's avatarYuly Novikov <ynovikov@chromium.org>
    • Disable broken tests on Fuchsia (reland) · d8506c7e
      Michael Spang authored 
      This disables tests that do not work on Fuchsia. Most of them are related
to cube maps which currently crash inside the intel driver.

Reland disabling -Wextra-semi.

BUG=angleproject:2475, angleproject:3145, angleproject:3081
TEST=angle_end2end_tests on Fuchsia

Change-Id: I65ad84f43c88e8ee83c581cc2f41046d00bbae7f
Reviewed-on: https://chromium-review.googlesource.com/c/1467604
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: 's avatarMichael Spang <spang@chromium.org>
    • Vulkan: Port renderer to Fuchsia (reland) · 229fc83d
      Michael Spang authored 
      Add DisplayVk and WindowSurfaceVk subclasses for Fuchsia to the vulkan
renderer, as well as an implementation of OSWindow that renders
fullscreen for the test suite.

Disallow use of the vulkan loader from third_party as Fuchsia uses a fork
of the loader and has not sent those changes upstream yet.

Add a small wayland-inspired library libfuchsia-egl to provide a type
"struct fuchsia_egl_window" to use as EGLNativeWindowType. This type
combines a zx_handle_t to an image pipe channel and a surface size.

Image pipes can only be used once to create a VkSurfaceKHR. This means we
have to recreate the pipe in tests that call eglCreateWindowSurface more
than once with a single OSWindow, or the second call will fail. Add a
resetNativeWindow() method to accomplish this.

Reland disabling -Wextra-semi.

BUG=angleproject:2475
TEST=angle_end2end_tests on Fuchsia

Change-Id: Ie91715bcd760c6c04d4b8a02a91daa71e32ee30c
Reviewed-on: https://chromium-review.googlesource.com/c/1467603
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
  11. 12 Feb, 2019 13 commits
  13. 11 Feb, 2019 5 commits
    • Vulkan: Port renderer to Fuchsia · 991d1cfb
      Michael Spang authored 
      Add DisplayVk and WindowSurfaceVk subclasses for Fuchsia to the vulkan
renderer, as well as an implementation of OSWindow that renders
fullscreen for the test suite.

Disallow use of the vulkan loader from third_party as Fuchsia uses a fork
of the loader and has not sent those changes upstream yet.

Add a small wayland-inspired library libfuchsia-egl to provide a type
"struct fuchsia_egl_window" to use as EGLNativeWindowType. This type
combines a zx_handle_t to an image pipe channel and a surface size.

Image pipes can only be used once to create a VkSurfaceKHR. This means we
have to recreate the pipe in tests that call eglCreateWindowSurface more
than once with a single OSWindow, or the second call will fail. Add a
resetNativeWindow() method to accomplish this.

BUG=angleproject:2475
TEST=angle_end2end_tests on Fuchsia

Change-Id: I71a613a362dd1c8aada49a3c02ae461e064457bf
Reviewed-on: https://chromium-review.googlesource.com/c/1446496
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    • Vulkan: Enable WebGLCompatiblityTest. · 6b695c3f
      Jamie Madill authored 
      Contains several useful tests including some that cover bugs with
compressed texture support. And some uses of CopyTexImage.

Bug: angleproject:2904
Bug: angleproject:2914
Change-Id: I90398ce2c513ace07cb9d414cd9a65c79e63aadb
Reviewed-on: https://chromium-review.googlesource.com/c/1462058
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: 's avatarGeoff Lang <geofflang@chromium.org>
    • Vulkan: Suppress layer warnings about unbound outputs. · 00f43c91
      Jamie Madill authored 
      This warning could pop up whenever an OpenGL app would write
to a particular output and not bind an attachment. This is
valid in OpenGL. Also it could happen when writing to
gl_FragData instead of gl_FragColor. Since it's hard to fix
every usage we can just suppress the warning.

Also adds a way to change test platform warnings into errors.

Bug: angleproject:2866
Change-Id: I9793f58121ac848d74d6b0131e79ebab2c70f45c
Reviewed-on: https://chromium-review.googlesource.com/c/1462057
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: 's avatarGeoff Lang <geofflang@chromium.org>
    • Vulkan: Fix UtilsVk invalidating Context descriptors. · 54ed8f0a
      Jamie Madill authored 
      Fixes a validation error and rendering artifact in the WebGL test:
textures/misc/tex-image-and-sub-image-2d-with-array-buffer-view

Only applies to masked clears when combined with draw calls using
uniforms or textures.

Also make it easier to inspect layer messages in the debugger.

Bug: angleproject:2912
Change-Id: I4561895439221581b9dbc341d6de5d5a6c2096aa
Reviewed-on: https://chromium-review.googlesource.com/c/1462056
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: 's avatarShahbaz Youssefi <syoussefi@chromium.org>
    • Vulkan:Adding Cmd Buffer Reset tests · 3571ad49
      Tobin Ehlis authored 
      Resetting cmd buffers in various ways to understand VK driver perf on
various devices.

Also includes some changes to get the chromium APK wrapper for
angle_white_box_perftests compiling.

Bug: angleproject:3137
Change-Id: I56bd163cdd6605ce09effe509a9c7ac5e0008e7a
Reviewed-on: https://chromium-review.googlesource.com/c/1456482
Commit-Queue: Tobin Ehlis <tobine@google.com>
Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>