Commits · 6bbd095aa49baade6cd231ce873910492af53efd · Chen Yisong / angle

29 Jun, 2021 1 commit

D3D11: Fix OOB write in Blit11. · 6bbd095a

authored Jun 14, 2021

This could happen for specific values of the 'dest' target.

Bug: chromium:1219082
(cherry picked from commit bd797f75)
Change-Id: I1895d2c614269f79376f49dbd87e279ca52c00a4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2994730Reviewed-by: Jamie Madill <jmadill@chromium.org>

6bbd095a

27 May, 2021 1 commit

D3D11: Fix respecifying 3D textures. · 10b8a6d1

authored May 20, 2021

The missing check for the "Depth" dimension could lead to a bug
where we would not recreate a texture when the dimension changed.

Bug: chromium:1210414
Change-Id: Id59097ad14ae77ff80d27081f61786dad17a77ea
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2911032Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
(cherry picked from commit 26973584)
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2921448Reviewed-by: Jamie Madill <jmadill@chromium.org>

10b8a6d1

14 May, 2021 7 commits

Roll VK-GL-CTS from 6498f4042d9f to 1c4a387382ea (19 revisions) · f871545d

authored May 14, 2021

https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/6498f4042d9f..1c4a387382ea

2021-05-14 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/master
2021-05-13 juha.heiskanen@siru.fi Add test for PBO bounds
2021-05-13 pdaniell@nvidia.com Fix Windows MSVC build regression from GitHub!261
2021-05-13 piotr.byszewski@mobica.com Portability: use triangle strips in amber tests
2021-05-13 piotr.byszewski@mobica.com Portability: handle mutableComparisonSamplers
2021-05-13 srisser@google.com Require geometry shaders for adjacency topologies
2021-05-13 jari.komppa@siru.fi Static code analysis fixes
2021-05-13 toni.salmivalli@siru.fi New SSBO corner case test
2021-05-13 siglesias@igalia.com Add more spir-v tests with empty structs
2021-05-13 alexander.galazin@arm.com Fix GL compatbility mustpass file names
2021-05-13 ari.suonpaa@siru.fi Add dynamic indexing test using gl_VertexID
2021-05-13 tapani.palli@intel.com Fix to GL 4.5 geometry shading provoking vertex tests
2021-05-13 alexander.galazin@arm.com Support GL 4.5 in the Linkage Tests
2021-05-13 alexander.galazin@arm.com Support GL 4.5 in the Arrays of Arrays Tests
2021-05-13 antto.makinen@siru.fi Add a batch of GraphicsFuzz coverage tests
2021-05-13 ilkka.saarelainen@siru.fi Update Amber
2021-05-13 lars-ivar.simonsen@arm.com Fix use of binary semaphore in signaled state
2021-05-13 slawomir.cygan@intel.com Fix condition for checking support of XFB streams other than 0
2021-05-13 siglesias@igalia.com Make sure minImportedHostPointerAlignment in a power of 2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC timvp@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: timvp@google.com,angle-bots+autoroll-info@google.com
Change-Id: I12e13ac730ce2ac1989feeb382a70e99d5a2f447
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2895922Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>

f871545d

Tests: Update capture_replay_expectations · ec362f9b

authored May 14, 2021

Bug: angleproject:5974
Change-Id: If8f210f569bdd1bf4e81c74cac894049b8c9cb7a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2896905Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

ec362f9b

Vulkan: Add feature flag to flush at framebuffer boundary · 09dad082

authored May 07, 2021

Testing shows most app traces seeing performance improved on ARM GPU
when we flush at FBO boundary instead of one submit per frame. This
likely due to more frequent submission means less chance of GPU
starvation. This also helps ANGLE to detect GPU finish at finer grain
since the queue serial is per submission. Finer grain detection of
object completion means memory gets recycled quicker and mapBufferRange
able to hit fast code path more often. With this CL, manhattan 3.1
offscreen score also score improves 7%. This may also helps onscreen
performance if frame time is on the edge of 16ms by submit FBO rendering
earlier instead of been blocked by vkAcquireNextImage.

Bug: b/187993625
Bug: angleproject:5295
Change-Id: I2946a7159231d36019ace89805a69ac8e906ce94
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2888709Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>

09dad082

TracePerfTests: Don't call framebuffer functions on GLES1. · 6f35e366

authored May 12, 2021

Skip unbinding the framebuffer on GLES1, where the function does not
exist. This caused a crash when recording screenshots on native GLES1
implementations on Android.

Bug: angleproject:5961
Change-Id: I7a35474154a4a8d56b36df02629944de7660dcd8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2891567
Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

6f35e366

CL: Add symbol version map to libOpenCL · 83689e32

authored May 13, 2021

Bug: angleproject:5904
Change-Id: I4a5859ea172c9d17cfd84ef219ddd9a71fb3b927
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2894428
Commit-Queue: John Plate <jplate@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

83689e32

Roll Chromium from b0687cb1f1ec to 3b747dab7bb3 (328 revisions) · c8c70ef8

authored May 14, 2021

https://chromium.googlesource.com/chromium/src.git/+log/b0687cb1f1ec..3b747dab7bb3

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/5d8fd334d9..00d8280637
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/9b15350d89..b0912f9572
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/fe582fda76..32fdfcc5af
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..affd272f9e
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f5c054ce53..5ab2f3314c
* third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/e3c17da190..2b99b37874
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/06d525cc6f..f6e0cbe7b7
* tools/luci-go: git_revision:d7393d163ecb11c44626b3b221f86efdd2861565..git_revision:808e8d99fad90d180286ce6d176de6373a5e1398
* tools/luci-go: git_revision:d7393d163ecb11c44626b3b221f86efdd2861565..git_revision:808e8d99fad90d180286ce6d176de6373a5e1398
* tools/luci-go: git_revision:d7393d163ecb11c44626b3b221f86efdd2861565..git_revision:808e8d99fad90d180286ce6d176de6373a5e1398
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/c4921c7a5b..971099ba3c
* tools/skia_goldctl/linux: JUdOUf3QO1PSVW0LijuPE20E8IiVUgPjyUkhri9CrosC..6gOkUwwapS1GyCkAQb7-gPiKnvzdUOyDzkT4NzmnYJEC
* tools/skia_goldctl/mac: -HuOY2pAKikKFvM5odfgh_GYbDKBGhCeKfGoDG4W46sC..43qoaMWgldhQiaXzcCNggSSWDmZQTNrK0cGEt5yysgsC
* tools/skia_goldctl/win: wL8AoIO8IDH7dKheA0iZneF9sE3DamLh6bBzj6I782oC..oodEEBUIHfKw18_-31PAsu3SFiLqvtsFDgbn6ohK5R4C
Clang version changed llvmorg-13-init-9881-g5dad3d1b:llvmorg-13-init-9302-g897d7bce
Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/06d525cc6f7770fe4aa305d73eb1fadc37865070..f6e0cbe7b7efe0ba94157937d701077aeaab2d5b/scripts/update.py

Bug: None
Tbr: timvp@google.com
Change-Id: Ia0b690d5c4609bfe8cfa097ed2d8e629fe5abd3f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2895908
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

c8c70ef8

CL: Implement context for front end and passthrough · 48b835cf

authored May 09, 2021

Bug: angleproject:5904
Change-Id: I23b764bba87be3a51a1b5b44b13968fc572efde9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2883773Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: John Plate <jplate@google.com>

48b835cf

13 May, 2021 13 commits

Translator: Fix struct/uniform separation w.r.t to arrays · 39ee3640

authored May 11, 2021

When a uniform of struct type was redeclared, the arrayness information
was not transferred.

Bug: chromium:1204861
Change-Id: Ic3f461a4aa349a73bc48568ee14b5418f0556238
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2889599
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

39ee3640

Disable GL_EXT_shader_framebuffer_fetch_non_coherent on Arm/QCOM · b0c217ba

authored May 13, 2021

Thie is a shorter-term work-around to games not checking extensions
properly.

Bug: b/177320565
Bug: b/186643966
Bug: b/186783762
Change-Id: Ic348396db1d081925cd9747cdd9406f5929313b9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2894407Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>

b0c217ba

Allow specifying GPU config on expectation check. · e601181d

authored May 11, 2021

When we load the expectations we can now specify the config at a later
point. This will make it easier to run test suites that use multiple
APIs, like angle_end2end_tests. We can instead specify the config when
we check the expectation.

Bug: angleproject:5951
Change-Id: I9607db093e4a459550a7cd6864b17adfa55e17f2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2892273
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

e601181d

Translator: Fix local var inits vs struct/uniform separation · c5e344b1

authored May 11, 2021

The declarations outside the global scope were being skipped in this
transformation, but if the initializer of a declaration referenced a
uniform struct that's being replaced, it should have been visited too.

Bug: chromium:1204861
Change-Id: Ie2a743126c785eb7d6e3542ba80faa4defc3509f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2889598
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

c5e344b1

Capture/Replay: recreate the EGL window if contexts don't match · ee2f3302

authored May 12, 2021

In addition enable affected tests.

Bug: angleproject:5955
Change-Id: I4fb72e38a633daa4565d3c0ae7cddb6ace7226f1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2891775
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

ee2f3302

Roll Chromium from 3fb708290557 to b0687cb1f1ec (639 revisions) · 2303f19c

authored May 13, 2021

https://chromium.googlesource.com/chromium/src.git/+log/3fb708290557..b0687cb1f1ec

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC timvp@google.com,jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/129bd6c0c0..5d8fd334d9
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/e72cd4587a..9b15350d89
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/43828a290e..fe582fda76
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..52e67e75f6
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6e5b0a5c45..f5c054ce53
* third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/c3edbeed8a..e3c17da190
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/53a9334ffe..06d525cc6f
* tools/luci-go: git_revision:37e5f238829f911f85b62d66670d2fbd88354ef1..git_revision:d7393d163ecb11c44626b3b221f86efdd2861565
* tools/luci-go: git_revision:37e5f238829f911f85b62d66670d2fbd88354ef1..git_revision:d7393d163ecb11c44626b3b221f86efdd2861565
* tools/luci-go: git_revision:37e5f238829f911f85b62d66670d2fbd88354ef1..git_revision:d7393d163ecb11c44626b3b221f86efdd2861565
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/ac77520e0e..c4921c7a5b
* tools/skia_goldctl/linux: EWfIod1MP71b48GlHnS5Rv9JpBzeTRQ6viIPDfFUSFEC..JUdOUf3QO1PSVW0LijuPE20E8IiVUgPjyUkhri9CrosC
* tools/skia_goldctl/mac: qwctaMZfXlU0u7OsbxWgOY_sBjsUYhlqwjJRbAXX3oYC..-HuOY2pAKikKFvM5odfgh_GYbDKBGhCeKfGoDG4W46sC
* tools/skia_goldctl/win: O2WsBEJgyjTsib6LvzoNqqXwfSylJFfTRxEKYr-IsocC..wL8AoIO8IDH7dKheA0iZneF9sE3DamLh6bBzj6I782oC
Clang version changed llvmorg-13-init-9302-g897d7bce:llvmorg-13-init-9881-g5dad3d1b
Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/53a9334ffea6aa748ff6c1ce8a46e71a90e7bc9f..06d525cc6f7770fe4aa305d73eb1fadc37865070/scripts/update.py

Bug: None
Tbr: timvp@google.com,jmadill@google.com
Change-Id: Iabcdb225075048bb3481d8cf516da157c330e2b2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2893193
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

2303f19c

Add messages for framebuffer completeness errors. · bccb0d56

authored May 11, 2021

This also creates a common code path for all framebuffer
completeness errors (FramebufferStatus::Incomplete) which
helps for adding a debug breakpoint.

Bug: angleproject:5949
Change-Id: Ib102dbf86e020777e56c6dc6b78dda8ebdba2127
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2888110
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

bccb0d56

Vulkan: Allow DynamicBuffer suballocation in BufferVk · e354ff1a

authored Mar 05, 2021

When allocations are made from DynamicBuffer, they suballocate from a
possibly larger BufferHelper.  In BufferVk, the offset of the
suballocation was discarded, which limited the use of DynamicBuffer to a
pool of small buffers.

This change applies any such offset that may arise from suballocations
everywhere, and makes BufferVk use a larger buffer size when the
GL_DYNAMIC_* buffer usage hints are provided.

Bug: angleproject:5719
Change-Id: I3df3317f7acff1b1b06a5e3e2bb707616a7d0512
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2738650
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

e354ff1a

Remove teglAndroidUtil.cpp override · cb69b46a

authored May 12, 2021

The file was fixed in https://gerrit.khronos.org/c/vk-gl-cts/+/7296.

Bug: angleproject:5870
Change-Id: I46410985ef0e66f886a6ee2ba321725242e01ce7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2892288Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

cb69b46a

Test Runner: Fixes to skipped tests. · 1d019f49

authored May 13, 2021

Uses a different token for skipped and not run tests in the json. The
token isn't standard but should only be visible when batches report
to the parent process that a test wasn't run. It shouldn't be visible
to the scripts that consume test results on the bots.

Also fixes the expected result for skipped tests to also be "SKIP".

Bug: angleproject:5951
Change-Id: I0bd7d13b2b25b583f9c42718786cb588bacd4bc6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2894524Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

1d019f49

CL: device partitioning for front end and passthrough · b300dc52

authored May 09, 2021

Partitioning is the creation of sub-devices. Also add reference
counting for CL objects, which is needed now for sub-devices.

Also fix CL print format strings, since cl_ulong is actually
always 64 bit and not unsigned long.

Bug: angleproject:5904
Change-Id: I006699fad2f953ce312bca87c9b6362b5d77a18a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2880665
Commit-Queue: John Plate <jplate@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

b300dc52

Add array bounds checks for WebGL shaders · b0d39ba2

authored May 12, 2021

WebGL shaders may contain OOB array accesses which in turn
cause undefined behavior, which may result in security
issues. This was detected as an UNKNOWN READ by UBSAN while
testing with SwANGLE.

Bug: chromium:1189110
Change-Id: I00f56e771ed0c675abb465fc3a3dc9d62ea8ed51
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2892286Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Alexis Hétu <sugoi@chromium.org>

b0d39ba2

Roll SwiftShader from be169ef35238 to c4d054c6ad41 (2 revisions) · 9809122d

authored May 13, 2021

https://swiftshader.googlesource.com/SwiftShader.git/+log/be169ef35238..c4d054c6ad41

2021-05-12 capn@google.com Work around MemorySanitizer scalar SSE false positives
2021-05-12 capn@google.com Work around MemorySanitizer movmsk false positives

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: timvp@google.com
Change-Id: I01cfd7f45b12c27615f6931a26de0407383ff2f4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2894130
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

9809122d

12 May, 2021 8 commits

Revert "Change to module directory when loading swiftshader ICD." · 25b53ceb

authored May 12, 2021

This reverts commit 3b10dda6.

Bug: angleproject:5954
Change-Id: I6199dc099dbf42605bbfc549e39cb6477e67442c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2891771
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>

25b53ceb

Test Runner: Handle skipped gtests. · 9a219a14

authored May 12, 2021

GTEST_SKIP() allows us to skip tests using the GoogleTest APIs.
This CL updates our test runner code to handle these skips.

Bug: angleproject:5951
Change-Id: Idef5802c7c81bd92226f5a93281a1cea0f1b24ee
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2892272Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

9a219a14

Tests: Add Dr. Driving trace. · 1d1c4518

authored May 11, 2021

Test: angle_perftests --gtest_filter="*dr_driving*"
Bug: b/181871119
Bug: angleproject:5944
Change-Id: I0a95f91d68957840da7c99580db60472e44467a0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2887286Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>

1d1c4518

FrameCapture: Use gl*Separate functions only when required. · 51d02ca0

authored May 06, 2021

Use non-separate stencil and blend functions that do not
distinguish between front and back buffers or color and alpha,
if they apply.

This prevents capturing GLES2 functions on GLES1 contexts.

Bug: angleproject:5893
Change-Id: I8303ee5b279268ea9c21e2c6465e1b155d1cc54d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2877238Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>

51d02ca0

Roll SwiftShader from dcb33711bd4b to be169ef35238 (1 revision) · 57bc7ce1

authored May 12, 2021

https://swiftshader.googlesource.com/SwiftShader.git/+log/dcb33711bd4b..be169ef35238

2021-05-11 swiftshader.regress@gmail.com Regres: Update test lists @ dcb33711

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: timvp@google.com
Change-Id: Ic3cd3631682b2cace3a6eed4ae0fe938766365fa
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2891641
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

57bc7ce1

Tests: Add Summoners War trace. · 8af704bd

authored May 11, 2021

Skip the trace on Windows/Intel since it produces GL_INVALID_ENUM.

Test: angle_perftests --gtest_filter="*summoners_war*"
Bug: b/181870341
Bug: angleproject:5943
Change-Id: I99b551294eeb267311728fd6f566cd549f97e90d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2887285Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>

8af704bd

Roll Chromium from fff9d6fb8ddf to 3fb708290557 (495 revisions) · cf1064e6

authored May 12, 2021

https://chromium.googlesource.com/chromium/src.git/+log/fff9d6fb8ddf..3fb708290557

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/4ff4105cd8..129bd6c0c0
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/504fae9f10..43828a290e
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/93eae7d9dc..371f2bea4f
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..302ca09b2d
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/cb17bc6028..6e5b0a5c45
* third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/5243354177..66e0a5d62b
* third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/618ddecd59..c3edbeed8a
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/e76c8f17cf..53a9334ffe
* tools/luci-go: git_revision:1b50bbe2f93441dd227ad6e6684fa9be4ab0dec2..git_revision:37e5f238829f911f85b62d66670d2fbd88354ef1
* tools/luci-go: git_revision:1b50bbe2f93441dd227ad6e6684fa9be4ab0dec2..git_revision:37e5f238829f911f85b62d66670d2fbd88354ef1
* tools/luci-go: git_revision:1b50bbe2f93441dd227ad6e6684fa9be4ab0dec2..git_revision:37e5f238829f911f85b62d66670d2fbd88354ef1
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/df10bb0bf8..ac77520e0e
* tools/skia_goldctl/mac: 5o7ziB6qRrSdtYJwKop8-5OFmvVQcxuNkGY1DRYggMsC..qwctaMZfXlU0u7OsbxWgOY_sBjsUYhlqwjJRbAXX3oYC
Clang version changed llvmorg-13-init-7296-ga749bd76:llvmorg-13-init-9302-g897d7bce
Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/e76c8f17cf2833813d671674cd89f01f3a21e851..53a9334ffea6aa748ff6c1ce8a46e71a90e7bc9f/scripts/update.py

Bug: None
Tbr: timvp@google.com
Change-Id: Iff9b5446b67a948eeb60e1aa7aaacf0725714c05
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2891629
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

cf1064e6

Roll VK-GL-CTS from dab93ea8f88c to 6498f4042d9f (9 revisions) · 14365e1d

authored May 11, 2021

https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/dab93ea8f88c..6498f4042d9f

2021-05-07 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/master
2021-05-06 alexander.galazin@arm.com Merge vk-gl-cts/github-master into vk-gl-cts/master
2021-05-06 juha.heiskanen@siru.fi Add TexSubImage2D format compatibility tests
2021-05-06 piotr.byszewski@mobica.com Rename all OperationId enum values
2021-05-06 juha.heiskanen@siru.fi Fix validation error 'InputNotProduced' in Amber tests
2021-05-06 rgarcia@igalia.com Decrease 3D image size in image atomic op tests
2021-05-06 venni.ihanakangas@siru.fi Fix interfaceTypeMismatch validation errors in Amber tests
2021-05-06 antto.makinen@siru.fi Add a batch of GraphicsFuzz coverage tests
2021-05-06 jari.komppa@siru.fi Cover array input to interpolateAtCentroid

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: angleproject:5952
Change-Id: Ic3a29ba2ae65ef1660c02b765a8fd767c6a5e133
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2890549Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>

14365e1d

11 May, 2021 10 commits

Follow up on Vulkan headers update to 1.2.177 · 859ed396

authored May 11, 2021

Removing duplicate definitions in ANGLE.

Bug: angleproject:5905
Change-Id: Ie62ad39a1ebc0d8b0d2c005723f461bc7309eade
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2889831Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

859ed396

Refactor CL platform object · 93aff937

authored May 08, 2021

Move GetPlatformInfo implementation from stubs to cl::Platform,
because stubs are meant to be small.
Also move CLPlatformImpl::Info instance to cl::Platform as it is
more efficient to be accessed from there, and more consistent with
cl::Device.

Bug: angleproject:5904
Change-Id: I4c0ba6390467d6ef357e38a5ef08f54b0a88d423
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2880663
Commit-Queue: John Plate <jplate@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

93aff937

Implement CL device object for front end and passthrough · e369a282

authored May 08, 2021

Bug: angleproject:5904
Change-Id: I17f6d10ed59c62fe9126d29b7de2c127c5d0039a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2880662Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: John Plate <jplate@google.com>

e369a282

EGL: setup extension EGL_EXT_protected_content · d52ed4bd

authored Mar 25, 2021

Add extension to registry
Update hashes

Bug: angleproject:3965
Change-Id: Ie2808b8a599ae4adbf6f2f1d24db046799f594df
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2800412
Commit-Queue: Brandon Schade <b.schade@samsung.com>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

d52ed4bd

infra: Switch Android ARM64 bots to compile-and-test. · cd535d2c

authored May 11, 2021

This will start to trigger tests on the Pixel 4 64-bit bots.

Patch Series:

1. http://crrev.com/c/2885381
2. http://crrev.com/c/2885346
3. This CL
4. http://crrev.com/c/2885384

Bug: angleproject:5941
Change-Id: Ib76fd27d0814896522aad84443f52b7f47566e85
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2885383Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

cd535d2c

FrameCapture: Capture GLES1 specific states. · 4901ac64

authored May 06, 2021

Implement capturing GLES1 specific state by checking the difference to
the default state using getEnableFeature.

When getEnableFeature is called from a context version higher than 1 and
a GLES1 state is requested, an assertion is hit. Therefore the context
version needs to be determined before calling getEnableFeature.

Use the available isTextureTargetEnabled function to determine
GL_TEXTURE_2D and GL_TEXTURE_CUBE_MAP states in getEnableFeature.

Return false in isTextureTargetEnabled when mTextUnitEnables is empty,
so the vector is not accessed when not initialized, which was the case
for a default state.

Bug: angleproject:5893
Change-Id: I66ee41c3bf7a8e1f04a8a4ce0461fddc16f9a013
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2877237Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>

4901ac64

Vulkan: set DS layout before using it in the endRenderPass · 46a139ad

authored May 06, 2021

In CommandBufferHelper::endRenderPass(), we are checking depth stencil's
initialLayout to change storeOp to None if the layout is read only. But
the layout was set after that check, which essentially voids the
optimization.  This CL moves the finalizeDepthStencilImageLayout() call
before the layout is used.

This CL also moves the depth stencil loadOp/storeOp to a new function
finalizeDepthStencilLoadStoreOp(). When depthImage gets deleted before
renderpass ends, we could also apply the same load/store optimization
just like we did at endRenderPass() time.

Bug: b/187425444
Change-Id: I89814274352f09cbf1f7b58a91bbaf131b983fb1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2877933Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>

46a139ad

infra: Remove old TODO. · 6e3c5321

authored May 11, 2021

Bug: angleproject:5114
Change-Id: I3b7255cc06bffd177f0b5ee8cad12bf2aad3089e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2885382
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

6e3c5321

Suppress MultithreadingTest.MultiContextClear on Linux+Nvidia · e19182ce

authored May 11, 2021

MultithreadingTest.MultiContextClear/ES3_Vulkan_NoVirtual is flaky on
linux-clang-rel NVIDIA, so it's being suppressed for now.

Bug: angleproject:5945
Change-Id: I9ef142c57b3fcf5224732edcea1650634ecc18ca
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2887905
Commit-Queue: Tim Van Patten <timvp@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

e19182ce

Change to module directory when loading swiftshader ICD. · 3b10dda6

authored May 05, 2021

When loading vulkan, we can be running from any directory. We need
to change to the module directory to ensure the swiftshader ICD is
loaded properly. For example, in some Chrome releases, libGLESv2.dll
and libvk_swiftshader.dll are in a subdirectory relative to chrome.exe

Bug: chromium:1198567
Change-Id: I9e68927e512b239728fb2903d1a04702508a4948
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2873452
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

3b10dda6