GLES 3.0.4 p147:
 "If internalformat is an ETC2/EAC format, CompressedTexImage3D will generate an
  INVALID_OPERATION error if target is not TEXTURE_2D_ARRAY."

This matches the validation of glTexImage3D.

TEST=conformance2/textures/misc/tex-storage-compressed-formats.html

BUG=chromium:983142

Change-Id: Ifc4ea9503182c43de7e58c4b45b59bb03ae2f901
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1698648Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

Bug: angleproject:3437
Test: angle_end2end_tests --gtest_filter=DepthStencilFormatsTest.VerifyStencilData/*
Change-Id: Iffab48eaea6aa35888560859e9f502a4f814b833
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1674663Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>

We use new logic to compare if the attribute format changes before
setting dirty bits. This improves performance of VBO-only state changes
significantly. On the VBO change Vulkan microbenchmark gives about a
30% improvement.

Bug: angleproject:3256
Change-Id: Ifaf1c92ed7a09422156ef79b5983e7349de63346
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1684294Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

When clearing to zeros or ones on some Intel drivers on Mac, the clear color
would be incorrect.

This replicates the chromium clear_to_zero_or_one_broken workaround.

BUG=angleproject:3672

Change-Id: I0f065420b577bd8f8d931ccdbeeebdcbf9fd08d2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1692977
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>

This reverts commit 9be098b5.

Reason for revert: Fixed in the auto-rollers. They should now
include Bug: tags.

Original change's description:
> PRESUBMIT.py: Don't require "Bug:" for autoroller CLs.
> 
> BUG=angleproject:3659
> 
> Change-Id: I29d77939953e3661ea979f8f7a9f44566079e567
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1692881
> Commit-Queue: Jamie Madill <jmadill@chromium.org>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>

TBR=geofflang@chromium.org,cwallez@chromium.org,jmadill@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: angleproject:3659
Change-Id: I01a2e82c24918c831a6c444360620d261ec892dc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1700141Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

When the source and target textures are the same texture but different
levels, there is a corner case which makes the framebuffer incomplete on
calling glCopyTexImage2D and fails
conformance2/textures/misc/copy-texture-image-same-texture.html

Bug: angleproject:2994
Change-Id: I906869c78aefded5688d4491e93b95dd2662175c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1697262Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>

The tests previously skipped for 3458 have 2 different root causes.
Bug 3458 was split into two: 3458 and 3674.  The SKIP lines have been
split into more-fine-grained SKIP lines, with some going to the new
3674 bug.

Bug: angleproject:3458
Bug: angleproject:3674
Change-Id: I2eaa83a30b87a81144d8f19658007386683e6388
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1695899Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/c538b5d796fb..71892a5eda90


Created with:
  gclient setdep -r ./third_party/glslang/src@71892a5eda90

The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-angle-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



Bug: None
TBR=cwallez@chromium.org
Change-Id: Ic3fa0d8603682ac27119c81252421dc140670b86
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1699756Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

Skip the GLES 3.2 context creation by overriding tes31Context.cpp
with an ANGLE-specific tes31Context_override.cpp that only creates a
GLES 3.1 context.

Bug: angleproject:3687
Test: dEQP.GLES31
Change-Id: I1afab5f04b79dc252f1b27563032a44ab37cacfe
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1698542Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>

Reset the base level of textures before call glTexImage on Mac
to prevent driver bugs that cause texture corruption.

BUG=angleproject:3671

Change-Id: I90e94b8395a781a2142ef6be3af1d6117f084152
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1692975
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>

This prevents later issues with some VkFormat values being over 256,
as well as providing more information to pipeline creation.
A preliminary step towards handling mismatched vertex attributes.

Bug: angleproject:3634
Change-Id: Idb15a14088a2d73b43b4b92d3cfdb12587c5f711
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1696212Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

This should reduce the number of merge conflicts when multiple people
touch different generators. There still will be merge conflicts when
two people touch the same code generator.

Bug: angleproject:3691
Change-Id: I0b179368a1352331c091972568c00213ab106e46
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1698650Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

This is more than just a noop: when ANGLE is rolled in Chromium it is
tested by the Android Binary Size trybot. This trybot runs an analysis
pass that checks that any new variable names "kSomthing" is in .rodata
or .data.rel.ro because it helps keep the binary size (and the size of
each new Chromium process) small on Android.

The analysis picks up new usages of StaticType::Helpers::kInstance as a
new constant varaible that isn't in .data.rel.ro or .rodata. My
understanding is that kInstances isn't put in those segments because it
contains a TType that has a "mutable" field so it would be incorrect to
put the variable in a read-only segment.

BUG=chromium:981610

Change-Id: I36e550e066206df3404619f1d012b183cbb72fe4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1698202
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

Fixes to make WGL implementation work with OpenGL tutorial
- Give directive parser the correct shader spec when on Desktop GL
- Minor changes to parse Desktop GL shaders
- Moved clientType parameter from Context to Context->mState
- Minor fixes to WGL functions

Bug: angleproject:3666
Change-Id: I01ddb828f6d581ad445f49942589436849eae5d9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1693244
Commit-Queue: Clemen Deng <clemendeng@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

Compute (single-stage pipeline) is upcoming, but this change prepares
GlslangWrapper to handle any number of stages (mostly).  Additionally,
this change binds each resource to each stage based on whether it's
active, so that we don't hit the per-stage limit of resources by binding
every resource to every stage.

Bug: angleproject:3633
Bug: angleproject:3562
Change-Id: Ifebf691482846e0371c6e314f514226a4cfee258
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1689330Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

This CL introduces a Recycler to reuse unreferenced vk::Fence, reducing
CPU time spent on vk::Fence init&destroy. Save around 15% of CPU time
for most glmark2 tests.

Bug: angleproject:3556
Change-Id: Ice5054305321c466c5be3bc368d04091f074729c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1679239
Commit-Queue: Tobin Ehlis <tobine@google.com>
Reviewed-by: Tobin Ehlis <tobine@google.com>

The deqp_gles3_test_expectations.txt file is being cleaned up to give
failures their own bug, rather than being lumped into the generic
"Implement GLES 3.0 conformance" bug. This gives more visibility to the
test failures and allows people to start working on this in isolation
more easily.

There were also some passing tests removed that were found while doing
this cleanup.

Bug: angleproject:2950
Test: dEQP-GLES3
Change-Id: I24810ac37053fba96bccc7f320bfacc66cc7da59
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1695927
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/8aa9a7bb8f74..c538b5d796fb


Created with:
  gclient setdep -r ./third_party/glslang/src@c538b5d796fb

The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-angle-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=cwallez@chromium.org

Change-Id: I3f06b71a73385d33349e971262bee6bc97bec183
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1697174Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

This change fixes below error:
Message 0: ID3D11DeviceContext::CSSetShaderResources: Resource being set
to CS shader resource slot 0 is still bound on output! Forcing to NULL.

Bug: angleproject:3658
Change-Id: I72d656cf61ffb7c39660c019eab980c39eafb70f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1688307Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jiajia Qin <jiajia.qin@intel.com>

Adds support for translating gl_BaseVertex and gl_BaseInstance for implementation of
GL_ANGLE_base_vertex_base_instance.

They will only be available in WebGL 2. Since there's no gl_VertexID and
gl_InstanceID in WebGL 1. It won't be very useful to add them to WebGL
1.

Mostly follow pattern of gl_DrawID of GL_multi_draw

BUG=angleproject:3402,chromium:891861

Change-Id: Ifcd990c52d12f6814127b904e61a779b8d382e0c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1666361
Commit-Queue: Shrek Shao <shrekshao@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Extend validation to allow texture rectangle-backed textures as
blitFramebuffer sources and destinations.

Add end-to-end test covering this functionality, and run the
IOSurfaceClientBufferTests against both ES2 and ES3.

Bug: angleproject:3669
Change-Id: I7b8815a2c98072c12de45717afbba9e9b29ba253
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1694483
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

A few WebGL tests were failing on Linux/NVIDIA/passthrough because the
luminance workaround doesn't handle the case where the destination
texture is a luminance texture. For now, fallback to CPU readback in
this case.

Bug: chromium:773861
Change-Id: I1b85edccc2e257a5fa19cd496d86443ba96e07ad
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1695922
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

The extra_args wildcard doesn't support extra arguments prepended with
'--'. By using the unknown args returned by argparse, you can add
arbitrary args to the swarming call.

Bug: angleproject:3272
Change-Id: I8d4ab1e19ceae80b47cc2331e6e30a4187da863f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1695921Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>

Fix various shader translator validation errors related to uniform
buffers and naming.

Bug: angleproject:3459
Test: angle_deqp_khr_gles3_tests
Change-Id: Iaa66b61e91c8f38ec7cccb43d71be9ba3cd83da3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1684302
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

This extension allows Chrome to use ANGLE on newer Android devices.

BUG=angleproject:3643

Change-Id: I5456d61749399ca2bbc11cc5e98b9120f8702406
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1687121Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

Changes instances where we were querying 'color buffers' and 'depth
buffers' to 'color attachments' and 'depth attachments', etc.

Bug: angleproject:3611
Change-Id: I7af7d33e5204f21d288f5bcad997988d36eabfc5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1690679
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>

Convert the texture ID parameters into optimized vectors of Texture objects.

BUG=angleproject:3656

Change-Id: Iffe824ade2a919c9771642ae501ff04712ca43ce
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1688505Reviewed-by: Michael Spang <spang@chromium.org>

Bug: angleproject:3668
Change-Id: Iaf529a5a50d1ab040f016fae0ea9bd3129a8fd6e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1692625Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

This support was missing and caused dEQP crashes.

Bug: angleproject:3627
Change-Id: Idc06cc92df676061f8a08d0f32a1b3e7f03a66f4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1691102
Commit-Queue: Ian Elliott <ianelliott@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

Not sure when these were fixed, but they pass now.

Bug: angleproject:3455
Bug: angleproject:3460
Change-Id: I0275ff001af3bab2599073143effcc54ee0bca82
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1692447
Commit-Queue: Ian Elliott <ianelliott@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Bug: angleproject:3651
Change-Id: I1af052da9bc2f64f2f29ea411902272987f21a0e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1688178
Commit-Queue: Clemen Deng <clemendeng@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

BUG=angleproject:3663

Change-Id: I13a1a920173e3f2e5360e6d7253f24a44bdc5e13
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1690675
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/4b4b41a63499..8aa9a7bb8f74


Created with:
  gclient setdep -r ./third_party/glslang/src@8aa9a7bb8f74

The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-angle-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=cwallez@chromium.org

Change-Id: Iec081c31b79bd1a555552e7649861f88f000f64f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1692188Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/9702d47c6fe4..0c4feb643b89


Created with:
  gclient setdep -r ./third_party/spirv-tools/src@0c4feb643b89

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=cwallez@chromium.org

Change-Id: I428c6d686be4b1721ecaa9398bbb0b4c83de859e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1692187Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

BUG=angleproject:3659

Change-Id: I29d77939953e3661ea979f8f7a9f44566079e567
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1692881
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

The storage buffers are placed in the same descriptor set as uniform
buffers.  Some refactoring is done to reuse code that handles UBOs to
handle SSBOs as well.  A good number of tests still fail as they test
SSBOs in conjunction with compute shaders.

Bug: angleproject:3561
Change-Id: Ia33c1f68e6f6402c746f5919ede87b2c308cf81c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1687126
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

Makes the QUALIFIER macro take arguments similar to LAYOUT, to allow
passing in tokens to be conditionally output after the storage
qualifier.

Bug: angleproject:3561
Change-Id: I4368eba2c34c1398f81d33cd23c9e56557fd4ed8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1685876
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Reason for disabling: Crashes are seen on
Fuchsia. Some parts are missing to appropriately
support the extension.

Bug: angleproject:3216
Bug: angleproject:3217
Bug: angleproject:3665
Change-Id: I4a7775e023702861d5e801289d49f39702cb19bf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1691311
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

This avoids using an unbounded number of semaphores in between calls to
swapbuffers. Using two semaphores should be sufficient to synchronize
swaps.

In addition, fix tracking of VkPipelineStageFlags by creating a 2nd
vector parallel to the semaphores vector. The last fix assumed there
could only be 2 wait semaphores, but that bound only applied to signal
semaphores. After this change, there can only be one signal semaphore,
but there's still no bound to wait semaphores.

Bug: angleproject:3637
Change-Id: I7fbba67fa4bbdf62b9e9d530a924acd5236705d3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1688435
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

- wglSwapBuffers
- wglCreateContext
- wglMakeCurrent
These functions are needed by the OpenGL tutorial for Windows desktop

Bug: angleproject:3620
Change-Id: I699af63eca4a2c8aaf2c72278a580322410ac499
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1688499
Commit-Queue: Clemen Deng <clemendeng@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>